Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 1:33 PM, Honza Bambas wrote: On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the ri

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My p

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 11:59 AM, Honza Bambas wrote: On 12/6/2013 5:31 PM, Ehsan Akhgari wrote: Can you please file a bug about this so that we can try to get this patch landed? WTC recently indicated to me (in ) that we should probably start add

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 5:31 PM, Ehsan Akhgari wrote: Can you please file a bug about this so that we can try to get this patch landed? WTC recently indicated to me (in ) that we should probably start adding support for having our own NSPR patche

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 10:05 AM, Honza Bambas wrote: On 12/6/2013 6:48 AM, Brian Smith wrote: On Thu, Dec 5, 2013 at 9:46 PM, Robert O'Callahan wrote: bug 924253 I think we should also be careful that, when we have multiple processes (which is always, because of e10s-based about:newtab fetching), that

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 6:48 AM, Brian Smith wrote: On Thu, Dec 5, 2013 at 9:46 PM, Robert O'Callahan wrote: bug 924253 I think we should also be careful that, when we have multiple processes (which is always, because of e10s-based about:newtab fetching), that those multiple processes are not clobbering

Re: NSPR logging dropping log messages

2013-12-05 Thread Brian Smith
On Thu, Dec 5, 2013 at 9:46 PM, Robert O'Callahan wrote: > bug 924253 I think we should also be careful that, when we have multiple processes (which is always, because of e10s-based about:newtab fetching), that those multiple processes are not clobbering each other's output, when NSPR_LOG_FILE is

Re: NSPR logging dropping log messages

2013-12-05 Thread Robert O'Callahan
Bill McCloskey pointed me to bug 924253, and his patch there fixed my problem. So basically, don't trust mochitest output until bug 924253 is fixed. Rob -- Jtehsauts tshaei dS,o n" Wohfy Mdaon yhoaus eanuttehrotraiitny eovni le atrhtohu gthot sf oirng iyvoeu rs ihnesa.r"t sS?o Whhei csha i