Re: Visibility of disabled tests

2020-01-11 Thread David Burns
I think a lot of the problem is not necessarily a technical issue, meaning I am not sure that tooling will solve the problem, but it is more of a social problem. I think the problem is making sure that items are triaged and placed into peoples workflow sooner would solve this problem but I also ap

Re: Visibility of disabled tests

2020-01-11 Thread James Graham
On 07/01/2020 13:29, Johann Hofmann wrote: /For disabling tests, review from the test author, triage owner or a component peer is required. If they do not respond within 2? business days or if the frequency is higher than x, the test may be disabled without their consent, but the triage own

Re: Visibility of disabled tests

2020-01-11 Thread James Graham
On 09/01/2020 10:46, David Burns wrote: I think a lot of the problem is not necessarily a technical issue, meaning I am not sure that tooling will solve the problem, but it is more of a social problem. To exapnd a little on this; we've had various attempts at making disabled tests more visibl

Re: Visibility of disabled tests

2020-01-11 Thread Geoffrey Brown
Thanks Johann. I agree it is important that we try to fix tests that have been disabled. I think the sheriffs usually needinfo the triage owner before/when disabling a test; I'm disappointed to hear that isn't happening consistently. However, I'd prefer not to change the review process for the dis

Re: Visibility of disabled tests

2020-01-11 Thread Andrew Sutherland
On 1/8/20 12:50 PM, Geoffrey Brown wrote: Instead of changing the reviewers, how about:  - we remind the sheriffs to needinfo  - #intermittent-reviewers check that needinfo is in place when reviewing disabling patches. To try and help address the visibility issue, we could also make searchfox

Re: Visibility of disabled tests

2020-01-15 Thread Botond Ballo
On Sat, Jan 11, 2020 at 10:38 AM Geoffrey Brown wrote: > It might be helpful if we explicitly consider some special cases. If the > sheriffs have needinfo'd for "needswork" and that needinfo has been > cleared, do we want to set needinfo again when disabling? Always? If the > triage owner has a h

Re: Visibility of disabled tests

2020-01-15 Thread Botond Ballo
On Sat, Jan 11, 2020 at 10:38 AM James Graham wrote: > So in addition to the specific changes for intermittent handling, can we > document how one nominates a bug for retriage in general (or point me at > those docs if they already exist) My understanding is that clearing the "priority" field is