Re: Shutting off leak tests?

2013-07-17 Thread Alex Keybl
> So the main thing we'd lose is graph server monitoring of Trace Malloc Leaks. > This is occasionally useful, but in a limited way because the monitoring > process is unowned, and because the current value of the benchmark is high > enough that small changes are ignored by the monitoring syste

Re: Shutting off leak tests?

2013-07-17 Thread Matt Brubeck
On 7/17/2013 4:26 AM, Ted Mielczarek wrote: The only valuable thing we're losing from shutting this off is tracemalloc coverage, which we don't have elsewhere. I don't have any evidence to show that anyone has actually looked at the tracemalloc data or done anything useful with it in recent histo

Re: Shutting off leak tests?

2013-07-17 Thread Ted Mielczarek
On 7/17/2013 2:05 AM, Jesse Ruderman wrote: > > AWSY is not a replacement for shutdown-leak testing. It's limited to code > exercised by TP5. Small leaks are masked by normal variation in memory use. > > Note, though, that we still run almost all of our test suites on debug builds with leak chec

Re: Shutting off leak tests?

2013-07-16 Thread Jesse Ruderman
On Monday, July 15, 2013 3:09:05 PM UTC-7, Kyle Huey wrote: > FWIW now that we have AWSY and we don't really care about > shutdown leaks > > specifically I don't think these tests are very useful to > memshrink anymore. AWSY is not a replacement for shutdown-leak testing. It's limited to code

Re: Shutting off leak tests?

2013-07-16 Thread Ehsan Akhgari
It's not exactly a knee jerk reaction. We discussed this quite a while ago as I mentioned earlier and there were more arguments in favor of turning these off. It's just that the work was never done. And in the mean time we have got much more useful test suites, such as AWSY which actually help u

Re: Shutting off leak tests?

2013-07-16 Thread Steven Michaud
> Steven, anyone else that can take a look at this mac bug? Not that I'm aware of. And are we sure this *is* a Mac bug? I've never seen anything like it in any other context, so I think this is most likely to be a tests bug. So the best person to look at it is probably someone who knows a lot a

Re: Shutting off leak tests?

2013-07-15 Thread Doug Turner
Makes me sad that the knee jerk reaction is to turn leak testing off before anyone actually does any engineering. Steven, anyone else that can take a look at this mac bug? Steven Michaud July 15, 2013 2:15 PM I'd say go ahead and shut them off. I'm not going to have

Re: Shutting off leak tests?

2013-07-15 Thread Ehsan Akhgari
I brought this up ~2 years ago , and we concluded that discussion saying that we should turn these tests off, so bug 617441 was filed and then nothing happened. I don't think anything has changed since we had that discus

Re: Shutting off leak tests?

2013-07-15 Thread Kyle Huey
On Mon, Jul 15, 2013 at 3:05 PM, Alex Keybl wrote: > I think we can only make this decision once we know the worst case > scenario these tests are currently preventing, so that we can mitigate or > plan for it. > > -Alex > > On Jul 15, 2013, at 1:45 PM, Chris AtLee wrote: > > > Hi! > > > > Leak

Re: Shutting off leak tests?

2013-07-15 Thread Alex Keybl
I think we can only make this decision once we know the worst case scenario these tests are currently preventing, so that we can mitigate or plan for it. -Alex On Jul 15, 2013, at 1:45 PM, Chris AtLee wrote: > Hi! > > Leak tests on OSX have been failing intermittently for nearly a year now[1]

Re: Shutting off leak tests?

2013-07-15 Thread Steven Michaud
I'd say go ahead and shut them off. I'm not going to have time to investigate this for the foreseeable future. I'm already dealing with one very difficult (and possibly intractable) tests bug (https://bugzilla.mozilla.org/show_bug.cgi?id=884471), and that's more than enough at one time :-( On 7/

Re: Shutting off leak tests?

2013-07-15 Thread Doug Turner
Has a developer investigated? Steven, do you know anything about this? doug Chris AtLee wrote: Hi! Leak tests on OSX have been failing intermittently for nearly a year now[1]. As yet, we don't have any ideas why they're failing, and nobody is working on fixing them. Would anybody be very sad

Re: Shutting off leak tests?

2013-07-15 Thread Ralph Giles
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 13-07-15 1:45 PM, Chris AtLee wrote: > Would anybody be very sad if we shut them off? I would be happy if you did, for the reasons you state. Please shut them off. -r -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.13 (Darwin) Comment: Using

Shutting off leak tests?

2013-07-15 Thread Chris AtLee
Hi! Leak tests on OSX have been failing intermittently for nearly a year now[1]. As yet, we don't have any ideas why they're failing, and nobody is working on fixing them. Would anybody be very sad if we shut them off? Are these tests providing useful information any more? If they are stil