Re: [dev-servo] PSA: Review delegation enabled for homu

2015-11-12 Thread Manish Goregaokar
Bit late to the party, but I think there are a couple of core issues causing this debate: There are actually two kinds of trust involved. First is the trust to not botnet the CI, basically everyone here (at least everyone with try) has that. But that's not the actual one being discussed here. The

Re: [dev-servo] diverging Servo' Browser API from Gecko' Browser API?

2015-11-12 Thread Josh Matthews
My understanding is that we want to be able to use Firefox OS as a testcase for Servo, so it seems important to maintain compatibility with Gecko's Browser API. On 2015-11-12 10:05 AM, Paul Rouget wrote: to dev-servo. dev-platform cc'ed. context: browser.html + servo There are some changes w

[dev-servo] diverging Servo' Browser API from Gecko' Browser API?

2015-11-12 Thread Paul Rouget
to dev-servo. dev-platform cc'ed. context: browser.html + servo There are some changes we'd like to make to the Browser API. At least, we'd like to always use event.detail instead of event.details (because DOM events use detail, not details). Also, the details field in Gecko can be a string, or

Re: [dev-servo] PSA: Review delegation enabled for homu

2015-11-12 Thread Till Schneidereit
> > >> On Wed, Nov 11, 2015 at 10:59 PM, Nicholas Nethercote < > n.netherc...@gmail.com> wrote: > >> On the other hand, I'm more optimistic than bholley about the per-bug > >> delegation. Given that it's been implemented I'd suggest using it and > >> if reviewers do tend to forget it then consider

Re: [dev-servo] PSA: Review delegation enabled for homu

2015-11-12 Thread Lars Bergstrom
> On Nov 11, 2015, at 8:31 PM, Bobby Holley wrote: > > On Wed, Nov 11, 2015 at 4:22 PM, Lars Bergstrom wrote: > I've been assuming the only time that we would use `delegate` is for > people like you (Bobby), whom we trust, but who have not gone through > the process to become a Servo reviewer.