Re: [dev-servo] Fwd: Re: Suggested code review workflow

2016-02-21 Thread Manish Goregaokar
One thing that I've found pretty useful (at least when digging into the history of some Rust feature) is that the merge commits in both Rust and Servo contain the full contents of the pull request text (not comments, just the PR message). However, there still are "fixes #123" type PR messages since

Re: [dev-servo] Suggested code review workflow

2016-02-21 Thread smaug
On 02/13/2016 07:26 AM, Josh Matthews wrote: On 2016-02-12 6:16 PM, Olaf Buddenhagen wrote: Hi, On Wed, Feb 03, 2016 at 02:21:46PM -0500, Boris Zbarsky wrote: On 2/3/16 1:46 PM, Josh Matthews wrote: https://github.com/servo/servo/wiki/Code-review Somewhere in there, one should read the co