Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Bobby Holley
On Mon, Feb 13, 2017 at 11:47 AM, Chris Peterson wrote: > On 2/12/2017 7:31 PM, Bobby Holley wrote: > >> There are two important pieces of our integration story that we still >> lack: >> (1) Running Firefox CI on Servo commits. >> > > Here you are talking about running Firefox tests on Servo pull

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Chris Peterson
On 2/12/2017 7:31 PM, Bobby Holley wrote: There are two important pieces of our integration story that we still lack: (1) Running Firefox CI on Servo commits. Here you are talking about running Firefox tests on Servo pull requests on GitHub before they are merged to servo/servo, right? We do

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Anthony Ramine
I have a few questions: Which changes will need to go through Firefox CI? How long does Firefox CI take to run all the tests? What happens if the bug is on Firefox's side? > Le 13 févr. 2017 à 20:50, Bobby Holley a écrit : > ___ dev-servo mailing l

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Manish Goregaokar
I think the plan is eventually that only a subset of changes go through Firefox CI, but this may not be the case when starting up. edunham would know. I think Firefox CI takes 2 hours or so, modulo coalescing. Not sure if we plan to reduce the tests run for pure-servo changesets. Firefox itself w

Re: [dev-servo] Quantum CSS (stylo) builds now on m-c

2017-02-13 Thread Jack Moffitt
> Firefox itself will run CI as usual so Firefox can't introduce bugs. Servo > may uncover a bug that needs Firefox changes to fix, in which case you have > to submit the unified change via the Firefox contribution process. We are hoping this case will be very rare, and Manish and others are willi