Re: [dev-servo] PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-13 Thread Xidorn Quan
On Sun, Jan 14, 2018, at 1:36 AM, Anthony Ramine wrote: > I would much rather prefer if we just checked that we didn't use the > Debug impls of large types. We could also just not derive them in > release mode. > > In the PR you link, AFAICT you also removed some uses that were just > very smal

Re: [dev-servo] PSA: Servo now uses rustup.rs, you can probably free up some disk space

2018-01-13 Thread pyfisch
Thanks. The .cargo folder contained .cargo/git and .cargo/registry but also the file. .cargo/config. So in the future it will only ever contain this one file? ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-s

Re: [dev-servo] PSA: Servo now uses rustup.rs, you can probably free up some disk space

2018-01-13 Thread Simon Sapin
On 13/01/18 23:35, pyfi...@gmail.com wrote: Hi, I deleted .cargo and noticed that there was a file .cargo/config in this folder which is still part of the git repo. (https://github.com/servo/servo/blob/7b92eb932b34ce1a4b823b2571a50a928491b4b2/.cargo/config) Is it still needed or can it be remo

Re: [dev-servo] PSA: Servo now uses rustup.rs, you can probably free up some disk space

2018-01-13 Thread pyfisch
> Similarly, in the default config we used to override $CARGO_HOME (which > contains a cache of crates.io and git dependencies) to .cargo under the > repo. You also remove that, now we leave the environment’s $CARGO_HOME > (which defaults to ~/.cargo). This cache is now shared with other clones

Re: [dev-servo] PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-13 Thread Anthony Ramine
That being said, looking at nsCSSParser.cpp in Gecko, I just realised you never had similar code (printing values when some invariant is broken). Given how old Gecko is, I guess that means this is not even useful to begin with (I mean the printing you removed was not useful to begin with, just t

Re: [dev-servo] PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-13 Thread Anthony Ramine
I would much rather prefer if we just checked that we didn't use the Debug impls of large types. We could also just not derive them in release mode. In the PR you link, AFAICT you also removed some uses that were just very small enums or even integers, which may not be necessary. > Le 13 janv.

Re: [dev-servo] PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-13 Thread Lars Bergstrom
At least for Servo, should we add a check to tidy ( https://github.com/servo/servo/blob/master/python/tidy/servo_tidy/tidy.py) immediately to catch the use of that fairly-unique formatting string, as we do for a bunch of other random stuff? We can always exempt particular files/folder where we thin