Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Manish Goregaokar
Just remove the Copy requirement on the OscillatorOptions type, it's not necessary. -Manish Goregaokar On Thu, Nov 15, 2018 at 4:15 PM Avanthikaa Ravichandran wrote: > Thank you so much. > We are also trying to implement the periodic wave option for the oscillator > node. The sizes of the real

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Avanthikaa Ravichandran
Thank you so much. We are also trying to implement the periodic wave option for the oscillator node. The sizes of the real and imag arrays in the PeriodicWaveOptions structure are not fixed during compile time and need to be generated based on the input terms. For this, we thought of using a vector

Re: [dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Manish Goregaokar
Yes, it's f(x) = k. Note that `k` here is an AudioParam, so it's not always a constant -- similar to how frequency in OscillatorSourceNode or gain in GainNode can vary per frame. -Manish Goregaokar On Thu, Nov 15, 2018 at 2:48 PM Avanthikaa Ravichandran wrote: > Hi, > > We are working on imple

[dev-servo] Mozilla Servo Media - Implementing WebAudio Nodes

2018-11-15 Thread Avanthikaa Ravichandran
Hi, We are working on implementing the missing WebAudio nodes in servo-media. One of the initial steps says* ‘implement the missing ConstantSource node type that produces a constant tone based on a stored value that can be modified using the GainNode implementation as a model*'. Am I right in und