Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Srivatsan Narasimhan
Hi Josh, I wrote the two methods with the help of the links you gave before and it is building without anu errors. Now i have some doubts regarding the NotSupportedError message. I am not sure when to call that because in the method description it says that it should be thrown if any of the attribu

Re: [dev-servo] Tree is closed for linux CI upgrade

2019-04-26 Thread Josh Bowman-Matthews
Everything worked smoothly the first time and https://github.com/servo/servo/pull/23182 successfully merged! I have reopened the tree, and I'll deal with the remaining TravisCI issues in https://github.com/servo/saltfs/pull/957 separately. If you need to deploy any changes to saltfs, please che

[dev-servo] Tree is closed for linux CI upgrade

2019-04-26 Thread Josh Bowman-Matthews
Since I have successfully performed builds on Xenial-based linux machines, I am closing the tree so I can upgrade the servo-linux[1-6] and servo-linux-cross[1-3] build machines from Trusty to Xenial. I hope to have the process complete by end of day. I'll track my progress in https://github.com

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Josh Bowman-Matthews
To throw a NotSupportedError, you can use https://dxr.mozilla.org/servo/source/components/script/dom/audionode.rs#280 as an example, and see that the WebIDL contains either [Throws] (for a method) or [SetterThrows]/[GetterThrows] for an attribute (https://dxr.mozilla.org/servo/rev/56c2e85cab5b0

Re: [dev-servo] Regarding CSC 517 OSS project

2019-04-26 Thread Niveditha Shankar
Hi Josh, We tried to run servo with our modified devices crate. Now we are getting the following errors, error[E0277]: the size for values of type `(dyn device::adapter::BluetoothAdapter + 'static)` cannot be known at compilation time --> components/bluetooth/lib.rs:193:5 | 193 | a

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Akhilesh Venkatasubramanian
HI CYBAI, 1. We are trying to implement the SetOrientation and the SetPosition methods as here . We tried quite a few variations, but not able to store the passed function value into forwardX

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Cheng You Bai
Hi Srivatsan, This is CYBAI who is a Servo contributor. I think you can try to read this blogpost . It explains how to add a new DOM API for Servo from scratch and also includes the uncomment methods part. Hope it help! Cheers, CY