-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi all,
Consecutive lines of imports are now sorted, thanks to Johann Tuffe.
test-tidy will complain about any violations.
This does have the unfortunate consequence that most PRs will have
been bitrotted; apologies for the inconvenience.
Ms2ger
---
On Thu, Aug 20, 2015 at 7:54 AM, Ms2ger wrote:
>
> Consecutive lines of imports are now sorted, thanks to Johann Tuffe.
> test-tidy will complain about any violations.
You're talking about `use` items, right? It looks like they're sorted
within each group, but you can still have separate groups.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Nick,
On 08/21/2015 03:15 AM, Nicholas Nethercote wrote:
> On Thu, Aug 20, 2015 at 7:54 AM, Ms2ger wrote:
>>
>> Consecutive lines of imports are now sorted, thanks to Johann
>> Tuffe. test-tidy will complain about any violations.
>
> You're talk
On Fri, Aug 21, 2015 at 4:40 AM, Ms2ger wrote:
>>
>> You're talking about `use` items, right? It looks like they're
>> sorted within each group, but you can still have separate groups.
>> (Where the boundary between a group is a blank line.) Is that
>> right?
>
> That's correct.
Unfortunately the
On 25/08/15 08:22, Nicholas Nethercote wrote:
Unfortunately the group ordering is inconsistent and sometimes wrong.
For example, in some files it goes:
- imports from this crate
- imports from other Servo crates
- imports from non-Servo crates
- imports from built-in crates
I’m in favor of a s
> I’m in favor of a single alphabetical-order group.
Nicholas's points are all valid, and while I kind of like the
groupings, I have no objection to a single alphabetical list.
jack.
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.m
I usually use two groups, but I'm about ready to give up, since it seems
impossible to maintain without tool support. Count me in for one group.
Patrick
On Aug 25, 2015 8:52 AM, "Jack Moffitt" wrote:
> > I’m in favor of a single alphabetical-order group.
>
> Nicholas's points are all valid, and
7 matches
Mail list logo
