Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Simon Sapin
On 01/03/17 18:38, Manish Goregaokar wrote: FWIW gps planned to strip @mentions in the autosync service, so most of the pain here could go away. Even only within servo/servo @-mentions in PR messages or commit messages still cause more email than necessary. So please keep them to separate PR

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Manish Goregaokar
FWIW gps planned to strip @mentions in the autosync service, so most of the pain here could go away. It already strips the boilerplate. -Manish Goregaokar On Wed, Mar 1, 2017 at 9:35 AM, Jack Moffitt wrote: > I agree that seems noisy and irrelevant I could have sworn we > previously had a patch

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Emilio Cobos Álvarez
On Wed, Mar 01, 2017 at 08:13:36AM -0700, Jack Moffitt wrote: > It contains a cohesive description of the entire set of changes. It > would be a shame to omit it. I think the reality is really far away from this. At least, we should strip the PR template boilerplate, the HTML comments meant to ind

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Jack Moffitt
I agree that seems noisy and irrelevant I could have sworn we previously had a patch to homu to remove the template. Did this regress or am I misremembering? jack. On Wed, Mar 1, 2017 at 10:29 AM, Emilio Cobos Álvarez wrote: > On Wed, Mar 01, 2017 at 08:13:36AM -0700, Jack Moffitt wrote: >> It c

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Anthony Ramine
> Le 1 mars 2017 à 15:41, Kartikaya Gupta a écrit : > > What was the rationale behind this, out of curiousity? Note that this is GH's default behaviour too when hitting the big green button. ___ dev-servo mailing list dev-servo@lists.mozilla.org http

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Simon Sapin
On 01/03/17 16:32, Nicholas Matsakis wrote: Something I learned the hard way is to avoid a sentence like this one: "Does not fix #123." Github will dutifully detect "fix #123" and close the corresponding issue. =) On Wed, Mar 1, 2017 at 10:21 AM, Alan Jeffrey wrote: The other thing I learn

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Nicholas Matsakis
Something I learned the hard way is to avoid a sentence like this one: "Does not fix #123." Github will dutifully detect "fix #123" and close the corresponding issue. =) On Wed, Mar 1, 2017 at 10:21 AM, Alan Jeffrey wrote: > The other thing I learned the hard way is not to #N-mention any

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Alan Jeffrey
The other thing I learned the hard way is not to #N-mention any issues that aren't to be closed when then PR is merged. On Wed, Mar 1, 2017 at 9:13 AM, Jack Moffitt wrote: > It contains a cohesive description of the entire set of changes. It > would be a shame to omit it. In the cases of a P

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Jack Moffitt
It contains a cohesive description of the entire set of changes. It would be a shame to omit it. In the cases of a PR with a single commit, this is the same as the commit message by default I think, but perhaps we detect that and don't duplicate. jack. On Wed, Mar 1, 2017 at 7:41 AM, Kartikaya Gu

Re: [dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Kartikaya Gupta
On Wed, Mar 1, 2017 at 6:02 AM, Simon Sapin wrote: > The first message of a pull request is copied into the merge commit when > bors/homu merges it. What was the rationale behind this, out of curiousity? Cheers, kats ___ dev-servo mailing list dev-serv

[dev-servo] Please avoid @-mentioning people in commit or PR messages

2017-03-01 Thread Simon Sapin
The first message of a pull request is copied into the merge commit when bors/homu merges it. When a commit with an @-mention in the message is pushed to any branch, GitHub sends an email notification to that person (unless they have disabled email notifications). Servo commits tend to be push