Re: handshake, next handshake, security handshake

2006-09-27 Thread Kyle Hamilton
Converse: If it's confusing, it's broken. Maintenance is a primary concern, and transparency is a primary concern in maintainable code. If someone's digging deeply enough to get confused by it, and there's inconsistency (aka obscurity) in the code that is examined when they look at it, it might

Re: handshake, next handshake, security handshake

2006-09-27 Thread Peter Djalaliev
Nelson, I completely agree with you about this not having to be a priority. Code transparency is definitely important, ambivalent/outdated code can cause the introduction of new bugs down the road, but it's eventually up to the NSS maintainers/contributors to decide what has higher priority.

Re: handshake, next handshake, security handshake

2006-09-27 Thread Wan-Teh Chang
Kyle Hamilton wrote: Converse: If it's confusing, it's broken. Maintenance is a primary concern, and transparency is a primary concern in maintainable code. If someone's digging deeply enough to get confused by it, and there's inconsistency (aka obscurity) in the code that is examined when they

Re: handshake, next handshake, security handshake

2006-09-26 Thread Peter Djalaliev
Helson, Thanks for you reply :) What is the ss-securityHandshake used for? I think it may now be unused. I think it was part of the old SOCKS implementation that was abandoned. This probably doesn't matter as much, but ssl_SecureConnect sets the handshake function using

Re: handshake, next handshake, security handshake

2006-09-25 Thread Nelson B
Peter Djalaliev wrote: Hello, I have a question about something I don't understand in the SSL implementation of NSS. When ssl_Do1stHandshake is called, it checks three handshake function pointers in the sslSocket struct: handshake, nextHandshake and securityHandshake. What is the

handshake, next handshake, security handshake

2006-09-22 Thread Peter Djalaliev
Hello, I have a question about something I don't understand in the SSL implementation of NSS. When ssl_Do1stHandshake is called, it checks three handshake function pointers in the sslSocket struct: handshake, nextHandshake and securityHandshake. What is the difference between the three? I can