Re: [JS-internals] YarrCanonicalizeUCS2.cpp

2013-06-18 Thread David Anderson
FWIW, I imported these file in our most recent YARR update (that was probably around a year ago?). Both files were directly from WebKit SVN. I didn't attempt to do any generation from the .js file. -David On 06/18/2013 06:18 PM, Nicholas Nethercote wrote: > Hi, > > YarrCanonicalizeUCS2.cpp is au

Re: [JS-internals] YarrCanonicalizeUCS2.cpp

2013-06-18 Thread Brendan Eich
Cc'ing Norbert and Allen. /be Nicholas Nethercote wrote: Hi, YarrCanonicalizeUCS2.cpp is autogenerated by YarrCanonicalizeUCS2.js, and yet we have a copy checked into the repository. Furthermore, if you run YarrCanonicalizeUCS2.js the output doesn't match our in-repo version of YarrCanonicali

[JS-internals] YarrCanonicalizeUCS2.cpp

2013-06-18 Thread Nicholas Nethercote
Hi, YarrCanonicalizeUCS2.cpp is autogenerated by YarrCanonicalizeUCS2.js, and yet we have a copy checked into the repository. Furthermore, if you run YarrCanonicalizeUCS2.js the output doesn't match our in-repo version of YarrCanonicalizeUCS2.cpp. Part of that is superficial changes, such as the

Re: [JS-internals] #include and #ifndef wrapper stuff

2013-06-18 Thread Nicholas Nethercote
On Fri, Jun 14, 2013 at 5:32 PM, Nicholas Nethercote wrote: > On Sat, Jun 15, 2013 at 10:16 AM, Luke Wagner wrote: >> >> Although 0 files do it already, we could switch to a single trailing _. > > Fine by me! I'll convert them next week. Emanuel submitted some patches doing the full conversion