Re: [JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Birunthan Mohanathas
On 27 March 2015 at 01:19, Bobby Holley wrote: > Can we switch from 4-space to 2-space indentation at some point too? > Together, those would remove the most glaring formatting differences. The > others (bracing single-line consequents, aNamingWarts, etc) might be harder. I've done all of that an

Re: [JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Nicholas Nethercote
On Fri, Mar 27, 2015 at 10:25 AM, Robert O'Callahan wrote: > > Switching method names to start with a capital letter would be helpful too > ... especially where it's leaked into MFBT. FWIW, here is the contents of mfbt/STYLE: > MFBT uses standard Mozilla style, with the following exceptions. > >

Re: [JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Eric Shepherd (Sheppy)
Is the bug tasking this marked dev-doc-needed? We will have SD A bunch of cleanup to do On Thursday, March 26, 2015, Jan De Mooij wrote: > Hi all, > > After some discussion, we want to switch SpiderMonkey and XPConnect style > for pointers/references from |T *p| to |T* p| (and |T &ref| to |T& r

Re: [JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Robert O'Callahan
On Fri, Mar 27, 2015 at 12:19 PM, Bobby Holley wrote: > \o/ > > Can we switch from 4-space to 2-space indentation at some point too? > Together, those would remove the most glaring formatting differences. The > others (bracing single-line consequents, aNamingWarts, etc) might be > harder. > Swit

Re: [JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Bobby Holley
\o/ Can we switch from 4-space to 2-space indentation at some point too? Together, those would remove the most glaring formatting differences. The others (bracing single-line consequents, aNamingWarts, etc) might be harder. On Thu, Mar 26, 2015 at 3:52 PM, Jan De Mooij wrote: > Hi all, > > Afte

[JS-internals] SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

2015-03-26 Thread Jan De Mooij
Hi all, After some discussion, we want to switch SpiderMonkey and XPConnect style for pointers/references from |T *p| to |T* p| (and |T &ref| to |T& ref|). This matches the rest of the project and will make life easier for developers working on multiple parts of the tree. Although this will break