Re: [JS-internals] Reducing SpiderMonkey's crash rate

2016-05-04 Thread Nicholas Nethercote
On Thu, May 5, 2016 at 3:14 AM, Jan de Mooij wrote: > > Results are here: > > https://bugzilla.mozilla.org/show_bug.cgi?id=1034706#c44 Thank you. Very useful data! Nick ___ dev-tech-js-engine-internals mailing list dev-tech-js-engine-internals@lists.mo

Re: [JS-internals] Reducing SpiderMonkey's crash rate

2016-05-04 Thread Jan de Mooij
On Thu, Apr 28, 2016 at 5:51 PM, Jan de Mooij wrote: > I will take a look at a number of JIT code crashes this week and > categorize them manually. > Results are here: https://bugzilla.mozilla.org/show_bug.cgi?id=1034706#c44 Jan ___ dev-tech-js-engin

Re: [JS-internals] Reducing SpiderMonkey's crash rate

2016-05-04 Thread faust . wallstreet
On Monday, May 2, 2016 at 4:35:33 PM UTC-7, Nicholas Nethercote wrote: > > - Should we look at how to make browser not a pain in debug builds (will > > make it harder to get the expected asserts)? Hoping that more people run it? > > Or will people still not run debug builds. > > - Should we look in

Re: [JS-internals] Generating an ErrorReport from a thrown value

2016-05-04 Thread Boris Zbarsky
On 5/4/16 11:40 AM, Ehsan Akhgari wrote: 1. If the JS code throws an ErrorObject (such as |throw new Error("foo");|) I get the line and column info as expected, but if it throws something else (such as |throw new "foo";|) then the line and column number seem to always be 0. That's because we do

[JS-internals] Generating an ErrorReport from a thrown value

2016-05-04 Thread Ehsan Akhgari
What's the correct way to get detailed information about an exception in SpiderMonkey? Right now I'm using js::ErrorReport and am getting a JSErrorReport* out of it, like this: < https://github.com/mozilla/spidernode/blob/a8d3d29956b6b7378b004e1dcde60f6528c60386/deps/spidershim/src/v8message.cc#L3

Re: [JS-internals] Reducing SpiderMonkey's crash rate

2016-05-04 Thread Nicolas B. Pierron
On 05/03/2016 08:10 PM, Steve Fink wrote: On 05/03/2016 11:11 AM, Jakob Stoklund Olesen wrote: LLVM had an EXPENSIVE_CHECKS macro for that kind of assertion, but I don’t think they use it any more. People would rarely enable it, so the expensive assertions had a tendency to bit rot. I think if t