Re: [JS-internals] Clang-format

2016-05-12 Thread Ehsan Akhgari
On 2016-05-12 9:53 AM, Nicolas B. Pierron wrote: > The more we empower people for working only on their domain(s) of > expertise, the less we would have need for such heroes. Having persons > responsible for the integration would help us on that. As someone who has worked on many parts of the bro

Re: [JS-internals] Clang-format

2016-05-12 Thread Nicolas B. Pierron
On 05/11/2016 06:31 PM, Bill McCloskey wrote: On Wed, May 11, 2016 at 5:01 AM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: If the problem are the pointless arguments on dev.platform, which are mistakenly considering SpiderMonkey as Gecko's property, I would totally agree on movin

Re: [JS-internals] Clang-format

2016-05-12 Thread Benjamin Bouvier
Agreed to everything Bill said. When it comes to the styling discussion, I don't really care about using one style or the other. I didn't like SM style at first, and now I am so used to it that I naturally use it everywhere (Stockholm syndrome?). What I do care about though is to be able to autom

Re: [JS-internals] Clang-format

2016-05-12 Thread Bobby Holley
On Wed, May 11, 2016 at 5:01 AM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: > On 05/11/2016 02:15 AM, Jason Orendorff wrote: > >> instead go with Terrence’s suggestion and simply adopt the same style as >>> the rest of Gecko, including the 2-space indent. >>> >>> >> I've said befor

Re: [JS-internals] Clang-format

2016-05-12 Thread Nicholas Nethercote
My first 1 or 2 years at Mozilla I spent entirely working on Spidermonkey. I was happy with it, and I even joked that I never wanted to work on the browser proper because compile times were so long compared the to JS shell. But eventually I branched out and worked on other components, and I'm glad