Re: [JS-internals] Proposal: always use braces for if/for/while statements

2018-09-05 Thread Jeff Walden
On 09/05/2018 02:29 AM, Benjamin Bouvier wrote: > I don't buy Jeff's argument at all; in the case of the (in)famous Apple SSL > bug, there *was* proper indentation and missing braces on the if, and > though this wasn't enough to catch the failure. *Having* the rule is not the same as *enforcing* i

Re: [JS-internals] Proposal: always use braces for if/for/while statements

2018-09-05 Thread Ehsan Akhgari
On Tue, Sep 4, 2018 at 12:49 PM Bobby Holley wrote: > +1 > > The one downside of doing this now is that we'll eventually do another bulk > reformat of all of mozilla-central once we settle on a clang-format > version+config whose output we're happy with. So if that were to happen > very soon (unl

Re: [JS-internals] Proposal: always use braces for if/for/while statements

2018-09-05 Thread Benjamin Bouvier
I don't buy Jeff's argument at all; in the case of the (in)famous Apple SSL bug, there *was* proper indentation and missing braces on the if, and though this wasn't enough to catch the failure. Meta bug 1297639 has dependents that show real-world issues because of missing braces, including in Gecko