Re: [JS-internals] Can SpiderMonkey build without NSPR on Windows?

2019-06-04 Thread Jan de Mooij
On Tue, Jun 4, 2019 at 5:48 PM Steve Fink wrote: > The library loading stuff is used for ctypes as well, which is used by > Firefox. It was the last difficult piece to remove. > True, but most shell and SpiderMonkey builds don't use --enable-ctypes so I think it would still be a win to drop NSPR

Re: [JS-internals] Can SpiderMonkey build without NSPR on Windows?

2019-06-04 Thread Steve Fink
The library loading stuff is used for ctypes as well, which is used by Firefox. It was the last difficult piece to remove. On 6/4/19 1:34 AM, Jan de Mooij wrote: Oh I forgot about the PR_LoadLibraryWithFlags call in JS shell code. We should make that optional too... Jan On Tue, Jun 4, 2019 at

[JS-internals] x86/x64 disassembler

2019-06-04 Thread Lars Hansen
I've just landed a patch to embed Zydis, a general x86/x64 disassembler, in SpiderMonkey, so that Cranelift can have reliably disassembly with IONFLAGS=codegen. (We already have ARM and ARM64 disassemblers and can use those when we get around to those platforms). Right now Zydis is compiled in on

Re: [JS-internals] Can SpiderMonkey build without NSPR on Windows?

2019-06-04 Thread Jan de Mooij
Oh I forgot about the PR_LoadLibraryWithFlags call in JS shell code. We should make that optional too... Jan On Tue, Jun 4, 2019 at 10:18 AM Jan de Mooij wrote: > It's possible to build SpiderMonkey without depending on NSPR with > --enable-posix-nspr-emulation, this uses the implementation in

Re: [JS-internals] Can SpiderMonkey build without NSPR on Windows?

2019-06-04 Thread Jan de Mooij
It's possible to build SpiderMonkey without depending on NSPR with --enable-posix-nspr-emulation, this uses the implementation in js/src/vm/PosixNSPR.{h,cpp} However these days we only depend on NSPR for memory mapped files in Wasm code (note that the PosixNSPR versions just crash because this API,