Re: [JS-internals] Do we want the old AWFY charts to be available online?

Since there is a silent consensus that such an archive website would not be needed, I'll go ahead and close bug 1489998 as WONTFIX. Cheers, Benjamin On Wed, Sep 12, 2018 at 2:59 PM Benjamin Bouvier wrote: > As you might have noticed, ye olde AreWeFastYet is no more and has been >

[JS-internals] Do we want the old AWFY charts to be available online?

As you might have noticed, ye olde AreWeFastYet is no more and has been replaced by a combination of Perfherder (backend) and js-perf-dashboard (frontend) by the Automation team. This email is not about presenting new capabilities that this system offers, or to explain how it works, how to add a te

Re: [JS-internals] Proposal: always use braces for if/for/while statements

I don't buy Jeff's argument at all; in the case of the (in)famous Apple SSL bug, there *was* proper indentation and missing braces on the if, and though this wasn't enough to catch the failure. Meta bug 1297639 has dependents that show real-world issues because of missing braces, including in Gecko

[JS-internals] Let's crowdsource JS shell flag combinations for fuzzing

See bug 1461689 for a full description and rationale. TL;DR: let's add a text file containing a list of interesting JS shell flag combinations so that our fuzzing people can parse this file and automatically pick random combinations from it. P

Re: [JS-internals] C++ coding style rule for keeping class fields together

2017-09-28 20:25 GMT+02:00 Jim Blandy : > On Thu, Sep 28, 2017 at 1:55 AM, Benjamin Bouvier wrote: > >> Agreed with Lars. In particular regarding (b), I tend to read unknown code >> by starting with the data (the "what") then look at how it's manipulated >>

Re: [JS-internals] C++ coding style rule for keeping class fields together

Agreed with Lars. In particular regarding (b), I tend to read unknown code by starting with the data (the "what") then look at how it's manipulated (the "how"). This stylistic change would be a huge regression to me, and there are already some places where the fields are grouped at the end, which I

[JS-internals] AWFY: Update of Speedometer2

TL;DR: speedometer2 results may vary in the next few hours, and it may not be caused by changes in our code. As you probably know, AreWeFastYet measures the performance of Speedometer2 over time for the Firefox 57 release. Historically, the URL used by AWFY for Speedometer2 pointed to my personal

[JS-internals] PSA: the JS shell must now be compiled with SSE2 support on x86 platforms

Following https://groups.google.com/d/topic/mozilla.dev.platform/v3Mz5iuMkig/discussion, Firefox builds now include SSE2 flags on all tier-1 32-bits x86 platforms. The Spidermonkey JS shell using a different build system, the SSE2 flags have not been included until bug 1326027 landed. Bug 1326027 a

Re: [JS-internals] Clang-format

Agreed to everything Bill said. When it comes to the styling discussion, I don't really care about using one style or the other. I didn't like SM style at first, and now I am so used to it that I naturally use it everywhere (Stockholm syndrome?). What I do care about though is to be able to autom

[JS-internals] AsmJS files moved to js/src/asmjs

Hi all, Following recent work, AsmJS files have been moved to their own /js/src/asmjs directory and AsmJS.{h,cpp} have been renamed into AsmJSValidate.{h,cpp}. This might impact your work if you have patches modifying these files. Here is the sed line to apply to modify references to the files: