Re: [JS-internals] Generator bindings approaches

2020-05-13 Thread Jan de Mooij
On Wed, May 13, 2020 at 7:54 PM Jason Orendorff wrote: > Jan, I'd like to know what you think about this. > Approach 2 is what we used to do before the big generator rewrite that resulted in Baseline JIT support. Problems I see with bringing it back: - It ties the generator's heap representa

Re: [JS-internals] Generator bindings approaches

2020-05-13 Thread Iain Ireland
On Wednesday, May 13, 2020 at 1:54:09 PM UTC-4, Jason Orendorff wrote: > Ted and I had a fun conversation just now about bindings in generators. > Jan, I'd like to know what you think about this. > > Currently, in generators, all bindings—arguments, locals, etc.—are > marked as "aliased". It's slo

[JS-internals] Generator bindings approaches

2020-05-13 Thread Jason Orendorff
Ted and I had a fun conversation just now about bindings in generators. Jan, I'd like to know what you think about this. Currently, in generators, all bindings—arguments, locals, etc.—are marked as "aliased". It's slow. Two possible fixes: 1. LOCALS ON GENERATOR Add bytecode instructions fo