Re: [JS-internals] jsid: struct vs int

2013-08-23 Thread Nicolas B. Pierron
On 08/23/2013 08:20 AM, Luke Wagner wrote: At any rate, we're definitely already screwed on compilers than don't properly optimized those kinds of structs. (See Value!) Value gets passed around by 'const Value &' since, on 32-bit, it gets passed on the stack anyways. Well, and HandleValue, bu

Re: [JS-internals] jsid: struct vs int

2013-08-23 Thread Luke Wagner
> > I'm wondering if this whole game is even necessary. Could we use the > > struct version in opt builds as well? The only reason I can think not > > to is if some compilers do not optimize a struct containing a single > > integer as well as they would a naked integer. That's right, in particul

Re: [JS-internals] jsid: struct vs int

2013-08-22 Thread Benjamin Peterson
2013/8/22 Nicholas Nethercote : > Hi, > > |jsid| is a struct in debug builds and an integral type in opt builds. > From jspubtd.h: > > /* > * In release builds, jsid is defined to be an integral type. This > * prevents many bugs from being caught at compile time. E.g.: > * > * jsid id = ... >

[JS-internals] jsid: struct vs int

2013-08-22 Thread Nicholas Nethercote
Hi, |jsid| is a struct in debug builds and an integral type in opt builds. From jspubtd.h: /* * In release builds, jsid is defined to be an integral type. This * prevents many bugs from being caught at compile time. E.g.: * * jsid id = ... * if (id) // error *... * * s