Re: Reflow branch XUL submenu issues

2006-08-02 Thread Boris Zbarsky
Boris Zbarsky wrote: Is there any good reason popups shouldn't be reflow roots? If not, then they should be. Conceptually, that would make a lot of sense to me. Is reflowing an nsBoxFrame equivalent to calling Layout() on the corresponding box? In any case, I'll try doing this. This does

Re: Reflow branch XUL submenu issues

2006-08-02 Thread Boris Zbarsky
L. David Baron wrote: On Wednesday 2006-08-02 21:50 -0500, Boris Zbarsky wrote: Setting the popup as a reflow root causes asserts in nsHTMLReflowState, since it's an unknown type of out-of-flow. So I think the right thing to Is there any good reason popups shouldn't be reflow roots? If not,

Re: Reflow branch XUL submenu issues

2006-08-02 Thread L. David Baron
On Wednesday 2006-08-02 21:50 -0500, Boris Zbarsky wrote: > Setting the popup as a reflow root causes asserts in nsHTMLReflowState, > since it's an unknown type of out-of-flow. So I think the right thing to Is there any good reason popups shouldn't be reflow roots? If not, then they should be.

Re: Reflow branch XUL submenu issues

2006-08-02 Thread Boris Zbarsky
Boris Zbarsky wrote: It seems odd to me that we can have a frame with NS_FRAME_HAS_DIRTY_CHILDREN set while mDirtyRoots is empty and we're not in the middle of reflow. Or can this happen in some sane way? OK, this is in fact happening in an insane way. We're messing with a kid of the popup,

Reflow branch XUL submenu issues

2006-08-02 Thread Boris Zbarsky
So I was poking around at why submenus of XUL context menus don't appear on reflow branch (see attached testcase). It looks like when we call PresShell::FrameNeedsReflow() on the menupopup, we bail out early because the nsMenuFrame has NS_FRAME_HAS_DIRTY_CHILDREN set. But mDirtyRoots is empty

Re: Scrollframe ascent

2006-08-02 Thread Robert O'Callahan
Boris Zbarsky wrote: It looks like nsGfxScrollFrame doesn't include its top padding in its ascent calculation. Is this purposeful? I ran into this because the baseline of a listbox is about 1px off from where it "should" be and I was just wondering whether I should fix this in listbox code (b

Re: Dom with Rendering info for HTML pages

2006-08-02 Thread alex
Recently I'm trying to explore gecko engine also, it seems a seperately self-maintained codebase of render engine is what many guys want, but it seems it's very hard to extract the codes from the firefox / mozilla codebase yet (At least I didn't find a good solution yet. According to the document,