Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
Claudenw commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1587463735
##
apache-rat-core/src/main/java/org/apache/rat/config/parameters/ComponentType.java:
##
@@ -28,6 +28,6 @@ public enum ComponentType {
MATCHER,
/** A Parameter for example the "id" parameter found in every component */
PARAMETER,
-/** A parameter that is supplied by the environment. Currently systems
using builders have to handle seting this. For example the list of matchers
for the "MatcherRefBuilder" */
-BULID_PARAMETER
+/** A parameter that is supplied by the environment. Currently systems
using builders have to handle setting this. For example the list of matchers
for the "MatcherRefBuilder" */
+BUILD_PARAMETER
Review Comment:
Thanks for catching this.
##
apache-rat-plugin/src/main/java/org/apache/rat/mp/util/ignore/GlobIgnoreMatcher.java:
##
@@ -25,11 +25,7 @@
import java.io.File;
import java.io.FileReader;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.List;
-import java.util.Optional;
+import java.util.*;
Review Comment:
Do not use '*" format for includes. If you are using IntelliJ you can
specify a large number of imports in the same package before * to stop this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579991867 ## apache-rat-core/spotbugs_ignore.xml: ## @@ -0,0 +1,27 @@ + + + + +
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579940463 ## apache-rat-core/spotbugs_ignore.xml: ## @@ -0,0 +1,27 @@ + + + + +
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on code in PR #238:
URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579989686
##
apache-rat-tasks/src/main/java/org/apache/rat/anttasks/Report.java:
##
@@ -318,7 +319,6 @@ public void log(Level level, String msg) {
write(Project.MSG_ERR, msg);
break;
case OFF:
- break;
default:
break;
}
Review Comment:
Done - thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579942537 ## apache-rat-plugin/spotbugs_ignore.xml: ## @@ -0,0 +1,27 @@ + + + + +
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579940463 ## apache-rat-core/spotbugs_ignore.xml: ## @@ -0,0 +1,27 @@ + + + + +
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
Claudenw commented on code in PR #238: URL: https://github.com/apache/creadur-rat/pull/238#discussion_r1579490672 ## apache-rat-core/spotbugs_ignore.xml: ## @@ -0,0 +1,27 @@ + + + + + + + + + + + + + + + + +
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2068186230 Most of the errors relate to the fact that many file operations rely on the default charset. Unfortunately newer version of the JDK provide constructors to specify an encoding, but as RAT still relies on JDK8 these changes will be bigger. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067991533 @Claudenw the thing is that it either breaks the build or not. One can configure exclusions in an XML file in order to tolerate certain bugs explicitly . I'll have a look, but the first report said roughly up to 100 errors per submodule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
Claudenw commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2067961771 My thought was to turn on the spotbugs and fix any critical errors at that time (the ones with the red circles). We should then open fixes to remove the yellow ones and/or determine if there are way to ignore them in specific cases (annotations perhaps?) so that we can fix the ones that need fixing and mark the ones that we determine are not an issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059927715 In order to be able to bring changes intro master I'd prefer to configure limits per module with the current threshold, thus we could make sure that no new stuff is being added and can fix the errors in an incremental way - WDYT @Claudenw ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] WIP: RAT-369: Add spotbugs to build and generate a report [creadur-rat]
ottlinger commented on PR #238: URL: https://github.com/apache/creadur-rat/pull/238#issuecomment-2059919599 @Claudenw in case of any errors the build fails. I'm not sure if it's that helpful or if we remove this setting on the branch . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@creadur.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
