[dpdk-dev] [PATCH] mk: fix linker script when re-building

2016-03-17 Thread Sergio Gonzalez Monroy
The linker script is generated by simply finding all libraries in RTE_OUTPUT/lib. The issue shows up when re-building the DPDK, hence already having a linker script in that directory, resulting in the linker script including itself. That does not play well with the linker. Simply filtering the

[dpdk-dev] Performance issue with uio_pci_generic driver

2016-03-17 Thread Simon Jouet
Hi everyone, First off I would like to thanks tmonjalo, Harry Van Harren and Bruce Richardson for the input they gave while I was trying to figure out the issue and pushing me to report the problem here ? Okay, so I was trying out some basic sanity benchmarks with DPDK before doing anything

[dpdk-dev] [PATCH] vhost: remove unnecessary memset for virtio net hdr

2016-03-17 Thread Xie, Huawei
On 3/16/2016 2:44 PM, Yuanhan Liu wrote: > We have to reset the virtio net hdr at virtio_enqueue_offload() > before, due to all mbufs share a single virtio_hdr structure: > > struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, }, 0}; > > foreach (mbuf) { >

[dpdk-dev] vhost: no protection against malformed queue descriptors in rte_vhost_dequeue_burst()

2016-03-17 Thread Xie, Huawei
On 3/16/2016 8:53 PM, Patrik Andersson R wrote: > Hello, > > When taking a snapshot of a running VM instance, using OpenStack > "nova image-create", I noticed that one OVS pmd-thread eventually > failed in DPDK rte_vhost_dequeue_burst() with repeating log entries: > >compute-0-6

[dpdk-dev] [PATCH] ixgbe: avoid unnessary break when checking at the tail of rx hwring

2016-03-17 Thread Jianbo Liu
On 16 March 2016 at 19:14, Bruce Richardson wrote: > On Wed, Mar 16, 2016 at 03:51:53PM +0800, Jianbo Liu wrote: >> Hi Wenzhuo, >> >> On 16 March 2016 at 14:06, Lu, Wenzhuo wrote: >> > HI Jianbo, >> > >> > >> >> -Original Message- >> >> From: dev [mailto:dev-bounces at dpdk.org] On

[dpdk-dev] [PATCH] eal/ppc: fix secondary process to map hugepages in correct order

2016-03-17 Thread gowrishankar
Could this patch be reviewed please. Thanks, Gowrishankar On Monday 07 March 2016 07:43 PM, Gowrishankar wrote: > From: Gowri Shankar > > For a secondary process address space to map hugepages from every segment of > primary process, hugepage_file entries has to be mapped reversely from the >

[dpdk-dev] vhost: no protection against malformed queue descriptors in rte_vhost_dequeue_burst()

2016-03-17 Thread Patrik Andersson R
Hi Huawei, thank you for the quick response and for the pointer to the 16.04-rc1 version. Nice! I think it would be great also to have a sanity check on the gpa_to_vva(). Although nothing recent has hit it we had some problems in that area in the past. Regards, Patrik On 03/17/2016 02:35 AM,

[dpdk-dev] Reg: promiscuous mode on VF

2016-03-17 Thread bharath paulraj
Hi Lu, Helin, Greg, Many thanks for your response, which is really quick. Now, If I want to implement L2 bridging with Intel virtualization technologies, using 82599 controller, then Michael is my only hope, as getting the new kernel versions and upstream support will take considerable amount

[dpdk-dev] [PATCH] app: fix for lpm in ip_pipeline

2016-03-17 Thread Michal Jastrzebski
From: Michal Kobylinski Updated ip_pipeline app is using new changes from LPM library (Increased number of next hops and added new config structure for LPM IPv4). Fixes: 7164439d017d ("lpm: add a new config structure for IPv4") Signed-off-by: Michal Kobylinski

[dpdk-dev] [PATCH] doc: mempool ABI deprecation notice for 16.07

2016-03-17 Thread Olivier Matz
Add a deprecation notice for coming changes in mempool for 16.07. Signed-off-by: Olivier Matz --- doc/guides/rel_notes/deprecation.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index 252a096..3e8e327

[dpdk-dev] [PATCH] mk: fix linker script when re-building

2016-03-17 Thread Panu Matilainen
On 03/17/2016 01:22 AM, Sergio Gonzalez Monroy wrote: > The linker script is generated by simply finding all libraries in > RTE_OUTPUT/lib. > > The issue shows up when re-building the DPDK, hence already having a > linker script in that directory, resulting in the linker script > including itself.

[dpdk-dev] Document8

2016-03-17 Thread dev@dpdk.org
-- next part -- A non-text attachment was scrubbed... Name: Document8.zip Type: application/zip Size: 4982 bytes Desc: Document8.zip URL: <http://dpdk.org/ml/archives/dev/attachments/20160317/77884823/attachment-0001.zip>

[dpdk-dev] Patch "Increased number of next hops for LPM IPv4" break IP Pipeline application

2016-03-17 Thread Jastrzebski, MichalX K
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zhang, Roy Fan > Sent: Monday, March 14, 2016 5:57 PM > To: dev at dpdk.org; Kobylinski, MichalX > Cc: Dumitrescu, Cristian ; Singh, Jasvinder > ; thomas.monjalon at 6wind.com; Glynn, > Michael J > Subject:

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-17 Thread Rahul Lakkireddy
On Thursday, March 03/10/16, 2016 at 16:03:30 +0300, Igor Ryzhov wrote: > Comment for "ierrors" counter says that it counts erroneous received packets. > But for some reason "imissed" counter is added to "ierrors" counter in most > drivers. It is a mistake, because missed packets are obviously

[dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-17 Thread Jan Mędala
> > > # > > +# Compile burst-oriented Amazon ENA PMD driver > > +# > > +CONFIG_RTE_LIBRTE_ENA_PMD=y > > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=y > > Do you really want initialization debuggin to be on by default? Normally, > we > keep all debug options disabled. This is actually error logging, so

[dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-17 Thread Thomas Monjalon
2016-03-17 14:48, Jan M?dala: > > > > > # > > > +# Compile burst-oriented Amazon ENA PMD driver > > > +# > > > +CONFIG_RTE_LIBRTE_ENA_PMD=y > > > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=y > > > > Do you really want initialization debuggin to be on by default? Normally, > > we > > keep all debug options

[dpdk-dev] [PATCH v4 1/2] eal/tile: add rte_vect.h and enable CONFIG_RTE_LIBRTE_LPM

2016-03-17 Thread Thomas Monjalon
Any news? a v5 could be part of the RC2. 2016-03-08 20:59, Thomas Monjalon: > 2016-02-09 23:04, Liming Sun: > > rte_vect.h was missing earlier thus LPM was disabled and l3fwd is > > not able to compile. This commit implements the vector api and > > enable LPM in the tilegx configuration by

[dpdk-dev] [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)

2016-03-17 Thread Thomas Monjalon
Hi Stephen, Please, could you turn it into a real patch with your sign-off? Thanks 2016-02-14 12:22, Stephen Hemminger: > A better patch would be to move the data structure into the > code block used, and get rid of the useless else (rte_panic never returns); > and fix the indentation, and use

[dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-17 Thread Jan Mędala
2016-03-17 14:57 GMT+01:00 Thomas Monjalon : > 2016-03-17 14:48, Jan M?dala: > > > > > > > # > > > > +# Compile burst-oriented Amazon ENA PMD driver > > > > +# > > > > +CONFIG_RTE_LIBRTE_ENA_PMD=y > > > > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=y > > > > > > Do you really want initialization debuggin

[dpdk-dev] [PATCH v8 0/4] DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-17 Thread Jan Medala
v3: Additional features for Amazon ENA: * Low Latenycy Queue (LLQ) for Tx * RSS v4: * Improved doc * Improved style according to checkpatch script * Fixed build problems on: i686, clang, +shared, +debug v5: * Removed 'cvos' environment code from ena Makefile * Driver symbol version fixed to

[dpdk-dev] [PATCH v8 1/4] ena: Amazon ENA documentation

2016-03-17 Thread Jan Medala
Signed-off-by: Alexander Matushevsky Signed-off-by: Jan Medala Signed-off-by: Jakub Palider --- MAINTAINERS | 8 ++ doc/guides/nics/ena.rst | 251 +++ doc/guides/nics/index.rst| 1 + doc/guides/nics/overview.rst | 116

[dpdk-dev] [PATCH v8 2/4] ena: Amazon ENA communication layer

2016-03-17 Thread Jan Medala
Low level common abstraction for ENA device communication. Signed-off-by: Netanel Belgazal Signed-off-by: Jan Medala Signed-off-by: Jakub Palider --- drivers/net/ena/base/ena_com.c | 2809 +++ drivers/net/ena/base/ena_com.h | 1052

[dpdk-dev] [PATCH v8 3/4] ena: Amazon ENA communication layer for DPDK platform

2016-03-17 Thread Jan Medala
Implementation of platform specific code for ENA communication layer. Signed-off-by: Evgeny Schemeilin Signed-off-by: Jan Medala Signed-off-by: Jakub Palider --- drivers/net/ena/base/ena_plat_dpdk.h | 217 +++ 1 file changed, 217 insertions(+) create mode

[dpdk-dev] [PATCH v8 4/4] ena: DPDK polling-mode driver for Amazon Elastic Network Adapters (ENA)

2016-03-17 Thread Jan Medala
This is a PMD for the Amazon ethernet ENA family. The driver operates variety of ENA adapters through feature negotiation with the adapter and upgradable commands set. ENA driver handles PCI Physical and Virtual ENA functions. Signed-off-by: Evgeny Schemeilin Signed-off-by: Jan Medala

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2016-03-17 Thread Thomas Monjalon
2015-08-07 19:20, Jan Kiszka: > On VHOST_*_RESET_OWNER, we reinitialize the device but without telling > the application. That will cause crashes when it continues to invoke > vhost services on the device. Fix it by calling the destruction hook if > the device is still in use. > > Signed-off-by:

[dpdk-dev] [PATCH v2] testpmd: avoid only working in XEN when LIBRTE_PMD_XENVIRT is configured

2016-03-17 Thread Christian Ehrhardt
With LIBRTE_PMD_XENVIRT enabled testpmd is built in a way to ONLY work in XEN environments. It will surface as: PMD: gntalloc: ioctl error EAL: Error - exiting with code: 1 Cause: Creation of mbuf pool for socket 0 failed With LIBRTE_PMD_XENVIRT enabled this now tries the xen style

[dpdk-dev] [PATCH] vchost: Notify application of ownership change

2016-03-17 Thread Jan Kiszka
On 2016-03-17 15:42, Thomas Monjalon wrote: > 2015-08-07 19:20, Jan Kiszka: >> On VHOST_*_RESET_OWNER, we reinitialize the device but without telling >> the application. That will cause crashes when it continues to invoke >> vhost services on the device. Fix it by calling the destruction hook if

[dpdk-dev] [PATCH] kni: set kni mac on ioctl_create

2016-03-17 Thread Thomas Monjalon
Helin, You have probably missed this (old) patch / bug report. 2015-08-28 16:08, Sergey Balabanov: > Hi, > > Probably I missed something in understanding why the mac is not set on kni > creation. Any comments would be highly appreciated. > > Thanks, > Sergey > > On Friday 28 August 2015

[dpdk-dev] [PATCH RFC v3 0/3] Thread safe rte_vhost_enqueue_burst().

2016-03-17 Thread Thomas Monjalon
2016-02-24 14:47, Ilya Maximets: > Implementation of rte_vhost_enqueue_burst() based on lockless ring-buffer > algorithm and contains almost all to be thread-safe, but it's not. > > This set adds required changes. > > First patch in set is a standalone patch that fixes many times discussed >

[dpdk-dev] [PATCH v3 0/5] Implement missing features in mlx5

2016-03-17 Thread Adrien Mazarguil
This patchset adds to mlx5 a few features available in mlx4 (TX from secondary processes) or provided by Verbs (support for HW packet padding, TX VLAN insertion). Release notes and documentation are updated accordingly. Changes in v3: - Removed compilation option for TX VLAN insertion, the

[dpdk-dev] [PATCH v3 1/5] mlx5: add callbacks to support link (up / down) changes

2016-03-17 Thread Adrien Mazarguil
From: Or Ami Burst functions are updated to make sure applications cannot attempt to send/receive after link is brought down. Signed-off-by: Or Ami --- doc/guides/rel_notes/release_16_04.rst | 4 ++ drivers/net/mlx5/mlx5.c| 2 + drivers/net/mlx5/mlx5.h

[dpdk-dev] [PATCH v3 2/5] mlx5: allow operation in secondary processes

2016-03-17 Thread Adrien Mazarguil
From: Or Ami Secondary processes are expected to use queues and other resources allocated by the primary, however Verbs resources can only be shared between processes when inherited through fork(). This limitation can be worked around for TX by configuring separate queues

[dpdk-dev] [PATCH v3 3/5] mlx5: add RX CRC stripping configuration

2016-03-17 Thread Adrien Mazarguil
From: Olga Shern Until now, CRC was always stripped by hardware. This feature can be configured since MLNX_OFED >= 3.2. Signed-off-by: Olga Shern --- doc/guides/nics/mlx5.rst | 2 ++ doc/guides/rel_notes/release_16_04.rst | 6 ++

[dpdk-dev] [PATCH v3 4/5] mlx5: add support for HW packet padding

2016-03-17 Thread Adrien Mazarguil
From: Olga Shern Environment variable MLX5_PMD_ENABLE_PADDING enables HW packet padding in PCI bus transactions. When packet size is cache aligned and CRC stripping is enabled, 4 fewer bytes are written to the PCI bus. Enabling padding makes such packets aligned again. In

[dpdk-dev] [PATCH v3 5/5] mlx5: add VLAN insertion offload

2016-03-17 Thread Adrien Mazarguil
From: Yaacov Hazan VLAN insertion can be done in hardware when supported in Verbs. A software fallback is provided otherwise. The software implementation is also used when multi-packet send is enabled on a queue, as both features are mutually exclusive. Signed-off-by:

[dpdk-dev] [PATCH 0/8] Various fixes to compile with gcc6

2016-03-17 Thread Thomas Monjalon
2016-02-25 13:48, Aaron Conole: > This series brings a number of code cleanups to allow building using gcc6, > with various legitimate warnings being fixed. > > In particular, patch 3 ("drivers/net/e1000: Fix missing brackets") should be > checked for correctness (it does not alter any behavior

[dpdk-dev] [PATCH 0/8] Various fixes to compile with gcc6

2016-03-17 Thread Thomas Monjalon
RE fixing email addresses... 2016-03-17 16:39, Thomas Monjalon: > 2016-02-25 13:48, Aaron Conole: > > This series brings a number of code cleanups to allow building using gcc6, > > with various legitimate warnings being fixed. > > > > In particular, patch 3 ("drivers/net/e1000: Fix missing

[dpdk-dev] [PATCH] ring: assert on zero objects dequeue/enqueue

2016-03-17 Thread Lazaros Koromilas
Sure, I'm sending it again with your suggestions. Lazaros. On Wed, Mar 16, 2016 at 1:21 PM, Bruce Richardson wrote: > On Tue, Mar 15, 2016 at 06:58:45PM +0200, Lazaros Koromilas wrote: >> Issuing a zero objects dequeue with a single consumer has no effect. >> Doing so with multiple consumers,

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-17 Thread Lazaros Koromilas
Issuing a zero objects dequeue with a single consumer has no effect. Doing so with multiple consumers, can get more than one thread to succeed the compare-and-set operation and observe starvation or even deadlock in the while loop that checks for preceding dequeues. The problematic piece of code

[dpdk-dev] [PATCH v2] ring: check for zero objects mc dequeue / mp enqueue

2016-03-17 Thread Mauricio Vásquez
Hi Lazaros, On Thu, Mar 17, 2016 at 4:49 PM, Lazaros Koromilas wrote: > Issuing a zero objects dequeue with a single consumer has no effect. > Doing so with multiple consumers, can get more than one thread to succeed > the compare-and-set operation and observe starvation or even deadlock in >

[dpdk-dev] [PATCH] ethdev: don't count missed packets in erroneous packets counter

2016-03-17 Thread Thomas Monjalon
CC Maryam and Olivier who had discussions about imissed and other stats: http://dpdk.org/ml/archives/dev/2015-August/022905.html http://dpdk.org/ml/archives/dev/2015-September/023351.html http://dpdk.org/ml/archives/dev/2015-September/023612.html 2016-03-10 16:03, Igor

[dpdk-dev] ixgbe TX function selection

2016-03-17 Thread Zoltan Kiss
On 10/03/16 07:51, Wu, Jingjing wrote: > Hi, Zoltan > >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Zoltan Kiss >> Sent: Wednesday, March 2, 2016 3:19 AM >> To: dev at dpdk.org >> Subject: [dpdk-dev] ixgbe TX function selection >> >> Hi, >> >> I've

[dpdk-dev] [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)

2016-03-17 Thread Stephen Hemminger
On Thu, 17 Mar 2016 15:18:15 +0100 Thomas Monjalon wrote: > Hi Stephen, > > Please, could you turn it into a real patch with your sign-off? > Thanks > > 2016-02-14 12:22, Stephen Hemminger: > > A better patch would be to move the data structure into the > > code block used, and get rid of the

[dpdk-dev] Huge pages to be allocated based on number of mbufs

2016-03-17 Thread Zoltan Kiss
On 14/03/16 17:54, Saurabh Mishra wrote: > Hi, > > We are planning to support virtio, vmxnet3, ixgbe, i40e, bxn2x and SR-IOV > on some of them with DPDK. > > We have seen that even if we give correct number of mbufs given the number > hugepages reserved, rte_eth_tx_queue_setup() may still fail

[dpdk-dev] [PATCH v11 0/8] ethdev: 100G and link speed API refactoring

2016-03-17 Thread Thomas Monjalon
There are still too few tests and reviews, especially for autonegotiation with Intel devices (patch #6). I would not be surprised to see some bugs in this rework. The capabilities must be adapted per device. It can be improved in a separate patch. It will be integrated in 16.04-rc2. Please test

[dpdk-dev] [PATCH v11 1/8] ethdev: use constants for link state

2016-03-17 Thread Thomas Monjalon
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- app/test-pipeline/init.c | 2 +- app/test-pmd/testpmd.c | 2 +- app/test/test_pmd_perf.c

[dpdk-dev] [PATCH v11 2/8] ethdev: use constants for link duplex

2016-03-17 Thread Thomas Monjalon
From: Marc Sune Some duplex values are replaced from 0 to half-duplex when link is down. Some drivers are still using their own constants for duplex modes. Signed-off-by: Marc Sune --- drivers/net/e1000/em_ethdev.c | 2 +- drivers/net/e1000/igb_ethdev.c | 2 +-

[dpdk-dev] [PATCH v11 3/8] app/testpmd: move speed and duplex parsing in a function

2016-03-17 Thread Thomas Monjalon
From: Marc Sune The code for checking and parsing speed/duplex was duplicated. The new function is also checking the speed/duplex combination. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c | 99 -- 1 file changed, 47

[dpdk-dev] [PATCH v11 4/8] ethdev: rename link speed constants

2016-03-17 Thread Thomas Monjalon
From: Marc Sune The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_. The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used for bit flags in next patch. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c| 10 +-

[dpdk-dev] [PATCH v11 5/8] ethdev: add speed capabilities

2016-03-17 Thread Thomas Monjalon
From: Marc Sune The speed capabilities of a device can be retrieved with rte_eth_dev_info_get(). The new field speed_capa is initialized in the drivers without taking care of device characteristics in this patch. When the capabilities of a driver are accurate, the table in

[dpdk-dev] [PATCH v11 6/8] ethdev: redesign link speed config

2016-03-17 Thread Thomas Monjalon
From: Marc Sune This patch redesigns the API to set the link speed/s configuration of an ethernet port. Specifically: - it allows to define a set of advertised speeds for auto-negociation. - it allows to disable link auto-negociation (single fixed speed). - default:

[dpdk-dev] [PATCH v11 7/8] ethdev: convert speed number to bitmap flag

2016-03-17 Thread Thomas Monjalon
From: Marc Sune It is a helper for the bitmap configuration. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 31 +++ lib/librte_ether/rte_ethdev.h | 13 +

[dpdk-dev] [PATCH v11 8/8] ethdev: add 100G link speed

2016-03-17 Thread Thomas Monjalon
The link speed configuration is now done with bitmaps so 100G speed requires only a new bit flag. The actual link speed is a number so its size must be increased from 16-bit to 32-bit. Signed-off-by: Marc Sune Tested-by: Nelio Laranjeiro Signed-off-by: Thomas Monjalon ---

[dpdk-dev] [PATCH] mk: fix linker script when re-building

2016-03-17 Thread Thomas Monjalon
2016-03-17 11:37, Panu Matilainen: > On 03/17/2016 01:22 AM, Sergio Gonzalez Monroy wrote: > > The linker script is generated by simply finding all libraries in > > RTE_OUTPUT/lib. > > > > The issue shows up when re-building the DPDK, hence already having a > > linker script in that directory,

[dpdk-dev] [PATCH] vhost: remove unnecessary memset for virtio net hdr

2016-03-17 Thread Thomas Monjalon
2016-03-17 01:19, Xie, Huawei: > On 3/16/2016 2:44 PM, Yuanhan Liu wrote: > > We have to reset the virtio net hdr at virtio_enqueue_offload() > > before, due to all mbufs share a single virtio_hdr structure: > > > > struct virtio_net_hdr_mrg_rxbuf virtio_hdr = {{0, }, 0}; > > > > foreach

[dpdk-dev] Fwd: EAL: map_all_hugepages(): mmap failed: Cannot allocate memory

2016-03-17 Thread John Wei
I am setting up OVS inside a Linux container. This OVS is built using DPDK library. During the startup of ovs-vswitchd, it core dumped due to fail to mmap. in eal_memory.c virtaddr = mmap(vma_addr, hugepage_sz, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0); This call is

[dpdk-dev] [PATCH] enic: change maintainers

2016-03-17 Thread John Daley
Change maintainers for ENIC PMD. Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst index 2a228fd..e67c3db 100644 --- a/doc/guides/nics/enic.rst +++

[dpdk-dev] [PATCH] enic: don't set enic->config.rq_desc_count in enic_alloc_rq()

2016-03-17 Thread John Daley
From: Nelson Escobar When the requested number of rx descriptors was less than the amount configured on the vic, enic_alloc_rq() was incorrectly setting enic->config.rq_desc_count to the lower value. This screwed up later calls to enic_alloc_rq(). Signed-off-by: Nelson

[dpdk-dev] [PATCH] enic: add missing \n to a few print statements

2016-03-17 Thread John Daley
From: Nelson Escobar Signed-off-by: Nelson Escobar Acked-by: John Daley --- drivers/net/enic/enic_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index cd7857f..2f79cf0 100644 ---

[dpdk-dev] [PATCH] enic: prevent segfaults when allocating too many TX or RX queues

2016-03-17 Thread John Daley
From: Nelson Escobar Add checks to make sure we don't try to allocate more tx or rx queues than we support. Signed-off-by: Nelson Escobar Reviewed-by: John Daley --- drivers/net/enic/enic_ethdev.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[dpdk-dev] [dpdk-dev, 1/3] rte_interrupts: add rte_eal_intr_exit to shut down IRQ thread

2016-03-17 Thread Matthew Hall
>From Cunming: > I'm trying to understand the motivation. > > I don't think you're going to gracefully exit intr thread but leave all > other eal threads live. We don't have API to new launch intr thread again. The doc comment added for rte_eal_intr_exit already explains this. According to the

[dpdk-dev] [PATCH 0/3] enic PMD receive path fixes

2016-03-17 Thread John Daley
These patches fix up some bugs in the enic receive path. John Daley (3): enic: mbuf->ol_flags could be set incorrectly enic: handle error packets properly enic: small cleanup- remove a packet_error conditional drivers/net/enic/enic_rx.c | 53 ++

[dpdk-dev] [PATCH 1/3] enic: mbuf->ol_flags could be set incorrectly

2016-03-17 Thread John Daley
In the receive path, the function to set mbuf ol_flags used the mbuf packet_type before it was set. Fixes: 947d860c821f ("enic: improve Rx performance") Signed-off-by: John Daley --- drivers/net/enic/enic_rx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[dpdk-dev] [PATCH 2/3] enic: handle error packets properly

2016-03-17 Thread John Daley
If the packet_error bit in the completion descriptor is set, the remainder of the descriptor and data are invalid. PKT_RX_MAC_ERR was set in the mbuf->ol_flags if packet_error was set and used later to indicate an error packet. But since PKT_RX_MAC_ERR is defined as 0, mbuf flags and packet types

[dpdk-dev] [PATCH 3/3] enic: small cleanup- remove a packet_error conditional

2016-03-17 Thread John Daley
Signed-off-by: John Daley --- drivers/net/enic/enic_rx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/enic/enic_rx.c b/drivers/net/enic/enic_rx.c index 817a891..232987a 100644 --- a/drivers/net/enic/enic_rx.c +++ b/drivers/net/enic/enic_rx.c @@

[dpdk-dev] [PATCH] eal_interrupts.c: properly init struct epoll_event (valgrind)

2016-03-17 Thread Matthew Hall
On Thu, Mar 17, 2016 at 10:19:24AM -0700, Stephen Hemminger wrote: > > > A better patch would be to move the data structure into the > > > code block used, and get rid of the useless else (rte_panic never > > > returns); > > > and fix the indentation, and use C99 initialization which should make