[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
Hi,
2016-02-09 21:33, Thomas Monjalon:
> 2016-02-09 18:37, Liming Sun:
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > A comment about the TILE-Mx would be welcome.
> > Is it supported currently?
> > Isn't it an ARM arch?
> >
> > [lsun] Yes, it's ARM arch, but with similar mpipe driver.
> > It's not fully supported yet. I'll remove this change and add it in a
> > different serie when it's ready.
>
> OK
> So we'll discuss how to integrate it later.
>
> > > +# Compile combined lib by default.
> > > +CONFIG_RTE_BUILD_COMBINE_LIBS=y
> >
> > Why forcing this option in the defconfig file?
> >
> > [lsun] It's just trying to make it handy for other applications like OVS or
> > ODP on top of DPDK. However we could remove this change if it's not the
> > recommended way.
>
> Yes please remove it.
>
> > > ARCH ?= tile
> > > +
> > > +HOST_ARCH := ${shell uname -m}
> > > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS = else
> > > CROSS ?= tile-
> > > +endif
> >
> > I don't think the CROSS variable should have a default value.
> > It really depends on the toolchain.
> >
> > [lsun] Make sense. The current code (before the change) has default value
> > 'CROSS ?= tile-' defined, which cause some issue when doing native build.
> > Another way is to define it as "CROSS ?=" just like other platforms. So
> > when doing cross-compile, we could pass " CROSS=tile-" .
>
> No need to keep a "CROSS ?=" line.
> The variables defined in the command line get the priority.
I have not seen patches to address these comments. Anything pending?
> > Talking about the toolchain, is it possible to build DPDK with the provided
> > binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
> > This is the Tilera Open Source page: http://www.tilera.com/scm/
> >
> > [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of
> > some header files and libraries to compile DPDK.
>
> Yes that's what I've experienced.
>
> > We're looking into it to see whether it can be easily fixed.
>
> Please keep us informed when the toolchain is ready. Thanks
Any news about the ready-to-use toolchain?
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
2016-02-10 09:49, Bruce Richardson: > On Tue, Feb 09, 2016 at 11:47:55PM +0100, Thomas Monjalon wrote: > > 2016-02-09 21:15, Liming Sun: > > > Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. > > > What would be the usual way to submit changes for new comments? Would it > > > be incremental changes (new commit) based on previous one? Thanks. > > > > Good question. > > I think it's better if Bruce drops or reverts the commits from dpdk-next-net > > to let you re-submit a better new version. > > Bruce, do you agree? > > Unless there is something actually broken - that was previously working - by > this patchset I'd rather not revert it. This patch was sitting acked for a > month > which is a reasonable time for comments before applying it. Allowing people to > step up post-apply and look for patches being reverted is not something we > want > to encourage IMHO. There are already too many reviews being done at the last > minute, and allowing reverts may make that situation worse, while applying > acked > patches within a reasonable time - irrespective of whether people subsequently > find issues with them - should encourage earlier reviews, and makes it easier > on > contributors. Yes you are right. > Therefore I'd rather see any additional enhancements or changes > done as incremental patches on top of this set. > > Regards, > /Bruce >
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
On Tue, Feb 09, 2016 at 11:47:55PM +0100, Thomas Monjalon wrote: > 2016-02-09 21:15, Liming Sun: > > Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. > > What would be the usual way to submit changes for new comments? Would it be > > incremental changes (new commit) based on previous one? Thanks. > > Good question. > I think it's better if Bruce drops or reverts the commits from dpdk-next-net > to let you re-submit a better new version. > Bruce, do you agree? Unless there is something actually broken - that was previously working - by this patchset I'd rather not revert it. This patch was sitting acked for a month which is a reasonable time for comments before applying it. Allowing people to step up post-apply and look for patches being reverted is not something we want to encourage IMHO. There are already too many reviews being done at the last minute, and allowing reverts may make that situation worse, while applying acked patches within a reasonable time - irrespective of whether people subsequently find issues with them - should encourage earlier reviews, and makes it easier on contributors. Therefore I'd rather see any additional enhancements or changes done as incremental patches on top of this set. Regards, /Bruce
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
2016-02-09 21:15, Liming Sun: > Looks like this patch serie has been merged into dpdk-next-net/rel_16_04. > What would be the usual way to submit changes for new comments? Would it be > incremental changes (new commit) based on previous one? Thanks. Good question. I think it's better if Bruce drops or reverts the commits from dpdk-next-net to let you re-submit a better new version. Bruce, do you agree?
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
2016-02-09 18:37, Liming Sun:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> A comment about the TILE-Mx would be welcome.
> Is it supported currently?
> Isn't it an ARM arch?
>
> [lsun] Yes, it's ARM arch, but with similar mpipe driver.
> It's not fully supported yet. I'll remove this change and add it in a
> different serie when it's ready.
OK
So we'll discuss how to integrate it later.
> > +# Compile combined lib by default.
> > +CONFIG_RTE_BUILD_COMBINE_LIBS=y
>
> Why forcing this option in the defconfig file?
>
> [lsun] It's just trying to make it handy for other applications like OVS or
> ODP on top of DPDK. However we could remove this change if it's not the
> recommended way.
Yes please remove it.
> > ARCH ?= tile
> > +
> > +HOST_ARCH := ${shell uname -m}
> > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS = else
> > CROSS ?= tile-
> > +endif
>
> I don't think the CROSS variable should have a default value.
> It really depends on the toolchain.
>
> [lsun] Make sense. The current code (before the change) has default value
> 'CROSS ?= tile-' defined, which cause some issue when doing native build.
> Another way is to define it as "CROSS ?=" just like other platforms. So when
> doing cross-compile, we could pass " CROSS=tile-" .
No need to keep a "CROSS ?=" line.
The variables defined in the command line get the priority.
> Talking about the toolchain, is it possible to build DPDK with the provided
> binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
> This is the Tilera Open Source page: http://www.tilera.com/scm/
>
> [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of
> some header files and libraries to compile DPDK.
Yes that's what I've experienced.
> We're looking into it to see whether it can be easily fixed.
Please keep us informed when the toolchain is ready. Thanks
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
Looks like this patch serie has been merged into dpdk-next-net/rel_16_04.
What would be the usual way to submit changes for new comments? Would it be
incremental changes (new commit) based on previous one? Thanks.
From: Thomas Monjalon <thomas.monja...@6wind.com>
Sent: Tuesday, February 9, 2016 3:33 PM
To: Liming Sun
Cc: dev at dpdk.org; bruce.richardson at intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build
on tilegx platform.
2016-02-09 18:37, Liming Sun:
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> A comment about the TILE-Mx would be welcome.
> Is it supported currently?
> Isn't it an ARM arch?
>
> [lsun] Yes, it's ARM arch, but with similar mpipe driver.
> It's not fully supported yet. I'll remove this change and add it in a
> different serie when it's ready.
OK
So we'll discuss how to integrate it later.
> > +# Compile combined lib by default.
> > +CONFIG_RTE_BUILD_COMBINE_LIBS=y
>
> Why forcing this option in the defconfig file?
>
> [lsun] It's just trying to make it handy for other applications like OVS or
> ODP on top of DPDK. However we could remove this change if it's not the
> recommended way.
Yes please remove it.
> > ARCH ?= tile
> > +
> > +HOST_ARCH := ${shell uname -m}
> > +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS = else
> > CROSS ?= tile-
> > +endif
>
> I don't think the CROSS variable should have a default value.
> It really depends on the toolchain.
>
> [lsun] Make sense. The current code (before the change) has default value
> 'CROSS ?= tile-' defined, which cause some issue when doing native build.
> Another way is to define it as "CROSS ?=" just like other platforms. So when
> doing cross-compile, we could pass " CROSS=tile-" .
No need to keep a "CROSS ?=" line.
The variables defined in the command line get the priority.
> Talking about the toolchain, is it possible to build DPDK with the provided
> binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
> This is the Tilera Open Source page: http://www.tilera.com/scm/
>
> [lsun] I tried it just now. The gcc appears ok. But this tarball lacks of
> some header files and libraries to compile DPDK.
Yes that's what I've experienced.
> We're looking into it to see whether it can be easily fixed.
Please keep us informed when the toolchain is ready. Thanks
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
Thanks Thomas for the comments.
Please see the response inline.
Thanks,
Liming
-Original Message-
From: Thomas Monjalon [mailto:thomas.monja...@6wind.com]
Sent: Tuesday, February 09, 2016 11:16 AM
To: Liming Sun
Cc: dev at dpdk.org; bruce.richardson at intel.com
Subject: Re: [dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build
on tilegx platform.
Hi,
Sorry for being late for commenting.
2016-01-08 09:30, Liming Sun:
> -EZchip TILE-Gx
> +EZchip TILE-Gx/Mx
A comment about the TILE-Mx would be welcome.
Is it supported currently?
Isn't it an ARM arch?
[lsun] Yes, it's ARM arch, but with similar mpipe driver.
It's not fully supported yet. I'll remove this change and add it in a different
serie when it's ready.
> M: Zhigang Lu
> +M: Liming Sun
> F: lib/librte_eal/common/include/arch/tile/
> F: drivers/net/mpipe/
[...]
> +# Compile combined lib by default.
> +CONFIG_RTE_BUILD_COMBINE_LIBS=y
Why forcing this option in the defconfig file?
[lsun] It's just trying to make it handy for other applications like OVS or ODP
on top of DPDK. However we could remove this change if it's not the recommended
way.
[...]
> ARCH ?= tile
> +
> +HOST_ARCH := ${shell uname -m}
> +ifneq ($(filter tile%,${HOST_ARCH}),) CROSS = else
> CROSS ?= tile-
> +endif
I don't think the CROSS variable should have a default value.
It really depends on the toolchain.
[lsun] Make sense. The current code (before the change) has default value
'CROSS ?= tile-' defined, which cause some issue when doing native build.
Another way is to define it as "CROSS ?=" just like other platforms. So when
doing cross-compile, we could pass " CROSS=tile-" .
Talking about the toolchain, is it possible to build DPDK with the provided
binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
This is the Tilera Open Source page: http://www.tilera.com/scm/
[lsun] I tried it just now. The gcc appears ok. But this tarball lacks of some
header files and libraries to compile DPDK.
We're looking into it to see whether it can be easily fixed.
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
Hi,
Sorry for being late for commenting.
2016-01-08 09:30, Liming Sun:
> -EZchip TILE-Gx
> +EZchip TILE-Gx/Mx
A comment about the TILE-Mx would be welcome.
Is it supported currently?
Isn't it an ARM arch?
> M: Zhigang Lu
> +M: Liming Sun
> F: lib/librte_eal/common/include/arch/tile/
> F: drivers/net/mpipe/
[...]
> +# Compile combined lib by default.
> +CONFIG_RTE_BUILD_COMBINE_LIBS=y
Why forcing this option in the defconfig file?
[...]
> ARCH ?= tile
> +
> +HOST_ARCH := ${shell uname -m}
> +ifneq ($(filter tile%,${HOST_ARCH}),)
> +CROSS =
> +else
> CROSS ?= tile-
> +endif
I don't think the CROSS variable should have a default value.
It really depends on the toolchain.
Talking about the toolchain, is it possible to build DPDK with the
provided binary toolchain http://www.tilera.com/scm/tilegx-x86_64.tar.bz2 ?
This is the Tilera Open Source page: http://www.tilera.com/scm/
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
On Fri, Jan 08, 2016 at 09:30:36AM -0500, Liming Sun wrote: > This submit updates the CROSS setting to support native build on > TileGx platform. It also enable the combined library by default. > > Signed-off-by: Liming Sun > Acked-by: Zhigang Lu Series applied to dpdk-next-net/rel_16_04. /Bruce
[dpdk-dev] [PATCH v2 1/3] driver/net/mpipe: support native build on tilegx platform.
This submit updates the CROSS setting to support native build on
TileGx platform. It also enable the combined library by default.
Signed-off-by: Liming Sun
Acked-by: Zhigang Lu
---
MAINTAINERS | 3 ++-
config/defconfig_tile-tilegx-linuxapp-gcc | 4
mk/arch/tile/rte.vars.mk | 6 ++
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3292e84..8f7e9ca 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -138,8 +138,9 @@ M: Jianbo Liu
F: lib/librte_eal/common/include/arch/arm/*_64.h
F: lib/librte_acl/acl_run_neon.*
-EZchip TILE-Gx
+EZchip TILE-Gx/Mx
M: Zhigang Lu
+M: Liming Sun
F: lib/librte_eal/common/include/arch/tile/
F: drivers/net/mpipe/
diff --git a/config/defconfig_tile-tilegx-linuxapp-gcc
b/config/defconfig_tile-tilegx-linuxapp-gcc
index 9df9d7f..fb61bcd 100644
--- a/config/defconfig_tile-tilegx-linuxapp-gcc
+++ b/config/defconfig_tile-tilegx-linuxapp-gcc
@@ -70,3 +70,7 @@ CONFIG_RTE_LIBRTE_SCHED=n
CONFIG_RTE_LIBRTE_PORT=n
CONFIG_RTE_LIBRTE_TABLE=n
CONFIG_RTE_LIBRTE_PIPELINE=n
+CONFIG_RTE_LIBRTE_CXGBE_PMD=n
+
+# Compile combined lib by default.
+CONFIG_RTE_BUILD_COMBINE_LIBS=y
diff --git a/mk/arch/tile/rte.vars.mk b/mk/arch/tile/rte.vars.mk
index b518986..06dab18 100644
--- a/mk/arch/tile/rte.vars.mk
+++ b/mk/arch/tile/rte.vars.mk
@@ -30,7 +30,13 @@
ARCH ?= tile
+
+HOST_ARCH := ${shell uname -m}
+ifneq ($(filter tile%,${HOST_ARCH}),)
+CROSS =
+else
CROSS ?= tile-
+endif
CPU_CFLAGS ?=
CPU_LDFLAGS ?=
--
1.8.3.1
