Super like it.
On 4/18/13 5:31 AM, Namit Jain nj...@fb.com wrote:
Hi,
Since we are developing at a very fast pace, it would be really useful to
think about maintainability and testing of the large codebase.
Historically, we have not focussed on a few things, and they might soon
bite us. I
Hi Namit,
I like your proposal very much and I would take it a bit further:
1. ... For any complex function, clear examples (input/output) would
really help.
I'm concerned that examples in the code (comments) might very quickly become
obsolete as it can very easily happen that someone
Agreed.
On 4/18/13 9:19 PM, Jarek Jarcec Cecho jar...@apache.org wrote:
Hi Namit,
I like your proposal very much and I would take it a bit further:
1. ... For any complex function, clear examples (input/output) would
really help.
I'm concerned that examples in the code (comments) might
Hi,
I like the proposal as well!
On Thu, Apr 18, 2013 at 10:49 AM, Jarek Jarcec Cecho jar...@apache.orgwrote:
Hi Namit,
I like your proposal very much and I would take it a bit further:
1. ... For any complex function, clear examples (input/output) would
really help.
I'm concerned
Having said that, it might be difficult to write unit tests for operator
trees.
Might take more time initially - so, making it a constraint might slow us
down.
On 4/18/13 9:41 PM, Brock Noland br...@cloudera.com wrote:
Hi,
I like the proposal as well!
On Thu, Apr 18, 2013 at 10:49 AM, Jarek
Agreed, given that most of our tests our existing tests are in .q files,
I'd prefer to see more of a unit tests highly encouraged policy as
opposed to must have unit tests.
On Thu, Apr 18, 2013 at 11:17 AM, Namit Jain nj...@fb.com wrote:
Having said that, it might be difficult to write unit
