[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823800#comment-16823800
]
Karl Wright commented on CONNECTORS-1498:
-
Hi,
The following settings were suggested by Michael Allen, original developer of
Jcifs:
{code}
jcifs.smb.client.soTimeout: 15
jcifs.smb.client.responseTimeout: 12
jcifs.resolveOrder: LMHOSTS,DNS,WINS
jcifs.smb.client.listCount: 20
jcifs.smb.client.dfs.strictView: true
{code}
The timeout values he chose were based on the behavior of the protocol, and
were the maximum values he felt were reasonable given that. The resolve order
was chosen based on his sense of how fast each one of these is. The listCount
is also based on protocol considerations, and strictView is required for proper
functioning of the connector.
> Support SMBv2/v3 protocol for Windows Shares connector
> --
>
> Key: CONNECTORS-1498
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1498
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Environment: OS: CentOS 7.2
> ManifoldCF: 2.8.1
>Reporter: Hiroaki Takasu
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.10
>
>
> Windows Shares connector (JCIFS connector) uses
> [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol
> v1.
> But many file servers were disabled SMBv1 by vulnerability
> [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010],
> so we can not use Windows Shares connector.
> I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g.
> [smbj|https://github.com/hierynomus/smbj])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823756#comment-16823756 ] Tang Huan Song commented on CONNECTORS-1498: Understood. Could you give me a brief rundown as to which settings you feel * should be left hardcoded * should be made changeable on a per-connection basis * should be made changeable on a connector-wide basis In addition, if you could also share your convictions as to why, that'd be great. > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > Fix For: ManifoldCF 2.10 > > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823745#comment-16823745 ] Karl Wright commented on CONNECTORS-1498: - Some of these settings should not be changed from a specific value. Other settings I could see changing on a per-connection basis. jcifs-ng does give the ability to control settings per connection, unlike the original jcifs. But I think that the ones that should be connection-based would be only: - jcifs.resolveOrder - jcifs.smb.client.minVersion - jcifs.smb.client.maxVersion - jcifs.smb.client.ipcSigningEnforced The first thing to do is verify that the ported code works properly though. > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > Fix For: ManifoldCF 2.10 > > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16823727#comment-16823727
]
Tang Huan Song commented on CONNECTORS-1498:
In addition to the changes required for the upgrade to utilize jcifs-ng over
the current jcifs library, I'd like to also suggest allowing the user to tweak
basic jcifs/jcifs-ng parameters in order to suit the target fileserver.
I'm unsure whether it's better to make it a connector-wide setting (and have it
adjustable via ManifoldCF's properties.xml) or have it modifiable
per-connection, but at the moment I have the former in mind.
Perhaps implementation could go like the following, placed within a static
block in the SharedDriveConnector class.
{code:java}
System.setProperty("jcifs.smb.client.soTimeout",
ManifoldCF.getStringProperty("jcifs.smb.client.soTimeout", "..."));
{code}
with the following settings and their suggested defaults:
* jcifs.smb.client.soTimeout: 15
* jcifs.smb.client.responseTimeout: 12
* jcifs.resolveOrder: DNS
* jcifs.smb.client.listCount: 20
* jcifs.smb.client.dfs.strictView: true
* jcifs.traceResources: true
* jcifs.smb.client.minVersion: SMB1
* jcifs.smb.client.maxVersion: SMB210
* jcifs.traceResources: true
* jcifs.smb.client.ipcSigningEnforced: true
> Support SMBv2/v3 protocol for Windows Shares connector
> --
>
> Key: CONNECTORS-1498
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1498
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Environment: OS: CentOS 7.2
> ManifoldCF: 2.8.1
>Reporter: Hiroaki Takasu
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.10
>
>
> Windows Shares connector (JCIFS connector) uses
> [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol
> v1.
> But many file servers were disabled SMBv1 by vulnerability
> [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010],
> so we can not use Windows Shares connector.
> I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g.
> [smbj|https://github.com/hierynomus/smbj])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821570#comment-16821570 ] Karl Wright commented on CONNECTORS-1498: - Ok, I got past the build problems and made (what I think) are the necessary changes. Please check out https://svn.apache.org/repos/asf/manifoldcf/branches/CONNECTORS-1498 and try it. Thanks! > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > Fix For: ManifoldCF 2.10 > > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821562#comment-16821562
]
Karl Wright commented on CONNECTORS-1498:
-
[~hhoechtl], I just tried this. The compilation errors are the following:
{code}
compile-connector:
[javac] C:\wip\mcf\trunk\dist\connector-build.xml:594: warning:
'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to
false for repeatable builds
[javac] Compiling 6 source files to
C:\wip\mcf\trunk\connectors\jcifs\build\connector\classes
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:20:
warning: [deprecation] NtlmPasswordAuthentication in jcifs.smb has been
deprecated
[javac] import jcifs.smb.NtlmPasswordAuthentication;
[javac] ^
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveHelpers.java:35:
warning: [deprecation] NtlmPasswordAuthentication in jcifs.smb has been
deprecated
[javac] import jcifs.smb.NtlmPasswordAuthentication;
[javac] ^
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:19:
error: cannot find symbol
[javac] import jcifs.smb.ACE;
[javac] ^
[javac] symbol: class ACE
[javac] location: package jcifs.smb
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:20:
warning: [deprecation] NtlmPasswordAuthentication in jcifs.smb has been
deprecated
[javac] import jcifs.smb.NtlmPasswordAuthentication;
[javac] ^
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:1246:
error: cannot find symbol
[javac] protected void convertACEs(List allowList, List
denyList, ACE[] aces)
[javac]
^
[javac] symbol: class ACE
[javac] location: class SharedDriveConnector
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:2404:
error: cannot find symbol
[javac] protected static ACE[] getFileSecurity(SmbFile file, boolean
useSIDs)
[javac]^
[javac] symbol: class ACE
[javac] location: class SharedDriveConnector
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveConnector.java:2442:
error: cannot find symbol
[javac] protected static ACE[] getFileShareSecurity(SmbFile file, boolean
useSIDs)
[javac]^
[javac] symbol: class ACE
[javac] location: class SharedDriveConnector
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveHelpers.java:34:
error: cannot find symbol
[javac] import jcifs.smb.ACE;
[javac] ^
[javac] symbol: class ACE
[javac] location: package jcifs.smb
[javac]
C:\wip\mcf\trunk\connectors\jcifs\connector\src\main\java\org\apache\manifoldcf\crawler\connectors\sharedrive\SharedDriveHelpers.java:35:
warning: [deprecation] NtlmPasswordAuthentication in jcifs.smb has been
deprecated
[javac] import jcifs.smb.NtlmPasswordAuthentication;
[javac] ^
[javac] 5 errors
[javac] 4 warnings
{code}
The thing that stops it from compiling is that there is no longer a class
jcifs.smb.ACE. This is an access-control list element. It's obviously
critical to the functioning of ManifoldCF to have that.
Can you research what happened to this in jcifs-ng? Did they just rename it,
or did they completely remove it?
> Support SMBv2/v3 protocol for Windows Shares connector
> --
>
> Key: CONNECTORS-1498
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1498
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Environment: OS: CentOS 7.2
> ManifoldCF: 2.8.1
>Reporter: Hiroaki Takasu
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.10
>
>
> Windows Shares connector (JCIFS connector) uses
> [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol
> v1.
> But many file servers were disabled SMBv1 by vulnerability
> [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010],
> so we
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821122#comment-16821122 ] Karl Wright commented on CONNECTORS-1498: - [~hhoechtl], this looks like a reimplementation of JCIFS which in theory should support the same original JCIFS API. It is LGPL, which is consistent with the original JCIFS, so I believe it includes much of the original code. It might well work by just downloading the jar and treating it just like the original JCIFS. Have you tried this? > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > Fix For: ManifoldCF 2.10 > > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[
https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16821090#comment-16821090
]
Hans Höchtl commented on CONNECTORS-1498:
-
{quote}JCIFS has been in maintenance-mode-only for several years and although
what it does support works fine (SMB1, NTLMv2, midlc, MSRPC and various utility
classes), jCIFS does not support the newer SMB2/3 variants of the SMB protocol
{quote}
There's a new library that would support SMB v2/v3 but somebody would need to
change the connectors implementation.
[https://github.com/AgNO3/jcifs-ng]
> Support SMBv2/v3 protocol for Windows Shares connector
> --
>
> Key: CONNECTORS-1498
> URL: https://issues.apache.org/jira/browse/CONNECTORS-1498
> Project: ManifoldCF
> Issue Type: Improvement
> Components: JCIFS connector
> Environment: OS: CentOS 7.2
> ManifoldCF: 2.8.1
>Reporter: Hiroaki Takasu
>Assignee: Karl Wright
>Priority: Major
> Fix For: ManifoldCF 2.10
>
>
> Windows Shares connector (JCIFS connector) uses
> [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol
> v1.
> But many file servers were disabled SMBv1 by vulnerability
> [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010],
> so we can not use Windows Shares connector.
> I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g.
> [smbj|https://github.com/hierynomus/smbj])
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382198#comment-16382198 ] Karl Wright commented on CONNECTORS-1498: - [~dawncalle], if that's the case, you are out of luck. ManifoldCF neither has the time nor the knowledge to develop a V2 or V3 version of JCIFS. However, Michael Allen consults (for a price) and might be willing to develop a new version of jcifs if you are willing to pay his development costs. Much of what is in JCIFS today is the result of my former company paying him to develop it. Sorry... > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382103#comment-16382103 ] Hiroaki Takasu commented on CONNECTORS-1498: I found some pages about what protocol JCIFS supports. * [https://lists.samba.org/archive/jcifs/2013-December/010123.html] * [http://samba.2283325.n4.nabble.com/Query-regarding-the-SMB-support-td4697093.html] According to this pages, JCIFS supports only SMBv1 and has no plan to improve/update for supporting SMBv2/v3... So I think Windows Share Connector uses SMBv1. > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (CONNECTORS-1498) Support SMBv2/v3 protocol for Windows Shares connector
[ https://issues.apache.org/jira/browse/CONNECTORS-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16382045#comment-16382045 ] Karl Wright commented on CONNECTORS-1498: - [~dawncalle], you will need to contact Michael Allen (email address at https://jcifs.samba.org/ ) to inquire what protocols the Windows Share Connector uses and whether this can be improved/updated. Thanks! > Support SMBv2/v3 protocol for Windows Shares connector > -- > > Key: CONNECTORS-1498 > URL: https://issues.apache.org/jira/browse/CONNECTORS-1498 > Project: ManifoldCF > Issue Type: Improvement > Components: JCIFS connector > Environment: OS: CentOS 7.2 > ManifoldCF: 2.8.1 >Reporter: Hiroaki Takasu >Assignee: Karl Wright >Priority: Major > > Windows Shares connector (JCIFS connector) uses > [JCIFS|https://jcifs.samba.org/] library which supports only samba protocol > v1. > But many file servers were disabled SMBv1 by vulnerability > [MS17-010|https://docs.microsoft.com/en-us/security-updates/SecurityBulletins/2017/ms17-010], > so we can not use Windows Shares connector. > I hope that ManifoldCF support SMBv2/v3 with other CIFS library (e.g. > [smbj|https://github.com/hierynomus/smbj]) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
