Re: [edk2-devel] [PATCH 16/16] OvmfPkg/EnrollDefaultKeys: remove Red Hat's hard-coded PK/KEK1

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The certificate > > "Red Hat Secure Boot (PK/KEK key 1)/emailAddress=secal...@redhat.com" > SHA1: fd:fc:7f:3c:7e:f3:e0:57:76:ad:d7:98:78:21:6c:9b:e0:e1:95:97 > > is no longer referenced; remove it. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [PATCH 15/16] OvmfPkg/EnrollDefaultKeys: enroll PK/KEK1 from the Type 11 SMBIOS table

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Disconnect the certificate that is enrolled as both Platform Key and first > Key Exchange Key from Red Hat: expect the hypervisor to specify it, as > part of SMBIOS. > > Example usage with QEMU: > > * Generate self-signed X509 certificate: > > openssl

Re: [edk2-devel] [PATCH 14/16] OvmfPkg: introduce OVMF_PK_KEK1_APP_PREFIX_GUID

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > For the EnrollDefaultKeys application, the hypervisor is expected to add a > string entry to the "OEM Strings" (Type 11) SMBIOS table, with the > following format: > > 4e32566d-8e9e-4f52-81d3-5bb9715f9727: > > The string representation of the GUID at the

Re: [edk2-devel] [PATCH 01/16] OvmfPkg: introduce EnrollDefaultKeys application

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Add the OvmfPkg/EnrollDefaultKeys shell application source as it is at the > "edk2-20190308git89910a39dcfd-2.el8" tag in RHEL8's downstream "edk2" > package. > > Further patches in this series will replace Red Hat-specific bits in the > application, with a

Re: [edk2-devel] [PATCH 02/16] OvmfPkg/EnrollDefaultKeys: update @file comment blocks

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Refresh the sentence that states the purpose of the application. > > Extend the copyright notice to the year 2019. > > Replace the 2-clause BSD License banner with the BSD-2-Clause-Patent SPDX > ID. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jor

Re: [edk2-devel] [PATCH 12/16] OvmfPkg/EnrollDefaultKeys: describe functions with leading comment blocks

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GetExact(), GetSettings(), PrintSettings(), and ShellAppMain() > functions lack leading comment blocks. Supply those. > > While at it, make sure that every such comment block is preceded by two > blank lines. > > Cc: Anthony Perard > Cc: Ard Biesheuv

Re: [edk2-devel] [PATCH 11/16] OvmfPkg/EnrollDefaultKeys: extract MICROSOFT_VENDOR_GUID

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GUID > > 77FA9ABD-0359-4D32-BD60-28F4E78F784B > > is specified in MSDN, at > , therefore it > deserves an entry in the package DEC file, and a header file under > "Include/Guid". > > (Arguably,

Re: [edk2-devel] [PATCH 07/16] OvmfPkg/EnrollDefaultKeys: clean up acronym capitalization in identifiers

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > According to the edk2 coding standards, "[w]hen all letters in an acronym > are capitalized, it makes the prior and subsequent words visually > difficult to distinguish". > > Fix the spellings of three acronyms, accordingly: > - "KEK" (Key Exchange Key) sh

Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Tuesday, April 30, 2019 12:51 AM > To: devel@edk2.groups.io; Gao, Liming > Cc: Ard Biesheuvel > Subject: Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new

Re: [edk2-devel] [Patch] Updated EDK II Release Notes

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 30, 2019 2:51 AM > To: devel@edk2.groups.io; Wang, Fan > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch] Updated EDK II Release Notes > > On 04/28/19 04:22, Wang Fan wrote: > > Remove IpSec dr

[edk2-devel] [edk2-test] The issue in DevicePathFromText test about DebugPort

Hi Sunny, Thank you to raise this issue. And I see a Bugzilla tracker (https://bugzilla.tianocore.org/show_bug.cgi?id=1769). I agree with you that UEFI SCT can do enhancement to meet this change. Could you please send a patch to fix it ? Add in the loop and change the email subject to [edk2-d

[edk2-devel] Missing protocols in IHV SCT compared to generic SCT

Changing subject line to include [edk2-test] + Supreeth Hi Jabir, In history, after the EFI_HII_CONFIG_ACCESS_PROTOCOL, EFI_FIRMWARE_MANAGEMENT_PROTOCOL defined in UEFI Spec, the test is developed and validated with the fake driver or contributed by UEFI member, but the true device is not seen

[edk2-devel] [PATCH] BaseTools:The code used to test python module is moved to edksetup

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1582 testing for presence of python modules should be done in edksetup to reduce impact on subsequent build times. This code currently exists in BaseTools/Tests/RunTest.py. This patch is going to fix this issue. Cc: Bob Feng Cc: Liming Gao Sign

[edk2-devel] [PATCH] BaseTools:corrected error message for the DatumType error

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1762 For structure Pcd, Its DatumType may be self-defined, If the PCD DatumType format is incorrect, this PCD DatumType error message is inappropriate. This patch corrects the error message. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan

Re: [edk2-devel] [[edk2-platforms] 1/1] Platform/Intel/Stratix10: Add Stratix 10 platform support

Hi Ard, Leif, Micheal, Can you help review this patch? Thanks! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#39813): https://edk2.groups.io/g/devel/message/39813 Mute This Topic: https://groups.io/mt/31320028/21656 Group Owner: devel+ow

Re: [edk2-devel] [edk2-test] Location of tests for vendor/edk2 specific protocols

Hi Jeff, For the test for non-standard or vendor specific protocols, in my initial idea, I would like to see them on a separate space and can be built with SCT infrastructure thru description files and build scripts provided by vendor. Anyone can fetch the UEFI SCT or other specific test with hi

[edk2-devel] [PATCH] BaseTools:Delete FrameworkDatabase.template from BaseTools/Conf

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627 The FrameworkDatabase.template was already obsolete, So, FrameworkDatabase.template can be removed. This patch is going to fix this issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- ArmPlatformPkg/Scripts/Makefile

[edk2-devel] [Patch V2 1/6] MdePkg: Add PcdSpeculationBarrierType

Add gEfiMdePkgTokenSpaceGuid.PcdSpeculationBarrierType that uses the PCD type FixedAtBuild. This performs a build time selection for the type of speculation barrier to use in the BaseLib function SpeculationBarrier(). The recommended speculation barrier for x86 is LFENCE and this is the default v

[edk2-devel] [Patch V2 3/6] QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID

Set PcdSpeculationBarrierType to use CPUID instead of the default LFENCE in the BaseLib function SpeculationBarrier(). LFENCE requires SSE2, and Quark platforms do not support SSE2. Cc: Kelly Steele Signed-off-by: Michael D Kinney --- QuarkPlatformPkg/Quark.dsc| 7 ++- QuarkPlatformPkg/

[edk2-devel] [Patch V2 5/6] QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close

The following commit removed the unconditional UC setting just prior to closing the SMRAM region. This is a correct change for most platforms. https://github.com/tianocore/edk2/commit/bfc87aa78e77ed15b09d1b4499c5eab63e8842bb The Quark platforms still require this UC setting, so move the UC setti

[edk2-devel] [Patch V2 2/6] MdePkg/BaseLib: Use PcdSpeculationBarrierType

Use PcdSpeculationBarrierType in the x86 implementation of SpeculationBarrier() to select between AsmLfence(), AsmCpuid(), and no operation. Cc: Liming Gao Signed-off-by: Michael D Kinney --- MdePkg/Library/BaseLib/BaseLib.inf | 1 + MdePkg/Library/BaseLib/X86SpeculationBarrier.c |

[edk2-devel] [Patch V2 0/6] Resolve Quark build and boot issues

New in V2 = * Add PcdSpeculationBarrierType to select between LFENCE, CPUID, and no operation in the x86 implementation of the BaseLib function SpeculationBarrier(). * Set PcdSpeculationBarrierType to CPUID on Quark platforms. This series of patches resolves a few issues with building

[edk2-devel] [Patch V2 4/6] UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for single core

Avoid access to MSR_IA32_APIC_BASE that may not be supported on single core CPUs. If PcdCpuMaxLogicalProcessorNumber is 1, then there is only one CPU that must be the BSP. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Michael D Kinney --- UefiCpuPkg/Library/MpInitLib/PeiMpLib.c |

[edk2-devel] [Patch V2 6/6] QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision

Change function name from ResetSystem() to PlatformResetSystem() to resolve name collision with ResetSystemLib. Cc: Kelly Steele Signed-off-by: Michael D Kinney Reviewed-by: Kelly Steele --- QuarkPlatformPkg/Platform/Pei/PlatformInit/MemoryCallback.c | 6 +++--- .../Platform/Pei/PlatformInit/P

Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 30, 2019 2:31 AM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Wang, Jian J ; Ye, Ting > Subject: Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata > HMAC_ctx size > > On 04/29

Re: [edk2-devel] [staging/HBFA][PATCH] Announce to create "HBFA" branch in edk2-staging.

Thank you Tengfen. When you create official edk2-staging branch, would you please also add edk2 repo to the same staging-project ? I think we may need submit some patch to update both edk2 and HBFA at same time. Thank you Yao Jiewen From: Sun, Tengfen Sent: Tuesday, April 23, 2019 7:21 PM To:

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

Zhichao, That sounds like a bug in you graphics console devices.  If they are already initialized (by pei or other platform code) they should not start in mode -1.   For bug 1412, can we make sure all Tianocore edk2 drivers support "flicker free" and don't unncecessarly re-initialize.  Do you se

Re: [edk2-devel] Error building Python

Paulo: A port of the MicroPython Interpreter for UEFI is available in edk2-staging: (MicroPythonPkg). This is a Python 3 compatible alternative for the Python 2.7 implementation in AppPkg. Can you try this and provide feedback? https://github.com/tianocore/tianocore.github.io/wiki/MicroPython

Re: [edk2-devel] [Patch] Updated EDK II Release Notes

On 04/28/19 04:22, Wang Fan wrote: > Remove IpSec driver and IpSecConfig application in NetworkPkg for BZ1697. > > Cc: Liming Gao > Signed-off-by: Wang Fan > --- > EDK-II-Release-Notes.md | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/EDK-II-Release-Notes.md b/EDK-II-Release-Not

Re: [edk2-devel] [Patch] BaseTools: Add GCC flags to Basetool build.

Hi Bob, On 04/29/19 10:01, Bob Feng wrote: > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 > > Some compiler flags restrict the compiler from making > arbitrary decisions while handling undefined C/C++ behaviors. > Therefore they can be used to fix some issues caused by undefined behavio

Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

On 04/29/19 10:15, Xiaoyu lu wrote: > From: Xiaoyu Lu > > Openssl internally redefines the size of HMAC_CTX, > but there is no external definition. > So add an additional nubmer. > > Cc: Jian J Wang > Cc: Ting Ye > Signed-off-by: Xiaoyu Lu > --- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacM

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

Hi, Thanks for the detailed feedback. I did consider moving the CPUID check up a level so AsmLfence() would always do the requested instruction. This would have been a larger patch set that would introduce an IA32 and X64 specific version of SpeculationBarrier(). I agree that a build time PCD wo

Re: [edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

Preliminary comments: On 04/29/19 10:15, Xiaoyu lu wrote: > From: Xiaoyu Lu > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > * update openssl submodule to OpenSSL_1_1_1b Seems OK (at 50eaac9f3337667259de725451f201e784599687). > * run process_files.pl script to regenerate Opens

Re: [edk2-devel] [Patch 2/4] UefiCpuPkg/MpInitLib: Avoid MSR_IA32_APIC_BASE for single core

Laszlo, I was attempting to follow the equivalent detection logic that is used in the SourceLevelDebugPkg. https://github.com/tianocore/edk2/blob/e2d3a25f1a3135221a9c8061e1b8f90245d727eb/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c#L140 Yes. CPUID can be used to determine a

Re: [edk2-devel] Error building Python

+AppPkg maintainers On Sun, Apr 28, 2019 at 09:25:28PM -0700, phlamo...@riseup.net wrote: > I want to use python to prototype some UEFI applications, but the build > is not working on my environment, im trying to build in a linux(debian) > which have "gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516" i

Re: [edk2-devel] [Patch 0/7] Add new CLANG8ELF tool chain for new LLVM/CLANG8

On Sun, Apr 28, 2019 at 12:55:02AM +, Liming Gao wrote: > >> This tool chain can be used to compile the firmware code. On windows OS, > >> Visual Studio is still required to compile BaseTools C tools and > >> provide nmake.exe for makefile. On Linux/Mac OS, gcc is used to compile > >> BaseTools

Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions

Hi Laszlo, I have entered 2 BZ for the STATIC -> static conversion. one for the EDK II C Coding Standard Specification and one for the C code in EDK II. https://bugzilla.tianocore.org/show_bug.cgi?id=1766 https://bugzilla.tianocore.org/show_bug.cgi?id=1767 Converting all CONST -> const will re

[edk2-devel] CredentialProviderDxe for Fingerprint Reader

Hi everyone, I have a research task on my current project to attempt some diagnostics routine for fingerprint readers in pre-OS. I would like to know if anyone has an example of Dxe driver that produces a CredentialProvider protocol for Fingerprint, so I can take a look at it and try modif

[edk2-devel] Error building Python

I want to use python to prototype some UEFI applications, but the build is not working on my environment, im trying to build in a linux(debian) which have "gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516" installed, the EDK2 is properly installed, i build other packages like OVMF and Mde*, at the first

[edk2-devel] [edk2] Example of CredentialProviderDxe for fingerprint class on UDK

Hi everyone, I have a research task on my current project to attempt some diagnostics routine for fingerprint readers in pre-OS. I would like to know if anyone has an example of Dxe driver that produces a CredentialProvider protocol for Fingerprint, so I can take a look at it and try modifying

[edk2-devel] [PATCH] SecurityPkg/OpalPassword: Add warning message for Secure Erase

https://bugzilla.tianocore.org/show_bug.cgi?id=1753 Add pop-up warning messages before secure erase action. In order to notify user the secure erase action will take a longer time. This change also fix some pop-up windows are unable to show up complete message due to some strings are too long. Con

[edk2-devel] [edk2] example of CredentialProviderDxe for fingerprint class on UDK

Hi everyone, I have a research task on my current project to attempt some diagnostics routine for fingerprint readers in pre-OS. I would like to know if anyone has an example of Dxe driver that produces a CredentialProvider protocol for Fingerprint, so I can take a look at it and try modifying

[edk2-devel] Error building Python

I want to use python to prototype some UEFI applications, but the build is not working on my environment, im trying to build in a linux(debian) which have "gcc (Debian 6.3.0-18+deb9u1) 6.3.0 20170516" installed, the EDK2 is properly installed, i build other packages like OVMF and Mde*, at the first

Re: [edk2-devel] [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS

On 04/29/19 15:35, Ard Biesheuvel wrote: > On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas wrote: >> >> Latest change allowed to add dependency on NvVarStoreFormattedLib >> for the DXE_DRIVER modules. Although effectively it is hooked >> using the 'NULL' class, extend the LIBRARY_CLASS with according

Re: [edk2-devel] [patch 09/11] UefiCpuPkg: Remove PcdFrameworkCompatibilitySupport usage

On 04/29/19 04:16, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464 > > Currently Framework compatibility support is not needed and > PcdFrameworkCompatibilitySupport will be removed from edk2. > So remove the usage of this PCD firstly. > > Cc: Eric Dong > Cc: Ray Ni

[edk2-devel] [Patch v4 3/3] NetworkPkg: Add package level include DSC file

Platform DSC can include Network.dsc.inc to enable network features. Signed-off-by: Liming Gao --- NetworkPkg/Network.dsc.inc | 40 NetworkPkg/NetworkPkg.dsc | 22 +- 2 files changed, 41 insertions(+), 21 deletions(-) create mode 100

[edk2-devel] [Patch v4 1/3] NetworkPkg DSC: Add the required ARM library to pass ARM build

Signed-off-by: Liming Gao --- NetworkPkg/NetworkPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index b5416b1614..be9d9248e4 100644 --- a/NetworkPkg/NetworkPkg.dsc +++ b/NetworkPkg/NetworkPkg.dsc @@ -72,6 +72,8 @

[edk2-devel] [Patch v4 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

This patch provides a set of include segment files for platform owner to easily enable/disable network stack support on their platform. For DSC, there are: - a "NetworkDefines.dsc.inc" for the [Defines] section(s), - a "NetworkLibs.dsc.inc" for the [LibraryClasses*] section(s), - a "NetworkPcds.ds

[edk2-devel] [Patch v4 0/3] Add package level include DSC/FDF in NetworkPkg

v4: Move library instance BaseStackCheckLib to ARM, AARCH64 arch in Patch 1/3 Move PLATFORMX64_ENABLE build flag to package level include DSC file Correct typo in Patch 3/3 BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 BZ 1293 requests to move Network modules from MdeModulePkg to Network

Re: [edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

Hi Xiaoyu, Small typos: "update" in subject. Maybe better described as "Make HMAC_CTX_SIZE backward compatible"? On 4/29/19 10:15 AM, Xiaoyu lu wrote: > From: Xiaoyu Lu > > Openssl internally redefines the size of HMAC_CTX, "OpenSSL"? > but there is no external definition. > So add an additi

Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Monday, April 29, 2019 9:11 PM > To: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in > NetworkPkg > > On

Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, April 29, 2019 9:05 PM > To: devel@edk2.groups.io; Gao, Liming > Cc: Wu, Jiaxin ; Ye, Ting ; Fu, > Siyuan > Subject: Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include > segment files to Ne

Re: [edk2-devel] [Patch v3 3/3] NetworkPkg: Add package level include DSC file

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Monday, April 29, 2019 8:04 PM > To: devel@edk2.groups.io; Gao, Liming > Subject: Re: [edk2-devel] [Patch v3 3/3] NetworkPkg: Add package level > include DSC file > > On 0

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Monday, April 29, 2019 7:15 PM > To: devel@edk2.groups.io; brian.john...@hpe.com; Kinney, Michael D > > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 1/4] MdePkg/Base

Re: [edk2-devel] [edk2-platforms: PATCH v3 0/4] Armada7k8k FVB improvements

Hi Leif, Ard, czw., 25 kwi 2019 o 14:35 Marcin Wojtas napisał(a): > > Hi Leif, > > czw., 25 kwi 2019 o 14:01 Leif Lindholm napisał(a): > > > > Hi Marcin, > > > > Just to be awkward - edk2-platforms (and edk2-non-osi) have not yet > > been relicensed, so we still need "contributed-under" here. >

Re: [edk2-devel] [PATCH] EmbeddedPkg: Extend NvVarStoreFormattedLib LIBRARY_CLASS

On Sat, 27 Apr 2019 at 11:16, Marcin Wojtas wrote: > > Latest change allowed to add dependency on NvVarStoreFormattedLib > for the DXE_DRIVER modules. Although effectively it is hooked > using the 'NULL' class, extend the LIBRARY_CLASS with according > type for consistency sake. > > Signed-off-by:

Re: [edk2-devel] [Patch v3 0/3] Add package level include DSC/FDF in NetworkPkg

On 04/25/19 14:37, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > BZ 1293 requests to move Network modules from MdeModulePkg to NetworkPkg. > To keep the backword compatiblity, Network package level include DSC/FDF > are introduced to be used in the platform DSC/FDF f

Re: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg.

On 04/25/19 14:37, Liming Gao wrote: > This patch provides a set of include segment files for platform owner to > easily enable/disable network stack support on their platform. > > For DSC, there are: > - a "NetworkDefines.dsc.inc" for the [Defines] section(s), > - a "NetworkLibs.dsc.inc" for the

Re: [edk2-devel] [PATCH 10/16] OvmfPkg/EnrollDefaultKeys: split out certificate and signature constants

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > A large portion of "EnrollDefaultKeys.c" is hex-encoded X509 certificates, > GUIDs, and signatures. These objects are constants, unlikely to see > changes anytime soon. Move them out of the way, to "AuthData.c", so we can > more easily work on functions in

Re: [edk2-devel] [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GetExact(), GetSettings(), PrintSettings() functions are only called > from within "EnrollDefaultKeys.c", and none of them take variable > arguments. Drop their EFIAPI calling convention specifiers. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: J

Re: [edk2-devel] [PATCH 13/16] OvmfPkg/EnrollDefaultKeys: document the steps of the entry point function

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The entry point function of EnrollDefaultKeys finishes with a sanity > check, verifying the values of the Secure Boot-related "control" > variables. Add a diagram to explain why we expect the values we do. > > While at it, write comments on the rest of the

Re: [edk2-devel] [PATCH 04/16] ArmVirtPkg: build EnrollDefaultKeys.efi

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Having removed VALID_ARCHITECTURES from > "OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.inf", it now makes sense to > reflect the related platform DSC bits from OvmfPkg to ArmVirtPkg. > > Build "EnrollDefaultKeys.efi" as part of ArmVirtQemu and ArmVirtQemuK

Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver

hi Ard/Leif On Mon, Apr 29, 2019 at 2:22 PM Leif Lindholm wrote: > > On Mon, Apr 29, 2019 at 10:17:17AM +0200, Ard Biesheuvel wrote: > > > I mean, the actually relevant bit is basically > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mtd/afs.c, > > > isn't it

Re: [edk2-devel] [PATCH 09/16] OvmfPkg/EnrollDefaultKeys: extract typedefs to a header file

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > "EnrollDefaultKeys.c" defines three structure types: SINGLE_HEADER, > REPEATING_HEADER, and SETTINGS. The definitions are scattered over the C > file, and lack high-level summary comments. > > Extract the structures to "EnrollDefaultKeys.h", and add the mi

Re: [edk2-devel] [PATCH 06/16] OvmfPkg/EnrollDefaultKeys: clean up global variable name prefixes

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > In edk2, we should start the names of module-global variables with "m". > Rename the "RedHatPkKek1", "MicrosoftKEK", "MicrosoftPCA", > "MicrosoftUefiCA" variables accordingly, with the following command: > > sed --regexp-extended --in-place \ > --exp

Re: [edk2-devel] [PATCH 05/16] OvmfPkg/EnrollDefaultKeys: clean up minor whitespace wart

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > In edk2, we should spell "#pragma pack(...)" with a space character in > front of the opening parenthesis. Fix up locations that suggest otherwise. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Bugzilla: https://b

Re: [edk2-devel] [PATCH 03/16] OvmfPkg/EnrollDefaultKeys: refresh INF file

On 4/27/19 2:53 AM, Laszlo Ersek wrote: > Bump INF_VERSION to the latest edk2 INF specification. > > Regenerate FILE_GUID to distinguish this application from downstream-only > versions. > > Remove the VALID_ARCHITECTURES comment as there is nothing ISA or platform > specific in the application.

Re: [edk2-devel] [PATCH edk2-platforms] Silicon/SynQuacer: add ACPI description of GPIO controller and power button

On Fri, 26 Apr 2019 at 12:58, Leif Lindholm wrote: > > On Thu, Apr 25, 2019 at 12:51:27PM +0200, Ard Biesheuvel wrote: > > Add ACPI descriptions of the GPIO and external interrupt (EXIU) > > controllers as well as the power button. Note that on rev 0.3 > > boards, the power button appears to reset

Re: [edk2-devel] [Patch v3 3/3] NetworkPkg: Add package level include DSC file

On 04/25/19 14:37, Liming Gao wrote: > Platform DSC can include Network.dsc.inc to enable network features. > > Signed-off-by: Liming Gao > --- > NetworkPkg/Network.dsc.inc | 30 ++ > NetworkPkg/NetworkPkg.dsc | 23 +-- > 2 files changed, 31 inser

Re: [edk2-devel] [Patch 1/4] MdePkg/BaseLib: Verify SSE2 support in IA32 AsmLfence()

On 04/26/19 23:08, Brian J. Johnson wrote: > On 4/26/19 3:27 PM, Laszlo Ersek wrote: >> On 04/25/19 19:53, Michael D Kinney wrote: >>> Use CPUID in IA32 implementation of AsmLfence() to verify >>> that SSE2 is supported before using the LFENCE instruction. >>> >>> Cc: Liming Gao >>> Signed-off-by:

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments

Pushed at 038f929c921c3b6f2fb47a79f0e89caa0ed649c0 Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, > Jian J > Sent: Sunday, April 28, 2019 4:02 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ye, Ting > Subject: Re: [ed

[edk2-devel] [PATCH] IntelSiliconPkg/IntelVTdDxe: Always do global invalidation

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1547 Only doing IOTLB invalidation would cause a BSOD 'DRIVER_VERIFIER_DMA_VIOLATION' while changing the second level page entry's attributes. So always do the global invalidation of context-cache and IOTLB. Cc: Jiewen Yao Cc: Ray Ni Cc: Ranga

Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver

On Mon, Apr 29, 2019 at 10:17:17AM +0200, Ard Biesheuvel wrote: > > I mean, the actually relevant bit is basically > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mtd/afs.c, > > isn't it? > > > > +Thomas. > > AIUI, these things are entirely separate. Exposing NO

[edk2-devel] [PATCH 1/3] CryptoPkg/IntrinsicLib: add ftol2 function

From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 MSFT build support for building OpenSSL_1_1_1b add _ftol2 function Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 22 ++ CryptoPkg/Library

[edk2-devel] [PATCH 3/3] CryptoPkg/BaseCryptLib: updata HMAC_ctx size

From: Xiaoyu Lu Openssl internally redefines the size of HMAC_CTX, but there is no external definition. So add an additional nubmer. Cc: Jian J Wang Cc: Ting Ye Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c| 11 ++- CryptoPkg/Library/BaseCryptLib

Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver

On Mon, 29 Apr 2019 at 09:58, Leif Lindholm wrote: > > On Mon, Apr 29, 2019 at 08:52:46AM +0200, Ard Biesheuvel wrote: > > > > > I am not sure if any other platform is using > > > > > “ArmPlatformPkg/Drivers/NorFlashDxe” and may require block I/O and > > > > > disk I/O protocols > > > > > if we r

[edk2-devel] [PATCH 2/3] CryptoPkg: Upgrade openssl to 1.1.1b

From: Xiaoyu Lu REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 * update openssl submodule to OpenSSL_1_1_1b * run process_files.pl script to regenerate OpensslLib[Crypto].inf * remove NO_SYSLOG from OpensslLib[Crypto].inf * add -DOPENSSL_RAND_SEED_NONE to OpensslLib[Crypto].inf * add -

[edk2-devel] [PATCH 0/3] CryptoPkg: Upgrade OpenSSL to 1_1_1b

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 Upgrade openssl to 1_1_1b Release. 1. add instrinsic function 2. disable ossl_store functions. we don't use them. 3. dummy implement rand_pool funtions. 4. fix HMAC_CTX size to compatible previous API. We tested https boot on OvmfPkg and N

[edk2-devel] [Patch] BaseTools: Add GCC flags to Basetool build.

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1764 Some compiler flags restrict the compiler from making arbitrary decisions while handling undefined C/C++ behaviors. Therefore they can be used to fix some issues caused by undefined behavior. For example, for GCC, the following flags are avai

Re: [edk2-devel] [edk2] [PATCH v2 edk2-platforms] Platform/ARM/Drivers: Add Nor Flash Driver

On Mon, Apr 29, 2019 at 08:52:46AM +0200, Ard Biesheuvel wrote: > > > > I am not sure if any other platform is using > > > > “ArmPlatformPkg/Drivers/NorFlashDxe” and may require block I/O and > > > > disk I/O protocols > > > > if we remove “support of block I/O and disk I/O protocols” then we > >

Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, > Hao A > Sent: Friday, April 26, 2019 4:35 PM > To: Loh, Tien Hock; devel@edk2.groups.io; thlo...@gmail.com > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH v5 1/1] MdeModulePkg: > BaseSer