Reviewed-by: Liming Gao
>-Original Message-
>From: Wu, Hao A
>Sent: Wednesday, May 08, 2019 1:39 PM
>To: devel@edk2.groups.io
>Cc: Wu, Hao A ; Wang, Jian J ;
>Ni, Ray ; Gao, Liming
>Subject: [PATCH] Maintainers.txt: Update the name of 'Hao Wu' to 'Hao A Wu'
>
>This commit will update
This commit will update the name of 'Hao Wu' to 'Hao A Wu' to match the
mail address.
Cc: Jian J Wang
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Hao A Wu
---
Maintainers.txt | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
I think ResetUtilityLib.h is a good place to add the new structure definition.
But I think this lib cannot be consumed in some conditions. The new
ResetUtilityLib add a new API which would consume a new API ResetSystem in
ResetSystemLib.
As we know different platforms have different instances of
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772
Transfer reset data start with a null sting and followed by
gEdkiiCapsuleUpdateCompleteResetGuid for capsule update.
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772
Add a useful definition of reset data which start with a NULL
string and followed by a EFI_GUID.
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Cc: Bret Barkelew
Cc: Laszlo
Change the comment of EfiResetSystem base on the
UEFI spec 2.8
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Zhichao Gao
---
MdePkg/Include/Library/UefiRuntimeLib.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Include/Library/UefiRuntimeLib.h
Indicate two guids gCapsuleArmedResetGuid and gCapsuleUpdateCompleteResetGuid
for capsule update. And define a struct which start with a null string and
followed by a EFI_GUID.
V2:
Add prefix Edkii to the new guids.
Move the new struct definition to ResetSystemLib.h.
Fix the wrong reset data to
Change the comment of EfiResetSystem base on the
UEFI spec 2.8
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Zhichao Gao
---
MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772
Transfer reset data start with a null sting and followed by
gEdkiiCapsuleArmedResetGuid for capsule update.
Cc: Jian J Wang
Cc: Hao Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
Cc: Michael Turner
Fix SyntaxWarning in regular expression on Python 3.8
Signed-off-by: Mikhail Terekhov
---
BaseTools/Source/Python/build/build.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/build.py
index
https://bugzilla.tianocore.org/show_bug.cgi?id=1782
After change behavior to send BlockSid command at EndOfDxe point,
check device ownership command will return un-authority error, it
finally caused opal driver can't show "Enable Feature" menu.
Update the code logic to send detect device
https://bugzilla.tianocore.org/show_bug.cgi?id=1782
Change BlockSID default policy, default enable BlockSid.
Signed-off-by: Eric Dong
Cc: Hao Wu
---
SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
SecurityPkg/SecurityPkg.dec | 2 +-
2 files changed, 3
https://bugzilla.tianocore.org/show_bug.cgi?id=1782
Change Send BlockSID command time from ReadyToBoot to
EndOfDxe.
Signed-off-by: Eric Dong
Cc: Hao Wu
---
.../Tcg/Opal/OpalPassword/OpalDriver.c| 104 --
1 file changed, 46 insertions(+), 58 deletions(-)
diff --git
This patch serial includes:
1. Change BlockSID default policy, default enable BlockSid.
2. Change SendBlockSID command time from ReadyToBoot to EndOfDxe.
3. Fix "Enable Feature" Menu disappear issue.
V2 change:
1. Include the Bugz link.
Eric Dong (3):
SecurityPkg/SecurityPkg.dec: Change
Hi all,
Thank you for the reminding and guidance.
V2 patch series has been sent out.
Regards,
Dandan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Tuesday, May 7, 2019 8:53 PM
> To: devel@edk2.groups.io;
Follow edk2 tree hash: 9343d0a1cd09544686b14dba5b428d7bc811f6b9 to use
VENDOR_DEVICE_PATH to create the Debug port device node.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nick Wang
---
.../DevicePathFromTextBBTestCoverage.c | 16 +++-
> On May 7, 2019, at 7:40 AM, Leif Lindholm wrote:
>
> Hi Fan Zhiju,
>
> But where does the string come from that contains a .C suffix?
> Is the tool internally converting things to uppercase, or is some
> source file in the build incorrectly named?
>
Leif,
Our build system defines .C as
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
TIANOCOMPRESSED rule in fdf is not used, so remove it.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Michael D Kinney
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Dandan Bi
---
Platform/ARM/SgiPkg/SgiPlatform.fdf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in fdf is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
1. TIANOCOMPRESSED rule in fdf is not used, so remove it.
2. The common UefiDecompressLib resolution in
[LibraryClasses.common] section can apply to
all module types. Remove the additional one.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in fdf is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in fdf is
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1722
BaseUefiDecompressLib in MdePkg is the
base UEFI decompress Library.
BaseUefiTianoCustomDecompressLib in MdeModulePkg
implements the base UEFI decompress functionality and
Tiano decompress functionality.
1. TIANOCOMPRESSED rule in
Hi Leif,
In AutoGen\GenMake.py. It's around line 917
if File.Ext not in [".c", ".C"] or File.Name == "AutoGen.c"
there is similar code to check the .C file.
The 'File' above refers to the source File.Some source files are named.C
Any question, please let me know. Thanks.
Best Regards
Fan
Hi Maggie,
Reviewed-by: Eric Dong
And pushed.
SHA-1: f5245a1db144be95046deaed71a99b64362595b6
* SecurityPkg/OpalPassword: Add warning message for Secure Erase
https://bugzilla.tianocore.org/show_bug.cgi?id=1753
Add pop-up warning messages before secure erase action.
In order to notify user
Hi Nick,
Thank you for the patch.
Comments (same as Supreeth) as below.
1. Please add your email . E.g: Signed-off-by: Nick Wang
2. replace 0x03 and 0x0a with meaningful macros. The macro can be defined in
SctPkg/UEFI/Protocol/DevicePath.h
Best Regards
Eric
-Original Message-
Sure. Thanks for your detail review.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, May 8, 2019 2:38 AM
> To: devel@edk2.groups.io; Gao, Liming
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu,
> Siyuan
> Subject: Re:
Yes, I would support it. Tim
-Original Message-
From: Carsey, Jaben
Sent: Tuesday, May 7, 2019 5:00 PM
To: Jonathan Watt ; devel@edk2.groups.io;
tim.le...@insyde.com; Gao, Zhichao ; Ni, Ray
Cc: Bi, Dandan
Subject: RE: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix
Tim,
Does this mean you would support such an errata? I would like to get the spec
to a place where the behavior is at least nailed down one way or the other...
-Jaben
> -Original Message-
> From: Jonathan Watt [mailto:jw...@jwatt.org]
> Sent: Tuesday, May 7, 2019 2:08 PM
> To:
Since UefiPayloadPkg in EDK2 supports Coreboot and Slim Bootloader, and
no concerns were received for the RFC to remove CorebootModulePkg and
CorebootPayloadPkg from EDK2 (https://edk2.groups.io/g/devel/message/39126),
here is the action patch to remove CorebootModulePkg and CorebootPayloadPkg.
RFC Edk2-Library creation
Create a new tianocore owned repository to host a python library package in
support of UEFI development. This package will allow easy sharing of python
library code to facilitate reuse. Inclusion of this package and dependency
management should be managed using
Ah, hopefully that simplifies the decision. At any rate, thank you for checking
and clarifying.
For those working on the spec, in addition to clarifying -opt to avoid this
confusion, one further thing to do would be to clarify the format of the "in
hexadecimal" option. It would be good if it
That is good news! Mostly because assuming it was decimal should make no sense
to an engineer! :-)
-Original Message-
From: Tim Lewis
Sent: Tuesday, May 7, 2019 3:49 PM
To: Dailey, Jim; devel@edk2.groups.io
Cc: dandan...@intel.com; jw...@jwatt.org; jaben.car...@intel.com;
Jonathan --
My apologies. I jumped because we've been bitten by shell "clarifications" in
the past.
As you've probably read in the other thread, it turns out that I (we) actually
did agree with your interpretation of the spec in our alternate implementation
and have been using it that way for
No apologies necessary! Raising compatibility concerns is very valid. As I said,
I just wanted to provide some other considerations I saw to weigh in the
decision.
All the best,
Jonathan
On 07/05/2019 22:02, Tim Lewis wrote:
> Jonathan --
>
> My apologies. I jumped because we've been bitten by
Tim,
Out of curiosity, what does the specification you refer to that was used to
write the non-EDK2 implementations say about the -opt switch?
Regards,
Jim
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tim Lewis
Sent: Tuesday, May 7, 2019 3:04 PM
To: 'Jonathan Watt';
Hi Tim,
For context, I'm just some random guy who tripped over this issue on his home
workstation and thought he'd try and remove the footgun to save anyone else the
same pain. I was specifically replying to the unconditional statement "It will
break existing scripts." (not made by you) to
Jim --
Well, speaking of shooting-oneself-in-the-foot, it turns out that our non-EDK2
implementation followed the recommendation in the patch.
I agree that the spec is ambiguous and, it turns out that our largest use case
already uses the recommended behavior.
Sorry to one and all.
Tim
Jonathan --
The bcfg command pre-dates the UEFI shell specification. I know of at least two
non-EDK2 implementations, including one maintained by my company, that are
implemented to the specification. Server platforms that use the "application"
style boot options can regularly run over 10
There is potential for that, but it's not certain. For it to happen scripts
would need to be both omitting the "0x" prefix and be pass an option number
greater than 9. The fact this very unexpected inconsistency (which will corrupt
the wrong option when those same two things are true!) hasn't been
Hi Liming,
On 05/07/19 16:27, Liming Gao wrote:
> This patch provides a set of include segment files for platform owner to
> easily enable/disable network stack support on their platform.
>
> For DSC, there are:
> - a "NetworkDefines.dsc.inc" for the [Defines] section(s),
> - a
It will break existing scripts. Do you have such scripts in your environment
dependent on this parameter?
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Tim Lewis
> Sent: Tuesday, May 07, 2019 9:20 AM
> To: devel@edk2.groups.io; Carsey,
Yes. And we have been recommending the usage of bcfg to our customers for
years.
Tim
-Original Message-
From: Carsey, Jaben
Sent: Tuesday, May 7, 2019 10:41 AM
To: devel@edk2.groups.io; tim.le...@insyde.com; Gao, Zhichao
; Ni, Ray ; jw...@jwatt.org
Cc: Bi, Dandan
Subject: RE:
On Tue, May 07, 2019 at 04:57:26PM +0100, Pete Batard wrote:
> While compiling drivers or applications on Debian 9.8, using the native
> gcc 6.3.0 ARM compiler, one may run into the following build failure:
>
> "undefined reference to `__aeabi_lasr'"
>
> This patch adds the missing definition,
The question is whether this will break compatibility with existing shell
scripts. In order to maintain that compatibility, it may be necessary to add
a new option rather than trying to update an existing one.
Tim
-Original Message-
From: devel@edk2.groups.io On Behalf Of Carsey, Jaben
While compiling drivers or applications on Debian 9.8, using the native
gcc 6.3.0 ARM compiler, one may run into the following build failure:
"undefined reference to `__aeabi_lasr'"
This patch adds the missing definition, through a port of the existing
RVCT lasr.asm source.
CC: Ard Biesheuvel
On 2019-05-07 05:49, Laszlo Ersek wrote:
>
> I'd expect it to interoperate with any gdb server implementation.
>
> Whenever I use DebugPkg, to connect to a running QEMU instance, I launch the
> following gdb scriptlet (with "gdb -x") from a file:
>
> set height 0
> set architecture
The change is good. Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Krzysztof Koch
> Sent: Tuesday, May 7, 2019 8:56 PM
> To: devel@edk2.groups.io
> Cc: sami.muja...@arm.com; n...@arm.com
> Subject:
Also agree to update Shell Spec to add description for "#" in "-opt" part to
make it consistent with other options since this patch has updated the code
behavior to be consistent.
For the patch
Reviewed-by: Bi Dandan
Thanks,
Dandan
> -Original Message-
> From: Carsey, Jaben
> Sent:
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming
> Gao
> Sent: Tuesday, May 7, 2019 10:27 PM
> To: devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan
>
> Subject: [edk2-devel] [Patch v5 2/3] NetworkPkg:
Hi Fan Zhiju,
But where does the string come from that contains a .C suffix?
Is the tool internally converting things to uppercase, or is some
source file in the build incorrectly named?
I am asking because it is not clear to me whether the patch resolves a
problem or hides one.
Best Regards,
Zhichao,
I can help submit errata for shell spec if needed.
Per patch,
I agree. This looks good.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, May 07, 2019 2:52 AM
> To: devel@edk2.groups.io; Ni, Ray ; jw...@jwatt.org
> Cc: Carsey, Jaben ; Bi,
Signed-off-by: Liming Gao
Reviewed-by: Laszlo Ersek
---
NetworkPkg/NetworkPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc
index b5416b1614..be9d9248e4 100644
--- a/NetworkPkg/NetworkPkg.dsc
+++
Platform DSC can include Network.dsc.inc to enable network features.
Signed-off-by: Liming Gao
Acked-by: Laszlo Ersek
---
NetworkPkg/Network.dsc.inc | 40
NetworkPkg/NetworkPkg.dsc | 22 +-
2 files changed, 41 insertions(+), 21
v5:
Update Network.fdf.inc to include the missing IScsiDxe
Update NetworkLibs.dsc.inc to add the comments for HttpLib
v4:
Move library instance BaseStackCheckLib to ARM, AARCH64 arch in Patch 1/3
Move PLATFORMX64_ENABLE build flag to package level include DSC file
Correct typo in Patch 3/3
BZ:
This patch provides a set of include segment files for platform owner to
easily enable/disable network stack support on their platform.
For DSC, there are:
- a "NetworkDefines.dsc.inc" for the [Defines] section(s),
- a "NetworkLibs.dsc.inc" for the [LibraryClasses*] section(s),
- a
Hi everyone,
My patch has finally reached the mailing list. The problem was the SMTP port
number 587 that I was using. Sorry for the trouble.
Kind regards,
Krzysztof Koch
-Original Message-
From: devel@edk2.groups.io On Behalf Of Krzysztof Koch
via Groups.Io
Sent: Tuesday, May 7,
The patch includes the following ACPI 6.3 updates:
1. Reserve CRAT and CDIT table names in ACPI 6.3 header.
- ACPI 6.3 January 2019, Table 5-30
- Mantis ID 1883 (https://mantis.uefi.org/mantis/view.php?id=1883)
2. Add new processor structure flags in PPTT.
- ACPI 6.3 January 2019,
On 05/07/19 13:31, Leif Lindholm wrote:
> Hi Dandan,
>
> Sorry to be a pain, but could you follow the steps in
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09
> and then regenerate these patches and send out
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Tuesday, May 07, 2019 1:55 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Dong, Eric
> Subject: [edk2-devel] [PATCH v3]
On 05/07/19 06:59, pavankuma...@persistent.co.in wrote:
> On Thu, May 2, 2019 at 03:11 AM,
> wrote:
>
>>
>> Hi Laszlo,
>
> As you suggested in the in-line mail I have found a machine which
> supports EPT technology in our lab environment. And to maintain a
> homogeneous KVM Host environment
On 05/07/19 10:59, Ryszard Knop wrote:
> Hi Mike,
>
> GdbSyms can be built separately from the debugged image. It produces a
> DLL file to load while starting GDB so that it properly detects the
> target once connected. The associated gdb_uefi.py script loads it with
> symbol-file to get some
Hi Dandan,
Sorry to be a pain, but could you follow the steps in
https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-09
and then regenerate these patches and send out again?
That way, it is obvious from the diff which
From: "tien.hock.loh"
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write. This patch adds the UNI information on the new
Pcd introduced - PcdSerialRegisterAccessWidth
Signed-off-by: "Tien Hock, Loh"
Cc: Jian J Wang
Cc: Hao Wu
Cc: "Zhu, YongHong"
On 05/06/19 23:02, Kinney, Michael D wrote:
> Laszlo,
>
> I agree with both your points. The file name should not imply
> that it can only be used for capsule resets.
>
> I also agree that the structure name and GUIDs should use
> EDKII_ and gEdkii prefixes.
>
> I also suggest, since the 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777
BootInRecoveryMode Ppi dependency should be removed from PEI storage stack
drivers. Besides recovery, more features are using the storage stack.
Platform can apply Ppi dependency in Recovery FV which contains full storage
driver stack.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777
BootInRecoveryMode Ppi dependency should be removed from PEI storage stack
drivers.Besides recovery, more features are using the storage stack.
CC: Ni Ray
CC: Wu Hao A
xuwei6 (2):
FatPkg/FatPei: Remove BootInRecoveryMode PPI DEPEX.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1777
BootInRecoveryMode Ppi dependency should be removed from PEI storage stack
drivers. Besides recovery, more features are using the storage stack.
Platform can apply Ppi dependency in Recovery FV which contains full storage
driver stack.
This patch looks good for me.
Reviewed-by: Zhichao Gao
But when I view the command in UEFI SHELL 2.2 spec:
...
bcfg driver|boot [-opt # [[filename]|["data"]] | [KeyData *]]
...
-opt
Modify the optional data associated with a driver or boot option. Followed
either by the filename of the file
Hi Leif,
We do not use this file and am ok if this is removed. However, I will let
Thomas confirm this.
Regards,
Sami Mujawar
-Original Message-
From: Leif Lindholm
Sent: 07 May 2019 10:31 AM
To: Fan, ZhijuX
Cc: devel@edk2.groups.io; Thomas Abraham ; Sami Mujawar
; Cohen, Eugene
On Mon, May 06, 2019 at 09:20:12AM +, Fan, ZhijuX wrote:
> BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
>
> The FrameworkDatabase was already obsolete,
> So, FrameworkDatabase can be removed from ArmPlatformPkg.
>
> This patch is going to fix this issue.
>
> Cc: Leif Lindholm
>
Reviewed-by: Zailiang Sun
> -Original Message-
> From: Fan, ZhijuX
> Sent: Monday, May 6, 2019 5:19 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi
> Subject: [PATCH 2/3] Vlv2TbltDevicePkg:Delete FrameworkDatabase from
> Vlv2TbltDevicePkg
>
>
Reviewed-by: Zailiang Sun
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, April 29, 2019 10:16 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi
> Subject: [patch 10/11] Vlv2TbltDevicePkg: Remove
> PcdFrameworkCompatibilitySupport usage
>
> REF:
Reviewed-by: Liming Gao
>-Original Message-
>From: Feng, Bob C
>Sent: Sunday, April 28, 2019 11:45 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [Patch] Document: Correct the Appendix G to Appendix F
>
>BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1690
>
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Tuesday, May 7, 2019 3:14 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH V2] BaseTools:corrected error message for the DatumType error
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1762
This patch serial includes:
1. For safe concern, change BlockSID default policy.
2. Change SendBlockSID command time from ReadyToBoot to EndOfDxe.
3. Fix "Enable Feature" Menu disappear issue.
Eric Dong (3):
SecurityPkg/SecurityPkg.dec: Change default value.
SecurityPkg/OpalPassword: Change
Change SendBlockSID command time from ReadyToBoot to EndOfDxe.
Signed-off-by: Eric Dong
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c | 104 +++--
1 file changed, 46 insertions(+), 58 deletions(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalDriver.c
After change behavior to send BlockSid command at EndOfDxe point,
check device ownership command will return un-authority error, it
finally caused opal driver can't show "Enable Feature" menu.
Update the code logic to send detect device ownership command
before send BlockSID command.
For safe concern, change BlockSID default policy.
Signed-off-by: Eric Dong
---
SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++-
SecurityPkg/SecurityPkg.dec | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git
https://bugzilla.tianocore.org/show_bug.cgi?id=1552
Add two libraries used to provide CMOS related operation.
CmosAccessLib exports below APIs:
CmosWrite32
CmosWrite16
CmosWrite8
CmosRead32
CmosRead16
CmosRead8
CmosInit
PlatformCmosAccessLib export below APIs:
https://bugzilla.tianocore.org/show_bug.cgi?id=1552
Add two libraries used to provide CMOS related operation.
CmosAccessLib exports below APIs:
CmosWrite32
CmosWrite16
CmosWrite8
CmosRead32
CmosRead16
CmosRead8
CmosInit
PlatformCmosAccessLib export below APIs:
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1762
For structure Pcd, Its DatumType may be self-defined,
If the PCD DatumType format is incorrect,
this PCD DatumType error message is inappropriate.
This patch corrects the error message.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, May 7, 2019 1:42 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Wu, Hao A ;
> Ni, Ray ; Zeng, Star ; Gao, Liming
> ; Sean Brogan ;
> Michael Turner ; Bret Barkelew
>
> Subject: Re:
Hi Hao and Liming,
Any comments for this patch itself?
As for whether delete the header definition of EFI_PE32_IMAGE_PROTOCOL , it is
another topic. Liming, do you have any comments on this one?
Thanks,
Dandan
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, May 6, 2019 10:55 AM
>
https://bugzilla.tianocore.org/show_bug.cgi?id=1753
Add pop-up warning messages before secure erase action.
In order to notify user the secure erase action will take a longer time.
This change also fix some pop-up windows are unable to show up
complete message due to some strings are too long.
Hi Rebecca,
This content does not look OVMF specific.
Does it depend on QEMU? Or would this
Potentially work on any target that supports
gdb?
How about adding to SourceLevelDebugPkg as
an another method to load symbols? Not sure
why the extra module is required. The Debug
Image Info Table
Reviewed-by: Eric Dong
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, April 29, 2019 10:16 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Dong, Eric
> Subject: [patch 06/11] MdeModulePkg/Setup: Remove
> PcdFrameworkCompatibilitySupport usage
>
> REF:
Reviewed-by: jiewen@intel.com
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Dandan Bi
> > Sent: Monday, April 29, 2019 10:16 AM
> > To: devel@edk2.groups.io
> > Cc: Yao, Jiewen ; Chao
> > Subject: [edk2-devel] [patch 08/11]
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dandan Bi
>Sent: Monday, April 29, 2019 10:16 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [edk2-devel] [patch 01/11] BaseTools/VfrCompile: Remove
90 matches
Mail list logo
