[edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

2019-06-18 Thread Dong, Eric
Add MM Mp Protocol in PiSmmCpuDxeSmm driver. Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Eric Dong --- UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c | 375 +++ UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h | 283 +++ UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c| 468

[edk2-devel] [Patch 1/2] MdePkg: Add new MM MP Protocol definition.

2019-06-18 Thread Dong, Eric
EFI MM MP Protocol is defined in the PI 1.7 specification. The MM MP protocol provides a set of functions to allow execution of procedures on processors that have entered MM. This protocol has the following properties: 1. The caller can invoke execution of a procedure on a processor, other than

Re: [edk2-devel] [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-18 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, June 19, 2019 11:10 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: [PATCH V4 1/2]

[edk2-devel] [PATCH V4 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-18 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Use the PcdPlatformRecoverySupport to control the function of platform recovery in BDS. First, set the variable's ("OsIndicationsSupported") EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit base on the pcd. It would affect the variable

[edk2-devel] [PATCH V4 0/2] Use a pcd to control Platform Recovery behavior

2019-06-18 Thread Gao, Zhichao
V1: Add a pcd PcdPlatformRecoverySupport to control the variable PlatformRecovery and the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit of variable "OsIndicationsSupported". V2: While PcdPlatformRecoverySupport is FALSE, do not set a PlatformRecovery Variable. But remain boot from a

[edk2-devel] [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-18 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Add a pcd PcdPlatformRecoverySupport to conditionally set an OS indications bit and set the 'PlatformRecovery' variable. This pcd would also control whether the BDS support platform recovery or not. Update the uni

Re: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

2019-06-18 Thread Wu, Hao A
From: Zhang, Chao B Sent: Wednesday, June 19, 2019 9:13 AM To: Wu, Hao A; devel@edk2.groups.io; Xu, Wei6 Cc: Wang, Jian J Subject: RE: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature. Hi Hao: OK that is a good point. We will follow up to clean

[edk2-devel] [PATCH 3/3] SecurityPkg: add FvReportPei.inf in dsc for build validation

2019-06-18 Thread Wang, Jian J
https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang Cc: Jiewen Yao Signed-off-by: Jian J Wang --- SecurityPkg/SecurityPkg.dsc | 5 + 1 file changed, 5 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index a2ee0528f0..4451bd1271 100644

[edk2-devel] [PATCH v3 1/3] SecurityPkg: add definitions for OBB verification

2019-06-18 Thread Wang, Jian J
> v3: update per Jiewen's comments > - remove HASHED_FV_MAX_NUMBER > - update _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI to > be more flexible > - update HASHED_FV_INFO to use UINT64 for Base and Length https://bugzilla.tianocore.org/show_bug.cgi?id=1617

[edk2-devel] [PATCH v3 0/3] Common OBB verification feature

2019-06-18 Thread Wang, Jian J
>V3: update per Jiewen's comments >V2: fix parameter description error found by ECC https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang Cc: Jiewen Yao Cc: "Hernandez Beltran, Jorge" Cc: Harry Han Jian J Wang (3): SecurityPkg: add definitions for OBB verification

[edk2-devel] [PATCH v3 2/3] SecurityPkg/FvReportPei: implement a common FV verifier and reporter

2019-06-18 Thread Wang, Jian J
>v3: > - shrink mHashAlgInfo and add FindHashAlgInfo() to find matched algorithm > - add ASSERT for illegal use cases > - add DEBUG print for skipped FV > - update code to use new definition of HASHED_FV_INFO and >_EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI > - some small code

Re: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

2019-06-18 Thread Zhang, Chao B
Hi Hao: OK that is a good point. We will follow up to clean this. Tks From: Wu, Hao A Sent: Wednesday, June 19, 2019 9:00 AM To: Zhang, Chao B ; devel@edk2.groups.io; Xu, Wei6 Cc: Wang, Jian J Subject: RE: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control

Re: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

2019-06-18 Thread Wu, Hao A
From: Zhang, Chao B Sent: Wednesday, June 19, 2019 8:42 AM To: Wu, Hao A; devel@edk2.groups.io; Xu, Wei6 Cc: Wang, Jian J Subject: RE: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature. Hi Hao: I think blocking UpdateCapsule interface is enough

Re: [edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

2019-06-18 Thread Zhang, Chao B
Hi Hao: I think blocking UpdateCapsule interface is enough for Capsule in RAM. QueryCapsuleCapabilities can still be used to test capsules before delivering by different sources. From: Wu, Hao A Sent: Wednesday, June 12, 2019 3:49 PM To: devel@edk2.groups.io; Xu, Wei6 Cc: Wang, Jian J ;

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread rebecca
On 2019-06-18 11:53, rebe...@bluestop.org wrote: > On 2019-06-18 02:52, Lu, XiaoyuX wrote: >> I test this in my own environment, It works well. >> The edk2 commit id : f03859ea6c8fddeaa3a5cc3d9a3461 >> Build command: >> build -p ~/code/edk2/OvmfPkg/OvmfPkgX64.dsc -a X64 -t

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-18 Thread rebecca
On 2019-06-18 07:26, Liming Gao wrote: > Rebecca: > Thanks for your report. Now, pylama is not the requirement for BaseTools > python script. Patch contributor can base on the report to fix the critical > issue. I know it's not a required tool, but many of these are common Python style

[edk2-devel] [PATCH] MdeModulePkg:Platform exception when callback function was destroyed by unconnected controller in setup browser

2019-06-18 Thread GregX Yeh
https://bugzilla.tianocore.org/show_bug.cgi?id=1920 Check ConfigAccess available before call callback function. Signed-off-by: GregX Yeh Cc: Dandan Bi Cc: Ray Ni Cc: Ted Kuo --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 17 + 1 file changed, 17 insertions(+)

Re: [edk2-devel] [edk2-platforms PATCH v2 1/1] Platform/ARM: Juno: Add support for PPTT dynamic generation

2019-06-18 Thread Leif Lindholm
On Tue, Jun 18, 2019 at 10:24:53AM +0100, Krzysztof Koch wrote: > Update the Platform Respository for the Juno platform > to include support for generation of the Processor Properties > Topology Table (PPTT) using the Dynamic Tables Framework. > > The Platform Repository now also describes the

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread rebecca
On 2019-06-18 02:52, Lu, XiaoyuX wrote: > I test this in my own environment, It works well. > The edk2 commit id : f03859ea6c8fddeaa3a5cc3d9a3461 > Build command: > build -p ~/code/edk2/OvmfPkg/OvmfPkgX64.dsc -a X64 -t GCC5 -D > NETWORK_TLS_ENABLE -D

[edk2-devel] [PATCH v2 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-18 Thread Albecki, Mateusz
From: "Albecki, Mateusz" https://bugzilla.tianocore.org/show_bug.cgi?id=1882 Implement support for GetOperatingParamters notify phase in SdMmcHcDxe driver. GetOperatingParameters notify phase is signaled before we start card detection and initialization. Code has been updated for both eMMC and

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase

2019-06-18 Thread Albecki, Mateusz
https://bugzilla.tianocore.org/show_bug.cgi?id=1882 The new notify phase allows platform to configure additional bus paramters in addition to parameters that can already be configured with capability override. Specifically we allow to configure bus width, clock frequency and driver strength. If

[edk2-devel] [PATCH v2 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol

2019-06-18 Thread Albecki, Mateusz
To allow platform greater control over the bus settings for SD card and eMMC card we have added a new notify phase to SdMmcOverrideProtocol called GetOperatingParam. This phase is signaled before SD card/eMMC initialization and allows platform to tweak the values in new structure called

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-18 Thread Albecki, Mateusz
Response inline to the bus width switch before SWITCH command in UHS-I mode. As I mentioned in forked message mapping SD driver strength to eMMC driver strength seems like a bad idea right now as I don't know of any eMMC host controller that would actually follow this map and would require any

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 06/19/2019 8:00am-9:00am #cal-reminder

2019-06-18 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 19 June 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=488584 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-06-18 Thread Liming Gao
Hi, all Besides those packages, I would like to introduce Tools directory to include some tools for the platform integration. Now, those tools are used and verified by Intel platform. So, I suggest to add them into Edk2Platforms Platform\Intel and Silicon\Intel first. When other platform uses

Re: [edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-18 Thread Liming Gao
Bob: I think these two C tools are only verified for IA32 and X64 arch OS. They may not work on ARM or AARCH64 OS. Once they are added into BaseTools C Makefile, they may cause compile failure on ARM or AARCH64 OS. So, I suggest to move them into edk2-platforms/Platform/Intel/Tools directory

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-18 Thread Liming Gao
Zhiju: For this tool, I see BiosLib is added into edk2-platforms/Platform/Intel/BoardModulePkg. I would suggest to add GenBiosId into edk2-platforms/Platform/Intel/Tools directory. Can you help update this tool as one standalone script? Thanks Liming > -Original Message- > From:

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-18 Thread Liming Gao
Rebecca: Thanks for your report. Now, pylama is not the requirement for BaseTools python script. Patch contributor can base on the report to fix the critical issue. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-18 Thread Liming Gao
Mike: I agree this suggestion. How about introduce -ot option for text file to include this string? Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Tuesday, June 18, 2019 1:18 AM > To: Fan, ZhijuX ; devel@edk2.groups.io; Kinney, Michael > D > Cc: Gao, Liming ;

Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Produce NVM Express PassThru PPI

2019-06-18 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Maggie Chu > Sent: Monday, June 17, 2019 10:11 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Wang, Jian J; Ni, Ray; Zeng, Star > Subject: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Produce

Re: [edk2-devel] [PATCH] MdeModulePkg: Add definitions for NVM Express Passthru PPI

2019-06-18 Thread Wu, Hao A
> -Original Message- > From: Chu, Maggie > Sent: Monday, June 17, 2019 10:11 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A; Wang, Jian J; Ni, Ray; Zeng, Star > Subject: [PATCH] MdeModulePkg: Add definitions for NVM Express Passthru > PPI > >

Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

2019-06-18 Thread Leif Lindholm
Hi Ray, This brings us to the core of the topic. This format permits (like it's used for Linux and QEMU) maintainership to be assigned based on logical function unrestricted by directory structure. See

[edk2-devel] [edk2-platforms PATCH v2 1/1] Platform/ARM: Juno: Add support for PPTT dynamic generation

2019-06-18 Thread Krzysztof Koch
Update the Platform Respository for the Juno platform to include support for generation of the Processor Properties Topology Table (PPTT) using the Dynamic Tables Framework. The Platform Repository now also describes the cache and processor topology in Juno (all revisions). Signed-off-by:

Re: [edk2-devel] [PATCH 2/2] LegacyBbs: add boot entries for virtio-blk devices

2019-06-18 Thread David Woodhouse
On Fri, 2013-01-25 at 22:04 +0100, Laszlo Ersek wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Laszlo Ersek Hm. This no longer works as-is because... > --- > .../Csm/LegacyBiosDxe/LegacyBbs.c | 134 > +++- > 1 files

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-18 Thread Xiaoyu Lu
Hi bcran, I test this in my own environment, It works well. The edk2 commit id : f03859ea6c8fddeaa3a5cc3d9a3461 Build command: build -p ~/code/edk2/OvmfPkg/OvmfPkgX64.dsc -a X64 -t GCC5 -D NETWORK_TLS_ENABLE -D NETWORK_HTTP_BOOT_ENABLE DHCP server:

[edk2-devel] [PATCH] BaseTools:Remove unused Edk2\BuildNotes2.txt

2019-06-18 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1889 Edk2\BuildNotes2.txt is not maintained any more. User can find the related info in wiki. So, this file can be removed. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan --- BuildNotes2.txt | 154