[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1946 The patch changes SMM environment to use 5 level paging when CPU supports it. Signed-off-by: Ray Ni Cc: Eric Dong Regression-tested-by: Laszlo Ersek --- .../PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c | 20 +- UefiCpuPkg/PiSmmCpuDxeSmm/Sm

[edk2-devel] [PATCH v2 2/3] MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging

5-level paging is documented in white paper: https://software.intel.com/sites/default/files/managed/2b/80/5-level_paging_white_paper.pdf Commit f8113e25001e715390127f23e2197252cbd6d1a2 changed Cpuid.h already. This patch updates IA32_CR4 structure to include LA57 field. Signed-off-by: Ray Ni Cc

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/PiSmmCpu: Change variable names and comments to follow SDM

Per SDM, for IA-32e 4-KByte paging, there are four layers in the page table structure: 1. PML4 2. Page-Directory-Pointer Table (PDPT) 3. Page-Directory (PD) 4. Page Table (PT) The patch changes the local variable names and comments to use "PML4", "PDPT", "PD", "PT" to better align to terms used in

[edk2-devel] [PATCH v2 0/3] Enable 5 level paging in SMM mode

v2: Added Laszlo's Regression-tested-by. Updated patch #3 to use PatchInstructionX86 to avoid using DBs in NASM. Ray Ni (3): UefiCpuPkg/PiSmmCpu: Change variable names and comments to follow SDM MdePkg/BaseLib.h: Update IA32_CR4 structure for 5-level paging UefiCpuPkg/PiSmmCpu: Enable 5

Re: [edk2-devel] [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg

Thanks all, The series has been pushed via commits 4286eb22f4..896db3a4ce. Best Regards, Hao Wu > -Original Message- > From: Ni, Ray > Sent: Wednesday, July 03, 2019 1:21 PM > To: Wu, Hao A; devel@edk2.groups.io; 'r...@edk2.groups.io' > Cc: Gao, Liming; Andrew Fish; Laszlo Ersek; Leif L

Re: [edk2-devel] [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg

Reviewed-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Tuesday, July 2, 2019 10:33 AM > To: devel@edk2.groups.io; 'r...@edk2.groups.io' > Cc: Gao, Liming ; Ni, Ray ; > Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > > Subject: RE: [RFC][PATCH v1 0/3] Remo

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

On Tue, Jul 02, 2019 at 09:11:06PM +, Kinney, Michael D wrote: > Hi Gary, > Hi Mike, > I have posted an update to your patches the removes the setting of WORKSPACE > and accesses all files relative to WORKSPACE in the Linux shell scripts. > It also fixes null pointer bugs in the SmbiosMiscD

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

It looks great. Thanks! > -Original Message- > From: Dong, Eric > Sent: Wednesday, July 3, 2019 10:58 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: RE: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol > > Hi Jiewen, > > I did below tests: > 1.

Re: [edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

Hi Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 2, 2019 10:16 PM > To: devel@edk2.groups.io; Dong, Eric > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: > Enable MM MP Protocol. > > Hi Eric, > > I

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

Hi Jiewen, I did below tests: 1. Use MpGetNumberOfProcessors and MpSetStartupProcedure. 2. Test MpDispatchProcedure 1.sync mode and async mode, 2. with and without CpuStatus. 3. In async mode, use long delay get the final result with MpWaitForProcedure 4. In async

Re: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest algorithm

Hi Imran, Usually we send the whole series of patches even only one of them is updated. It's hard to find old ones. I'm not going to ask you to re-send whole patch series this time. But please follow the convention for any future patches. For this patch series, Reviewed-by: Jian J Wang > ---

Re: [edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

HI Eric Would you please share what unit test you have done for this new feature? > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dong, Eric > Sent: Wednesday, July 3, 2019 10:43 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > S

[edk2-devel] [Patch v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

v3 changes: 1. Fix Token clean up too early caused CheckProcedure return error. v2 changes: 1. Remove some duplicated global variables. 2. Enhance token design to support multiple task trig for different APs at the same time. V1 changes: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1937

[edk2-devel] [Patch v3 0/2] Enable new MM MP protocol

v3 changes: 1. Fix Token clean up too early caused CheckProcedure return error. https://bugzilla.tianocore.org/show_bug.cgi?id=1937 PI spec added a new protocol named MM MP protocol. This protocol allows for better remote queuing of execution of procedures on an AP. This extends the existing pro

[edk2-devel] [Patch v3 1/2] MdePkg: Add new MM MP Protocol definition.

V2 change: 1. Remove SMM prefix definition which not required by spec. V1 changes: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1937 EFI MM MP Protocol is defined in the PI 1.5 specification. The MM MP protocol provides a set of functions to allow execution of procedures on processors tha

Re: [edk2-devel] May I become a contributor in EmulatorPkg ?

Hi, You are right, please don’t download win32 bin file to use since it’s not update any longer. Please run BaseTools Python from source in Windows OS. Here is wiki: https://github.com/tianocore/tianocore.github.io/wiki/Windows-systems#compile-tools Thanks, Bob From: 戴，曉政 [mailto:cloud0...@yaho

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP Python scripts to support 3.x.

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Sunday, June 30, 2019 11:20 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [edk2-devel] [PATCH v2] IntelFsp2Pkg: FSP Python scripts to sup

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

Hi Gary, I have posted an update to your patches the removes the setting of WORKSPACE and accesses all files relative to WORKSPACE in the Linux shell scripts. It also fixes null pointer bugs in the SmbiosMiscDxe module. https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_Smbios

[edk2-devel] 回覆: May I become a contributor in EmulatorPkg ?

Dear Bob, First, please forgive me to bother you if you are very busy . For my first issue, I don’t do any extra action for building EmulatorPkg so I just provide edksetup.bat that is modified by me to you. Could you try to build EmulatorPkg again for me? If you feel my letter is impolite plea

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

Hi Gary, Thanks for the branch. I have the build working and have reproduced the SMBIOS issue and am debugging that now. Mike > -Original Message- > From: Gary Lin [mailto:g...@suse.com] > Sent: Tuesday, July 2, 2019 2:48 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Qian, Y

[edk2-devel] [PATCH v2 7/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/BootModePei/BootModePei.c         |  2 +- .../FirmwareVolumePei/FirmwareVolumePei.c     |  2 +- EmulatorPkg/Unix/Host/Host.c                  | 20 +-- Emu

[edk2-devel] [PATCH v2 6/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Unix/GdbRun.sh                   |  4 ++-- EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c |  2 +- EmulatorPkg/Unix/Host/BlockIo.c              | 12 ++-- EmulatorPkg

[edk2-devel] [PATCH v2 5/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Sec/Ia32/SwitchRam.S   | 18 +- EmulatorPkg/Sec/Ia32/SwitchRam.asm | 20 ++-- EmulatorPkg/Sec/Sec.c              |  5 ++--- EmulatorPkg/Sec/

[edk2-devel] [PATCH v2 2/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- .../EmuSimpleFileSystemDxe/EmuSimpleFileSystem.c       |  2 +- EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c     | 10 +- EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c     

[edk2-devel] [PATCH v2 3/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Include/Library/EmuThunkLib.h        |  2 +- EmulatorPkg/Include/Library/SmbiosLib.h          | 12 ++-- EmulatorPkg/Include/Protocol/EmuBlockIo.h        |  6 +++-

[edk2-devel] [PATCH v2 4/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/Library/DxeEmuLib/DxeEmuLib.c                 | 2 +- .../DxeEmuPeCoffExtraActionLib.c                          | 2 +- .../DxeEmuPeCoffExtraActionLib.inf                 

[edk2-devel] [PATCH v2 1/7] EmulatorPkg: Fix various typos

Fix various typos in EmulatorPkg. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Coeur --- EmulatorPkg/CpuRuntimeDxe/MpService.c  | 11 +-- EmulatorPkg/EmuBlockIoDxe/EmuBlockIo.c | 14 +++--- EmulatorPkg/EmuGopDxe/GopDriver.c      |  4 ++-- EmulatorPkg/EmuGop

[edk2-devel] [PATCH v2 0/7] EmulatorPkg: Fix various typos

Each commit can be reviewed/merged independently. Each commit is roughly 20 lines modified. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43174): https://edk2.groups.io/g/devel/message/43174 Mute This Topic: https://groups.io/mt/3228818

[edk2-devel] [edk2-platforms: PATCH 2/2] Platform/Rpi3: Add custom CPU frequency support

Allow users to set a custom CPU frequency [100 - 1600 MHz] in 'Device Manager' -> 'Raspberry Pi Configuration'. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.c | 13 +++- Platform/RaspberryPi/RPi3/Drivers/ConfigDxe/ConfigDxe.inf |

[edk2-devel] [edk2-platforms: PATCH 0/2] Platform/RPi3 improve boot order and add custom freqs

The following 2 patches update the Raspberry Pi 3 platform to: - Remove UEFI Shell as default boot target, to instead default to SD then USB, which is the what most users of the UEFI firmware are likely to expect. - Add the ability to set a custom CPU frequency [100 - 1600 MHz] instead of only

[edk2-devel] [edk2-platforms: PATCH 1/2] Platform/RPi3: Set the boot option of UEFI Shell as non-active

This makes boot from SD/USB the default, which is what most users should expect. Pressing F1 at boot still boots to UEFI Shell. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- Platform/RaspberryPi/RPi3/Readme.md

Re: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest algorithm

Reviewed-by: jiewen@intel.com > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Imran Desai > Sent: Tuesday, July 2, 2019 9:31 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest > algor

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

On 07/02/19 17:18, Laszlo Ersek wrote: > On 07/02/19 16:44, Ni, Ray wrote: >> Laszlo, >> I agree with your changes. >> Will include your changes in V2. > > Thanks, Ray -- currently waiting for suitable hardware (with 5-level > paging support) to become available internally @RH for my testing. > >

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

On 07/02/19 16:44, Ni, Ray wrote: > Laszlo, > I agree with your changes. > Will include your changes in V2. Thanks, Ray -- currently waiting for suitable hardware (with 5-level paging support) to become available internally @RH for my testing. On host hardware that does not support 5-level paging

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 07/03/2019 8:00am-9:00am #cal-reminder

*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 3 July 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=489078 ) *Organizer:* Stephano Cetola stephano.cet...@linux.int

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

Laszlo, I agree with your changes. Will include your changes in V2. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Monday, July 1, 2019 8:45 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/Pi

Re: [edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

Hi Eric, I cannot apply this patch for testing, because it is corrupt. Git complains about it (and it's justified): On 07/02/19 09:37, Dong, Eric wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1937 > > v2 changes: > 1. Remove some duplicated global variables. > 2. Enhance token design t

[edk2-devel] [PATCH v4 2/5] SecurityPkg: introduce the SM3 digest algorithm

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 v4: Fixed truncated email addresses EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b in

Re: [edk2-devel] [PATCH] Platform/Intel:Change the way of getting the env file content

Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, July 2, 2019 9:02 AM > To: devel@edk2.groups.io > Cc: Fan, ZhijuX ; Gao, Liming ; > Feng, Bob C ; Ard Biesheuvel > ; Leif Lindholm ; > Kinney, Michael D > Subject: [PATCH] Platform/Intel:Change the wa

[edk2-devel] [PATCH 1/3] MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub impl

Rewrite Base64Decode() from scratch, due to reasons listed in the second reference below. As first step, redo the interface contract, and replace the current implementation with a stub that asserts FALSE, then fails. Cc: Liming Gao Cc: Marvin Häuser Cc: Michael D Kinney Cc: Philippe Mathieu-Da

[edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

Rewrite Base64Decode() from scratch, due to reasons listed in the second reference below. Implement Base64Decode() according to the specification added in the previous patch. The decoder scans the input buffer once, it has no inner loop(s), and it spills each output byte as soon as the output byte

[edk2-devel] [PATCH 3/3] OvmfPkg/EnrollDefaultKeys: clean up Base64Decode() retval handling

Base64Decode() now guarantees that DestinationSize is larger on output than it was on input if RETURN_BUFFER_TOO_SMALL is returned. Clean up the retval handling for the first Base64Decode() call in EnrollDefaultKeys, which used to work around the ambiguity in the previous Base64Decode() interface c

[edk2-devel] [PATCH 0/3] MdePkg, OvmfPkg: rewrite Base64Decode(), clean up call site

Repo: https://github.com/lersek/edk2.git Branch: base64_decode_bz1891 Base64Decode() has a number of issues; see - - and the mailing list discussion linked from . In my opinion, rew

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

On Mon, Jul 01, 2019 at 11:07:11PM +, Michael D Kinney wrote: > Hi Gary, > > I recommend you rebase on top of this series. > > I have verified Linux boots and I have been working > on the GCC and Linux build scripts as well. > > Please let me know if you see any issues with this > series

Re: [edk2-devel] [PATCH v1 0/4] Fix a number of small issues in acpiview

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 28 June 2019 11:25 AM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 0/4] Fix a number of small issues in acpiv

Re: [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 28 June 2019 09:57 AM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 0/5] Clean up acpiview input parameters T

[edk2-devel] [Patch v2 0/2] Enable new MM MP protocol

https://bugzilla.tianocore.org/show_bug.cgi?id=1937 PI spec added a new protocol named MM MP protocol. This protocol allows for better remote queuing of execution of procedures on an AP. This extends the existing procedures to allow: 1. A function to be called in blocking and non-blocking manner

[edk2-devel] [Patch v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

https://bugzilla.tianocore.org/show_bug.cgi?id=1937 v2 changes: 1. Remove some duplicated global variables. 2. Enhance token design to support multiple task trig for different APs at the same time. V1 changes: Add MM Mp Protocol in PiSmmCpuDxeSmm driver. Cc: Ray Ni Cc: Laszlo Ersek Signed-off-

[edk2-devel] [Patch v2 1/2] MdePkg: Add new MM MP Protocol definition.

https://bugzilla.tianocore.org/show_bug.cgi?id=1937 V2 change: 1. Remove SMM prefix definition which not required by spec. V1 changes: EFI MM MP Protocol is defined in the PI 1.5 specification. The MM MP protocol provides a set of functions to allow execution of procedures on processors that hav

[edk2-devel] [PATCH] UefiCpuPkg/RegisterCpuFeaturesLib: Delete CPU_FEATURE_[BEFORE|AFTER]

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1366 Commit b3c71b472dff2c02f0cc38d7a1959cfb2ba8420d supported MSR setting in different scopes. It added below macro: CPU_FEATURE_THREAD_BEFORE CPU_FEATURE_THREAD_AFTER CPU_FEATURE_CORE_BEFORE CPU_FEATURE_CORE_AFTER CPU_FEATURE_PACKAGE_BEFOR