Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI encodings to PCI Plat protocol

2019-07-05 Thread Laszlo Ersek
On 07/05/19 07:23, Javeed, Ashraf wrote: > Hi, > Please note that these 2 tags are automatically added when the mail is sent > with the formatted patch of the commit > [edk2-devel] [PATCH] (1) The [edk2-devel] prefix is prepended by groups.io (i.e. by the mailing list software) when it

Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it work on both

Re: [edk2-devel] [PATCH v3 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > ACPI Timer does not work in a PVH guest, but local APIC works on both > PVH and HVM. > > Note that the use of SecPeiDxeTimerLibCpu might be an issue with a > driver of type DXE_RUNTIME_DRIVER. I've attemptde to find out which of > the DXE_RUNTIME_DRIVER

Re: [edk2-devel] [PATCH v3 08/35] OvmfPkg/XenResetVector: Allow jumpstart from either hvmloader or PVH

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > This patch allows the ResetVector to be run indenpendently from build > time addresses. > > The goal of the patch is to avoid having to create RAM just below 4G > when creating a Xen PVH guest while being compatible with the way > hvmloader currently

Re: [edk2-devel] [PATCH v3 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-05 Thread Andrew Cooper
On 04/07/2019 15:42, Anthony PERARD wrote: > Add a new entry point for Xen PVH that enter directly in 32bits. > > Information on the expected state of the machine when this entry point > is used can be found at: > https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > > Ref:

[edk2-devel] [PATCH 3/3] BaseTools/FMMT: Change FCE script type in PosixLike

2019-07-05 Thread Zhang, Shenglei
Change the script type from PC to UNIX. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/BinWrappers/PosixLike/FCE | 58 ++--- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/BaseTools/BinWrappers/PosixLike/FCE

[edk2-devel] [PATCH 1/3] BaseTools/FMMT: Change FMMT script type in PosixLike

2019-07-05 Thread Zhang, Shenglei
Change the script type from PC to UNIX. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/BinWrappers/PosixLike/FMMT | 58 ++-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/BaseTools/BinWrappers/PosixLike/FMMT

[edk2-devel] [PATCH 2/3] BaseTools/FMMT: Change BfmLib script type in PosixLike

2019-07-05 Thread Zhang, Shenglei
Change the script type from PC to UNIX. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- BaseTools/BinWrappers/PosixLike/BfmLib | 58 +- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/BaseTools/BinWrappers/PosixLike/BfmLib

[edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike

2019-07-05 Thread Zhang, Shenglei
The existing scripts are PC type, which cause the tools can't be used conveniently like "FMMT -h" in all directories. So change them to UNIX type to fix this problem. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang Shenglei Zhang (3): BaseTools/FMMT: Change FMMT script type in

Re: [edk2-devel] [PATCH v3 07/35] OvmfPkg/XenResetVector: Saving start of day pointer for PVH guests

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > As described in the Xen PVH documentation [1], "ebx: contains the > physical memory address where the loader has placed the boot start info > structure". To have this pointer saved to be able to use it later in the > PEI phase, we allocate some space in

[edk2-devel] [PATCH] FmpDevicePkg: Fix various typos

2019-07-05 Thread Cœur
Fix one typo in FmpDevicePkg. --- FmpDevicePkg/FmpDxe/DetectTestKey.c | 2 +- FmpDevicePkg/Include/Library/FmpDeviceLib.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/FmpDevicePkg/FmpDxe/DetectTestKey.c b/FmpDevicePkg/FmpDxe/DetectTestKey.c index

[edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos

2019-07-05 Thread Cœur
Fix various typos in IntelFsp2Pkg. --- .../FspSecCore/Ia32/FspApiEntryM.nasm | 4 +-- .../FspSecCore/Ia32/InitializeFpu.nasm| 2 +- .../FspSecCore/Ia32/SaveRestoreSseNasm.inc| 2 +- IntelFsp2Pkg/FspSecCore/Ia32/Stack.nasm | 2 +- IntelFsp2Pkg/FspSecCore/SecFsp.c

[edk2-devel] [Patch] BaseTools FCE: Update GNUmakefile to BSD + Patent License

2019-07-05 Thread Liming Gao
And, also update GNUmakefile to remove unnecessary ARCH detection Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Source/C/FCE/GNUmakefile | 40 ++ 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/BaseTools/Source/C/FCE/GNUmakefile

Re: [edk2-devel] [PATCH v3 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > Add a new entry point for Xen PVH that enter directly in 32bits. > > Information on the expected state of the machine when this entry point > is used can be found at: > https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > > Ref:

[edk2-devel] [Patch v2] BaseTools: Fix GCC compiler failure in new added tools.

2019-07-05 Thread Liming Gao
From: gaozhic GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. Signed-off-by: Liming Gao Cc: Bob Feng --- In V2, continue to fix strncat failure in gcc version 8. BaseTools/Source/C/BfmLib/BfmLib.c | 117 +++--

Re: [edk2-devel] [PATCH v3 05/35] OvmfPkg/OvmfXen: Creating an ELF header

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > This patch changes the flash device image of OvmfXen to make it look > like it's an ELF. For this, we replace the empty embedded variable store > by a binary array, which is a ELF file header. > > The ELF header explain to a loader to load the binary at

Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

2019-07-05 Thread Leif Lindholm
On Fri, Jul 05, 2019 at 01:41:54PM +, Gao, Liming wrote: > Thanks for your catch. Yes. This is an issue. I will send the patch to clean > it. > > For this patch, the change is good. Reviewed-by: Liming Gao > Thanks! Pushed as d031fc07eb83. / Leif > From: devel@edk2.groups.io

Re: [edk2-devel] [PATCH v3 04/35] OvmfPkg: Introduce XenPlatformPei

2019-07-05 Thread Laszlo Ersek
Hi Anthony, On 07/04/19 16:42, Anthony PERARD wrote: > Introduce XenPlatformPei, a copy of OvmfPkg/PlatformPei without some > of QEMU specific initialization, Xen does not support QemuFwCfg. > > This new module will be adjusted to accommodate Xen PVH. > > fw_cfg dependents that have been

Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

2019-07-05 Thread Liming Gao
Thanks for your catch. Yes. This is an issue. I will send the patch to clean it. For this patch, the change is good. Reviewed-by: Liming Gao From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Hiber He Sent: Friday, July 5, 2019 7:26 PM To: devel ; leif.lindholm Subject: Re:

[edk2-devel] [PATCH] SignedCapsulePkg: Fix various typos

2019-07-05 Thread Cœur
Fix various typos in SignedCapsulePkg. --- .../Include/Guid/EdkiiSystemFmpCapsule.h | 4 +-- .../Include/Library/IniParsingLib.h | 14 +- .../Library/IniParsingLib/IniParsingLib.c | 26 +-- SignedCapsulePkg/SignedCapsulePkg.dec | 4 +--

[edk2-devel] [PATCH] PcAtChipsetPkg: Fix various typos

2019-07-05 Thread Cœur
Fix various typos in PcAtChipsetPkg. --- PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c| 4 ++-- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf | 2 +- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.uni | 2 +- PcAtChipsetPkg/Include/Library/IoApicLib.h | 2 +-

Re: [edk2-devel] [PATCH v3 02/35] OvmfPkg: Create platform OvmfXen

2019-07-05 Thread Laszlo Ersek
On 07/04/19 16:42, Anthony PERARD wrote: > OvmfXen is a copy of OvmfX64, removing VirtIO and some SMM. > > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. > > Compare to OvmfX64, this patch: > > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY,

Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos

2019-07-05 Thread Cœur
I didn't kept that specific patch. Anyway, if Pccts is dead, let's forget about that one. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43352): https://edk2.groups.io/g/devel/message/43352 Mute This Topic:

Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-05 Thread Laszlo Ersek
Hi Anthony, On 07/04/19 16:41, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v3 > > Hi, > > I've started to create a Xen specific platform, in OvmfPkg/XenOvmf.dsc > with the goal to make it

Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

2019-07-05 Thread Hiber He
Hi, I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted. I deleted the ARCH related lines and it did built. Best Regards, Hiber On 07/05/2019 18:34, Leif Lindholm wrote: Commit 3c59d94637ad

Re: [edk2-devel] [PATCH] [MdePkg/Protocols]: New interface, EFI encodings to PCI Plat protocol

2019-07-05 Thread Javeed, Ashraf
Please let me know if this is good enough? Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Friday, July 5, 2019 4:02 PM > To: Javeed, Ashraf ; Gao, Liming > ; devel@edk2.groups.io; ler...@redhat.com > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH]

[edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed

2019-07-05 Thread Leif Lindholm
Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool that is always built. Pre-existing tools locate the makefile includes with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency on having sourced edksetup.sh before building BaseTools. Change FCE GNUmakefile to

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Chen, Farrah
Thanks! With this patch, new error occurred in my environment: .. make -C FMMT make[2]: Entering directory '/home/build/fan/edk2/BaseTools/Source/C/FMMT' gcc -c -I .. -I ../Include/Common -I ../Include/ -I ../Include/IndustryStandard -I ../Common/ -I .. -I . -I ../Include/X64/ -MD

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Gary Lin
On Fri, Jul 05, 2019 at 07:33:17AM +, Gary Lin wrote: > On Fri, Jul 05, 2019 at 07:25:18AM +, Liming Gao wrote: > > Can you let me know your GCC compiler version? > > > I also encountered the error. My system is openSUSE Tumbleweed, and the > gcc version is 9.1.1. > > It seems the

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Liming Gao
I just send the patch to fix this issue. Can you help verify it? From: Chen, Farrah Sent: Friday, July 05, 2019 3:35 PM To: Gao, Liming ; devel@edk2.groups.io Cc: Hao, Xudong ; Wei, Danmei Subject: RE: Make edk2 fail on Red Hat 8.0 I am using the default GCC of RHEL8.0: [root@localhost edk2]$

[edk2-devel] [Patch] BaseTools: Fix GCC compiler failure in new added tools.

2019-07-05 Thread Liming Gao
From: gaozhic GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Source/C/BfmLib/BfmLib.c | 2 +- BaseTools/Source/C/FCE/BinaryParse.c | 2 +- BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2

[edk2-devel] [edk2-InfSpecification PATCH v2] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-05 Thread Xiaoyu Lu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 Background: Host-based Firmware Analyzer (HBFA) is a opensouce tools enables advanced testing of UEFI and UEFI PI drivers in developer's OS environment. It will generate OS application which can run directly in OS environment. But there is

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Chen, Farrah
I am using the default GCC of RHEL8.0: [root@localhost edk2]$ gcc -v Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-redhat-linux/8/lto-wrapper OFFLOAD_TARGET_NAMES=nvptx-none OFFLOAD_TARGET_DEFAULT=1 Target: x86_64-redhat-linux Configured with: ../configure

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Gary Lin
On Fri, Jul 05, 2019 at 07:25:18AM +, Liming Gao wrote: > Can you let me know your GCC compiler version? > I also encountered the error. My system is openSUSE Tumbleweed, and the gcc version is 9.1.1. It seems the new gcc is restricter on memset and strncat. Gary Lin > From:

Re: [edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Liming Gao
Can you let me know your GCC compiler version? From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chen, Farrah Sent: Friday, July 05, 2019 3:10 PM To: devel@edk2.groups.io Cc: Hao, Xudong ; Wei, Danmei Subject: [edk2-devel] Make edk2 fail on Red Hat 8.0 Hi, I tried to make

[edk2-devel] Make edk2 fail on Red Hat 8.0

2019-07-05 Thread Chen, Farrah
Hi, I tried to make ovmf with the latest commit: 0a487ef96bd6d2e0ac23323adab86f9949068ed6 on Red Hat 8.0, it failed, while it succeed on Red Hat 7.6. With commit 4b04d9d73604080a42daf737c39b98d4e1245a51 I used several days ago, it works well on both RHEL8.0 and RHEL7.6. Steps: git clone