[edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

Hi BaseTools experts, We saw the clean build performance improvement after updating from edk2-stable201905 to edk2-stable201908, which is promising. But we found the incremental build time increase 25%~35%, which is not good. We're building server platform. And we use --hash to speed up incremen

Re: [edk2-devel] [Patch V3] UefiCpuPkg/CpuExceptionHandlerLib: Fix split lock

Reviewed-by: Eric Dong And pushed: SHA-1: f4c898f2b2db2819c519cdce05403d4ba0234979 Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of John > E Lofgren > Sent: Wednesday, September 18, 2019 11:43 PM > To: devel@edk2.groups.io > Sub

Re: [edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

I just push @d7bf973e43ad949706f936f61cd6be8e63ce136f > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Friday, September 20, 2019 2:11 PM > To: Ni, Ray ; Carsey, Jaben ; > devel@edk2.groups.io > Cc: Kinney, Michael D ; An

Re: [edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace

On 09/19/19 20:06, Leif Lindholm wrote: > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Cc: David Woodhouse > Signed-off-by: Leif Lindholm > --- > OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- > OvmfPkg/AcpiPlatf

Re: [edk2-devel] [Patch v1] Maintainers.txt update for ShellPkg

Hi, Jaben would be busy with other work. The patch is pending for a long time. Is there any comment of this? It may be required to get the comments from the stewards. Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Thursday, August 22, 2019 4:56 AM

Re: [edk2-devel] [PATCH v4] BaseTools/LzmaCompress: Add two switches

This version is good. Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Friday, September 20, 2019 10:29 AM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Feng, Bob C > ; Gao, Liming > Subject: [PATCH v4] BaseTools/LzmaCompress: Add two switches > > From:

[edk2-devel] [Patch] Revert "BaseTools: Improve GetDependencyList function"

This reverts commit bc9e4194cf3edaf9524c83098ba3f72008c70190. This change causes the dependent header files are missing in Makefile. It makes the incremental build not work. So, revert this change. Cc: Bob Feng Signed-off-by: Liming Gao --- BaseTools/Source/Python/AutoGen/GenMake.py | 29 +++

[edk2-devel] [PATCH v4 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

Shell command smbiosview updates for SMBIOS 3.3.0 spec. Signed-off-by: Abner Chang Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../SmbiosView/PrintInfo.c | 23 +++- .../SmbiosView/PrintInfo.h | 13 ++

[edk2-devel] [PATCH v4 1/3] MdeModulePkg: Update to support SmBios 3.3.0

This commit updates the revision of SMBIOS spec reported in PCDs. Signed-off-by: Abner Chang Cc: Hao A Wu Cc: Jian J Wang Cc: Leif Lindholm Cc: Gilbert Chen --- MdeModulePkg/MdeModulePkg.dec | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdeModulePkg/MdeModulePk

[edk2-devel] [PATCH v4 0/3] Update to support SmBios 3.3.0

**Please ignore v3. I sent the wrong patches. Codes changes for SMBIOS spec 3.3.0 (Not public yet) Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Abner Chang (3): MdeModulePkg: Update to support SmBios 3.3.0 MdePkg/Include: Update to support SmBios 3.3.0 ShellPkg/UefiShe

[edk2-devel] [PATCH v4 2/3] MdePkg/Include: Update to support SmBios 3.3.0

Update SmBios.h to support SMBIOS 3.3.0 spec. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- MdePkg/Include/IndustryStandard/SmBios.h | 76 ++-- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/

Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/BM_UI: Add the new terminal types to related menu

> -Original Message- > From: Bi, Dandan > Sent: Friday, September 20, 2019 11:05 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/BM_UI: Add the > new terminal types to related me

Re: [edk2-devel] [Patch 1/3] BaseTools: Improve GetDependencyList function

Bob: I find this patch will cause the dependent header files not be listed in module Makefile. Then, it will cause the incremental build issue. I don't think this is a good fix. I will send the patch to revert this change. Thanks Liming > -Original Message- > From: Feng, Bob C

[edk2-devel] [PATCH v3 2/3] MdePkg/Include: Update to support SmBios 3.3.0

Update SmBios.h to support SMBIOS 3.3.0 spec. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Leif Lindholm Cc: Gilbert Chen --- MdePkg/Include/IndustryStandard/SmBios.h | 76 ++-- 1 file changed, 3 insertions(+), 73 deletions(-) diff --git a/

[edk2-devel] [PATCH v3 1/3] MdeModulePkg: Update to support SmBios 3.3.0

This commit update the revision of SMBIOS spec reported in PCDs. Signed-off-by: Abner Chang Cc: Hao A Wu Cc: Jian J Wang Cc: Leif Lindholm Cc: Gilbert Chen --- MdeModulePkg/MdeModulePkg.dec | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.d

[edk2-devel] [PATCH v3 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support

Shell command smbiosview updates for SMBIOS 3.3.0 spec. Signed-off-by: Abner Chang Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../SmbiosView/PrintInfo.c | 23 +--- .../SmbiosView/PrintInfo.h | 13 +-

[edk2-devel] [PATCH v3 0/3] Update to support SmBios 3.3.0

Codes changes for SMBIOS spec 3.3.0 (Not public yet) Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Abner Chang (3): MdeModulePkg: Update to support SmBios 3.3.0 MdePkg/Include: Update to support SmBios 3.3.0 ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination

Reviewed-by: Eric Jin -Original Message- From: Liu, XianhuiX Sent: Wednesday, September 18, 2019 10:38 AM To: devel@edk2.groups.io Cc: Oleksiy ; Supreeth Venkatesh ; Jin, Eric Subject: [edk2-test][Patch] uefi-sct/SctPkg: Fix invalid attribute combination REF: https://bugzilla.tianoco

Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/BM_UI: Add the new terminal types to related menu

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, September 18, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Gao, Liming > Subject: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/

[edk2-devel] [PATCH v4] BaseTools/LzmaCompress: Add two switches

From: "Zhang, Shenglei" As is requested in the BZ 2077, add two switches to support setting compression mode and dictionary size. (https://bugzilla.tianocore.org/show_bug.cgi?id=2077) Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang --- v2: 1.Update DictionarySize to mDictionarySize

[edk2-devel] [edk2-platforms][PATCH V1 1/1] ClevoOpenBoardPkg/N1xxWU: Enable Synaptics touchpad support in OS

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2068 Adds the ACPI device for the Synaptics touchpad. With this change, the touchpad device is functional in the OS. Cc: Ankit Sinha Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Platform/Intel/ClevoOpenBoardPkg/N1xxWU/Library/BoardAc

Re: [edk2-devel] [PATCH] Maintainers.txt: Unify one maintainer name

Push @ 13bfe3e4520f509e7cb86085ea21276b1c4fc83b Regards, Jian > -Original Message- > From: Laszlo Ersek > Sent: Friday, September 20, 2019 2:27 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: Re: [PATCH] Maintainers.txt: Unify one maintainer name > > On 09/19/

Re: [edk2-devel][edk2-test][PATCH v2 1/1] uefi-sct/SctPkg AdapterInfo SetInformation may return unsupported

Add [edk2-test] in subject Hi Tom, Revisit the test, it gets the InformationType from GetSupportedTypes(), then call SetInformation() with the supported InformationType. In this scenario, the EFI_UNSUPPORTED doesn't make sense. If the adapter doesn't want to support the function SetInformatio

Re: [edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 09/19/2019 6:30pm-7:30pm #cal-reminder

In the bug triage meeting, we found the Bluejeans APP works better than the WEB app. Download here: https://www.bluejeans.com/downloads -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47686): https://edk2.groups.io/g/devel/message/47686 M

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 09/19/2019 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 19 September 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=478438 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com ( st

Re: [edk2-devel] [PATCH 5/7] MdeModulePkg: strip trailing whitespace

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Friday, September 20, 2019 2:06 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Bi, Dandan; Gao, Liming; Dong, Eric; Gao, > Zhichao; > Ni, Ray > Subject: [edk2-

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 09/19/2019 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 19 September 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=478437 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com ( step

Re: [edk2-devel] Do latest edk2 build tool support C99 standard

Ersek, thanks for your information 获取 Outlook for Android From: Laszlo Ersek Sent: Friday, September 20, 2019 4:32:20 AM To: Wang, Cloud Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] Do latest edk2 build tool support C99 standard

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Hi Sean, Which OS/Compiler configurations are currently enabled for the Code Compilation Test? I have been working on enabling multiple OS/Compiler configurations in Azure Pipelines. There are some tools that need to be installed for each of these environments. Examples include NASM, iASL, Pytho

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Hi Sean, This looks really good and I agree we can combine the RFCs and enable more pre-commits tests. Additional responses below. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Sean via Groups.Io > Sent: Thursday, August 29, 2019 7:22 PM > To: r...@edk2.groups.

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures

Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Thursday, September 19, 2019 10:54 AM To: devel@edk2.groups.io Cc: Bi, Dandan ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures R

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Sean, There may be many ways to improve the process and reduce the work maintainers perform. So these are ideas we can explore further going forward. I will add the concept of a non-maintainer opening the PR to the Wiki. In order to get the improvements to code quality from CI enabled as quickl

Re: [edk2-devel] Do latest edk2 build tool support C99 standard

On 09/19/19 04:40, Wang, Cloud wrote: > Dear Edk2 Base tool owner, > Do latest edk2 build tool support C99 standard? C source code in edk2 targets C95 in general. There are a few extensions that are allowed (such as the __FUNCTION__ macro, "//"-style comments, ...), and there are some surpris

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

On Thu, Sep 19, 2019 at 09:24:15PM +0200, Laszlo Ersek wrote: > On 09/19/19 11:44, Leif Lindholm wrote: > > I agree with this as a general rule, but for this (hopefully never to > > be repeated) operation, it makes sense to me to keep each change in > > this set as one patch. > > > > For the simpl

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

> On Sep 19, 2019, at 12:24 PM, Laszlo Ersek wrote: > > On 09/19/19 11:44, Leif Lindholm wrote: >> Hi Liming, >> >> On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote: >>> I add my comments. >>> -Original Message- From: Baptiste Gerondeau [mailto:baptiste.gerond...

[edk2-devel] [RFC PATCH v2 34/44] UefiCpuPkg/MpInitLib: Update CPU MP data with a flag to indicate if SEV-ES is active

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 When starting APs in an SMP configuration, the AP needs to know if it is running as an SEV-ES guest in order to assign a GHCB page. Add a field to the CPU_MP_DATA structure that will indicate if SEV-ES is active. This ne

[edk2-devel] [RFC PATCH v2 32/44] UefiCpuPkg/CpuExceptionHandler: Add support for MWAIT/MWAITX NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MWAIT/MWAITX intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../

[edk2-devel] [RFC PATCH v2 30/44] UefiCpuPkg/CpuExceptionHandler: Add support for RDTSCP NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a RDTSCP intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AM

[edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Typically, an AP is booted using the INIT-SIPI-SIPI sequence. This sequence is intercepted by the hypervisor, which sets the AP's registers to the values requested by the sequence. At that point, the hypervisor can start

[edk2-devel] [RFC PATCH v2 28/44] UefiCpuPkg/CpuExceptionHandler: Add support for INVD NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a INVD intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AMDS

[edk2-devel] [RFC PATCH v2 36/44] UefiCpuPkg: Add a 16-bit protected mode code segment descriptor

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guests register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead, an SEV-ES AP must be transitio

[edk2-devel] [RFC PATCH v2 40/44] MdePkg: Add a finalization function to the CPU protocol

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Expand the CPU protocol to include a finalization function that can be used to perform any final AP processing or AP environment setup before transferring control over to an OS. Cc: Michael D Kinney Cc: Liming Gao Sign

[edk2-devel] [RFC PATCH v2 31/44] UefiCpuPkg/CpuExceptionHandler: Add support for MONITOR/MONITORX NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MONITOR/MONITORX intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky ---

[edk2-devel] [RFC PATCH v2 29/44] UefiCpuPkg/CpuExceptionHandler: Add support for VMMCALL NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a VMMCALL intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/A

[edk2-devel] [RFC PATCH v2 33/44] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a DR7 read or write intercept generates a #VC exception. The #VC handler must provide special support to the guest for this. On a DR7 write, the #VC handler must cache the value and issue a VMGEXIT to notify

[edk2-devel] [RFC PATCH v2 37/44] OvmfPkg: Add support for SEV-ES AP reset vector re-directing

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A hypervisor is not allowed to update an SEV-ES guests register state, so when booting an SEV-ES guest AP, the hypervisor is not allowed to set the RIP to the guest requested value. Instead an SEV-ES AP must be re-directe

[edk2-devel] [RFC PATCH v2 35/44] MdeModulePkg: Reserve a 16-bit protected mode code segment descriptor

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 SEV-ES guest AP boot support needs to transition from 64-bit long mode into 16-bit real mode. This will require a 16-bit code segment descriptor. Reserve one of the spare segment descriptors (0x28) for this purpose. Cc:

[edk2-devel] [RFC PATCH v2 13/44] MdePkg/BaseLib: Add support for the VMGEXIT instruction

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 VMGEXIT is a new instruction used for Hypervisor/Guest communication when running as an SEV-ES guest. A VMGEXIT will cause an automatic exit (AE) to occur, resulting in a #VMEXIT with an exit code value of 0x403. Provide

[edk2-devel] [RFC PATCH v2 27/44] UefiCpuPkg/CpuExceptionHandler: Add support for RDPMC NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a RDPMC intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AMD

[edk2-devel] [RFC PATCH v2 17/44] UefiCpuPkg/CpuExceptionHandler: Add #VC exception handling for Sec phase

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 An SEV-ES guest will generate a #VC exception when it encounters a non-automatic exit (NAE) event. It is expected that the #VC exception handler will communicate with the hypervisor using the GHCB to handle the NAE event.

[edk2-devel] [RFC PATCH v2 23/44] UefiCpuPkg/CpuExceptionHandler: Add support for MSR_PROT NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support an MSR_PROT NAE event. Par

[edk2-devel] [RFC PATCH v2 19/44] UefiCpuPkg/CpuExceptionHandler: Add support for IOIO_PROT NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support a IOIO_PROT NAE event. P

[edk2-devel] [RFC PATCH v2 12/44] MdePkg: Add a structure definition for the GHCB

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The GHCB is used by an SEV-ES guest for communicating between the guest and the hypervisor. Create the GHCB definition as defined by the GHCB protocol definition. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Tom

[edk2-devel] [RFC PATCH v2 15/44] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VC exception

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Add base support to handle #VC exceptions. This includes a stub routine to invoke when a #VC exception occurs and special checks in the common exception handlers to invoke the #VC exception handler routine. Cc: Eric Don

[edk2-devel] [RFC PATCH v2 25/44] UefiCpuPkg/CpuExceptionHandler: Add support for WBINVD NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a WBINVD intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AM

[edk2-devel] [RFC PATCH v2 21/44] MdePkg: Add support for the XGETBV instruction

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a CPUID instruction requires the current value of the XCR0 register. In order to retrieve that value, the XGETBV instruction needs to be executed. Provide the necessary support to execute the XGETBV instruc

[edk2-devel] [RFC PATCH v2 20/44] UefiCpuPkg/CpuExceptionHandler: Support string IO for IOIO_PROT NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Add support to the #VC exception handler to handle string IO. This requires expanding the IO instruction parsing to recognize string based IO instructions as well as preparing an un-encrypted buffer to be used to transfer

[edk2-devel] [RFC PATCH v2 18/44] OvmfPkg/Sec: Enable cache early to speed up booting

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Currently, the OVMF code relies on the hypervisor to enable the cache support on the processor in order to improve the boot speed. However, with SEV-ES, the hypervisor is not allowed to change the CR0 register to enable c

[edk2-devel] [RFC PATCH v2 24/44] UefiCpuPkg/CpuExceptionHandler: Add support for NPF NAE events (MMIO)

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a NPF intercept for an NPT entry with a reserved bit set generates a #VC exception. This condition is assumed to be an MMIO access. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add

[edk2-devel] [RFC PATCH v2 16/44] OvmfPkg/MemEncryptSevLib: Make MemEncryptSevLib available during SEC

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The SEC phase of OVMF will need access to the MemEncryptSevLib library, so make the library available during SEC. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Tom Lendacky --- OvmfPkg/Library

[edk2-devel] [RFC PATCH v2 26/44] UefiCpuPkg/CpuExceptionHandler: Add support for RDTSC NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a RDTSC intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Tom Lendacky --- .../X64/AMD

[edk2-devel] [RFC PATCH v2 22/44] UefiCpuPkg/CpuExceptionHandler: Add support for CPUID NAE events

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be used to allow the hypervisor to handle this intercept. Add support to construct the required GHCB values to support a CPUID NAE event. Additional

[edk2-devel] [RFC PATCH v2 14/44] UefiCpuPkg: Implement library support for VMGEXIT

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 To support issuing a VMGEXIT instruction, create a library that can be used to perform GHCB and VMGEXIT related operations and to issue the actual VMGEXIT instruction when using the GHCB. Cc: Eric Dong Cc: Ray Ni Cc: L

[edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A per-CPU implementation for holding values specific to a CPU when running as an SEV-ES guest, specifically to hold the Debug Register value. Allocate an extra page immediately after the GHCB page for each AP. Using the

[edk2-devel] [RFC PATCH v2 04/44] OvmfPkg/ResetVector: Add support for a 32-bit SEV check

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 During BSP startup, the reset vector code will issue a CPUID instruction while in 32-bit mode. When running as an SEV-ES guest, this will trigger a #VC exception. Add exception handling support to the early reset vector

[edk2-devel] [RFC PATCH v2 06/44] OvmfPkg: Create a GHCB page for use during Sec phase

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 A GHCB page is needed during the Sec phase, so this new page must be created. Since the GHCB must be marked as an un-encrypted, or shared, page, an additional pagetable page is required to break down the 2MB region where

[edk2-devel] [RFC PATCH v2 08/44] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Allocate memory for the GHCB pages during SEV initialization for use during Pei and Dxe phases. The GHCB page(s) must be shared pages, so clear the encryption mask from the current page table entries. Upon successful allo

[edk2-devel] [RFC PATCH v2 11/44] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result

[edk2-devel] [RFC PATCH v2 03/44] OvmfPkg: Add support to perform SEV-ES initialization

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 When SEV-ES is active, then SEV is also active. Add support to the SEV initialization function to also check for SEV-ES being active. If SEV-ES is active, set the SEV-ES active PCD (PcdSevEsActive). Cc: Jordan Justen Cc

[edk2-devel] [RFC PATCH v2 09/44] MdeModulePkg/DxeIplPeim: Support GHCB pages when creating page tables

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 GHCB pages must be mapped as shared pages, so modify the process of creating identity mapped pagetable entries so that GHCB entries are created without the encryption bit set. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi

[edk2-devel] [RFC PATCH v2 05/44] MdePkg: Add the MSR definition for the GHCB register

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 For SEV-ES, the GHCB page address is stored in the GHCB MSR register (0xc0010130). Define the register and the format used for register during GHCB protocol negotiation. Cc: Michael D Kinney Cc: Liming Gao Signed-off-b

[edk2-devel] [RFC PATCH v2 07/44] OvmfPkg/PlatformPei: Reserve GHCB-related areas if S3 is supported

From: Tom Lendacky Protect the memory used by an SEV-ES guest when S3 is supported. This includes the page table used to break down the 2MB page that contains the GHCB so that it can be marked un-encrypted, as well as the GHCB area. Regarding the lifecycle of the GHCB-related memory areas: Pcd

[edk2-devel] [RFC PATCH v2 01/44] MdePkg: Create PCDs to be used in support of SEV-ES

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Three new PCDs are needed to support SEV-ES under OVMF: - PcdSevEsActive: BOOLEAN value used to indicate if SEV-ES is active - PcdGhcbBase:UINT64 value that is the base address of the GHCB allo

[edk2-devel] [RFC PATCH v2 00/44] SEV-ES guest support

From: Tom Lendacky This patch series provides support for running EDK2/OVMF under SEV-ES. Secure Encrypted Virtualization - Encrypted State (SEV-ES) expands on the SEV support to protect the guest register state from the hypervisor. See "AMD64 Architecture Programmer's Manual Volume 2: System Pr

[edk2-devel] [RFC PATCH v2 02/44] OvmfPkg/MemEncryptSevLib: Add an SEV-ES guest indicator function

From: Tom Lendacky BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 Create a function that can be used to determine if the VM is running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Tom Lendacky --- OvmfPkg/Include/Library/MemEncryptSevLib

Re: [edk2-devel] [PATCH] Edk2: Add Zhichao as the maintainer for shellbin relase

On 09/19/19 16:56, Gao, Liming wrote: > Leif: > >> -Original Message- >> From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >> Sent: Thursday, September 19, 2019 10:39 PM >> To: Gao, Liming >> Cc: Gao, Zhichao ; devel@edk2.groups.io; Andrew Fish >> ; Laszlo Ersek ; >> Kinney, Michael

Re: [edk2-devel] [PATCH 0/3] Arm builds on Visual Studio

On 09/19/19 11:44, Leif Lindholm wrote: > Hi Liming, > > On Thu, Sep 19, 2019 at 06:19:42AM +, Gao, Liming wrote: >> I add my comments. >> >>> -Original Message- >>> From: Baptiste Gerondeau [mailto:baptiste.gerond...@linaro.org] >>> Sent: Thursday, September 19, 2019 12:05 AM >>> To:

Re: [edk2-devel] [PATCH 0/7] Strip trailing whitespace

On Thu, 19 Sep 2019 at 21:06, Leif Lindholm wrote: > > *cough* 5-6/7 do take a bit of a shotgun approach with the Cc:s, but I > would prefer not breaking the set up any more than it already is. > The changes are however trivial, so hopefully not much of an issue. > > Before we start looking into m

Re: [edk2-devel] [PATCH 4/7] EmulatorPkg: strip trailing whitespace

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Thursday, September 19, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [edk2-devel] [PATCH 4/7] EmulatorPkg: strip trailing whi

Re: [edk2-devel] [PATCH 7/7] UefiCpuPkg: strip trailing whitespace

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Thursday, September 19, 2019 11:06 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [edk2-devel] [PATCH 7/7] UefiCpuPkg: strip trailing whitespac

Re: [edk2-devel] [PATCH] Maintainers.txt: Unify one maintainer name

On 09/19/19 04:34, Jian J Wang wrote: > Update all occurrences of "Jian Wang" to be "Jian J Wang". > > Cc: Laszlo Ersek > Cc: Liming Gao > Signed-off-by: Jian J Wang > --- > Maintainers.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintain

[edk2-devel] [PATCH 7/7] UefiCpuPkg: strip trailing whitespace

Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Leif Lindholm --- UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UefiCpuPkg/Application/Cpuid/Cpuid.c b/UefiCpuPkg/Application/Cpuid/Cpuid.c index f39a7fb33ae5..cee64f2fb5fc 1006

[edk2-devel] [PATCH 5/7] MdeModulePkg: strip trailing whitespace

Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Eric Dong Cc: Zhichao Gao Cc: Ray Ni Signed-off-by: Leif Lindholm --- MdeModulePkg/Application/UiApp/FrontPageVfr.Vfr| 8 MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerVfr.Vfr

[edk2-devel] [PATCH 0/7] Strip trailing whitespace

*cough* 5-6/7 do take a bit of a shotgun approach with the Cc:s, but I would prefer not breaking the set up any more than it already is. The changes are however trivial, so hopefully not much of an issue. Before we start looking into migrating the repository to native line endings, let's start by

[edk2-devel] [PATCH 2/7] ArmPlatformPkg: strip trailing whitespace

Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm --- ArmPlatformPkg/Scripts/Ds5/profile.py | 2 +- ArmPlatformPkg/Scripts/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPlatformPkg/Scripts/Ds5/profile.py b/ArmPlatformPkg/Scripts/Ds5/profile.py index 8f74

[edk2-devel] [PATCH 6/7] OvmfPkg: strip trailing whitespace

Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Anthony Perard Cc: Julien Grall Cc: David Woodhouse Signed-off-by: Leif Lindholm --- OvmfPkg/AcpiPlatformDxe/AcpiPlatform.c | 4 ++-- OvmfPkg/AcpiPlatformDxe/Xen.c | 8 Ov

[edk2-devel] [PATCH 1/7] ArmPkg: strip trailing whitespace

Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm --- ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf b/ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf index f4fecbb4098a..5028a955afac 100644

[edk2-devel] [PATCH 4/7] EmulatorPkg: strip trailing whitespace

Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Leif Lindholm --- EmulatorPkg/Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmulatorPkg/Readme.md b/EmulatorPkg/Readme.md index 5ea61ca7ab5a..0c2eea6a9a02 100644 --- a/EmulatorPkg/Readme.md +++ b/Em

[edk2-devel] [edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg/Ipmi: Fix X64 GCC Build Failures

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2204 These build failures can be reproduced simply by building the AdvancedFeaturePkg.dsc file in GCC5 for X64 architecture. To build the whole package DSC (not pull individual features into other packages), set the WORKSPACE variable to the edk2

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Responses below. Mike > -Original Message- > From: Gao, Liming > Sent: Friday, August 30, 2019 1:44 AM > To: r...@edk2.groups.io; Kinney, Michael D > ; devel@edk2.groups.io > Subject: RE: [RFC] EDK II Continuous Integration Phase > 1 > > Mike: > I add my comments. > > >-Original

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

Hi Igor, (+Brijesh) long-ish pondering ahead, with a question at the end. On 09/17/19 15:07, Igor Mammedov wrote: > Use commit (2f295167e0 q35/mch: implement extended TSEG sizes) for > inspiration and (ab)use reserved register in config space at 0x9c > offset [*] to extend q35 pci-host with abil

[edk2-devel] [PATCH v2 8/9] BaseTools: correct line endings for ConvertFce Python script

Cc: Bob Feng Cc: Liming Gao Signed-off-by: Leif Lindholm Reviewed-by: Bob Feng --- BaseTools/Scripts/ConvertFceToStructurePcd.py | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py b/BaseTools/Scripts/ConvertFceToStructu

[edk2-devel] [PATCH v2 6/9] DynamicTablesPkg: fix .dsc line ending

Correct line ending in package .dsc. Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Leif Lindholm Reviewed-by: Sami Mujawar --- DynamicTablesPkg/DynamicTablesPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesP

[edk2-devel] [PATCH v2 4/9] EmbeddedPkg: delete outdated FdtLib README.txt

While looking at encoding and line ending errors, I found this file in fact simply points to a sourceforge page which no longer exists. Since there is nothing more to say than "this is an import of libfdt", let's just delete it. Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm --- EmbeddedPkg/Li

[edk2-devel] [PATCH v2 9/9] EmbeddedPkg: convert Lauterbach README.txt to 7-bit safe Readme.md

This file contained what looked like windows 1250 encoded single quotation marks. Convert them to regular 's. Rework the file to markdown format and and rename it Readme.md while we're at it. Cc: Ard Biesheuvel Cc: "Kinney, Michael D" Signed-off-by: Leif Lindholm --- EmbeddedPkg/Scripts/Lauter

[edk2-devel] [PATCH v2 7/9] ArmPkg: ArmScmiDxe - convert .h to from 8859-x to 7-bit

A paragraph sign in a comment came from some ISO8859 encoding, convert it to the word "section" to remain 7-bit safe, since we're not actually doing anything special. Cc: Ard Biesheuvel Cc: "Kinney, Michael D" Signed-off-by: Leif Lindholm --- ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtoco

[edk2-devel] [PATCH v2 5/9] BaseTools: fix line endings in SetupGit.py Conf files

A file header license/copyright header copied around in commit 5b3e695d8ac5 ("BaseTools: add centralized location for git config files") was missing a CR - add it in both faulty locations. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Leif Lindholm Reviewed-by: Bob Feng --- BaseTools/Conf/diff.o

[edk2-devel] [PATCH v2 3/9] NetworkPkg: add missing newline at end of file

Add missing newline at end of WifiConnectionManagerDxe .uni. Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Leif Lindholm Reviewed-by: Siyuan Fu --- NetworkPkg/WifiConnectionManagerDxe/WifiConnectionManagerDxeStrings.uni | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Network

[edk2-devel] [PATCH v2 0/9] Various line ending and encoding fixes

I have started looking into doing the CRLF->native conversion for EDK2, and as part of my initial scan, I found a bunch of trivial issues that would be easier to just fix beforehand. Mike asked me to also do a trainling whitespace cleanup, and that will be coming next. I will refrain from pushing

[edk2-devel] [PATCH v2 2/9] EmbeddedPkg: add missing newline at end of TemplateResetSystemLib.inf

Cc: Ard Biesheuvel Signed-off-by: Leif Lindholm --- EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/EmbeddedPkg/Library/TemplateResetSystemLib/TemplateResetSystemLib.inf b/EmbeddedPkg/Library/TemplateRese

  1   2   >