I've given R-b for other patches in this series. I just give R-b this one which
is only changed
in v7.
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, November 02, 2019 1:35 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard
Hi Laszlo,
Everything is back online now. Will be doing more extensive
CI unit tests next.
If there is a merge conflict at the time the PR is submitted
you should be notified by email. I think you ran into what
should be an impossible case when the service is running
correctly. The fact it
Hello,
This RFC proposes adding a new directory to edk2-platforms called
"Features". The purpose of this directory is to add support code
for platform features. Intel would like to maintain features in the
form of feature packages in which a feature may be composed of
multiple libraries, modules,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2164
Replaced Cmos.c and Cmos.h with BoardModulePkg's
Cmos library CmosAccessLib
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Kubacki Michael A
Signed-off-by: Prince Agyeman
---
.../BoardInitLib/PeiX58Ich10InitPreMemLib.c | 46 ---
Laszlo,
You're right. I'll do more tests for secure boot. I'll leave https boot to you.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek
> Sent: Saturday, November 02, 2019 6:03 AM
> To: Wang, Jian J ; Zhang, Shenglei
> ; devel@edk2.groups.io
> Cc: Lu, XiaoyuX ; Gao, Liming
>
On 11/01/19 23:39, Laszlo Ersek wrote:
> * When I submitted PR#87, there had been no conflicts; the PR was simply
> blocked on the CI tasks. Now, there are conflicts (I assume due to
> intervening pushes, while my PR#87 was blocked). It's useful that the
> WebUI points out this change in the
Hi Laszlo,
I did not make any changes to the OvmfPkg patch and I forgot to carry forward
the R-b.
I'll keep that in mind in the future.
For V7, I request the MdeModulePkg maintainers please add the R-b for the
patches
not changed. If this is not acceptable, I will be happy to send out a patch
On 11/01/19 23:05, Ashish Singhal wrote:
> Please refer to https://edk2.groups.io/g/devel/message/49627 for the patch.
Thanks! The subject line is:
[PATCH] MdeModulePkg/UefiBootManagerLib: Support skipping BM enumeration
This looks like a glitch to me -- a failure to reflect your
message to
Hi Mike,
On 11/01/19 06:03, Kinney, Michael D wrote:
> Hi Laszlo,
>
> ===
> Note for all reviewers:
> ---
> Pull requests against edk2-staging/edk2-ci are not
> being processed right now. We are
Hello Michael,
On 11/01/19 18:34, Michael Kubacki wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
>
> V7 Changes:
> [PATCH V6 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support
> * Remove VariableRuntimeCache.c and VariableRuntimeCache.h from
>
Please refer to https://edk2.groups.io/g/devel/message/49627 for the patch.
Thanks
Ashish
-Original Message-
From: Laszlo Ersek
Sent: Friday, November 1, 2019 3:42 PM
To: Ashish Singhal ; devel@edk2.groups.io;
jian.j.w...@intel.com; hao.a...@intel.com; Ray Ni ; Zhichao
Gao
Subject:
On 11/01/19 08:31, Wang, Jian J wrote:
> Hi Laszlo,
>
> I did simple ovmf boot tests (shell, linux, windows) and all passed. Let me
> know if you have
> any comments or want to do more tests against v4 before check in.
>
> Based on my review and tests,
>Reviewed-by: Jian J Wang
I can get
For the patch series...
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Friday, November 1, 2019 2:03 PM
To: devel@edk2.groups.io
Cc: Bu, Daocheng ; Desimone, Nathaniel L
; Gillispie, Thad ;
Kinney, Michael D ; Lu, Shifei A
; Oram, Isaac W ; Piwko,
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Agyeman, Prince
Sent: Friday, November 1, 2019 12:51 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
Subject: [edk2-devel] [edk2-platforms] [PATCH 3/5]
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Friday, November 1, 2019 12:51 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
Subject: [edk2-platforms] [PATCH 2/5] Platform/Intel: Move Sio Dxe Driver
Moved
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Friday, November 1, 2019 12:51 PM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Chiu, Chasel
; Desimone, Nathaniel L
Subject: [edk2-platforms] [PATCH 1/5] Platform/Intel: Add
gBoardModulePkgTokenSpaceGuid
Please implement a patch 6 and 7 adding the same changes you made here for
GalagoPro3 to KabylakeRvp3 and WhiskeyLakeURvp. Both of those boards have PS/2
keyboard connectors and your change is valuable there too.
-Original Message-
From: devel@edk2.groups.io On Behalf Of Agyeman,
On 10/31/19 13:42, Ashish Singhal wrote:
> Hello Laszlo,
>
> This is the cover letter. The patch was also submitted.
Can you please state the groups.io permalink for the posted patch,
and/or the Message-Id header for the posted patch?
> Please let me know if you are unable to find it and I'll
For the patch series...
Reviewed-by: Isaac Oram
-Original Message-
From: Kubacki, Michael A
Sent: Friday, November 1, 2019 2:03 PM
To: devel@edk2.groups.io
Cc: Bu, Daocheng ; Desimone, Nathaniel L
; Gillispie, Thad ;
Kinney, Michael D ; Lu, Shifei A
; Oram, Isaac W ; Piwko, Maciej
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
The current set of maintainers do not plan to maintain this package
moving forward. Simply leaving the code as unmaintained is
undesirable for several reasons including presence of build issues,
functional issues, and lack of consistency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2325
The current set of maintainers do not plan to maintain this package
moving forward. Simply leaving the code as unmaintained is
undesirable for several reasons including presence of build issues,
functional issues, and lack of consistency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
The current set of maintainers do not plan to maintain this package
moving forward. Simply leaving the code as unmaintained is
undesirable for several reasons including presence of build issues,
functional issues, and lack of consistency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
The current set of maintainers do not plan to maintain this package
moving forward. Simply leaving the code as unmaintained is
undesirable for several reasons including presence of build issues,
functional issues, and lack of consistency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2325
Due to some Intel packages being removed, this change removes the
corresponding packages from Maintainers.txt.
Cc: Bu, Daocheng
Cc: Nate DeSimone
Cc: Gillispie, Thad
Cc: Michael D Kinney
Cc: Shifei A Lu
Cc: Isaac W Oram
Cc: Piwko,
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
The current set of maintainers do not plan to maintain this package
moving forward. Simply leaving the code as unmaintained is
undesirable for several reasons including presence of build issues,
functional issues, and lack of consistency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
Removes the BoardMtOlympus build configuration from build.cfg as
the package will be removed in a future change.
Cc: Nate DeSimone
Cc: Michael D Kinney
Cc: Shifei A Lu
Cc: Isaac W Oram
Cc: Xiaohu Zhou
Signed-off-by: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322
Removes all references to PurleyOpenBoardPkg in Readme.md files in
edk2-platforms as the package will be removed in a future change.
Cc: Nate DeSimone
Cc: Michael D Kinney
Cc: Shifei A Lu
Cc: Isaac W Oram
Cc: Xiaohu Zhou
Signed-off-by:
Added GalagoPro3 board ps2 keyboard library
that adds ps2 device path to ConIn and ConInDev
Uefi variables
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../GalagoPro3/Library/Ps2KbcLib/Ps2KbcLib.c | 202 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228
This patch series enables BIOS Ps2 keyboard in GalagoPro3
What was done:
Patch 0001 adds PCDs to BoardModulePkg that will enable/disable,
describe Super I/O , Ps2 keyboard/mouse, uart1 and uart2 com ports
Patch 0002 moves the generic
Added gBoardModulePkgTokenSpaceGuid to BoardModulePkg
Added ps2 keyboard and Uart enable PCDs.
Added PCDs to define IO ports for Uart1 and Uart2
Enabled KabylakeOpenBoardPkg and WhiskeylakeOpenBoardPkg
boards to use the ps2 keyboard enable PCD.
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228
Added Ps2Keyboard DXE driver.
Added Sio dxe driver to publish the SIO protocol
needed by the Ps2Keyboard DXE driver.
Included a Ps2 null Library to BdsDxe driver
to add the Ps2 device path to ConIn and ConInDev
variables
Configured the
Moved LegacySioDxe from SimicsOpenBoardPkg
to BoardModulePkg as LegacySioDxe is generic
and can be shared between open board packages
Removed unused libraries and functions in LegacySioDxe
Pointed BoardX58Ich10 to the current LegacySioDxe
location
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate
Included PCDs to the Sio dxe driver,
to allow the enable/disable of Ps2 keyboard/mouse,
UART1 and UART2 com ports.
Renamed the Sio driver's base name
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Prince Agyeman
---
.../LegacySioDxe/LegacySioDxe.inf | 15
With Michael's comments addressed...
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel]
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Wei, David Y ; Agyeman, Prince
Subject: [edk2-devel] [edk2-platforms: PATCH v3 6/6]
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
Subject: [edk2-devel] [edk2-platforms: PATCH v3 4/6]
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming ; Jeremy
Soller
Subject: [edk2-devel] [edk2-platforms:
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
; Gao, Liming
Subject: [edk2-devel] [edk2-platforms: PATCH v3 2/6]
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Thursday, October 31, 2019 3:28 AM
To: devel@edk2.groups.io
Cc: Lu, Shifei A ; Zhou, Bowen ;
Oram, Isaac W
Subject: [edk2-devel] [edk2-platforms: PATCH v3 5/6]
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change reduces SMIs for GetVariable () by maintaining a
UEFI variable cache in Runtime DXE in addition to the pre-
existing cache in SMRAM. When the Runtime Service GetVariable()
is invoked, a Runtime DXE cache is used instead of
This change enables the variable runtime cache by default by setting
gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in
MdeModulePkg.dec to TRUE.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J Wang
Cc:
The majority of logic related to GetNextVariableName () is currently
implemented in VariableServiceGetNextVariableInternal (). The list
of variable stores to search for the given variable name and variable
GUID is defined in the function body. This change adds a new parameter
so that the caller
Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache
to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc
so that when SMM_REQUIRE is TRUE, the SMM variable driver will not
use the runtime variable cache.
This is done for OvmfPkg because it currently depends upon a SMM
UpdateVariableInfo () currently accepts parameters regarding updates
to be made to a global variable of type VARIABLE_INFO_ENTRY. This
change passes the structure by pointer to UpdateVariableInfo ()
so structures other than the fixed global variable can be updated.
Cc: Dandan Bi
Cc: Ard
The file VariableParsing.c provides generic functionality related
to parsing variable related structures and information. In order to
calculate offsets for certain operations, the functions must know if
authenticated variables are enabled as this increases the size of
variable headers.
This
https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change implements the Runtime Service GetNextVariableName()
using the runtime cache in VariableSmmRuntimeDxe. Runtime Service
calls to GetNextVariableName() will no longer trigger a SW SMI
when
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
V7 Changes:
[PATCH V6 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support
* Remove VariableRuntimeCache.c and VariableRuntimeCache.h from
VariableSmmRuntimeDxe.inf since they are not needed to build the module.
V6 Changes:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
The current VariableInfo application only checks for variable
statistics from SMM if the variable information entries are
not present in the UEFI System Configuration table as published
by the DXE UEFI variable driver (VariableRuntimeDxe).
This change adds a dedicated file for variable operations specific
to non-volatile variables. This decreases the overall length of the
relatively large Variable.c file.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J
Tested-by: Sudipto Paul https://community.arm.com/developer/tools-software/oss-platforms/w/docs/440/neoverse-n1-sdp
-Sudipto
-Original Message-
From: Sami Mujawar
Sent: 21 October 2019 17:06
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: jaben.car...@intel.com; ray...@intel.com;
Hi Prabhakar,
On Fri, Nov 1, 2019 at 10:22 AM Prabhakar Kushwaha
wrote:
>
> Hi Bhupesh,
>
> On Fri, Nov 1, 2019 at 1:59 AM Bhupesh Sharma wrote:
> >
> > Hi Prabhakar,
> >
> > On Wed, Oct 30, 2019 at 1:47 PM Prabhakar Kushwaha
> > wrote:
> > >
> > > On Wed, Oct 30, 2019 at 1:14 PM Ard
On Fri, Nov 01, 2019 at 10:17:30AM +0530, Prabhakar Kushwaha wrote:
> On Fri, Nov 1, 2019 at 2:04 AM dann frazier
> wrote:
> >
> > On Thu, Oct 31, 2019 at 12:55:10PM -0600, dann frazier wrote:
> > > On Thu, Oct 31, 2019 at 6:16 AM Leif Lindholm
> > > wrote:
> > > >
> > > > On Thu, Oct 31, 2019
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to enable the configuration of new PCI feature
Max_Payload_Size (MPS), which defines the data packet size for the PCI
transactions, as per the PCI Base Specification 4 Revision 1.
The code changes are made to
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2313
The code changes are made; as per the PCI Base Specification 4 Revision
1; to enable the configuration of new PCI feature Completion Timeout
(CTO), which enables the PCI function to wait on programmed duration for
its transactions before
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to enable the configuration of new PCI feature
Max_Read_Req_Size (MRRS), which defines the memory read request size for
the PCI transactions, as per the PCI Base Specification 4 Revision 1.
The code changes are
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2313
The code changes are made; as per the PCI Base Specification 4 Revision
1; to enable the configuration of new PCI feature No-Snoop (NS), which
enables the PCI function to initiate requests if it does not require har-
dware enforced
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2313
The code changes are made to enable the configuration of new PCI feature
Relax Ordering (OR), which enables the PCI function to initiate requests
if it does not require strong write ordering for its transactions; as per
the PCI Base
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The following legacy PCI Platform Protocol usage is reorganized in the
separate source files:-
(1) PlatformPrepController
(2) PlatformNotify
(3) GetPlatformPolicy
(4) GetPciRom
This code changes are made to support the new PCI Platform
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to integrate the setup infrastructure for the
PCI feature enumeration, in the last phase of the PCI Bus driver, after
its registration and its option ROM loading phase is complete.
Signed-off-by: Ashraf Javeed
Cc:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to setup the following internal sub-phases for
enumerating the PCI features in the late phase of the PCI Bus driver.
(1) PciFeatureRootBridgeScan - initial phase in configuring the other PCI
features to record
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The separation of the PCI device registration phase includes only the
installation of the PCI IO Protocol on the PCI node to acquire the EFI
handles, and loading of its applicable PCI Option ROM.
The separation of the PCI device start phase
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to support the new PCI Platform Protocol, as
well as the legacy PCI Platform Protocol interfaces.
The code change is made to consume the new interface to acquire the PCI
device-specific platform policy.
This code
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2194
The code changes are made to record the PCI device's PCI-Express
Capability Structure register set during early PCI enumeration phase.
This data shall be used during PCI feature enumeration phase.
Signed-off-by: Ashraf Javeed
Cc: Jian J
The EDK2 Kernel PciBusDxe driver is enhanced to enable the configuration
of PCI features like
(1) Max_Payload_Size
(2) Max_Read_Req_Size
(3) Relax Ordering
(4) No-Snoop
(5) Completion Timeout
Max_Payload_Size:- The PCI Device Control register provides this feature
register field which controls
On Fri, Nov 1, 2019 at 6:57 AM Jon Nettleton via Groups.Io
wrote:
>
> On Thu, Oct 31, 2019 at 5:44 PM Andrew Fish via Groups.Io
> wrote:
> >
> > Jon,
> >
> > Its a little confusing but gBS->GetMemoryMap () only returns information
> > about DRAM and any address that requires a kernel virtual
Hi Laszlo,
I did simple ovmf boot tests (shell, linux, windows) and all passed. Let me
know if you have
any comments or want to do more tests against v4 before check in.
Based on my review and tests,
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Zhang,
Update openssl from 1.1.1b to 1.1.1d.
Something needs to be noticed is that, there is a bug existing in the
released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
which causes build failure. So we switch the code base to a usable
version, which is 2 commits later than the stable tag.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2320
Add support for parseing map files generated by CLANG9 in GenFv
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Source/C/GenFv/GenFvInternalLib.c | 28 +++-
1 file changed, 23
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Source/Python/Common/Misc.py | 9 ++---
BaseTools/Source/Python/GenPatchPcdTable/GenPatchPcdTable.py | 9 ++---
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git
EsrtRepository might be NULL. So return EFI_OUT_OF_RESOURCES
when it is NULL.
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EsrtDxe/EsrtImpl.c | 10 ++
1 file changed, 10 insertions(+)
diff --git
Add error handling and ASSERT to ensure the variables are
usable when called.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Dandan Bi
Cc: Eric Dong
Cc: Hao A Wu
Cc: Liming Gao
Shenglei Zhang (4):
v2: Update the checking method in 02/04.
v3: Add ASSERT instead of error handling in 04/04.
Shenglei
The caller of CompareAndMergeDefaultString has checked that
AltCfgResp must contain AltConfigHdr. So we add ASSERT to assume
StringPtr is not NULL.
Cc: Dandan Bi
Cc: Eric Dong
Signed-off-by: Shenglei Zhang
Reviewed-by: Dandan Bi
---
MdeModulePkg/Universal/HiiDatabaseDxe/ConfigRouting.c | 1 +
Before called by GetBufferForValue(), Value has already been called
function IsTypeInBuffer to make sure the value must be buffer type.
So GetBufferForValue can not return NULL.
This commit adds ASSERT to assume (GetBufferForValue () is not
NULL.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by:
Entry and RetEntry might be NULL before used.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
Reviewed-by: Hao A Wu
---
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 2 +-
MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c| 2 +-
2 files changed, 2
74 matches
Mail list logo
