> -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, November 14, 2019 5:33 PM > To: devel@edk2.groups.io; Zhang, Shenglei <shenglei.zh...@intel.com> > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com>; > Wu, Jiaxin <jiaxin...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Rabeda, > Maciej <maciej.rab...@intel.com>; Dong, Eric <eric.d...@intel.com>; Ni, > Ray <ray...@intel.com> > Subject: Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files > > On 11/14/19 12:46, Zhang, Shenglei wrote: > > From: Shenglei Zhang <shenglei.zh...@intel.com> > > > > There are missing strings in MdeModulePkg.uni, NetworkPkg.uni > > and UefiCpuPkg.uni. So add them into uni files. > > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Hao A Wu <hao.a...@intel.com> > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Maciej Rabeda <maciej.rab...@intel.com> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Laszlo Ersek <ler...@redhat.com> > > Shenglei Zhang (3): > > MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD > > NetworkPkg/NetworkPkg.uni: Add missing strings for PCD > > UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD > > > > MdeModulePkg/MdeModulePkg.uni | 12 ++++++++++++ > > NetworkPkg/NetworkPkg.uni | 7 +++++++ > > UefiCpuPkg/UefiCpuPkg.uni | 16 ++++++++++++++++ > > 3 files changed, 35 insertions(+) > > > > This blurb announces three patches in the series. However, in response to the > blurb, five patches in total seem to have been posted (and, based on the > message-id fields in those patch emails, everything was sent out in a single > git > invocation): > > [edk2-devel] [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing > strings for PCD > [edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported > [edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles > [edk2-devel] [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for > PCD > [edk2-devel] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for > PCD > > This makes no sense to me. Please either repost the full (5-part) series with > correct numbering on each patch (including the blurb), or else, please split > out > the un-numbered patches to standalone postings. The decision between both > options should be based on whether it is logical to collect all five patches > into a > single series, or if it's more logical to post 3 + 1 + 1 patches. > > (Note: despite appearances, this problem is *not* inherent to mailing lists > -- if > you submit a github pull request with 5 patches, and it turns out that 2 out > of 5 > are (each) unrelated to anything else, then any reviewer worth their salt will > request separate PRs for each of those stand-alone patches.) >
Hi Laszlo, I sent all these 5 patches in one git command. So they may cause confusion. I think I can submit separated pull request for these patches. Thanks, Shenglei > Thanks > Laszlo > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50819): https://edk2.groups.io/g/devel/message/50819 Mute This Topic: https://groups.io/mt/57476153/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
