Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Saturday, November 23, 2019 12:32 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Chen, Gilbert > Subject: Re: [edk2-devel] [edk2-staging/RI

Re: [edk2-devel] Interpretation of specification

2019-11-22 Thread Eugene Khoruzhenko
Hi Paulo, Just to be clear - your variables have your own GUID and Name, so your variables are "common" Authenticated Variables, correct? What exactly is failing in your case: * You cannot write your variable first time, so it does not get created? * Or you can create, but cannot update after i

Re: [edk2-devel] [RFC PATCH v3 30/43] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2019-11-22 Thread Lendacky, Thomas
On 11/22/19 3:10 PM, Laszlo Ersek wrote: On 11/22/19 17:30, Tom Lendacky wrote: On 11/22/19 6:52 AM, Laszlo Ersek wrote: On 11/21/19 21:46, Tom Lendacky wrote: On 11/21/19 6:06 AM, Laszlo Ersek wrote: On 11/20/19 21:06, Lendacky, Thomas wrote: @@ -737,6 +738,21 @@ SecCoreStartupWithStack (

Re: [edk2-devel] [RFC PATCH v3 30/43] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2019-11-22 Thread Laszlo Ersek
On 11/22/19 17:30, Tom Lendacky wrote: > On 11/22/19 6:52 AM, Laszlo Ersek wrote: >> On 11/21/19 21:46, Tom Lendacky wrote: >>> On 11/21/19 6:06 AM, Laszlo Ersek wrote: On 11/20/19 21:06, Lendacky, Thomas wrote: > @@ -737,6 +738,21 @@ SecCoreStartupWithStack ( >   Table[Index] = 0

Re: [edk2-devel] [PATCH] BaseTools:fixed Build failed issue for Non-English OS

2019-11-22 Thread Laszlo Ersek
Hi Bob, On 11/22/19 07:39, Feng, Bob C wrote: > [Bob] The build failure was found on a platform which uses Structure Pcds in > dsc and the build machine is a Win10 with Korean language. > The present patch descripts the build failure case. > [Bob] I agree. "Non-English OS" is not precise. For t

Re: [edk2-devel] [RFC PATCH v3 37/43] OvmfPkg: Reserve a page in memory for the SEV-ES AP reset vector

2019-11-22 Thread Lendacky, Thomas
On 11/22/19 10:06 AM, Laszlo Ersek wrote: On 11/21/19 23:49, Tom Lendacky wrote: On 11/21/19 1:27 PM, Laszlo Ersek wrote: On 11/20/19 21:06, Lendacky, Thomas wrote: +; sevEsResetBlock: +; For the initial boot of an AP under SEV-ES, the "reset" RIP must be +; programmed to the RAM area de

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 16:05:07 +, Abner Chang wrote: > > > > Sure, but we also don't *need* to add a new implementation for this > > > > - RiscVPkg can still use the EmbeddedPkg one. > > > > > > > > (And if we did, it should probably be in MdeModulePkg.) > > > > > > I think we had similar dis

Re: [edk2-devel] [RFC PATCH v3 30/43] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2019-11-22 Thread Lendacky, Thomas
On 11/22/19 6:52 AM, Laszlo Ersek wrote: On 11/21/19 21:46, Tom Lendacky wrote: On 11/21/19 6:06 AM, Laszlo Ersek wrote: On 11/20/19 21:06, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7

Re: [edk2-devel] [RFC PATCH v3 37/43] OvmfPkg: Reserve a page in memory for the SEV-ES AP reset vector

2019-11-22 Thread Laszlo Ersek
On 11/21/19 23:49, Tom Lendacky wrote: > On 11/21/19 1:27 PM, Laszlo Ersek wrote: >> On 11/20/19 21:06, Lendacky, Thomas wrote: >>> +; sevEsResetBlock: >>> +; For the initial boot of an AP under SEV-ES, the "reset" RIP must be >>> +; programmed to the RAM area defined by SEV_ES_RESET_IP. A kno

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Friday, November 22, 2019 10:56 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-devel] [edk2-staging/RISC-V

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 14:19:55 +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > On Mon, Oct 28, 2019 at 09:59:07 +0800, Abner Chang wrote: > > > > > Null instance of Real Time Clock lib for RISC-V platform. > > > > > > > > > > Signed-off-by: Abner Chang > > > > > > > > > > Cc: Leif L

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, November 22, 2019 10:09 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-staging/RISC-V-V2 PATCH v3 29/39] > RiscVPlatformPkg/RealTi

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 12:28:01 +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Friday, November 22, 2019 1:03 AM > > To: Chang, Abner (HPS SW/FW Technologist) > > Cc: devel@edk2.groups.i

Re: [edk2-devel] [RFC PATCH v3 30/43] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2019-11-22 Thread Laszlo Ersek
On 11/21/19 21:46, Tom Lendacky wrote: > On 11/21/19 6:06 AM, Laszlo Ersek wrote: >> On 11/20/19 21:06, Lendacky, Thomas wrote: >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >>> >>> An SEV-ES guest will generate a #VC exception when it encounters a >>> non-automatic exit (NAE) event.

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 29/39] RiscVPlatformPkg/RealTimeClockLibNull: Null instance of RTC lib.

2019-11-22 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, November 22, 2019 1:03 AM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-staging/RISC-V-V2 PATCH v3 29/39] > RiscVPlatformPkg/RealTim

Re: [edk2-devel] [RFC PATCH v3 32/43] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with SEV-ES is enabled

2019-11-22 Thread Laszlo Ersek
On 11/21/19 22:11, Tom Lendacky wrote: > On 11/21/19 6:31 AM, Laszlo Ersek via Groups.Io wrote: >> On 11/20/19 21:06, Lendacky, Thomas wrote: >>> The flash detection routine will attempt to determine how the flash >>> device behaves (e.g. ROM, RAM, Flash). But when SEV-ES is enabled and >>> the fla

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

2019-11-22 Thread Abner Chang
Oops. You are right. Just forward that email to all in CCed. -Original Message- From: Leif Lindholm [mailto:leif.lindh...@linaro.org] Sent: Friday, November 22, 2019 5:43 PM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) Cc: Andrew Fish ; Laszlo Ersek ; Michael D Kinne

Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 12:30:13 +0100, Philippe Mathieu-Daudé wrote: > Hi, > > On 11/22/19 9:07 AM, Zhiguang Liu wrote: > > V1: > > > > After unifying the definition of size_t, EBC compiler has failure. > > So don't compile this inf file for EBC > > > > V2: > > > > Thanks for Leif's comment >

[edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Add support for parsing FACS

2019-11-22 Thread Sami Mujawar
Add support for parsing the ACPI FACS table. The FADT parser has also been updated as it links the FACS table using the FIRMWARE_CTRL or X_FIRMWARE_CTRL fields. Since the FACS table does not follow the standard ACPI header, the FADT parser extracts the FACS signature, length and version fields be

Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

2019-11-22 Thread Philippe Mathieu-Daudé
Hi, On 11/22/19 9:07 AM, Zhiguang Liu wrote: V1: After unifying the definition of size_t, EBC compiler has failure. So don't compile this inf file for EBC V2: Thanks for Leif's comment Updated VALID_ARCHITECTURES in inf file REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338 Cc: Liming

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/Variable: Initialize local variable "RtPtrTrack"

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/22/19 12:02 AM, Kubacki, Michael A wrote: REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2364 Fixes a new build warning in VS2012 introduced in f8ff4cca7c. This patch initializes the local variable "RtPtrTrack" in FindVariableInRuntimeCache (). This ensures the pointers in the struct

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg/Variable: Initialize local variable

2019-11-22 Thread Philippe Mathieu-Daudé
On 11/21/19 8:22 PM, Kubacki, Michael A wrote: Hi Philippe, I will split the change into two patches. Thanks. In the current implementation of VariableSmmRuntimeDxe.c there is not an actual problem. The Status variable is set to EFI_NOT_FOUND and RtPtrTrack is only used if Status is not set

[edk2-devel] [PATCH V3] BaseTools:fix regression issue for platform .map file

2019-11-22 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2363 This patch is to fix a build tool regression issue which was introduced by commit b8ac0b7f28.This issue caused map file lost the line of IMAGE=***. For example,in Ovmf.map, there is no line of (IMAGE= ) under each of modules item. The path to

Re: [edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 16:07:26 +0800, Zhiguang Liu wrote: > V1: > > After unifying the definition of size_t, EBC compiler has failure. > So don't compile this inf file for EBC > > V2: > > Thanks for Leif's comment > Updated VALID_ARCHITECTURES in inf file Please remove the versioning informat

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: Fix build failure - Bug 2253

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 02:20:52 +, Gao, Liming wrote: > >Reviewed-by: Laszlo Ersek > > > >This should be included in edk2-stable201911 -- it fixes obscure build > >failures. > > > > Agree. If no objection, I will create pull request for this patch to push it. No objection. / Leif -=-

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 39/39] edk2-staging: Revise Readme.md

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 02:05:30 +, Abner Chang wrote: > Palmer removed. > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Friday, November 22, 2019 1:15 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > > > Cc: Andre

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 37/39] edk2-staging:RISC-V-V2: Add RiscVEdk2Readme.md

2019-11-22 Thread Leif Lindholm
On Fri, Nov 22, 2019 at 03:57:22 +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > +## RISC-V EDK2 Package > > > +``` > > > +RiscVPkg - RISC-V processor package. This package provides RISC-V > > > + processor related protocols/libraries accroding to UEFI > > > +

[edk2-devel] [PATCH 2/6] MdeModulePkg/SmmIpl: expose MM communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
The MM communicate 2 protocol was introduced to factor out the mismatch between traditional MM, which requires the physical address of the MM buffer to be passed, and standalone MM, which copies the MM communicate buffer data into a separate buffer, requiring the virtual address. For this reason, M

[edk2-devel] [PATCH 4/6] MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Application/VariableInfo/VariableInfo.c | 19 +++ MdeModulePkg/Application/VariableInfo/VariableInfo.inf | 2 +- 2 files changed, 12 in

[edk2-devel] [PATCH 3/6] ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
Implement the new MmCommunication2 protocol which supports the use of standalone MM at runtime inside an address space that has been virtually remapped by the OS. Note that the implementation of the old MM Communicate protocol is removed: it never worked correctly so there is no point in keeping i

[edk2-devel] [PATCH 0/6] PIWG M1993 - implement EFI_MM_COMMUNICATE2_PROTOCOL

2019-11-22 Thread Ard Biesheuvel
As discussed in the PIWG call on 21 November, I am sending out my implementation of the MM communicate 2 protocol for review. It is intended to work around the impedance mismatch between traditional SMM (which uses physical addresses in the communication between DXE components) and standalone MM (w

[edk2-devel] [PATCH 6/6] MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Include/Guid/SmmVariableCommon.h| 6 +-- MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 39 +++--

[edk2-devel] [PATCH 5/6] MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 2 +- MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmDxe.c| 25 +

[edk2-devel] [PATCH 1/6] MdePkg: introduce MM communicate 2 protocol

2019-11-22 Thread Ard Biesheuvel
Add the protocol definition of the MM communicate 2 protocol, which has been introduced by version 1.7 errata A of the PI spec. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Protocol/MmCommunication2.h | 69 MdePkg/MdePkg.dec | 7 ++ 2 files chan

Re: [edk2-devel] [PATCH 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-22 Thread Wang, Sunny (HPS SW)
Thanks for the clarification, Ray. Regards, Sunny Wang -Original Message- From: Ni, Ray [mailto:ray...@intel.com] Sent: Thursday, November 21, 2019 7:51 PM To: devel@edk2.groups.io; Wang, Sunny (HPS SW) ; Gao, Zhichao ; Jeff Brasen ; edk2-de...@lists.01.org Cc: Gao, Liming ; Kinney, Mi

[edk2-devel] [Patch V2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore

2019-11-22 Thread Zhiguang Liu
V1: After unifying the definition of size_t, EBC compiler has failure. So don't compile this inf file for EBC V2: Thanks for Leif's comment Updated VALID_ARCHITECTURES in inf file REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338 Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Cc: Leif Li