Re: [edk2-devel] [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors

2019-11-27 Thread Wang, Jian J
For this patch series, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Kubacki, Michael A > Sent: Thursday, November 28, 2019 3:58 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Gao, Liming ; > Wang, Jian J ; Wu, Hao A > Subject: [PATCH V2 0/2] MdeModulePkg PeiCo

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

2019-11-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, > Eric > Sent: Thursday, November 28, 2019 2:17 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid > allocate Token every

[edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

2019-11-27 Thread Dong, Eric
v2 changes: Minor update based on comments. v1 changes: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 Current logic allocate Token every time when need to use it. The logic caused SMI latency raised to very high. Update logic to allocate Token buffer at driver's entry point. Later us

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-27 Thread Gao, Zhichao
This bitmask value only affect the runtime service at runtime phase. So the implementation should be after the ExitBootServices() called. I think the patch set is only implemented the basic setting of the variable but no implementation of the RuntimeServices. Thanks, Zhichao > -Original Mes

Re: [edk2-devel] [PATCH v2 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-27 Thread Ni, Ray
Jeff, I think I forgot to ask a very basic question on the new variable RuntimeServicesSupported. What if the variable claims SetVariable() is not supported but OS still calls SetVariable()? I think to behave in a consistent way, SetVariable() should reject to service. But I cannot find it in yo

Re: [edk2-devel] [PATCH] ShellPkg/UefiHandleParsingLib: Fix error allocate pool

2019-11-27 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Thursday, November 28, 2019 10:23 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Carsey, Jaben ; Ni, Ray ; > Andrew Fish > Subject: RE: [edk2-devel] [PATCH] ShellPkg/UefiHandleParsingLib: Fix error > allocate pool

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

2019-11-27 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, > Eric > Sent: Thursday, November 28, 2019 10:58 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek > Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid > allocate Token every time. > > REF: https://bugzill

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid allocate Token every time.

2019-11-27 Thread Dong, Eric
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 Current logic allocate Token every time when need to use it. The logic caused SMI latency raised to very high. Update logic to allocate Token buffer at driver's entry point. Later use the token from the allocated token buffer. Only when all

Re: [edk2-devel] [PATCH] ShellPkg/UefiHandleParsingLib: Fix error allocate pool

2019-11-27 Thread Gao, Zhichao
Hi Ray, Can you help to review this patch? Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao, > Zhichao > Sent: Monday, July 15, 2019 3:30 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Andrew Fish > Subject

[edk2-devel] [edk2-platforms][PATCH V2 42/47] Platform/Intel/AdvancedFeaturePkg: Remove the SMBIOS feature

2019-11-27 Thread Kubacki, Michael A
Removes the SMBIOS feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. The feature has been moved to Features/Intel/SystemInformation/SmbiosFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/

[edk2-devel] [edk2-platforms][PATCH V2 44/47] DebugFeaturePkg: Remove the ACPI Debug feature

2019-11-27 Thread Kubacki, Michael A
Removes the ACPI Debug feature from DebugFeaturePkg. The feature does not follow the advanced feature design. The feature has been moved to Features/Intel/Debugging/AcpiDebugFeaturePkg. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/DebugFeaturePkg/DebugFeatureP

[edk2-devel] [edk2-platforms][PATCH V2 47/47] Maintainers.txt: Update Intel feature maintainers

2019-11-27 Thread Kubacki, Michael A
Cc: Dandan Bi Cc: Sai Chaganty Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Maintainers.txt | 32 ++-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index cb7ae0a95d..8cea67e310

[edk2-devel] [edk2-platforms][PATCH V2 40/47] Platform/Intel/AdvancedFeaturePkg: Remove the S3 feature

2019-11-27 Thread Kubacki, Michael A
Removes the S3 feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. The feature has been moved to Features/Intel/PowerManagement/S3FeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/Adva

[edk2-devel] [edk2-platforms][PATCH V2 43/47] Platform/Intel/AdvancedFeaturePkg: Remove remaining contents

2019-11-27 Thread Kubacki, Michael A
This change removes the remaining files in AdvancedFeaturePkg that were located in Platform/Intel. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 30 Plat

[edk2-devel] [edk2-platforms][PATCH V2 41/47] Platform/Intel/AdvancedFeaturePkg: Remove the IPMI feature

2019-11-27 Thread Kubacki, Michael A
Removes the IPMI feature from AdvancedFeaturePkg. The feature does not follow the advanced feature design. The feature has been moved to Features/Intel/OutOfBandManagement/IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Platform/Intel/AdvancedFeaturePkg/Advan

[edk2-devel] [edk2-platforms][PATCH V2 39/47] MinPlatformPkg: Install advanced feature FVs by stage enabled

2019-11-27 Thread Kubacki, Michael A
This change updates the FvReportLib instance in MinPlatformPkg to only install advanced feature firmware volumes if the advanced feature stage should be active. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/MinPl

[edk2-devel] [PATCH 1/2] MdePkg/UefiDevicePathLib: Separate the device path lib

2019-11-27 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 UefiDevicePathLibOptionalDevicePathProtocol's implementation isn't fit its description. It should be implement as blow: Try to find the DevicePathProtocol, if found then use it to implement the interface. Else, use the local interface. It sh

[edk2-devel] [PATCH 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances

2019-11-27 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 The UefiDevicePathLibOptionalDevicePathProtocolConstructor's implementation isn't match with its instance name. Remove the ASSERT and depex of the gEfiDevicePathUtilitiesProtocolGuid because of "Optional". Add a mandatory instance to force

[edk2-devel] [PATCH 2/2] MdePkg/dsc: Add UefiDevicePathLibMandatoryDevicePathProtocol for build

2019-11-27 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2298 Add the new instance lib for build. Cc: Michael D Kinney Cc: Liming Gao Cc: Vitaly Cheptsov Signed-off-by: Zhichao Gao --- MdePkg/MdePkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MdePkg/MdePkg.dsc b/MdeP

[edk2-devel] [edk2-platforms][PATCH V2 35/47] KabylakeOpenBoardPkg/GalagoPro3: Enable advanced features

2019-11-27 Thread Kubacki, Michael A
This change enables advanced features to be used by the GalagoPro3 board in KabylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Micha

[edk2-devel] [edk2-platforms][PATCH V2 38/47] SimicsOpenBoardPkg: Use new advanced feature refactor

2019-11-27 Thread Kubacki, Michael A
Updates advanced feature references in SimicsOpenBoardPkg to the new advanced feature packages in Features/Intel. Previously, the advanced features in Platform/Intel were used. SimicsOpenBoardPkg currently uses the SMBIOS and Network advanced features. These are the same features used by the packa

[edk2-devel] [edk2-platforms][PATCH V2 37/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Enable advanced features

2019-11-27 Thread Kubacki, Michael A
This change enables advanced features to be used by the WhiskeylakeURvp board in WhiskeylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-b

[edk2-devel] [edk2-platforms][PATCH V2 33/47] Platform/Intel: Add advanced feature build support

2019-11-27 Thread Kubacki, Michael A
This change adds the ability for board packages built with build_bios.py to build advanced features located in Features/Intel. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Agyeman Prince Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/build.cfg | 1 +

[edk2-devel] [edk2-platforms][PATCH V2 34/47] Platform/Intel/Readme.md Content update

2019-11-27 Thread Kubacki, Michael A
Updates the advanced feature location referenced in Readme.md to edk2-platforms/Features/Intel. Cc: Dandan Bi Cc: Sai Chaganty Cc: Eric Dong Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/Readme.md | 14 +++--- 1 file c

[edk2-devel] [edk2-platforms][PATCH V2 36/47] KabylakeOpenBoardPkg/KabylakeRvp3: Enable advanced features

2019-11-27 Thread Kubacki, Michael A
This change enables advanced features to be used by the KabylakeRvp3 board in KabylakeOpenBoardPkg. Some platform macros in OpenBoardPkg.dsc are consolidated so all values are set at the top of the file before including advanced feature code. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Mic

[edk2-devel] [edk2-platforms][PATCH V2 25/47] KabylakeOpenBoardPkg/KabylakeRvp3: Add PEI_ARCH and DXE_ARCH

2019-11-27 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V2 28/47] SimicsOpenBoardPkg/BoardX58Ich10: Use PEI_ARCH and DXE_ARCH

2019-11-27 Thread Kubacki, Michael A
This change updates OpenBoardPkg.dsc to use the PEI_ARCH and DXE_ARCH specified in the DSC file for the board package components. An EDK II build limitation currently prevents the macros from being able to be used, so a todo has been placed with the action needed when the BaseTools update is compl

[edk2-devel] [edk2-platforms][PATCH V2 32/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add FvAdvancedPreMemory

2019-11-27 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V2 26/47] KabylakeOpenBoardPkg/GalagoPro3: Add PEI_ARCH and DXE_ARCH

2019-11-27 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V2 31/47] KabylakeOpenBoardPkg/GalagoPro3: Add FvAdvancedPreMemory

2019-11-27 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V2 27/47] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Add PEI_ARCH and DXE_ARCH

2019-11-27 Thread Kubacki, Michael A
This change adds two new macros to OpenBoardPkg.dsc that identify the build architecture for PEI and DXE modules. The intention of this macro is to ensure that all DSC files that compose the package build (such as those included from MinPlatformPkg or an advanced feature package) build phase-specif

[edk2-devel] [edk2-platforms][PATCH V2 24/47] Features/Intel/AdvancedFeaturePkg: Add FDF include files

2019-11-27 Thread Kubacki, Michael A
Adds FDF files that group all currently available advanced features so they can be conveniently included into board packages. The Minimum Platform defines two firmware volumes for advanced features: FvAdvancedPreMemory and FvAdvanced. This change provides all pre-memory advanced feature modules t

[edk2-devel] [edk2-platforms][PATCH V2 29/47] MinPlatformPkg: Add FvAdvancedPreMemory

2019-11-27 Thread Kubacki, Michael A
This change adds a new firmware volume to MinPlatformPkg called FvAdvancedPreMemory. This firmware volume is used to hold advanced feature modules that must be available in pre-memory. Previously, these modules were kept as an uncompressed child FV in FvAdvanced. However, in memory constrained env

[edk2-devel] [edk2-platforms][PATCH V2 30/47] KabylakeOpenBoardPkg/KabylakeRvp3: Add FvAdvancedPreMemory

2019-11-27 Thread Kubacki, Michael A
This change adds a standalone firmware volume for pre-memory advanced features called FvAdvancedPreMemory to the flash map. Pre-memory advanced feature modules were previously kept in a child firmware volume of FvAdvanced called FvAdvancedPreMem. This change simplifies the flash layout and separat

[edk2-devel] [edk2-platforms][PATCH V2 23/47] Features/Intel/AdvancedFeaturePkg: Add temporary build workaround

2019-11-27 Thread Kubacki, Michael A
This change adds a temporary build workaround to allow the advanced feature PCDs to be used in conditional statements in DSC files even if they are not referenced in INF files. Support to allow a FeaturePCD to be used in a conditional statement without being referenced in an INF file has been requ

[edk2-devel] [edk2-platforms][PATCH V2 21/47] Features/Intel/NetworkFeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
Adds a new feature package for the Network feature. The Network feature code is actually in edk2/NetworkPkg at this time so this package inclues the content from edk2/NetworkPkg. In the future, it is preferred to move the source code from NetworkPkg to NetworkFeaturePkg. Cc: Sai Chaganty Cc: Lim

[edk2-devel] [edk2-platforms][PATCH V2 15/47] Features/Intel/IpmiFeaturePkg: Add modules

2019-11-27 Thread Kubacki, Michael A
This change adds the modules for the IPMI feature to IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 8 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiF

[edk2-devel] [edk2-platforms][PATCH V2 14/47] Features/Intel/IpmiFeaturePkg: Add libraries

2019-11-27 Thread Kubacki, Michael A
This change adds the libraries required for the IPMI feature to IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dec | 9 + Features/Intel/OutOfBandMan

[edk2-devel] [edk2-platforms][PATCH V2 06/47] Features/Intel/OutOfBandManagement: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the OutOfBandManagement feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/Readme.md | 8 1 file changed, 8 insertions(+) diff --

[edk2-devel] [edk2-platforms][PATCH V2 22/47] Features/Intel/AdvancedFeaturePkg: Add package

2019-11-27 Thread Kubacki, Michael A
This change adds AdvancedFeaturePkg to the Features/Intel directory. AdvancedFeaturePkg is a special package that is located at the root level of Features/Intel. All advanced features can be built using the AdvancedFeaturePkg build. To build all advanced features, follow the instructions in the Fe

[edk2-devel] [edk2-platforms][PATCH V2 17/47] Features/Intel/SmbiosFeaturePkg: Update default strings

2019-11-27 Thread Kubacki, Michael A
Updates the PCD string default values so they are generic. The PCDs should be customized by the package that uses the feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec |

[edk2-devel] [edk2-platforms][PATCH V2 10/47] Features/Intel/Network: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the Network feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/Network/Readme.md | 5 + 1 file changed, 5 insertions(+) diff -

[edk2-devel] [edk2-platforms][PATCH V2 16/47] Features/Intel/SmbiosFeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
Adds a new feature package for the SMBIOS feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec | 172 Features/Intel/SystemInformation/SmbiosFeatur

[edk2-devel] [edk2-platforms][PATCH V2 12/47] Features/Intel/S3FeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
Adds a new feature package for the S3 feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dec | 30 + Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 122 Feat

[edk2-devel] [edk2-platforms][PATCH V2 18/47] Features/Intel/AcpiDebugFeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
Adds a new feature package for the ACPI Debug feature. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec | 39 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeat

[edk2-devel] [edk2-platforms][PATCH V2 13/47] Features/Intel/IpmiFeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
Adds a new feature package for the IPMI feature. This change updates the advanced feature package template for IPMI and adds the updated template to the IpmiFeaturePkg. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFea

[edk2-devel] [edk2-platforms][PATCH V2 09/47] Features/Intel/UserInterface: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the UserInterface feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/UserInterface/Readme.md | 9 + 1 file changed, 9 inser

[edk2-devel] [edk2-platforms][PATCH V2 08/47] Features/Intel/Debugging: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the Debugging feature domain directory. Note that the domain directory is named "Debugging" as opposed to "Debug" to help indicate that the directory is related to features used for debugging and it is not an output dire

[edk2-devel] [edk2-platforms][PATCH V2 11/47] TemplateFeaturePkg: Add initial package

2019-11-27 Thread Kubacki, Michael A
This change adds a new package called TemplateFeaturePkg that should be used as a starting point for the creation of new advanced feature packages. TemplateFeaturePkg is not meant to be built or used directly for functionality. It simply serves as a template to be copied and modified. The advanced

[edk2-devel] [edk2-platforms][PATCH V2 07/47] Features/Intel/SystemInformation: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the SystemInformation feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/SystemInformation/Readme.md | 8 1 file changed,

[edk2-devel] [edk2-platforms][PATCH V2 02/47] DebugFeaturePkg: Package DSC style cleanup

2019-11-27 Thread Kubacki, Michael A
This change refactors DebugFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by

[edk2-devel] [edk2-platforms][PATCH V2 04/47] Features/Intel: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
This change adds the initial Readme.md to the root of the Features/ Intel directory. The features are maintained in an Intel directory because they are not tested on other systems. If there is interest to support a feature on systems other than Intel, the feature should be tested on those other sys

[edk2-devel] [edk2-platforms][PATCH V2 01/47] AdvancedFeaturePkg: Package DSC style cleanup

2019-11-27 Thread Kubacki, Michael A
This change refactors AdvancedFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Revie

[edk2-devel] [edk2-platforms][PATCH V2 03/47] UserInterfaceFeaturePkg: Package DSC style cleanup

2019-11-27 Thread Kubacki, Michael A
This change refactors UserInterfaceFeaturePkg.dsc to consolidate redundant sections and better group file content to improve maintainability and readability. This pattern is being applied in all Minimum Platform package DSC files. Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Michael Kubacki Rev

[edk2-devel] [edk2-platforms][PATCH V2 05/47] Features/Intel/PowerManagement: Add Readme.md

2019-11-27 Thread Kubacki, Michael A
Adds the Readme.md file to briefly explain the types of features supported in the PowerManagement feature domain directory. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Features/Intel/PowerManagement/Readme.md | 10 ++ 1 file changed, 1

[edk2-devel] [edk2-platforms][PATCH V2 00/47] Intel Advanced Feature Refactor

2019-11-27 Thread Kubacki, Michael A
RFC:https://edk2.groups.io/g/devel/message/49880 V2 Changes: 1. Reordered the patch series to the following high-level order: 1. Clean up existing advanced feature DSC files 2. Add new Readme.md files 3. Add new advanced feature packages in Features/Intel 4. Make changes in board packa

Re: [edk2-devel] [PATCH v2 2/3] MdePkg/MdeModule: Add support for RuntimeServicesSupported variable

2019-11-27 Thread Liming Gao
Please separate the change per package. You can combine MdePkg changes into one patch. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Jeff Brasen >Sent: Thursday, November 28, 2019 7:25 AM >To: devel@edk2.groups.io >Cc: Gao, Limi

Re: [edk2-devel] [PATCH v2 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8 RuntimeServicesSuppported definations

2019-11-27 Thread Liming Gao
The change is good. And, please remove Change-Id: in the commit message. Last, have you submitted BZ for it? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Jeff Brasen >Sent: Thursday, November 28, 2019 7:25 AM >To: devel@edk2.gr

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override

2019-11-27 Thread Kubacki, Michael A
Hi Sai, I'd like to fix the VS2017 build failure asap. What would you like done to resolve this? I would prefer to eliminate the local ResetSystemLib.h file in KabylakeSiliconPkg but I'd be happy to revise the patch series based on your suggestion. Thanks, Michael > -Original Message

[edk2-devel] [PATCH v2 2/3] MdePkg/MdeModule: Add support for RuntimeServicesSupported variable

2019-11-27 Thread Jeff Brasen
Add support for new global variable defined in the UEFI 2.8 specification. This provides a bitmask of which calls are implemented by the firmware during runtime services. Change-Id: If871e16052ecd871fd03a0eef2e3ed5fa5beb93c Signed-off-by: Jeff Brasen --- .../Library/VarCheckUefiLib/VarCheckUefiL

[edk2-devel] [PATCH v2 0/3] Support for RuntimeServicesSupported global variable

2019-11-27 Thread Jeff Brasen
Add support for the new UEFI 2.8 runtime services supported variable that is used to indicate which runtime services a platform supports. Also, add support for initializing this variable based on a PCD. Change Log: v1 - Initial version v2 - Move pcd from MdeModulePkg to MdePkg and update uni fi

[edk2-devel] [PATCH v2 3/3] MdeModulePkg/BdsDxe: Set RuntimeServicesSupported variable

2019-11-27 Thread Jeff Brasen
Add support for initializing and setting the UEFI 2.8 global variable RuntimeServicesSupported based on the value of a PCD. Change-Id: I8fbd404d492ff8278466edde8aa37d203537318c Signed-off-by: Jeff Brasen --- MdeModulePkg/Universal/BdsDxe/BdsDxe.inf | 1 + MdeModulePkg/Universal/BdsDxe/BdsEntry.

[edk2-devel] [PATCH v2 1/3] MdePkg-UefiSpec.h: Add UEFI 2.8 RuntimeServicesSuppported definations

2019-11-27 Thread Jeff Brasen
Add bitmask values for the value of the RuntimeServicesSupported variable defined in the UEFI 2.8 specification. This is used to describe what services the platform supports while in runtime. Change-Id: I7ff0fcdb856b4d2e4ba90a08291f8980e2f66375 Signed-off-by: Jeff Brasen --- MdePkg/Include/Uefi/

Re: [edk2-devel] [edk2-platforms][PATCH V1 00/49] Intel Advanced Feature Refactor

2019-11-27 Thread Kubacki, Michael A
Yes, I reordered the patch series this way in V2 and I will update the closed source platforms before the old advanced feature dependencies are removed. Thanks, Michael > -Original Message- > From: Bi, Dandan > Sent: Monday, November 18, 2019 12:41 AM > To: Kubacki, Michael A ; > devel@

Re: [edk2-devel] [PATCH V1 2/2] MdeModulePkg PeiCore: Improve comment semantics

2019-11-27 Thread Kubacki, Michael A
Hi Philippe, Thanks for your suggestions. I incorporated some of the suggestions into the V2 series. Thanks, Michael > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daudé > Sent: Wednesday, November 27, 2019 3:49 AM > To: devel@edk2.groups.io; Kubacki,

[edk2-devel] [PATCH V2 2/2] MdeModulePkg PeiCore: Improve comment semantics

2019-11-27 Thread Kubacki, Michael A
This patch clarifies wording in several PeiCore comments to improve reading comprehension. Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Michael Kubacki --- MdeModulePkg/Core/Pei/FwVol/FwVol.h | 9 MdeModulePkg/Core/Pei/PeiMain.h |

[edk2-devel] [PATCH V2 1/2] MdeModulePkg PeiCore: Fix typos

2019-11-27 Thread Kubacki, Michael A
Cc: Dandan Bi Cc: Liming Gao Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Michael Kubacki --- MdeModulePkg/Core/Pei/PeiMain.inf | 10 ++-- MdeModulePkg/Core/Pei/FwVol/FwVol.h | 20 MdeModulePkg/Core/Pei/PeiMain.h | 40 MdeModulePkg/

[edk2-devel] [PATCH V2 0/2] MdeModulePkg PeiCore: Fix grammatical errors

2019-11-27 Thread Kubacki, Michael A
V2 Changes: * "The index of the FV to search." to "Index of the FV to search" in the "Instance" parameter of ProcessFvFile () * Removed "in this FV format" in the function description of AddUnknownFormatFvInfo () * Explicitly stated the implied subject noun in the commit message of patc

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2019-11-27 Thread Michael D Kinney
Hi Laszlo, Do you want to see the presence of the 'push' label in a notification when the PR is created, or just when the checks have been completed in either the pass or the fail state? A PR may be created initially without the 'push' label. The EDK II Maintainer can resolve any issues in that P

[edk2-devel] [PATCH edk2-platforms v2 4/8] Silicon/AMD/Styx: clean up stream ID mappings for SMMU

2019-11-27 Thread Ard Biesheuvel
Tighten the stream ID mappings for the SMMU to only cover the stream IDs that are actually being issued by the respective masters. This is mostly just a cleanup exercise, since specifying unused stream IDs does not typically create any problems. However, the CCP crypto accelerator on B1 silicon act

[edk2-devel] [PATCH edk2-platforms v2 0/8] fixes and updates for AMD OverDrive

2019-11-27 Thread Ard Biesheuvel
Fix some issues in the ACPI and DT descriptions of the SMMU routing, in particular the routing of the CCP crypto accelerator, which sits behind an SMMU as well on B1 silicon (but not on B0, strangely enough) Changes since v1: - add Leif's ack to patches #1, #2 and #4 - add patches to fix some erro

[edk2-devel] [PATCH edk2-platforms v2 8/8] Silicon/AMD/StyxDtbLoaderLib: omit linux,phandle properties

2019-11-27 Thread Ard Biesheuvel
The linux,phandle property is a deprecated alias for the phandle property which was standardized long ago, so don't bother emitting it. Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/Silicon/AMD/St

[edk2-devel] [PATCH edk2-platforms v2 6/8] Silicon/AMD/StyxDtbLoaderLib: add description of the cache topology

2019-11-27 Thread Ard Biesheuvel
Emit the cache topology into the device tree too when generating the CPU nodes and the cpu-map. Note that the cache geometries are all fixed and thus hardcoded - the only runtime variable aspect is how many L2 nodes to generate (one per detected cluster) Signed-off-by: Ard Biesheuvel --- Silicon

[edk2-devel] [PATCH edk2-platforms v2 7/8] Silicon/AMD/StyxDtbLoaderLib: use Cortex-A57 IDs instead of generic ARMv8

2019-11-27 Thread Ard Biesheuvel
Use the more precise Cortex-A57 based compatible strings to describe the CPUs and the PMUs in the device tree. Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Library/StyxDtbLoaderLib/StyxDtbLoaderLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/AMD/Styx/L

[edk2-devel] [PATCH edk2-platforms v2 2/8] Platform/Overdrive: clean up stream ID descriptions in DT

2019-11-27 Thread Ard Biesheuvel
Align the DT description of the SMMU topology and stream IDs with the actual routing of the SoC. As with the preceding IORT change, this is mostly a cleanup exercise, but it does actually fix an issue with the CCP crypto accelerator on B1 silicon. Since the CCP shares its SMMU with the second SATA

[edk2-devel] [PATCH edk2-platforms v2 5/8] Silicon/AMD/StyxDtbLoaderLib: add interrupt-affinity property to PMU node

2019-11-27 Thread Ard Biesheuvel
AMD Seattle uses a range of SPIs to signal PMU events, and this requires a description in the DT which SPI maps to which CPU. This requires us to defer the generation of the PMU node to a point where the CPU phandles have been allocated. Signed-off-by: Ard Biesheuvel --- Silicon/AMD/Styx/Library

[edk2-devel] [PATCH edk2-platforms v2 1/8] Platform/Overdrive: add missing resolution for FileHandleLib

2019-11-27 Thread Ard Biesheuvel
Changes to the core EDK2 repository have caused the build for Overdrive to break. Move the existing FileHandleLib resolution to global scope to get things working again. Signed-off-by: Ard Biesheuvel Acked-by: Leif Lindholm --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 2 +- 1 file chang

[edk2-devel] [PATCH edk2-platforms v2 3/8] Platform/Overdrive: fix a typo in the DT

2019-11-27 Thread Ard Biesheuvel
DT unit addresses are hex quantities but they should not include the 0x prefix. Signed-off-by: Ard Biesheuvel --- Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/AMD/OverdriveBoard/DeviceTree/OverdriveBoard.dt

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/2] KabylakeSiliconPkg: Remove ResetSystemLib.h override

2019-11-27 Thread Kubacki, Michael A
This dependency existed prior to this change (and still does exist). It was obfuscated in such a way that contributed to this problem. See the previous library header path: \Silicon\Intel\KabylakeSiliconPkg\SampleCode\MdeModulePkg\Include\Library\ResetSystemLib.h The fact KabylakeSiliconPkg i

Re: [edk2-devel] [PATCH edk2-platforms 0/3] fixes for AMD OverDrive

2019-11-27 Thread Ard Biesheuvel
On Tue, 26 Nov 2019 at 12:47, Leif Lindholm wrote: > > On Mon, Nov 25, 2019 at 19:07:07 +0100, Ard Biesheuvel wrote: > > Fix some issues in the ACPI and DT descriptions of the SMMU routing, > > in particular the routing of the CCP crypto accelerator, which sits > > behind an SMMU as well on B1 sil

Re: [edk2-devel] [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 6:04 PM, Leif Lindholm wrote: On Wed, Nov 27, 2019 at 16:33:28 +, Pete Batard wrote: Signed-off-by: Pete Batard ---   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 137 ++--   1 file changed, 96 insertions(+), 41 deletions(-) diff --git a/Platform/Raspbe

Re: [edk2-devel] [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model

2019-11-27 Thread Leif Lindholm
On Wed, Nov 27, 2019 at 16:33:28 +, Pete Batard wrote: > > > Signed-off-by: Pete Batard > > > --- > > >   Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 137 > > > ++-- > > >   1 file changed, 96 insertions(+), 41 deletions(-) > > > > > > diff --git a/Platform/RaspberryPi

Re: [edk2-devel] [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model

2019-11-27 Thread Pete Batard
On 2019.11.27 15:24, Philippe Mathieu-Daudé wrote: On 11/27/19 1:37 PM, Pete Batard wrote: From: Samer El-Haj-Mahmoud The Raspberry Pi 4 has a new SD controller. As a result we must handle SD routing according to the model, which we perform in the Config driver by using the GetModelFamily () c

Re: [edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewer email address

2019-11-27 Thread Maciej Rabeda
Oops - apparently I have managed to send this twice. Please disregard this one. On 27-Nov-19 15:02, Maciej Rabeda wrote: Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Maciej Rabeda (1): Maintainers.txt: Update reviewer email addres

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update reviewer email address

2019-11-27 Thread Maciej Rabeda
Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Signed-off-by: Maciej Rabeda --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 180ad35d0976..246583204139 100644

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewer email address

2019-11-27 Thread Maciej Rabeda
Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Maciej Rabeda (1): Maintainers.txt: Update reviewer email address Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Grou

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Update reviewer email address

2019-11-27 Thread Maciej Rabeda
Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Signed-off-by: Maciej Rabeda --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 180ad35d0976..246583204139 100644

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Update reviewer email address

2019-11-27 Thread Maciej Rabeda
Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Maciej Rabeda (1): Maintainers.txt: Update reviewer email address Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.0.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Grou

Re: [edk2-devel] [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 1:37 PM, Pete Batard wrote: From: Samer El-Haj-Mahmoud The Raspberry Pi 4 has a new SD controller. As a result we must handle SD routing according to the model, which we perform in the Config driver by using the GetModelFamily () call that was recently introduced. Signed-off-by: Pe

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 3:59 PM, Pete Batard wrote: On 2019.11.27 14:47, Philippe Mathieu-Daudé wrote: On 11/27/19 1:37 PM, Pete Batard wrote: Add missing RNG registers, This is one change. prefer reusing shorter define's instead of PCDs and clean up spacing. This is another change. All these chang

[edk2-devel] [staging/branch]: CdePkg - added unit test for STDLIB.H functions - atoi(), atol(), strtol(), strtoul(), rand(), srand(), calloc(), free(), malloc(), realloc(), atexit(), exit(), qsort(),

2019-11-27 Thread Kilian Kegel
Hi UEFI community, I’d like to inform you about an update in the CdePkg branch of edk2-staging. https://github.com/tianocore/edk2-staging/tree/CdePkg#cdepkg The goal of the CdePkg is to provide an ANSI C Interface for UEFI POST drivers, that enables BIOS engineers to (more) easily port standard

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Pete Batard
On 2019.11.27 14:47, Philippe Mathieu-Daudé wrote: On 11/27/19 1:37 PM, Pete Batard wrote: Add missing RNG registers, This is one change. prefer reusing shorter define's instead of PCDs and clean up spacing. This is another change. All these changes belong to a "cleanup" category, which

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Philippe Mathieu-Daudé
On 11/27/19 1:37 PM, Pete Batard wrote: Add missing RNG registers, This is one change. prefer reusing shorter define's instead of PCDs and clean up spacing. This is another change. Why suddenly go back to fixed PERIPHERAL block base address? Signed-off-by: Pete Batard --- Silicon/Bro

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Pete Batard
On 2019.11.27 13:17, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 14:09, Pete Batard wrote: On 2019.11.27 13:00, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote: On 2019.11.27 12:48, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: Add missin

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Ard Biesheuvel
On Wed, 27 Nov 2019 at 14:09, Pete Batard wrote: > > On 2019.11.27 13:00, Ard Biesheuvel wrote: > > On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote: > >> > >> On 2019.11.27 12:48, Ard Biesheuvel wrote: > >>> On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: > > Add missing RNG registers

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Pete Batard
On 2019.11.27 13:00, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote: On 2019.11.27 12:48, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: Add missing RNG registers, prefer reusing shorter define's instead of PCDs and clean up spacing. Is the

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Ard Biesheuvel
On Wed, 27 Nov 2019 at 13:56, Pete Batard wrote: > > On 2019.11.27 12:48, Ard Biesheuvel wrote: > > On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: > >> > >> Add missing RNG registers, prefer reusing shorter define's > >> instead of PCDs and clean up spacing. > >> > > > > Is there a source for t

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Pete Batard
On 2019.11.27 12:48, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: Add missing RNG registers, prefer reusing shorter define's instead of PCDs and clean up spacing. Is there a source for these register definitions? I used the most recent Linux driver I could find (

Re: [edk2-devel] [edk2-platforms][PATCH 1/5] Silicon/Bcm283x: Clean up Bcm2836.h header

2019-11-27 Thread Ard Biesheuvel
On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: > > Add missing RNG registers, prefer reusing shorter define's > instead of PCDs and clean up spacing. > Is there a source for these register definitions? It seems the Linux driver deviates from the below (and the warmup count thing uses the status

Re: [edk2-devel] [edk2-platforms][PATCH 2/5] Silicon/Bcm283x: Add FIFO mode for RNG

2019-11-27 Thread Pete Batard
On 2019.11.27 12:44, Ard Biesheuvel wrote: On Wed, 27 Nov 2019 at 13:37, Pete Batard wrote: The Bcm283x Random Number Generator does not work in regular mode on the Bcm2711 powered Raspberry Pi 4. It does however work when using FIFO mode. So we add this new mode, which is governed by the use

  1   2   >