[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 0/1] EdkRepo: Add squash command

2019-12-12 Thread Nate DeSimone
Changes from V3 to V2: Fixed bug where edkrepo.git_automation was not added to setup.py Fixed bug where non-ASCII characters can cause encoding issues in commit_msg.py Fixed bug where the commit_message variable was not initialized Changes from V2 to V1: Forget to commit the

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 1/1] EdkRepo: Add squash command

2019-12-12 Thread Nate DeSimone
Adds the squash command, which takes a range of commits and compacts them into a single commit. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo/commands/arguments/squash_args.py | 19 +

Re: [edk2-devel] [PATCH] CryptoPkg/SysCall: Cast variables from 4 to 8-byte size

2019-12-12 Thread Zhang, Shenglei
Thanks, Lazslo. I will add it to the exception list on my local tool. Thanks, Shenglei > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Saturday, December 7, 2019 10:11 PM > To: devel@edk2.groups.io; Zhang, Shenglei >

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 27 December 2019 #cal-cancelled

2019-12-12 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20191213T052143Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20191227T013000Z DTEND:20191227T023000Z

Re: [edk2-devel] [PATCH v2 083/105] .mailmap: Add an entry for Shenglei Zhang

2019-12-12 Thread Zhang, Shenglei
Reviewed-by: Shenglei Zhang > -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Friday, December 6, 2019 7:26 PM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Zhang, Shenglei > > Subject: [PATCH v2 083/105] .mailmap: Add an entry for

Re: [edk2-devel] [PATCH v2] Maintainers.txt: Update email address and role

2019-12-12 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Maciej Rabeda > Sent: Wednesday, December 11, 2019 5:54 PM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH v2] Maintainers.txt: Update email address and role > > Created new email account

Re: [edk2-devel] [PATCH 69/79] ShellPkg/DynamicCommand: Fix various typos

2019-12-12 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Wednesday, December 4, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Ni, Ray ; Gao, > Zhichao ; Philippe Mathieu-Daude > > Subject: [PATCH 69/79]

Re: [edk2-devel] [PATCH 68/79] ShellPkg/Application: Fix various typos

2019-12-12 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] > Sent: Wednesday, December 4, 2019 12:16 AM > To: devel@edk2.groups.io > Cc: Antoine Coeur ; Ni, Ray ; Gao, > Zhichao ; Philippe Mathieu-Daude > > Subject: [PATCH 68/79]

Re: [edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-12-12 Thread Ni, Ray
yes. > -Original Message- > From: Tom Lendacky > Sent: Friday, December 13, 2019 4:48 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > ; Kinney, Michael D ; > Gao, Liming ; Dong, > Eric ; Brijesh Singh ; Wang, Jian > J ; Wu, Hao A > >

Re: [edk2-devel] [RFC PATCH v3 33/43] MdeModulePkg: Reserve a 16-bit protected mode code segment descriptor

2019-12-12 Thread Ni, Ray
It's not a requirement. > -Original Message- > From: Tom Lendacky > Sent: Friday, December 13, 2019 5:19 AM > To: devel@edk2.groups.io; Ni, Ray > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > ; Kinney, Michael D ; > Gao, Liming ; Dong, > Eric ; Brijesh Singh ; Wang, Jian >

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 12/13/2019 9:30am-10:30am #cal-reminder

2019-12-12 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 13 December 2019, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* BlueJeans Meeting View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=605908 ) *Organizer:* Ray Ni ray...@intel.com (

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 12/12/2019 5:00pm-5:30pm #cal-reminder

2019-12-12 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 12 December 2019, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503272 ) *Organizer:* Brian Richardson

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Make Python scripts in git_automation executable

2019-12-12 Thread Nate DeSimone
Scripts in the git_automation folder need to be executable so that git can invoke them as editor commands. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo_installer/linux-scripts/install.py | 27 ++ 1 file

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 1/1] EdkRepo: Add squash command

2019-12-12 Thread Nate DeSimone
Adds the squash command, which takes a range of commits and compacts them into a single commit. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo/commands/arguments/squash_args.py | 19 +

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V2 0/1] EdkRepo: Add squash command

2019-12-12 Thread Nate DeSimone
Changes from V2 to V1: Forget to commit the git_automation folder, added in V2. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Nate DeSimone (1): EdkRepo: Add squash command edkrepo/commands/arguments/squash_args.py | 19 +

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Add squash command

2019-12-12 Thread Nate DeSimone
Adds the squash command, which takes a range of commits and compacts them into a single commit. Cc: Ashley DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Signed-off-by: Nate DeSimone --- edkrepo/commands/arguments/squash_args.py | 19 +

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

2019-12-12 Thread Nate DeSimone
Hi Prince, Is 256KB really necessary? Could you try the 152KB (0x26000) that we had previously? Thanks, Nate -Original Message- From: Agyeman, Prince Sent: Wednesday, December 11, 2019 5:13 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A

Re: [edk2-devel] [edk2-platforms][PATCH 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

2019-12-12 Thread Jeremy Linton
Hi, On Thu, Dec 12, 2019 at 7:35 AM Ard Biesheuvel wrote: > > On Thu, 12 Dec 2019 at 11:55, Pete Batard wrote: > > > > From: Jeremy Linton > > > > Signed-off-by: Pete Batard > > --- > > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | > > 1432 >

Re: [edk2-devel] [RFC PATCH v3 35/43] UefiCpuPkg/MpInitLib: Add a CPU MP data flag to indicate if SEV-ES is enabled

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 1:01 AM, Ni, Ray wrote: > OK I see now the Enable PCD is defined in MdeModulePkg, produced in platform > and consumed in MpInitLib. > > Is there a way to easily detect whether SEV-ES is enabled? (without > triggering CPUID as what SEC does) No, I would need to read an MSR and I

Re: [edk2-devel] [RFC PATCH v3 33/43] MdeModulePkg: Reserve a 16-bit protected mode code segment descriptor

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:57 AM, Ni, Ray via Groups.Io wrote: > Is the 16bit code segment descriptor needed in early DXE before CpuDxe (DXE > MP)? I don't believe it is. I did this to keep all of the CS descriptors consistent since the ones here seemed to line up with the ones in

Re: [edk2-devel] [RFC PATCH v3 28/43] OvmfPkg: Create GHCB pages for use during Pei and Dxe phase

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:54 AM, Ni, Ray wrote: >> + // Allocate GHCB and per-CPU variable pages. >> + // >> + GhcbPageCount = mMaxCpuCount * 2; >> + GhcbBase = AllocatePages (GhcbPageCount); >> + ASSERT (GhcbBase != NULL); >> + >> + GhcbBasePa = (PHYSICAL_ADDRESS)(UINTN) GhcbBase; >> + >> +

Re: [edk2-devel] [RFC PATCH v3 04/43] MdeModulePkg/DxeIplPeim: Support GHCB pages when creating page tables

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:53 AM, Ni, Ray wrote: > Tom, > When are GHCP pages are allocated? Can DxeIpl gets the address by reading the > GHCB MSR? > > Can the GHCB PCD be eliminated by updating all GHCB address consumer to read > the GHCB MSR? The non-SEC GHCB pages are allocated in PEI. DxeIpl should be

Re: [edk2-devel] [RFC PATCH v3 01/43] MdePkg: Create PCDs to be used in support of SEV-ES

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:53 AM, Ni, Ray wrote: > Do you really need to define the PCD in MdePkg? > General guide lines are: > 1. Avoid UefiCpuPkg depend on MdeModulePkg. > 2. Do not define platform level PCD in core pkgs (MdePkg, MdeModulePkg, > UefiCpuPkg, etc) > > > PcdSevEsIsEnabled seems to be used

Re: [edk2-devel] [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:53 AM, Ni, Ray wrote: > Tom, > Why all DR registers are not pushed to stack in VC handler? > I thought only DR7 pushing is skipped. It was probably just to be on the safe side in case the hypervisor didn't remove the intercept for them. And since none of the other debug registers

Re: [edk2-devel] [RFC PATCH v3 22/43] UefiCpuPkg/CpuExceptionHandler: Add support for DR7 Read/Write NAE events

2019-12-12 Thread Lendacky, Thomas
On 12/12/19 12:53 AM, Ni, Ray wrote: >> >> ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >> +cmp qword [rbp + 8], 29 > > Can you define a macro instead of using 29? Yes, I can do that. Thanks, Tom > >> +je VcDebugRegs ; For SEV-ES (#VC) Debug registers ignored > >

[edk2-devel] [edk2] [PATCH 1/2] MdeModulePkg/Usb/EfiKey: Fix endpoint selection

2019-12-12 Thread MrChromebox
>From e7648a8c3efae0540586ad497a5366ffd0c87fb7 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 12 Dec 2019 12:46:47 -0600 Subject: [PATCH 1/2] MdeModulePkg/Usb/EfiKey: Fix endpoint selection The endpoint selected by the driver needs to not only be an interrupt type, but have direction

[edk2-devel] [edk2] [PATCH 2/2] MdeModulePkg/Usb/UsbMouse: Fix endpoint selection

2019-12-12 Thread MrChromebox
>From 2a8e343f8a5848825d3d12ba76df0fb4212ab5b8 Mon Sep 17 00:00:00 2001 From: Matt DeVillier Date: Thu, 12 Dec 2019 12:54:14 -0600 Subject: [PATCH 2/2] MdeModulePkg/Usb/UsbMouse: Fix endpoint selection The endpoint selected by the driver needs to not only be an interrupt type, but have direction

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Vladimir Olovyannikov via Groups.Io
Sami, I follow your reply style below. > -Original Message- > From: Sami Mujawar > Sent: Thursday, December 12, 2019 10:33 AM > To: Vladimir Olovyannikov ; Ard > Biesheuvel > Cc: devel@edk2.groups.io; nd ; Matteo Carlini > ; Laura Moretta > Subject: RE: Debugging aarch64 edk2 built with

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Sami Mujawar
Hi Vladimir, Please find may response marked [SAMI] Regards, Sami Mujawar -Original Message- From: Vladimir Olovyannikov Sent: 12 December 2019 05:51 PM To: Sami Mujawar ; Ard Biesheuvel Cc: devel@edk2.groups.io; nd Subject: RE: Debugging aarch64 edk2 built with gcc-8.x 64-bit arm

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

2019-12-12 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, December 11, 2019 5:13 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-12-12 Thread Jeff Brasen
Thanks for the summary Ray, for the problem summary only thing I would add would be that platform also wants to create/modify boot options when full enumeration is requested as well. For solutions I prefer option 2 as we don't have to put the same logic everywhere of how to modify the default

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Vladimir Olovyannikov via Groups.Io
> -Original Message- > From: Sami Mujawar > Sent: Thursday, December 12, 2019 8:07 AM > To: Ard Biesheuvel ; Vladimir Olovyannikov > > Cc: edk2-devel-groups-io ; nd > Subject: RE: Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler > > Hi Vladimir, > > I have built the edk2

Re: [edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-12 Thread Sami Mujawar
Hi Vladimir, I have built the edk2 firmware using the following toolchains and find that the symbols are loaded correctly using DS5. - gcc-arm-8.3-2019.03-x86_64-aarch64-elf.tar.xz - gcc-arm-8.3-2019.03-x86_64-aarch64-linux-gnu.tar.xz The above toolchains are available at

Re: [edk2-devel] [edk2-platforms][PATCH 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

2019-12-12 Thread Ard Biesheuvel
On Thu, 12 Dec 2019 at 11:55, Pete Batard wrote: > > From: Jeremy Linton > > Signed-off-by: Pete Batard > --- > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | > 1432 > Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf |

Re: [edk2-devel] [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

2019-12-12 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Thursday, December 12, 2019 9:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH] WhiskeylakeOpenBoardPkg: Update PCDs >

Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances

2019-12-12 Thread Liming Gao
Thanks for your test. Reviewed-by: Liming Gao > -Original Message- > From: Gao, Zhichao > Sent: Thursday, December 12, 2019 5:15 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Gao, Liming > > Cc: Kinney, Michael D ; Vitaly Cheptsov > > Subject: RE: [edk2-devel] [PATCH V2 0/2]

[edk2-devel] [edk2-platforms][PATCH 1/4] Silicon/Bcm27xx: Add PCIe constants to Bcm2711.h

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Bcm27xx.dec| 4 ++ Silicon/Broadcom/Bcm27xx/Include/IndustryStandard/Bcm2711.h | 71 2 files changed, 75 insertions(+) diff --git a/Silicon/Broadcom/Bcm27xx/Bcm27xx.dec

[edk2-devel] [edk2-platforms][PATCH 0/4] Platform/RPi4: Add PCIe and xHCI support

2019-12-12 Thread Pete Batard
The following patch series adds xHCI support for the Broadcom 2711 SoC used on the Raspberry Pi 4 by: * Adding the relevant constants to the Silicon header files * Adding the segment library required to handle the nonstandrd ECAM that the SoC uses. Basically, in the Bcm2711, root port is the

[edk2-devel] [edk2-platforms][PATCH 2/4] Silicon/Bcm27xx: Add segment library to handle nonstandard ECAM

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.c | 1432 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciSegmentLib/PciSegmentLib.inf | 34 + 2 files changed, 1466 insertions(+) diff --git

[edk2-devel] [edk2-platforms][PATCH 4/4] Platform/RPi4: Build the PCIe and xHCI drivers into the firmware

2019-12-12 Thread Pete Batard
From: Jeremy Linton This uses the recently introduced NonCoherentIoMmuDxe for PCIe access and should enable USB device usage in the UEFI environment. As mentioned in https://lkml.org/lkml/2019/9/9/170, imposing a 3 GB DMA limit might be necessary for the 4 GB models so we follow suit by setting

[edk2-devel] [edk2-platforms][PATCH 3/4] Silicon/Bcm27xx: Add PCIe host bridge config library

2019-12-12 Thread Pete Batard
From: Jeremy Linton Signed-off-by: Pete Batard --- Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.c | 193 Silicon/Broadcom/Bcm27xx/Library/Bcm2711PciHostBridgeLib/Bcm2711PciHostBridgeLib.inf | 51 +

Re: [edk2-devel] [PATCH V2 0/2] MdePkg/UefiDevicePathLib: Separate the lib instances

2019-12-12 Thread Gao, Zhichao
I have ported a test case from SCT to test the interfaces in UefiDevicePathLibMandatoryDevicePathProtocol.c and UefiDevicePathLibOptionalDevicePathProtocol.c only. And I do the test on Ovmf environment for two configuration: one is include DevicePathDxe, and the other is not. Optional one lib

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

2019-12-12 Thread Bob Feng
Hi Pierre, Currently, I don’t have good solution for this issue. I considered the solution that I mentioned before, I don’t think that is a good solution either. As you mentioned that to split one feature into 2 modules is not good, and now there is no way to describe the dependency of those

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2019-12-12 Thread Ard Biesheuvel
On Thu, 12 Dec 2019 at 09:59, Ni, Ray wrote: > > Ard, > I still cannot understand it. > > Since Driver are processed (process = LoadImage + StartImage) after > EndOfDxe, they are not deferred. > It means the Driver entrypoints are called directly. > Inside the entrypoints, driverbinding

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2019-12-12 Thread Ni, Ray
Ard, I still cannot understand it. Since Driver are processed (process = LoadImage + StartImage) after EndOfDxe, they are not deferred. It means the Driver entrypoints are called directly. Inside the entrypoints, driverbinding protocols are installed. After that,

Re: [edk2-devel] [RFC PATCH v2 42/44] UefiCpuPkg/MpInitLib: Prepare SEV-ES guest APs for OS use

2019-12-12 Thread Ni, Ray
Tom, why this cannot be done as today's code in ExitBS callback? Because it should be done after interrupt is disabled? > -Original Message- > From: Lendacky, Thomas > Sent: Friday, September 20, 2019 3:53 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard