Re: [edk2-devel] [PATCH v2] SecurityPkg/Tpm2Help.c: Add boundary check for array

2019-12-15 Thread Yao, Jiewen
I don't think it is good idea to *ignore* the error. If you don't assert, please stop processor and return error. > -Original Message- > From: Zhang, Shenglei > Sent: Monday, December 16, 2019 3:53 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B >

[edk2-devel] [PATCH v2] SecurityPkg/Tpm2Help.c: Add boundary check for array

2019-12-15 Thread Zhang, Shenglei
Add 'Index < HASH_COUNT' to ensure things out of digests[] can not be visited. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- v2: Remove the comma operator and use &&. SecurityPkg/Library/Tpm2CommandLib/Tpm2Help.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [edk2-devel] [PATCH] SecurityPkg/Tpm2Help.c: Add boundary check for array

2019-12-15 Thread Zhang, Shenglei
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, December 6, 2019 5:27 PM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Yao, Jiewen ; Wang, Jian J > ; Zhang, Chao B > Subject: Re: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH] SecurityPkg/Tpm2Help.c: Add boundary check for array

2019-12-15 Thread Zhang, Shenglei
> -Original Message- > From: Yao, Jiewen > Sent: Friday, December 6, 2019 10:04 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: RE: [PATCH] SecurityPkg/Tpm2Help.c: Add boundary check for array > > Hi > May I know where is the data from?

Re: [edk2-devel] [Patch 1/1] BaseTools/Scripts: Add package dependency graphing tool

2019-12-15 Thread Ni, Ray
Mike, 2 minor comments regarding the help string in below. > -Original Message- > From: Kinney, Michael D > Sent: Saturday, December 14, 2019 3:45 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Feng, Bob C ; Gao, > Liming ; Sean Brogan ; > Bret Barkelew > Subject: [Patch 1/1]

Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids

2019-12-15 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Saturday, December 14, 2019 9:32 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook >

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Build ASL files before C files

2019-12-15 Thread PierreGondois
Hello Bob, > I think if we can describe the dependency between source files in INF file. > For example, > [Sources.IA32] >   asl_source.asl >   c_source.c | asl_source.asl This looks good to me! Would it be possible to have multiple dependencies on one file (1), or would it be limited to one

Re: [edk2-devel] [edk2-platforms] [PATCH v2] WhiskeylakeOpenBoardPkg: Update PCDs to enable stack sharing

2019-12-15 Thread Chiu, Chasel
Hi Nate, Prince, I would recommend that we set larger gSiPkgTokenSpaceGuid.PcdPeiTemporaryRamStackSize so we do not have to update this again and again later when required temporary ram increased by enabling some boot loader features. How about set it to 0x3? Thanks, Chasel >