[edk2-devel] [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition.

2019-12-20 Thread Yao, Jiewen
Since official TCG definition is added to MdePkg, IntelPciDeviceSecurityDxe should not define its own TCG event log. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Jiewen Yao --- .../IntelPciDeviceSecurityDxe.c | 19 ++-- .../IntelPciDeviceSecurityDxe.inf | 1 -

Re: [edk2-devel] [edk2-platforms] [PATCH 02/11] BoardModulePkg: Add BDS Hook Library

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:32 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 02/11] BoardModulePkg: Add BDS Hook >

Re: [edk2-devel] [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS Board Boot Manager library

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kubacki, > Michael A > Subject: [edk2-platforms] [PATCH 10/11] SimicsOpenBoardPkg: Add BDS > Board Boot Manager

Re: [edk2-devel] [edk2-platforms] [PATCH 06/11] BoardModulePkg: Add Generic BoardBootManagerLib

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 06/11] BoardModulePkg: Add Generic >

Re: [edk2-devel] [edk2-platforms] [PATCH 09/11] SimicsOpenBoardPkg: Add Bds Hook Library

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Kubacki, > Michael A > Subject: [edk2-platforms] [PATCH 09/11] SimicsOpenBoardPkg: Add Bds > Hook Library > >

Re: [edk2-devel] [edk2-platforms] [PATCH 05/11] MinPlatformPkg: Add BDS Hook Points

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 05/11] MinPlatformPkg: Add BDS Hook >

Re: [edk2-devel] [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook Point Guids

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:32 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 01/11] MinPlatformPkg: Add BDS Hook >

Re: [edk2-devel] [edk2-platforms] [PATCH 04/11] MinPlatformPkg: Add BDS Board Boot Manager library

2019-12-20 Thread Kubacki, Michael A
Since BoardBootManagerWaitCallback () is a new function, please add @param[in] for the TimeoutRemain parameter. With that change - Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc:

Re: [edk2-devel] [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds Hook Points

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 11/11] SimicsOpenBoardPkg: Add Bds >

Re: [edk2-devel] [edk2-platforms] [PATCH 03/11] BoardModulePkg: Add BDS Hook DXE Driver

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:32 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 03/11] BoardModulePkg: Add BDS Hook >

Re: [edk2-devel] [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add BDS Hook Dxe Driver

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 08/11] WhiskeylakeOpenBoardPkg: Add >

Re: [edk2-devel] [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS Hook Dxe Driver

2019-12-20 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, December 13, 2019 5:33 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [PATCH 07/11] KabylakeOpenBoardPkg: Add BDS >

[edk2-devel] [PATCH 1/2] SdMmcPciHcDxe: Send EdkiiSdMmcSwitchClockFreq after SD clock start

2019-12-20 Thread Albecki, Mateusz
For eMMC modules we used to notify the platform about frequency change only after sending CMD13 which meant that platform might not get a chance to apply required post frequency change fixes to get the clock stable. To fix this notification has been moved to SdMmcHcClockSupply function just after

[edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcPciHcDxe: Add function to start SD clock

2019-12-20 Thread Albecki, Mateusz
In SD card voltage switch flow we used to redo the entire internal clock setup after voltage switch. Since internal clock has already been setup this is wasting time on polling the internal clock stable. This commit changes it to only start the SD clock. Cc: Hao A Wu Cc: Marcin Wojtas Cc:

[edk2-devel] [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the EdkiiSdMmcSwitchClockFreq notification before sending CMD13

2019-12-20 Thread Albecki, Mateusz
The first patch refactors the SdMmcClockSupply function with a goal of sending the EdkiiSdMmcSwitchClockFreq notification before we send the CMD13 to check the switch status in eMMC init flow. This is required to avoid sending the CMD13 on link that still has not been fixed by platform. To avoid

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 18/39] RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library.

2019-12-20 Thread Abner Chang
> -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, December 19, 2019 2:00 PM > To: devel@edk2.groups.io; leif.lindh...@linaro.org > Cc: Chen, Gilbert > Subject: RE: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v3 18/39] > RiscVPkg/Library: Add EDK2

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2019-12-20 Thread Wang, Sunny (HPS SW)
Good point. The way you used is more robust. It can cover a mistake in function's error handling. Thanks for clarifying this, Ashish. In addition, the other naming suggestion just comes to mind. How about we rename the function to a more generic one (based on location) like

Re: [edk2-devel] reg: HTTPS Certificate Update

2019-12-20 Thread Sivaraman Nainar
Thanks Jiaxin for the prompt reply. Created ticket : https://bugzilla.tianocore.org/show_bug.cgi?id=2433 From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wu, Jiaxin Sent: Friday, December 20, 2019 3:17 PM To: Sivaraman Nainar; devel@edk2.groups.io; Fu, Siyuan; Rabeda, Maciej

Re: [edk2-devel] reg: HTTPS Certificate Update

2019-12-20 Thread Wu, Jiaxin
Hi Siva, I agree we should continue the next certificates configuration even the current one is invalid (since we already have the sanity check before the setting). Please report one Bugzilla for the issue. Maciej, can you help fix on that? Thanks, Jiaxin From: Sivaraman Nainar Sent:

[edk2-devel] [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e

2019-12-20 Thread Bob Feng
8b72f720d53e introduced a regression bug that make GenBiosId failed if -ot is passed to this tool. This patch is going to fix it. Cc: Liming Gao Cc: Kilian Kegel Signed-off-by: Bob Feng --- Platform/Intel/Tools/GenBiosId/GenBiosId.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [edk2-devel] [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB

2019-12-20 Thread Ni, Ray
Reviewed-by:Ray Ni -- Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#52456): https://edk2.groups.io/g/devel/message/52456 Mute This Topic: https://groups.io/mt/68846551/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB

2019-12-20 Thread Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2404 Set the below two environment variables in edksetup.bat: set CLANG_HOST_BIN=n set CLANG_BIN=C:\Program Files\LLVM\bin\ In Windows, set CLANG_HOST_BIN=n to use nmake command The CLANG_BIN is only be set if it is not defined. Cc: Liming

Re: [edk2-devel] [PATCH] [edk2/BaseTools] edksetup.bat stuck on unicode locale Windows

2019-12-20 Thread Bob Feng
Hi Aiden, Thanks for clarifying this issue. Since I have no Unicode locales windows environment, I can't help to do the verification. For the following 2# message = stdout.decode(encoding='utf-8', errors='ignore').encode('utf-8'), after encode(), on python3, the message will not a string,