Re: [edk2-devel] [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

Reviewed-by: Ray Ni > -Original Message- > From: Tsao, Ethan > Sent: Monday, December 23, 2019 2:35 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chaganty, Rangasai V > > Subject: [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h > >

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs

Hi Ray, > -Original Message- > From: Ni, Ray > Sent: Monday, December 23, 2019 3:38 PM > To: devel@edk2.groups.io; Dong, Eric > Cc: Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: > Remove dependence between APs > > > > > + WaitForSemaphore

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue.

Reviewed-by: Ray Ni > -Original Message- > From: Dong, Eric > Sent: Monday, December 23, 2019 2:48 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek > Subject: [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow > issue. > > The size for the array of

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs

> > + WaitForSemaphore (>RunningApCount); > + > + if (Token->RunningApCount == 0) { > +ReleaseSpinLock (Token->SpinLock); >} 1. if (InterlockedDecrement (>RunningApCount) == 0) { ReleaseSpinLock (Token->SpinLock); } We should avoid checking RunningApCount directly because

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs.

Hi Ray, > -Original Message- > From: Ni, Ray > Sent: Friday, December 20, 2019 2:15 PM > To: Dong, Eric mailto:eric.d...@intel.com>>; > devel@edk2.groups.io > Cc: Laszlo Ersek mailto:ler...@redhat.com>> > Subject: RE: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Remove

[edk2-devel] [Patch 0/2] UefiCpuPkg/CpuCommonFeaturesLib: Set SMXE bit of CR4 when SMX is enabled.

From: Jason Voelz Jason Voelz (2): MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should set UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c | 9 + MdePkg/Include/Library/BaseLib.h

[edk2-devel] [Patch 2/2] UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should set

From: Jason Voelz Add code to set SMXE in CR4 in the SmxInitialize flow when SMX is enabled. Signed-off-by: Jason Voelz Cc: Ray Ni --- UefiCpuPkg/Library/CpuCommonFeaturesLib/FeatureControl.c | 9 + 1 file changed, 9 insertions(+) diff --git

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2268 In current implementation, when check whether APs called by StartUpAllAPs or StartUpThisAp, it checks the Tokens value used by other APs. Also the AP will update the Token value for itself if its task finished. In this case, the potential

[edk2-devel] [PATCH v2 0/2] Fix potential race condition issue.

This patch serial 1. patch 1 fixed potential race condition issue for PiSmmCpuDxeSmm. 2. Patch 2 fixed a potential buffer overflow issue. Cc: Ray Ni Cc: Laszlo Ersek Eric Dong (2): UefiCpuPkg/PiSmmCpuDxeSmm: Remove dependence between APs UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix buffer overflow issue.

The size for the array of mSmmMpSyncData->CpuData[] is 0 ~ mMaxNumberOfCpus -1. But current code may use mSmmMpSyncData->CpuData[mMaxNumberOfCpus]. This patch fixed this issue. Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Eric Dong --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 16

[edk2-devel] [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Create header for BaseConfigBlockLib Signed-off-by: Ethan Tsao Cc: Ray Ni Cc: Sai Chaganty --- Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70 ++

[edk2-devel] [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Create header for BaseConfigBlockLib Signed-off-by: Ethan Tsao --- Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70 ++ 1 file changed, 70

Re: [edk2-devel] [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition.

Yes. I will. Thank you Yao Jiewen > -Original Message- > From: Ni, Ray > Sent: Monday, December 23, 2019 10:00 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG > definition. > > > > > -

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

Please ignore patch 5. I have sent patch 6 for consideration. Thanks Ashish -Original Message- From: Ashish Singhal Sent: Sunday, December 22, 2019 7:09 PM To: Ni, Ray ; devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A ; Gao, Zhichao Subject: RE: [PATCH v4] MdeModulePkg: Add EDK2

[edk2-devel] [PATCH v6] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

Add edk2 platform boot manager protocol which would have platform specific refreshes to the auto enumerated as well as NV boot options for the platform. Signed-off-by: Ashish Singhal --- .../Include/Protocol/PlatformBootManager.h | 82 ++

Re: [edk2-devel] [PATCH] IntelSiliconPkg/IntelPciDeviceSecurity: Use EDKII TCG definition.

> > - PcrIndex = EDKII_DEVICE_MEASUREMENT_COMPONENT_PCR_INDEX; > + PcrIndex = 2; Jiewen, PcrIndex assignment is using magic value 2 here. I am ok with this magic value. Can you please add comment to say that this PCR is a device measurement component PCR? With that, Reviewed-by: Ray Ni

Re: [edk2-devel] [PATCH v4] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

+ typedef struct _PLATFORM_BOOT_MANAGER_PROTOCOL PLATFORM_BOOT_MANAGER_PROTOCOL; Ashish, Please add EDKII_ prefix to the protocol structure as well: EDKII_PLATFORM_BOOT_MANAGER_PROTOCOL. I see you already added the prefix to the GUID name. Thanks, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

Re: [edk2-devel] [PATCH V2] [edk2/BaseTools] edksetup.bat stuck on unicode locale Windows

Reviewed-by: Bob Feng -Original Message- From: Park, Aiden Sent: Saturday, December 21, 2019 2:25 AM To: Feng, Bob C ; devel@edk2.groups.io Subject: [PATCH V2] [edk2/BaseTools] edksetup.bat stuck on unicode locale Windows This issue happens under two conditions. 1. Unicode language

Re: [edk2-devel] [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e

Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Friday, December 20, 2019 4:42 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kilian Kegel > > Subject: [Patch] GenBiosId: Fixed a regression bug introduced by 8b72f720d53e > > 8b72f720d53e introduced a

Re: [edk2-devel] [PATCH V3 0/2] *MdePkg/UefiDevicePathLib: Separate the lib instances

Ray, Your suggestion is good for open source, but unfriendly to the close source platforms which consume this lib. Hi Mike/Liming/Ray/Others, Do we have a progress to retire lib/API/others in the open source, like below? 1. Announce that there is something going to retire. 2. Suggestion to