Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious check for pointer Suite

2020-03-03 Thread Zhang, Shenglei
Reviewed-by: Shenglei Zhang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Wednesday, February 19, 2020 10:35 AM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [PATCH] UnitTestFrameworkPkg: Suspicious

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Wang, Sunny (HPS SW)
Sure! Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray Sent: Wednesday, March 4, 2020 3:26 PM To: devel@edk2.groups.io; Wang, Sunny (HPS SW) ; Sean Brogan ; Kinney, Michael D Cc: Wei, Kent (HPS SW) ; Spottswood, Jason

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Ni, Ray
Sunny, Let's discuss in this week's meeting to see whether the below enhancement proposal can be aligned first. Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Sunny > (HPS SW) > Sent: Wednesday, March 4, 2020 12:12 PM > To: devel@edk2.groups.io; Ni,

[edk2-devel] [PATCH edk2-platforms 1/1] DeveloperBox: implement measured boot

2020-03-03 Thread Ard Biesheuvel
Enable the various components, library class resolutions and PCD defaults to enable measured boot based on a version 2 TPM. The TPM is exposed as having a memory mapped TIS frame, which is accomplished using the SPI command sequencer that is available on this platform. Note that this requires SCP

[edk2-devel] [edk2/master PATCH RISC-V CI v1 2/6] RiscVPkg: Add RiscVPkg yaml file for EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 Add yaml file for EDK2 CI testing on RiscVPkg. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Gilbert Chen Cc: Daniel Helmut Schaefer --- RiscVPkg/RiscVPkg.ci.yaml | 80

[edk2-devel] [edk2/master PATCH RISC-V CI v1 6/6] .pytool: Add RISC-V architecture on RISC-V EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 Add RISC-V architecture on RISC-V EDK2 CI testing. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Michael D Kinney Cc: Gilbert Chen Cc: Daniel Helmut Schaefer --- .pytool/CISettings.py | 15

[edk2-devel] [edk2/master PATCH RISC-V CI v1 0/6] RISC-V EDK2 CI configuration files.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 This set of patches enale RISC-V architecture on EDK2 CI test process. The external dependency of toolchain for RISCV64 architecture is retrieved from:

[edk2-devel] [edk2/master PATCH RISC-V CI v1 3/6] MdeModulePkg: Revise MdeModulePkg yaml file for RISC-V EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 Revise yaml file for EDK2 CI testing on RISC-V architecture. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Gilbert Chen Cc: Daniel Helmut Schaefer ---

[edk2-devel] [edk2/master PATCH RISC-V CI v1 5/6] .azurepipelines: Add RISC-V architecture on RISC-V EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 Add RISC-V architecture on RISC-V EDK2 CI. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Michael D Kinney Cc: Gilbert Chen Cc: Daniel Helmut Schaefer --- .azurepipelines/Ubuntu-GCC5.yml | 3

[edk2-devel] [edk2/master PATCH RISC-V CI v1 1/6] RiscVPlatformPkg: Add RiscVPlatformPkg yaml file for EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 Add yaml file for EDK2 CI testing on RiscVPlatformPkg. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Leif Lindholm Cc: Gilbert Chen Cc: Daniel Helmut Schaefer --- RiscVPlatformPkg/RiscVPlatformPkg.ci.yaml |

[edk2-devel] [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI.

2020-03-03 Thread Abner Chang
BZ:2562: https://bugzilla.tianocore.org/show_bug.cgi?id=2562 EDK CI for RISC-V architecture Enable RISC-V architecture for RISC-V EDK2 CI testing. Signed-off-by: Abner Chang Cc: Bret Barkelew Cc: Sean Brogan Cc: Bob Feng Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Gilbert

[edk2-devel] EDK II Stable Tag edk2-stable202002 will be created based on commit 4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70

2020-03-03 Thread Liming Gao
Hi, all edk2-stable202002 tag will be created on Mar 4th (UTC-8 00:00:00). It will base on current edk2 trunk (the latest commit https://github.com/tianocore/edk2/commit/4c0f6e349d32cf27a7104ddd3e729d6ebc88ea70 UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors). If you have any

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Wang, Sunny (HPS SW)
Sorry for not making any progress since last meeting. Sure! I will work on enhancing the variable policy to support partial protection and recovery. However, the update will be late because I need to first deal with other urgent stuff. By the way, thanks for giving a lot of valuable comments at

Re: [edk2-devel] TianoCore Community Design Meeting Minutes - Feb 21, 2020

2020-03-03 Thread Ni, Ray
Variable policy works well on protecting a whole variable. But the BootOrder in Sunny's case may require a partial protection, which means portion of the variable buffer needs to be read-only. Today's variable policy proposal doesn't take this into consideration. If we could enhance variable

[edk2-devel] [PATCH v1 2/2] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

2020-03-03 Thread Ming Huang
When occur reclaim in AutoUpdateLangVariable(), the CurrPtr of Variable is invalid. The State will be update with wrong position after UpdateVariable in this situation and two valid PlatformLang or Lang variables will exist. BmForEachVariable() will enter endless loop while exist two valid

[edk2-devel] [PATCH v1 0/2] Fix two issue in variable

2020-03-03 Thread Ming Huang
There are two infrequent issues in variable. Ming Huang (2): MdeModulePkg/Variable: Remove some debug print for runtime MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable .../Universal/Variable/RuntimeDxe/Variable.c | 44 ++-- 1 file changed, 21

[edk2-devel] [PATCH v1 1/2] MdeModulePkg/Variable: Remove some debug print for runtime

2020-03-03 Thread Ming Huang
System will hang at debug print if enter RecordVarErrorFlag in runtime. This patch fix hang issue when run fwts in OS: fwts uefirtmisc Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ming Huang --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 18

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Liming Gao
Marvin: I will add this feature into next stable tag planning. Let's try to finish it for next stable tag. Thanks Liming -Original Message- From: devel@edk2.groups.io On Behalf Of Marvin Häuser Sent: 2020年3月4日 3:39 To: Andrew Fish ; devel@edk2.groups.io Cc: Kinney, Michael D ;

Re: [edk2-devel] [PATCH v5 09/42] UefiPayloadPkg: Prepare UefiPayloadPkg to use the VmgExitLib library

2020-03-03 Thread Guo Dong
It looks good to me. Reviewed-by: Guo Dong Thanks, Guo > -Original Message- > From: devel@edk2.groups.io On Behalf Of Lendacky, > Thomas > Sent: Monday, March 2, 2020 4:07 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel ; Kinney, > Michael D ;

Re: [edk2-devel] Disabling safe string constraint assertions

2020-03-03 Thread Andrew Fish via Groups.Io
Vitaly, I was planing on bringing it up at the Stewards meeting that was scheduled for today, but it got rescheduled to next week. So if we don't get traction on the mailing list I'll bring it up in the meeting. > On Mar 3, 2020, at 1:12 PM, Vitaly Cheptsov wrote: > > Hello, > > I am

Re: [edk2-devel] [PATCH v4 6/7] OvmfPkg IA32: add support for loading X64 images

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 21:54, Laszlo Ersek wrote: > > On 03/03/20 15:01, Ard Biesheuvel wrote: > > This is the UEFI counterpart to my Linux series which generalizes > > mixed mode support into a feature that requires very little internal > > knowledge about the architecture specifics of booting

Re: [edk2-devel] [PATCH v4 7/7] OvmfPkg/LinuxInitrdDynamicShellCommand: bail if initrd already exists

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 22:08, Laszlo Ersek wrote: > > On 03/03/20 22:03, Laszlo Ersek wrote: > > On 03/03/20 15:01, Ard Biesheuvel wrote: > >> Before taking any actions, check if an instance of the LoadFile2 exists > >> already on the Linux initrd media GUID device path, and whether it was > >>

[edk2-devel] Disabling safe string constraint assertions

2020-03-03 Thread Vitaly Cheptsov
Hello, I am creating a new thread for this issue, as for some reason half of my messages do not display in the web-interface and some of e-mail clients in the previous one. It seems that somebody sent broken HTML code to groups.io , and it did not like to be quoted. It will

Re: [edk2-devel] [PATCH v4 7/7] OvmfPkg/LinuxInitrdDynamicShellCommand: bail if initrd already exists

2020-03-03 Thread Laszlo Ersek
On 03/03/20 22:03, Laszlo Ersek wrote: > On 03/03/20 15:01, Ard Biesheuvel wrote: >> Before taking any actions, check if an instance of the LoadFile2 exists >> already on the Linux initrd media GUID device path, and whether it was >> provided by this command. If so, abort, since no duplicate

Re: [edk2-devel] [PATCH v4 7/7] OvmfPkg/LinuxInitrdDynamicShellCommand: bail if initrd already exists

2020-03-03 Thread Laszlo Ersek
On 03/03/20 15:01, Ard Biesheuvel wrote: > Before taking any actions, check if an instance of the LoadFile2 exists > already on the Linux initrd media GUID device path, and whether it was > provided by this command. If so, abort, since no duplicate instances of > the device path should exist. > >

Re: [edk2-devel] [PATCH v4 6/7] OvmfPkg IA32: add support for loading X64 images

2020-03-03 Thread Laszlo Ersek
On 03/03/20 15:01, Ard Biesheuvel wrote: > This is the UEFI counterpart to my Linux series which generalizes > mixed mode support into a feature that requires very little internal > knowledge about the architecture specifics of booting Linux on the > part of the bootloader or firmware. > >

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Andrew Fish via Groups.Io
Marvin, If no one else objects to your proposal I don't want to block forward progress. My main intent was to have a conversation about this topic. > On Feb 20, 2020, at 2:18 AM, Marvin Häuser wrote: > > Hey Andrew, > > Thanks once again for your comments, mine are inline. > > Best

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Marvin Häuser
Good day, Unfortunately, this discussion has died again. This is fine by me, I'm also fine with the already proposed patch and mostly shared different approaches based on the vastly diverging feedback, but it works for us either way. Can the patch please be reviewed and accepted for the next

Re: [edk2-devel][PATCH v2 6/6] Platform/RPi/ConfigDxe: Improve RPi configuration form

2020-03-03 Thread Andrei Warkentin via Groups.Io
Nevermind, I missed all the current reviews and the code is already in. A From: devel@edk2.groups.io on behalf of Andrei Warkentin via Groups.Io Sent: Tuesday, March 3, 2020 11:17 AM To: Pete Batard; devel@edk2.groups.io Cc: ard.biesheu...@linaro.org;

Re: [edk2-devel][PATCH v2 6/6] Platform/RPi/ConfigDxe: Improve RPi configuration form

2020-03-03 Thread Andrei Warkentin via Groups.Io
Reviewed-by: Andrei Warkentin From: Pete Batard Sent: Tuesday, March 3, 2020 8:08 AM To: devel@edk2.groups.io Cc: ard.biesheu...@linaro.org; l...@nuviainc.com; phi...@redhat.com; Andrei Warkentin Subject: [edk2-devel][PATCH v2 6/6]

Re: [edk2-devel] [PATCH v5 36/42] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with SEV-ES is enabled

2020-03-03 Thread Lendacky, Thomas
On 3/3/20 6:33 AM, Laszlo Ersek wrote: > Hi Tom, > > On 03/03/20 00:07, Lendacky, Thomas wrote: >> BZ: >>

Re: [edk2-devel] [PATCH v5 34/42] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2020-03-03 Thread Lendacky, Thomas
On 3/3/20 7:29 AM, Laszlo Ersek wrote: > Hi Tom, > > On 03/03/20 00:07, Lendacky, Thomas wrote: >> BZ: >>

Re: [edk2-devel][PATCH v2 0/6] Platform/RPi: User config improvements

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 14:08, Pete Batard wrote: > > Changes from v1: > * Split first commit into 2 patches. > * Clarify commit message for 3/6 and remove extra line-removal hunk. > * Improve and clarify computation of 3G+ segment size in > ConfigDxe.c/ApplyVariables (). > * Minor whitespace

[edk2-devel] [PATCH v4 3/7] ArmVirtPkg: add the 'initrd' dynamic shell command

2020-03-03 Thread Ard Biesheuvel
Add the 'initrd' dynamic shell command to the build so we can load Linux initrds straight from the shell using the new generic protocol, which does not rely on initrd= being passed on the command line. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2564 Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH v4 4/7] OvmfPkg: add the 'initrd' dynamic shell command

2020-03-03 Thread Ard Biesheuvel
Add the 'initrd' dynamic shell command to the build so we can load Linux initrds straight from the shell using the new generic protocol, which does not rely on initrd= being passed on the command line. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2564 Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH v4 5/7] MdeModulePkg/DxeCore: defer PE/COFF emulator registration to StartImage

2020-03-03 Thread Ard Biesheuvel
EDK2's implementation of the LoadImage() boot service permits non-native binaries to be loaded (i.e., X64 images on IA32 firmware), but any attempts to start such an image using StartImage() will return EFI_UNSUPPORTED. The integration of the PE/COFF emulator protocol into the DXE core deviates

[edk2-devel] [PATCH v4 2/7] OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path

2020-03-03 Thread Ard Biesheuvel
Add a new 'initrd' command to the UEFI Shell that allows any file that is accessible to the shell to be registered as the initrd that is returned when Linux's EFI stub loader invokes the LoadFile2 protocol on its special vendor media device path. Ref:

[edk2-devel] [PATCH v4 0/7] OvmfPkg: implement initrd shell command and mixed mode loader

2020-03-03 Thread Ard Biesheuvel
This series is part of my effort to define a generic EFI boot protocol for Linux, i.e,. one that is the same across all different architectures that are able to boot Linux from EFI, and naturally reused the firmware's infrastructure for authenticated boot and measured boot. Path #1 ... #4

[edk2-devel] [PATCH v4 1/7] OvmfPkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

2020-03-03 Thread Ard Biesheuvel
Add LINUX_EFI_INITRD_MEDIA_GUID to our collection of GUID definitions, it can be used in a media device path to specify a Linux style initrd that can be loaded by the OS using the LoadFile2 protocol. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2564 Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH v4 7/7] OvmfPkg/LinuxInitrdDynamicShellCommand: bail if initrd already exists

2020-03-03 Thread Ard Biesheuvel
Before taking any actions, check if an instance of the LoadFile2 exists already on the Linux initrd media GUID device path, and whether it was provided by this command. If so, abort, since no duplicate instances of the device path should exist. Ref:

[edk2-devel] [PATCH v4 6/7] OvmfPkg IA32: add support for loading X64 images

2020-03-03 Thread Ard Biesheuvel
This is the UEFI counterpart to my Linux series which generalizes mixed mode support into a feature that requires very little internal knowledge about the architecture specifics of booting Linux on the part of the bootloader or firmware. Instead, we add a .compat PE/COFF header containing an

Re: [edk2-devel] [PATCH v5 34/42] OvmfPkg/Sec: Add #VC exception handling for Sec phase

2020-03-03 Thread Laszlo Ersek
Hi Tom, On 03/03/20 00:07, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > An SEV-ES guest will generate a #VC exception when it encounters a > non-automatic exit (NAE) event. It is expected that the #VC exception > handler will communicate with the

[edk2-devel][PATCH v2 6/6] Platform/RPi/ConfigDxe: Improve RPi configuration form

2020-03-03 Thread Pete Batard
Group all SD/MMC settings under the SD/MMC form. Make CPU settings more prominent. Harmonise form titles and text content. Reorder forms in the order they are most likely to be queried. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 24 +-

[edk2-devel][PATCH v2 5/6] Platform/RPi: Make Device Tree provision a runtime (BIOS setup) choice

2020-03-03 Thread Pete Batard
With this and the previous commit, ACPI_BASIC_MODE_ENABLE becomes superfluous so remove it. New option defaults to enabled on Pi 3, disabled on Pi 4. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 8

[edk2-devel][PATCH v2 1/6] Platform/RPi: Add firmware call to read installed memory size

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Add a new RPiFirmwareGetModelInstalledMB () call in RpiFirmwareDxe to return the amount of detected installed RAM on the system (in MB). Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 29 +++-

[edk2-devel][PATCH v2 4/6] Platform/RPi: Make 3GB/4GB a runtime (BIOS setup) choice

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Currently some OSes (e.g FreeBSD) can make full use of the maximum 4 GB of RAM a Raspberry Pi 4 can offer, whereas others (e.g. Linux) must be restricted to only the first 3 GB. Previously this was a compile-time choice chosen by PcdAcpiBasicMode, and now we make it

[edk2-devel][PATCH v2 0/6] Platform/RPi: User config improvements

2020-03-03 Thread Pete Batard
Changes from v1: * Split first commit into 2 patches. * Clarify commit message for 3/6 and remove extra line-removal hunk. * Improve and clarify computation of 3G+ segment size in ConfigDxe.c/ApplyVariables (). * Minor whitespace fixes (e.g. "3GB" -> "3 GB" in strings). Andrei Warkentin (4):

[edk2-devel][PATCH v2 2/6] Platform/RPi: Use GetModelInstalledMB () to read RAM size

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Use the call introduced in the previous commit to read the platform's installed memory. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[edk2-devel][PATCH v2 3/6] Platform/RPi: Separate RAM descriptors between 0-3 GB and 3+ GB

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Splitting the RAM descriptors is required so that we can make the 3 to 4 GB segment of the Raspberry Pi 4 a user-configurable option. This also removes the need for the PcdAcpiBasicMode PCD. Signed-off-by: Pete Batard ---

Re: [edk2-devel] [PATCH v5 36/42] OvmfPkg/QemuFlashFvbServicesRuntimeDxe: Bypass flash detection with SEV-ES is enabled

2020-03-03 Thread Laszlo Ersek
Hi Tom, On 03/03/20 00:07, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > The flash detection routine will attempt to determine how the flash > device behaves (e.g. ROM, RAM, Flash). But when SEV-ES is enabled and > the flash device behaves as a ROM device

Re: [edk2-devel] [PATCH v5 08/42] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library

2020-03-03 Thread Laszlo Ersek
On 03/03/20 00:06, Lendacky, Thomas wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Various CpuExceptionHandlerLib libraries will updated to use the new > VmgExitLib library. To prevent any build breakage, update the OvmfPkg > DSC files that use a form of the

[edk2-devel] [edk2-platforms] [PATCH] IntelSiliconPkg: IOMMU generic bug fix

2020-03-03 Thread De Leon Vazquez, Lorena R
Looks like Addresswidth is BIT wise values. Right now these values are not used any Suggested-by: Star Zeng star.z...@intel.com Signed-off-by: lorena.r.de.leon.vazq...@intel.com --

Re: [edk2-devel] Patch List for 202002 stable tag

2020-03-03 Thread Laszlo Ersek
On 03/03/20 09:29, Gao, Liming wrote: > Hi, Stewards and all: > Below three patches status are updated. If you have no other comments, I > will create edk2-stable202002 tomorrow and send the announcement. > > https://edk2.groups.io/g/devel/message/55105 [PATCH 0/2] UefiCpuPkg/Library: > Fix

Re: [edk2-devel] [PATCH 12/13] OvmfPkg/QemuKernelLoaderFsDxe: add support for new Linux initrd device path

2020-03-03 Thread Laszlo Ersek
On 03/03/20 11:18, Ard Biesheuvel wrote: > On Tue, 3 Mar 2020 at 11:10, Laszlo Ersek wrote: >> >> On 03/02/20 08:29, Ard Biesheuvel wrote: >>> Linux v5.7 will introduce a new method to load the initial ramdisk >>> (initrd) from the loader, using the LoadFile2 protocol installed on a >>> special

Re: [edk2-devel] [PATCH 09/13] OvmfPkg: implement QEMU loader library for X86 with legacy fallback

2020-03-03 Thread Laszlo Ersek
On 03/03/20 11:08, Ard Biesheuvel wrote: > On Tue, 3 Mar 2020 at 10:45, Laszlo Ersek wrote: >> (13) I'm worried that we are installing custom protocols on a handle >> that was first created by LoadImage(), before we pass it to >> UnloadImage(). I don't know if, per spec, LoadImage() /

Re: [edk2-devel][PATCH 5/5] Platform/RPi/ConfigDxe: Improve RPi configuration forms

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:34, Pete Batard wrote: > > Group all SD/MMC settings under the SD/MMC form. > Make CPU settings more prominent. > Harmonise form titles and text content. > Reorder forms in the order they are most likely to be queried. > > Signed-off-by: Pete Batard Reviewed-by: Ard

Re: [edk2-devel][PATCH 4/5] Platform/RPi: Make Device Tree provision a runtime (BIOS setup) choice

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:33, Pete Batard wrote: > > With this and the previous commit, ACPI_BASIC_MODE_ENABLE becomes > superfluous so remove it. > > New option defaults to enabled on Pi 3, disabled on Pi 4. > > Signed-off-by: Pete Batard This touches a lot of different files at the same time,

Re: [edk2-devel][PATCH 3/5] Platform/RPi: Make 3GB/4GB a runtime (BIOS setup) choice

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:33, Pete Batard wrote: > > From: Andrei Warkentin > > Currently some OSes (e.g FreeBSD) can make full use of the maximum > 4 GB of RAM a Raspberry Pi 4 can offer, whereas others (e.g. Linux) > must be restricted to only the first 3 GB. > > Previously this was a

Re: [edk2-devel][PATCH 2/5] Platform/RPi: Separate RAM descriptors between 0-3 GB and 3+ GB

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:33, Pete Batard wrote: > > From: Andrei Warkentin > > This is required so that we can make the 3 to 4 GB segment of > the Raspberry Pi 4 a user-configurable option. > > This also removes the need for the PcdAcpiBasicMode PCD. > > Signed-off-by: Pete Batard Please fix

Re: [edk2-devel][PATCH 1/5] Platform/RPi: Add firmware call to read installed memory size

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:33, Pete Batard wrote: > > From: Andrei Warkentin > > Add a new RPiFirmwareGetModelInstalledMB () call in RpiFirmwareDxe > to return the amount of detected installed RAM on the system (in MB). > > Use the new call in PlatformSmbiosDxe. > > Signed-off-by: Pete Batard

[edk2-devel][PATCH 4/5] Platform/RPi: Make Device Tree provision a runtime (BIOS setup) choice

2020-03-03 Thread Pete Batard
With this and the previous commit, ACPI_BASIC_MODE_ENABLE becomes superfluous so remove it. New option defaults to enabled on Pi 3, disabled on Pi 4. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 8

[edk2-devel][PATCH 3/5] Platform/RPi: Make 3GB/4GB a runtime (BIOS setup) choice

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Currently some OSes (e.g FreeBSD) can make full use of the maximum 4 GB of RAM a Raspberry Pi 4 can offer, whereas others (e.g. Linux) must be restricted to only the first 3 GB. Previously this was a compile-time choice chosen by PcdAcpiBasicMode, and now we make it

[edk2-devel][PATCH 5/5] Platform/RPi/ConfigDxe: Improve RPi configuration forms

2020-03-03 Thread Pete Batard
Group all SD/MMC settings under the SD/MMC form. Make CPU settings more prominent. Harmonise form titles and text content. Reorder forms in the order they are most likely to be queried. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 24 +-

[edk2-devel][PATCH 2/5] Platform/RPi: Separate RAM descriptors between 0-3 GB and 3+ GB

2020-03-03 Thread Pete Batard
From: Andrei Warkentin This is required so that we can make the 3 to 4 GB segment of the Raspberry Pi 4 a user-configurable option. This also removes the need for the PcdAcpiBasicMode PCD. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Library/PlatformLib/PlatformLib.inf | 3 --

[edk2-devel][PATCH 0/5] Platform/RPi: User config improvements

2020-03-03 Thread Pete Batard
This series improves on the configuration options made available to users in the firmware/BIOS setup. It adds 2 new options, one aimed at limiting the total amount of RAM presented to the OS to 3 GB (currently needed for xHCI on Linux) and the other toggling the provision of the Device Tree,

[edk2-devel][PATCH 1/5] Platform/RPi: Add firmware call to read installed memory size

2020-03-03 Thread Pete Batard
From: Andrei Warkentin Add a new RPiFirmwareGetModelInstalledMB () call in RpiFirmwareDxe to return the amount of detected installed RAM on the system (in MB). Use the new call in PlatformSmbiosDxe. Signed-off-by: Pete Batard ---

Re: [edk2-devel] [PATCH v2 09/16] OvmfPkg/CpuHotplugSmm: add function for collecting CPUs with events

2020-03-03 Thread Laszlo Ersek
On 03/02/20 21:34, Philippe Mathieu-Daudé wrote: > On 2/26/20 11:11 PM, Laszlo Ersek wrote: >> Add a function that collects the APIC IDs of CPUs that have just been >> hot-plugged, or are about to be hot-unplugged. >> >> Pending events are only located and never cleared; QEMU's AML needs the >>

Re: [edk2-devel] [PATCH 12/13] OvmfPkg/QemuKernelLoaderFsDxe: add support for new Linux initrd device path

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 11:10, Laszlo Ersek wrote: > > On 03/02/20 08:29, Ard Biesheuvel wrote: > > Linux v5.7 will introduce a new method to load the initial ramdisk > > (initrd) from the loader, using the LoadFile2 protocol installed on a > > special vendor GUIDed media device path. > > > > Add

Re: [edk2-devel] [PATCH 13/13] OvmfPkg: use generic QEMU image loader for secure boot enabled builds

2020-03-03 Thread Laszlo Ersek
On 03/02/20 08:29, Ard Biesheuvel wrote: > The QemuLoadImageLib implementation we currently use for all OVMF > builds copies the behavior of the QEMU loader code that precedes it, > which is to disregard UEFI secure boot policies entirely when it comes > to loading kernel images that have been

Re: [edk2-devel] [PATCH 12/13] OvmfPkg/QemuKernelLoaderFsDxe: add support for new Linux initrd device path

2020-03-03 Thread Laszlo Ersek
On 03/02/20 08:29, Ard Biesheuvel wrote: > Linux v5.7 will introduce a new method to load the initial ramdisk > (initrd) from the loader, using the LoadFile2 protocol installed on a > special vendor GUIDed media device path. > > Add support for this to our QEMU command line kernel/initrd loader.

Re: [edk2-devel] [PATCH 09/13] OvmfPkg: implement QEMU loader library for X86 with legacy fallback

2020-03-03 Thread Ard Biesheuvel
On Tue, 3 Mar 2020 at 10:45, Laszlo Ersek wrote: > > On 03/02/20 08:29, Ard Biesheuvel wrote: > > Implement another version of QemuLoadImageLib that uses LoadImage and > > StartImage, but falls back to the legacy Linux loader code if that > > fails. The logic in the legacy fallback routines is

Re: [edk2-devel] [PATCH 11/13] OvmfPkg/PlatformBootManagerLib: switch to QemuLoadImageLib

2020-03-03 Thread Laszlo Ersek
On 03/03/20 10:52, Laszlo Ersek wrote: > On 03/02/20 08:29, Ard Biesheuvel wrote: >> Replace the open coded sequence to load Linux on x86 with a short and >> generic sequence invoking QemuLoadImageLib, which can be provided by >> a generic version that only supports the LoadImage and StartImage

Re: [edk2-devel] [PATCH 11/13] OvmfPkg/PlatformBootManagerLib: switch to QemuLoadImageLib

2020-03-03 Thread Laszlo Ersek
On 03/02/20 08:29, Ard Biesheuvel wrote: > Replace the open coded sequence to load Linux on x86 with a short and > generic sequence invoking QemuLoadImageLib, which can be provided by > a generic version that only supports the LoadImage and StartImage boot > services, and one that incorporates the

Re: [edk2-devel] [PATCH 10/13] OvmfPkg: add new QEMU kernel image loader components

2020-03-03 Thread Laszlo Ersek
On 03/02/20 08:29, Ard Biesheuvel wrote: > Add the components that expose the QEMU abstract loader file system so > that we can switch over our PlatformBmLib over to it in a subsequent > patch. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2566 > Signed-off-by: Ard Biesheuvel > --- >

Re: [edk2-devel] [PATCH 09/13] OvmfPkg: implement QEMU loader library for X86 with legacy fallback

2020-03-03 Thread Laszlo Ersek
On 03/02/20 08:29, Ard Biesheuvel wrote: > Implement another version of QemuLoadImageLib that uses LoadImage and > StartImage, but falls back to the legacy Linux loader code if that > fails. The logic in the legacy fallback routines is identical to the > current QEMU linux loader for X64 and IA32.

Re: [edk2-devel] Patch List for 202002 stable tag

2020-03-03 Thread Liming Gao
Hi, Stewards and all: Below three patches status are updated. If you have no other comments, I will create edk2-stable202002 tomorrow and send the announcement. https://edk2.groups.io/g/devel/message/55105 [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib (BZ: 2556) [Liming 2020-02-28]