Reviewed-by: Bob Feng
-Original Message-
From: Leif Lindholm
Sent: Thursday, April 30, 2020 12:36 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH 1/3] BaseTools: add handling for 'S:' flag to GetMaintainer.py
GetMaintainer.py already extracts the value of any
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Thursday, April 16, 2020 4:31 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming ;
> Bret Barkelew ; Kinney, Michael D
> ; Sean Bro
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, April 30, 2020 3:12 PM
> To: devel@edk2.groups.io; michael.kuba...@outlook.com
> Cc: Feng, Bob C ; Gao, Liming ;
> Bret Barkelew ; Kinney,
> Michael D ; Sean Brogan
>
> Subject: RE: [edk2-devel] [PA
On 4/28/20 1:25 PM, Philippe Mathieu-Daudé wrote:
On 4/28/20 7:08 AM, GH Cao wrote:
The original comment incorrectly named the PWM controller as Power
Management
Contoller, this commit fixes it.
Signed-off-by: GH Cao
---
Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
On 4/24/20 7:59 PM, Ard Biesheuvel via groups.io wrote:
On 4/19/20 10:06 AM, Bi, Dandan wrote:
Ok, thanks Ard!
Reviewed-by: Dandan Bi for this patch.
Hao, Jian,
I intend to merge this patch next week, unless you have any objections.
Merged as https://github.com/tianocore/edk2/pull/566, w
ArmPkg's ArmLib recently dropped an unnecessary reference to
gEfiCpuArchProtocolGuid, causing the build to fail for BeagleBoard,
due to the fact that LcdGraphicsOutputDxe does need it, but lacks the
reference, which no longer gets satisfied transitively through ArmLib.
So add the reference to LcdG
On 4/29/20 11:37 PM, Leif Lindholm wrote:
On Wed, Apr 29, 2020 at 20:47:04 +0200, Ard Biesheuvel wrote:
The protocol name for EmbeddedPkg's version of the MMC host protocol was
changed to reflect that this protocol is not the one that the UEFI spec
defines. So update OMAP3's MMC host DXE driver
On 4/29/20 11:34 PM, Leif Lindholm wrote:
On Wed, Apr 29, 2020 at 23:27:52 +0200, Ard Biesheuvel wrote:
On 4/29/20 10:06 PM, Leif Lindholm wrote:
On Wed, Apr 29, 2020 at 20:27:04 +0200, Ard Biesheuvel wrote:
In EDK2, identifiers carrying the EFI prefix are reserved for ones
that are defined in
Reviewed-by: Ray Ni
> -Original Message-
> From: Shindo, Miki
> Sent: Wednesday, April 29, 2020 10:32 AM
> To: devel@edk2.groups.io
> Cc: Chaganty, Rangasai V ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Agyeman, Prince ;
> Ni, Ray
> Subject: [edk2-platforms:PATCH v4 0/7] IntelSilicon
This is a followup to two patches I sent out separately yesterday, and to
the subsequent discussion regarding annotating obsolete drivers as unfit
for reuse if they don't follow the UEFI driver model.
Changes since v1:
- use gEmbeddedMmcHostProtocolGuid not gEdkiiMmcHostProtocolGuid
- add WARNING
The PL180 SD host controller driver is only used on emulated ARM
platforms, uses an obsolete version of the MMC host protocol and
does not adhere to the UEFI driver model.
Given the above, let's just move it into VExpressPkg where it
belongs.
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/VExpr
Juno is the only user of the SiI3132 SATA controller driver, which
is not quite fit for reuse in its current state. So incorporate it
into JunoPkg so we will be able to drop it from the core EDK2
repository.
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/JunoPkg/ArmJuno.dec
Pushed: 4b24363cbfbe9498272dba86644caed365329610
Thanks,
Chasel
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Thursday, April 30, 2020 2:04 PM
> To: Kumar, Chandana C ;
> devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: RE: [edk2-platforms: PATC
v1.2 (not older) actually uses the same BCM2837 SoC as
Pi 3, and is thus a 64-bit device that this firmware
easily supports as a minor variant of the Pi 3.
The difference from Pi 3 is choice of UART (PL011), no WiFi,
no BT and slower clock due to thermal problems caused by
older board design.
Sig
Dear all,
This is a patch set which brings in Pi 2B (v1.2), Pi 3A+
and CM3 support. Most of this is documentation, and
where there was some overlap I touched up RPi4 readme as well.
Pi 2B v1.2 is actually a Pi 3 SoC tacked to a Pi 2 board.
We can treat it as a WiFi- and BT- less variant of the Pi
Just cleanups to areas I know have gotten a bit stale.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/RPi3/Readme.md | 6 --
Platform/RaspberryPi/RPi4/Readme.md | 20
2 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/Platform/RaspberryPi/RPi3/Rea
Mostly strings and documentation, but also fixes a dumb bug
I introduced when I added SD block write validation back
in RaspberryPiPkg (which broke eMMC support, even though
I could have tested it with a discrete eMMC media on regular
Pies)
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryP
The RPi3 target also supports the 3A+, so let's document it.
(The 3A+ lacks the ethernet port and has less RAM)
Clarify RPi3 is for BCM2837-based variants, while RPi4 is
for the BCM2711-based variants.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/RPi3/Readme.md | 23 ++-
For PFTF developers working on the firmware, being able to use a
local TF-A build without extra extra copy operations ends up being
very helpful.
This can be accomplished via a TFA_BUILD_ARTIFACTS option passed
to the edk2 build tool.
If/when the Pi 3 and 4 DSC/FDFs become unified, this will be e
On 4/30/20 10:47 AM, Andrei Warkentin wrote:
Mostly strings and documentation, but also fixes a dumb bug
I introduced when I added SD block write validation back
in RaspberryPiPkg (which broke eMMC support, even though
I could have tested it with a discrete eMMC media on regular
Pies)
Signed-off
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:g7lq.1578029159272351097.u...@groups.io
DTSTAMP:20200430T085148Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20200501T013000Z
DTEND:20200501T023000Z
SUMMARY:Tiano
On 4/30/20 10:47 AM, Andrei Warkentin wrote:
Dear all,
This is a patch set which brings in Pi 2B (v1.2), Pi 3A+
and CM3 support. Most of this is documentation, and
where there was some overlap I touched up RPi4 readme as well.
Pi 2B v1.2 is actually a Pi 3 SoC tacked to a Pi 2 board.
We can tre
On 4/30/20 10:49 AM, Andrei Warkentin wrote:
For PFTF developers working on the firmware, being able to use a
local TF-A build without extra extra copy operations ends up being
very helpful.
This can be accomplished via a TFA_BUILD_ARTIFACTS option passed
to the edk2 build tool.
If/when the Pi
Hi,
After launching Winhost.exe. Emulator exits after displaying "Sec Has Started".
I have not built any platform pkgs yet. This is just after building Emulator
Pkg .
To boot to Shell what shall I do. How can I achive this.
Is there a document I can refer to.
[cid:image002.jpg@01D61EDB.8CF621
Hi Ard,
> Is it my fault that we are using bl1+fip on RPi3? I don't remember, but
> I suppose we could easily switch to BL31 only like we have on RPI4
AFAIK, Andre P. was looking at unifying the pi3 tf-a target with pi 4 long
term. I might end up proposing something there because after I fix DT
[ This v2 patch set aggregates all the doc changes and separates out
functionality
fixes into separate patches, based on Ard's feedback ]
This is a patch set which brings in Pi 2B (v1.2), Pi 3A+
and CM3 support. Most of this is documentation, and
where there was some overlap I touched up RPi4 re
Way back when I added write block validation
(https://github.com/andreiw/RaspberryPiPkg/commit/bdea35dc3f1652bf7b17505a20a5f52f7fde9707),
I had screwed the logic up breaking eMMC.
This starts to matter on the CM3, which has eMMC.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/Drivers
Now that RPi3 supports CM3, let's edit the flash controller
options a bit.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.uni | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.u
The Pi 2B v1.2 uses the same SoC as Pi 3B/3B+, but reports self as model 2.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c
b/Platfor
This cleans up the (related) Readme.md files for both platforms.
- The RPi3 target also supports the 3A+, so let's document it.
(The 3A+ lacks the ethernet port and has less RAM)
- Clarify RPi3 is for BCM2837-based variants, while RPi4 is
for the BCM2711-based variants.
- v1.2 (not older) actual
On 4/30/20 11:26 AM, Andrei Warkentin wrote:
[ This v2 patch set aggregates all the doc changes and separates out
functionality
fixes into separate patches, based on Ard's feedback ]
This is a patch set which brings in Pi 2B (v1.2), Pi 3A+
and CM3 support. Most of this is documentation, and
w
On 04/24/20 19:59, Nikita Leshenko wrote:
> Machines should be able to boot after this commit. Tested with different
> Linux distributions (Ubuntu, CentOS) and different Windows
> versions (Windows 7, Windows 10, Server 2016).
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2390
> Signed-o
Hi Jeremy,
I still debugging it.
Even though the Assert issue disappear and can normally boot, but the USB
device will lose, I am debugging it.
Have you encountered the bug?
Hi Hao,
I am still evaluating the memory leakage and working out the best solution.
All,
I will be out of office durin
On 04/24/20 19:59, Nikita Leshenko wrote:
> This causes the device to forget about the reply frame. We allocated the
> reply frame in EfiBootServicesData type memory, and code executing after
> ExitBootServices() is permitted to overwrite it.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id
Hi Ard,
On 4/30/20 10:25 AM, Ard Biesheuvel wrote:
The PL180 SD host controller driver is only used on emulated ARM
platforms, uses an obsolete version of the MMC host protocol and
does not adhere to the UEFI driver model.
Given the above, let's just move it into VExpressPkg where it
belongs.
On 4/30/20 12:06 PM, Philippe Mathieu-Daudé wrote:
Hi Ard,
On 4/30/20 10:25 AM, Ard Biesheuvel wrote:
The PL180 SD host controller driver is only used on emulated ARM
platforms, uses an obsolete version of the MMC host protocol and
does not adhere to the UEFI driver model.
Given the above, let
On 04/29/20 23:47, Ard Biesheuvel wrote:
> On 4/29/20 11:45 PM, Leif Lindholm wrote:
>> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote:
> I am mostly concerned about the use of MmcDxe in new platforms. The
> other
> bits I'm not too worried about, and I think it would be f
On 04/30/20 03:18, Gao, Liming wrote:
> Laszlo:
>
>
> Thanks
> Liming
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Thursday, April 30, 2020 2:04 AM
>> To: Sean Brogan ; devel@edk2.groups.io;
>> michael.kuba...@outlook.com
>> Cc: Andrew Fish ; Ard Biesheuvel ;
>> Bret Barkelew ;
On 04/30/20 03:12, Rebecca Cran wrote:
> On bhyve, the ACPI timer is located at a fixed IO address; it need
> not be programmed into, nor fetched from, the PMBA -- power
> management base address -- register of the PCI host bridge.
>
> Signed-off-by: Rebecca Cran
> Cc: Jordan Justen
> Cc: Laszlo
On 04/29/20 23:53, Rebecca Cran wrote:
> Generated mechanically with:
> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>
> Signed-off-by: Rebecca Cran
Reviewed-by: Laszlo Ersek
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply On
On 04/30/20 03:13, Rebecca Cran wrote:
> Add a null implementation library for QemuFwCfgLib, in order to
> support building PciHostBridgeLib for bhyve.
>
> Signed-off-by: Rebecca Cran
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> ---
> .../Library/QemuFwCfgLib/QemuFwCfgLibNull
(+Sean, Mike, Michael)
On 04/30/20 14:51, Laszlo Ersek wrote:
> On 04/29/20 23:53, Rebecca Cran wrote:
>> Generated mechanically with:
>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>
>> Signed-off-by: Rebecca Cran
>
> Reviewed-by: Laszlo Ersek
>
Submitted this patch for m
On 04/30/20 15:04, Laszlo Ersek wrote:
> (+Sean, Mike, Michael)
>
> On 04/30/20 14:51, Laszlo Ersek wrote:
>> On 04/29/20 23:53, Rebecca Cran wrote:
>>> Generated mechanically with:
>>> find OvmfPkg -type f -exec sed -i -e 's/EFI_D_/DEBUG_/g' {} \;
>>>
>>> Signed-off-by: Rebecca Cran
>>
>> Review
Add a null implementation library for QemuFwCfgLib, in order to
support building PciHostBridgeLib for bhyve.
Signed-off-by: Rebecca Cran
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
---
.../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37
OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgNu
On 4/30/20 6:59 AM, Laszlo Ersek wrote:
On 04/30/20 03:13, Rebecca Cran wrote:
+#include
+#include
+#include
Didn't you mean to address Phil feedback?
https://edk2.groups.io/g/devel/message/58165
Sorry, yes I did. I've posted the updated patch.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=
On Thu, Apr 30, 2020 at 13:17:26 +0200, Laszlo Ersek wrote:
> On 04/29/20 23:47, Ard Biesheuvel wrote:
> > On 4/29/20 11:45 PM, Leif Lindholm wrote:
> >> On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote:
> > I am mostly concerned about the use of MmcDxe in new platforms. The
> >
On Thu, Apr 30, 2020 at 13:24:57 +0200, Laszlo Ersek wrote:
> On 04/30/20 03:18, Gao, Liming wrote:
> > Laszlo:
> >
> >
> > Thanks
> > Liming
> >> -Original Message-
> >> From: Laszlo Ersek
> >> Sent: Thursday, April 30, 2020 2:04 AM
> >> To: Sean Brogan ; devel@edk2.groups.io;
> >> mic
On 4/30/20 3:28 PM, Leif Lindholm wrote:
On Thu, Apr 30, 2020 at 13:17:26 +0200, Laszlo Ersek wrote:
On 04/29/20 23:47, Ard Biesheuvel wrote:
On 4/29/20 11:45 PM, Leif Lindholm wrote:
On Wed, Apr 29, 2020 at 22:04:08 +0200, Ard Biesheuvel wrote:
I am mostly concerned about the use of MmcDxe i
On 04/30/20 03:12, Rebecca Cran wrote:
> On bhyve, the ACPI timer is located at a fixed IO address; it need
> not be programmed into, nor fetched from, the PMBA -- power
> management base address -- register of the PCI host bridge.
>
> Signed-off-by: Rebecca Cran
> Cc: Jordan Justen
> Cc: Laszlo
On 04/30/20 03:15, Rebecca Cran wrote:
> bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info
> structure to IndustryStandard/LegacyVgaBios.h
>
> Signed-off-by: Rebecca Cran
> Acked-by: Laszlo Ersek
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> ---
> .../Includ
On 04/27/20 18:53, Leif Lindholm wrote:
> Hi Liming,
>
> Thanks!
> I'm sorry but I don't know what "PatchCheck CI pipe line can support
> the exception." means. I did ask before if there was a way to
> bypass that particular test.
>
> Anyway, I created
> https://github.com/tianocore/edk2/pull/549
On Thu, Apr 30, 2020 at 15:43:22 +0200, Ard Biesheuvel wrote:
> > > > > Thinking a bit more on this, maybe what we should do is add a template
> > > > > to each file's top comment block. Draft proposal:
> > > > >
> > > > > *
> > > > > * WARNING:
> > > > > * This driver fails to follow
On Wed, Apr 29, 2020 at 21:54:35 +0200, Ard Biesheuvel wrote:
> Juno is the only user of the SiI3132 SATA controller driver, which
> is not quite fit for reuse in its current state. So incorporate it
> into JunoPkg so we will be able to drop it from the core EDK2
> repository.
>
> Signed-off-by: A
On 04/30/20 15:22, Rebecca Cran wrote:
> Add a null implementation library for QemuFwCfgLib, in order to
> support building PciHostBridgeLib for bhyve.
>
> Signed-off-by: Rebecca Cran
> Cc: Jordan Justen
> Cc: Laszlo Ersek
> Cc: Ard Biesheuvel
> ---
> .../Library/QemuFwCfgLib/QemuFwCfgLibNull.
Incorporate the Lan91x driver from EmbeddedPkg, which is only used
on obsolete ARM development platforms and does not follow the UEFI
driver model. This will allow us to drop if from the core EDK2
repository.
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/JunoPkg/ArmJuno.dsc
Incorporate the Lan91x driver from EmbeddedPkg, which is only used
on emulated ARM development platforms and does not follow the UEFI
driver model. This will allow us to drop if from the core EDK2
repository.
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/SgiPkg/SgiPlatform.dsc
Incorporate the driver for the DesignWare eMMC host controller that is
based on the obsolete MMC host controller protocol that is defined in
EmbeddedPkg.
This driver does not follow the UEFI driver model, and is only kept
around for its only users, which is the HiKey platform, which is
rapidly rea
ArmPkg's ArmLib recently dropped an unnecessary reference to
gEfiCpuArchProtocolGuid, causing the build to fail for BeagleBoard,
due to the fact that LcdGraphicsOutputDxe does need it, but lacks the
reference, which no longer gets satisfied transitively through ArmLib.
So add the reference to LcdG
Incorporate the ISP 1761 USB host driver from EmbeddedPkg, which is
only used on obsolete ARM development platforms and does not follow
the UEFI driver model. This will allow us to drop it from the core EDK2
repository.
Signed-off-by: Ard Biesheuvel
---
Platform/ARM/VExpressPkg/ArmVExpress-CTA15
This is a followup to two patches I sent out separately yesterday, and to
the subsequent discussion regarding annotating obsolete drivers as unfit
for reuse if they don't follow the UEFI driver model.
I have rounded up all the stuff I have in flight for edk2-platforms at
the moment, so this v3 sup
The PL180 SD host controller driver is only used on emulated ARM
platforms, uses an obsolete version of the MMC host protocol and
does not adhere to the UEFI driver model.
Given the above, let's just move it into VExpressPkg where it
belongs.
Signed-off-by: Ard Biesheuvel
Reviewed-by: Philippe M
Juno is the only user of the SiI3132 SATA controller driver, which
is not quite fit for reuse in its current state. So incorporate it
into JunoPkg so we will be able to drop it from the core EDK2
repository.
Signed-off-by: Ard Biesheuvel
Reviewed-by: Leif Lindholm
---
Platform/ARM/JunoPkg/ArmJu
Switch to the version of the DesignWare eMMC host controller driver
that was moved into edk2-platforms, as part of a spring cleaning
exercise of EmbeddedPkg.
Signed-off-by: Ard Biesheuvel
---
Platform/Hisilicon/HiKey/HiKey.dsc | 7 ---
Platform/Hisilicon/HiKey/HiKey.fdf | 2 +-
2 files chang
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C
Sent: Tuesday, April 21, 2020 4:27 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Desimone, Ashley E
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-devel] [e
Pushed: https://github.com/tianocore/edk2-staging/commit/8caf3640
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C
Sent: Tuesday, April 21, 2020 4:27 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Desimone, Ashley E
; Pandya, Puja ; Bret
Barkelew ; Agye
Hi Tom,
On 04/22/20 19:41, Lendacky, Thomas wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Reserve a fixed area of memory for SEV-ES use and set a fixed PCD,
> PcdSevEsWorkAreaBase, to this value.
>
> This area will be used by SEV-ES support for two purposes:
> 1. Communi
A rev-up of start.elf VPU firmware meant that the previous scheme of
loading the DTB over top of RPI_EFI.FD no longer works - the DT is now
loaded way before the armstub, so any overlap means the DT is overridden.
This change re-arranges a few items in the FD, allowing the DTB to loaded
directly a
Dear all,
This patch set finishes what I started with the Pi 4 fix for
the regression seen with newer VideoCore firmware, where a
device tree passed via config.txt would not be detected by UEFI.
This makes VPU-passed FDT work again on Pi 3 variants. This also
cleans up the docs around correctly u
Now that Pi 3 FDT handling is fixed, let's update the docs. Furthermore,
let's simplify - be proscriptive about the minimal supported
config.txt configuration. Also, fix some factual mistakes:
- device_tree= override is not mandatory when device_tree_address= is used.
Not using it means start.elf
Matches the new reality around FDT support (edk2-platform patches).
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Platform/RaspberryPi/RPi3/TrustedFirmware/Readme.md
b/Platform/Raspb
On 4/30/20 10:46 AM, Laszlo Ersek wrote:
Please pay more attention to review feedback. If you post a new version
without even attempting to address review comments, that's a waste of
time for both you and your reviewers.
It's something I really do need to work on. I need to take a step back
I only updated links to the top-level mailing list, not any links to
individual messages.
Signed-off-by: Rebecca Cran
---
HardFeatureFreeze.md | 2 +-
...unkempt-git-guide-for-edk2-contributors-and-maintainers.md | 2 +-
Member-FAQ.md
On 4/30/20 1:58 PM, Laszlo Ersek wrote:
Hi Tom,
Hi Laszlo,
On 04/22/20 19:41, Lendacky, Thomas wrote:
BZ:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cce256f35aa2e4748e8e008d7e
Dear all,
This patch set removes the internal (embedded) DTB support from Pi 3
and Pi 4 platforms, since these platforms should *always* be using
the devicetree passed by the VideoCore firmware.
Andrei Warkentin (2):
RPi: rip out FdtDxe logic to use internal DTB
RPi: remove any mention of an
For Pi 3 and Pi 4, since the relevant functionality is gone from FdtDxe.
Signed-off-by: Andrei Warkentin
---
Platform/RaspberryPi/RPi3/Readme.md | 3 +--
Platform/RaspberryPi/RPi4/Readme.md | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/Platform/RaspberryPi/RPi3/Readme.m
Initially, FdtDxe used an internal (embedded in UEFI) FDT,
because it was neither understood how to consume the
one loaded by the VideoCore firmware, nor understood just
how important it is to use the DTB provided by config.txt.
Embedding the DT was a bad idea, because:
- Permanently stale
- No ov
These are unnecessary, because we've ripped out FdtDxe logic
to use internal devicetree. We are mandating that devicetree
must come from the VideoCore firmware (driven by config.txt)
[ this must be applied only after the FdtDxe patch removing support
for embedding DTs in UEFI ]
Signed-off-by: An
I just realized it’s not entirely clear from the patch that this is against the
wiki repo.
Rebecca Cran
> On Apr 30, 2020, at 3:06 PM, Rebecca Cran wrote:
>
> I only updated links to the top-level mailing list, not any links to
> individual messages.
>
> Signed-off-by: Rebecca Cran
> ---
> H
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-st
Reviewed-by: Nate DeSimone
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ashley E
> Desimone
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject:
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ashley E
> Desimone
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agy
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-st
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-st
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-st
Hi Ashley,
Please see comments inline.
Thanks,
Nate
> -Original Message-
> From: Desimone, Ashley E
> Sent: Tuesday, April 28, 2020 2:57 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Pandya, Puja
> ; Bjorge, Erik C ; Bret
> Barkelew ; Agyeman, Prince
>
> Subject: [edk2-st
I agree with your comment about moving magic strings to a common location. I
would suggest that we put it someplace other than humble.py. I think we should
add a new file for configuration settings like this. I think something like
tool_config.py would be good.
Thanks,
-Erik
-Original M
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, April 29, 2020 6:38 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silic
On 4/30/20 4:12 PM, Tom Lendacky wrote:
On 4/30/20 1:58 PM, Laszlo Ersek wrote:
Hi Tom,
Hi Laszlo,
On 04/22/20 19:41, Lendacky, Thomas wrote:
BZ:
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendac
Hi Erik,
Sure, sounds good.
Thanks,
Nate
On 4/30/20, 2:40 PM, "Bjorge, Erik C" wrote:
I agree with your comment about moving magic strings to a common location.
I would suggest that we put it someplace other than humble.py. I think we
should add a new file for configuration settings l
Just cleaning up the file to meet Flake8 expectations.
Signed-off-by: Erik Bjorge
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo_manifest_parser/edk_manifest.py | 159 ++--
1 file changed, 94 insertions(+), 65 del
The ETree exception contains additional information about the location
of XML tag errors. Adding this information to the error message for
better debugging support.
Signed-off-by: Erik Bjorge
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
---
e
Refactoring private variables to remove name mangling from double
underscores to using single underscores. This allows for better
creation of derived classes.
Signed-off-by: Erik Bjorge
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo
General cleanup of the manifest parser and minor improvements to make
the code more flexible.
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
Erik Bjorge (3):
EdkRepo: Flake8 cleanup
EdkRepo: Improve error message with invalid XML
EdkRepo: R
Reviewed-by: Star Zeng
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Friday, May 1, 2020 5:59 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: Support Multi-Phase silicon
> initialization.
>
> Rev
Add pull_workspace_man_repo() to pull only the global manifest
repository affiliated with a single workspace.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
.../manifest_repos_maintenance.py | 23 +
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
.../humble/manifest_repos_maintenance_humble.py| 2 +-
.../manifest_repos_maintenance.py | 32 --
edkrepo/config/tool_config.p
V2 Adds an additional patch (8/8) to address all of the
feedback from Erik and nate
Add the required support functionaility for consuming multiple
manifest repositories defined in both the edkrepo.cfg and
edkrepo_user.cfg files.
Includes support for determining the source manifest repository,
pul
Add the SourceManifestRepository to the edkrepo manfiest general config
for use by edkrepo to track the source manifest repository for the workspace.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo_manifest_
Add a function that will download all available manifest
repositories defined in either the edkrepo.cfg or the
edkrepo_user.cfg
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
.../humble/manifest_repos_maintenance_h
Add find_source_man_repo() to check if for the source manifest
repo is contained in the workspaces project manifest file.
If it is not determine the value and write it to the manifest.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Pri
1 - 100 of 104 matches
Mail list logo
