Re: [edk2-devel] [edk2-staging/EdkRepo-Manifest] [PATCH] Intel-MinPlatform: Update FSP repo URL

2020-06-09 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Monday, June 08, 2020 6:49 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Chiu, Chasel ; Chaganty, Rangasai V ; Oram, Isaac W ; Gao, Liming ; Ni, Ray ; Agyeman, Prince ; Pandya, Puja Subject: [edk2

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-09 Thread Sean
I think your copyright year is off. 2022? After you fix that Reviewed-by: Sean Brogan Also since you are the package maintainer of this package what do you think about enabling Core CI? We do this already in Project Mu which is how this missing entry was identified. https://github.com/mic

[edk2-devel] [PATCH] Features/Intel/PostCodeDebugFeaturePkg: add it.

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478 The PostCodeDebugFeaturePkg include some useful post code debug libraries, such as get post code from status code and show it. It provide a library PostCodeStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to show the post code.

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCorePerformanceLib: Switch to UnicodeStrnToAsciiStrS

2020-06-09 Thread Dandan Bi
Thanks for the fix. Could you also help update the UnicodeStrToAsciiStrS usage at line 840? Which potentially has the similar issue. UnicodeStrToAsciiStrS(StringPtr, ComponentNameString, ControllerNameStringSize); Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io On Behal

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

2020-06-09 Thread Abner Chang
Thanks Dandan. Abner > -Original Message- > From: Bi, Dandan [mailto:dandan...@intel.com] > Sent: Wednesday, June 10, 2020 1:33 PM > To: Li, Walon ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; Wang, Sunny (HPS SW) > ; Dong,

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

2020-06-09 Thread Dandan Bi
This patch is committed via 365fdb0f939cf00b26d37f27adbf579aa984221b Thanks, Dandan > -Original Message- > From: Bi, Dandan > Sent: Monday, June 8, 2020 3:16 PM > To: Li, Walon ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS > SW/FW Technologist) ; W

Re: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption.

2020-06-09 Thread Dandan Bi
This patch is committed via 9b52b06f964226780b7047e10be0c1a65e223eb1 Thanks, Dandan > -Original Message- > From: Bi, Dandan > Sent: Monday, June 8, 2020 3:19 PM > To: devel@edk2.groups.io; Bi, Dandan ; Abdul Lateef > Attar > Cc: Dong, Eric ; Wang, Jian J ; > Wu, Hao A > Subject: RE: [ed

Re: [edk2-devel] [PATCH v1 1/3] BaseTools: Generate multiple rules when multiple output files

2020-06-09 Thread Bob Feng
Hi Pierre, I found there is an incorrect target generated in the OvmfPkg/AcpiTables Makefile when I tried to build Ovmf. That incorrect target causes ovmf to build failed. $(DEBUG_DIR)\PlatformAcpiTables : $(MAKE_FILE) $(DEBUG_DIR)\PlatformAcpiTables : $(STATIC_LIBRARY_FILES) $(DEBUG_DIR)\Plat

Re: [edk2-devel] [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about status code

2020-06-09 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Ming > Sent: Wednesday, June 10, 2020 10:57 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about > status code > > REF: https:

[edk2-devel] [PATCH v4 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Signed-off-by: Ming T

[edk2-devel] [PATCH v4 4/4] OvmfPkg/OvmfPkg*.dsc: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-b

[edk2-devel] [PATCH v4 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Ming Ta

[edk2-devel] [PATCH v4 1/4] MdeModulePkg.dec: Change PCDs for status code.

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 In order to support enable/disable report status code through memory or serial dynamic, change the following PCDs from [PcdsFeatureFlag] to [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]: PcdStatusCodeUseSerial Pcd

[edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-09 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2788 DSC is incomplete according to the established CI policies. Fsp22SecCoreS.inf needs to be added to the Components section for completeness. Cc: Maurice Ma Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Inte

Re: [edk2-devel] Help to review this patch

2020-06-09 Thread Ni, Ray
Reviewed-by: Ray Ni > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dong, Eric > Sent: Wednesday, June 3, 2020 11:18 AM > To: devel@edk2.groups.io > Cc: De, Debkumar ; Han, Harry > ; West, Catharine > Subject: [edk2-devel] [PATCH 4/5] Maintainers.txt: Add reviewer for

Re: [edk2-devel] [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about status code

2020-06-09 Thread Agyeman, Prince
Reviewed-by: Prince Agyeman -Original Message- From: Tan, Ming Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Agyeman, Prince Subject: [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about status code REF: https://bugzilla.tianocore.org/show_bug.cg

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/09/2020 6:30pm-7:30pm #cal-reminder

2020-06-09 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 9 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816011 ) *Organizer:* Brian Richardson brian.richar

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Add force flag when removing submodules

2020-06-09 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Tuesday, June 9, 2020 4:04 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: A

[edk2-devel] [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic bug

2020-06-09 Thread Nate DeSimone
(Cpptv & B_PCH_SPI_SFDPX_VSCCX_CPPTV) can only evaluate to two possible values, 0x0 or B_PCH_SPI_SFDPX_VSCCX_CPPTV (aka BIT31). The current comparison to 0x1 will always fail. Fixed the if statement to compare to B_PCH_SPI_SFDPX_VSCCX_CPPTV. Signed-off-by: Nate DeSimone Cc: Chasel Chiu Cc: Sai

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 0/2] Small fixes to submodule support

2020-06-09 Thread Bjorge, Erik C
Fixed issues when submodule has untracked files and can't be deinitialized. Fixed backwards compatibility issue with old pin files. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Erik Bjorge (2): EdkRepo: Add force flag when re

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 1/2] EdkRepo: Add force flag when removing submodules

2020-06-09 Thread Bjorge, Erik C
Submodules may generate un-tracked or modify files in the repo. when removing the submodule do so even with modifications. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- project_utils/submodule.py

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Adding backwards compatibility for old pin files

2020-06-09 Thread Bjorge, Erik C
Older pin files used the invalid enable_submodule attribute. This has been fixed for new pin files but we need to be able to support older pin files as well. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjor

Re: [edk2-devel] [edk2-staging/EdkRepo-Manifest] [PATCH] Intel-MinPlatform: Update FSP repo URL

2020-06-09 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Desimone, Nathaniel L Sent: Monday, June 8, 2020 6:49 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Chiu, Chasel ; Chaganty, Rangasai V ; Oram, Isaac W ; Gao, Liming ; Ni, Ray ; Agyeman, Pr

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: check for manifest-repos section in edkrepo_user.cfg

2020-06-09 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Monday, June 8, 2020 2:52 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: check for

Re: [edk2-devel] github PRs keep breaking for me

2020-06-09 Thread Laszlo Ersek
On 06/09/20 23:51, Laszlo Ersek wrote: > On 06/09/20 23:37, Laszlo Ersek wrote: >> Hi, >> >> On 03/12/20 22:57, Michael D Kinney wrote: >> >>> The hub command is very flexible. What commands did you try? >> >> github again failed to accept the "push" label when I tried to set it. >> >> Unlike last

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument checks in manifest-repos

2020-06-09 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Monday, June 8, 2020 5:18 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argume

Re: [edk2-devel] github PRs keep breaking for me

2020-06-09 Thread Laszlo Ersek
On 06/09/20 23:37, Laszlo Ersek wrote: > Hi, > > On 03/12/20 22:57, Michael D Kinney wrote: > >> The hub command is very flexible. What commands did you try? > > github again failed to accept the "push" label when I tried to set it. > > Unlike last time, the push label *is* offered to me in th

Re: [edk2-devel] Device and driver

2020-06-09 Thread Andrew Fish via groups.io
Kumar, Tom gave a really good answer. Let my give you some history. Big picture the UEFI Driver Model that uses the DRIVER_BINDING_PROTOCOL is the the replacement for old BIOS Option ROMs. In olden times the BIOS Option ROMs started to get workarounds for the BIOS and the BIOS had work around

Re: [edk2-devel] github PRs keep breaking for me

2020-06-09 Thread Laszlo Ersek
Hi, On 03/12/20 22:57, Michael D Kinney wrote: > The hub command is very flexible. What commands did you try? github again failed to accept the "push" label when I tried to set it. Unlike last time, the push label *is* offered to me in the small widget to the right. When I click the label, it

Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg/OvmfPkg*.dsc: Change PCDs type about status code

2020-06-09 Thread Laszlo Ersek
On 06/09/20 13:23, Tan, Ming wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 > > Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory > in MdeModulePkg.dec are changed, so change them from > PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. > > Cc: Jordan Justen

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg: remove unused files

2020-06-09 Thread Laszlo Ersek
On 06/08/20 19:34, Ard Biesheuvel wrote: > We no longer use ELF PIE executables to implement the self-relocating > PrePi so drop the custom linker script and visibility override header > file. > > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/Include/Platform/Hidden.h | 22 --- > Ar

Re: [edk2-devel] [PATCH 3/4] ArmVirtPkg/PrePi: use standard PeCoff routines for self-relocation

2020-06-09 Thread Laszlo Ersek
On 06/08/20 19:34, Ard Biesheuvel wrote: > Instead of having a GCC specific routine to perform self-relocation > based on ELF metadata, use the PE/COFF metadata and the existing > PeCoff library routines. This reduces the amount of bespoke assembler > code that is a burden to maintain, and is not p

Re: [edk2-devel] [PATCH 1/4] ArmVirtPkg: add FDF rule for self-relocating PrePi

2020-06-09 Thread Laszlo Ersek
On 06/08/20 19:34, Ard Biesheuvel wrote: > In preparation for making the self-relocating PrePi use the ordinary > BasePeCoffLib routines for relocating the image in place in memory > at start, add a special FDF rule that builds SEC modules as PE32 > images with the relocation metadata preserved. >

Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: handle EFI_ACCESS_DENIED from LoadImage()

2020-06-09 Thread Laszlo Ersek
On 06/06/20 01:52, Laszlo Ersek wrote: > When an image fails Secure Boot validation, LoadImage() returns > EFI_SECURITY_VIOLATION if the platform policy is > DEFER_EXECUTE_ON_SECURITY_VIOLATION. > > If the platform policy is DENY_EXECUTE_ON_SECURITY_VIOLATION, then > LoadImage() returns EFI_ACCESS

Re: [edk2-devel] [edk2-InfSpecification PATCH] Clarify statement on package ordering

2020-06-09 Thread Laszlo Ersek
On 06/03/20 20:04, Laszlo Ersek wrote: > The description of [Packages] sections states, > >> Packages must be listed in the order that may be required for specifying >> include path statements for a compiler. For example, the >> MdePkg/MdePkg.dec file must be listed before the >> MdeModulePkg/MdeM

Re: [edk2-devel] [PATCH 0/2] OvmfPkg/Tcg2ConfigPei: trivial cleanups

2020-06-09 Thread Laszlo Ersek
On 06/03/20 19:04, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2752 > Repo: https://pagure.io/lersek/edk2.git > Branch: tcg_config_pei_trivial > > Two trivial cleanups after commit 89236992913f ("OvmfPkg: detect TPM 1.2 > in Tcg2ConfigPei", 2020-03-04) and commit

Re: [edk2-devel] [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type

2020-06-09 Thread Guo Dong
Reviewed-by: Dong, Guo Thanks, Guo > -Original Message- > From: Tan, Ming > Sent: Tuesday, June 9, 2020 4:24 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change > some PCDs type > > REF:

Re: [edk2-devel] [PATCH 0/3] Maintainers.txt: restore lexicographical order between package / subsystem headers

2020-06-09 Thread Laszlo Ersek
On 06/03/20 18:06, Laszlo Ersek wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2778 > Repo: https://pagure.io/lersek/edk2.git > Branch: sort_maintainers > > We originally meant to keep the subsystem (package) titles sorted, in > "Maintainers.txt". > > However, as of 7191dd3c599

Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero

2020-06-09 Thread Irene Park
Hi Ard, Would you please review this patch v2? Thank you, Irene -Original Message- From: Irene Park Sent: Tuesday, June 9, 2020 1:59 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero From: Irene Park PL011UartL

[edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero

2020-06-09 Thread Irene Park
From: Irene Park PL011UartLib determines its FIFO depth based on the PID2 value but the register PID2 is not mandatory as per the SBSA spec. This change won't check PID2 if PcdUartDefaultReceiveFifoDepth is set to a value > 0. Change-Id: I2dd7b3412f9306888078e0cb0488b902d4a8ace9 Signed-off-by: I

Re: [edk2-devel] [Question] How to static link OpenSSL library?

2020-06-09 Thread Liming Gao
Please refer to https://bugzilla.tianocore.org/show_bug.cgi?id=2420 This is another solution to generate the binary Crypto PEIM, DXE, and SMM modules. Then, you don't need to compile them again. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek >

[edk2-devel] [PATCH edk2-platforms v2 0/2] Optimize Smbios type 9

2020-06-09 Thread Ming Huang
Main change since v1: 1 Add some commit messages. Ming Huang (2): Silicon/Hisilicon/Smbios: correct coding style issue in type 9 Silicon/Hisilicon/Smbios: Optimize type 9 Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 325 +++- 1 file changed, 174 inserti

[edk2-devel] [PATCH edk2-platforms v2 2/2] Silicon/Hisilicon/Smbios: Optimize type 9

2020-06-09 Thread Ming Huang
Break down AddSmbiosType9Entry to three funtions for optimizing Smbios type 9. Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 173 +++- 1 file changed, 95 insertions(+), 78 deletions(-) diff --git a/S

[edk2-devel] [PATCH edk2-platforms v2 1/2] Silicon/Hisilicon/Smbios: correct coding style issue in type 9

2020-06-09 Thread Ming Huang
The main changes are whitespace/indentation fixing and wrapping of long lines and changing some macros from EFI_D_ERROR to DEBUG_ERROR. This patch is prepare for optimizing Smbios type 9. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 286 ++

Re: [edk2-devel] [PATCH edk2-platforms v1 1/2] Silicon/Hisilicon/Smbios: correct coding style issue in type 9

2020-06-09 Thread Ming Huang
在 2020/6/8 23:41, Leif Lindholm 写道: > On Mon, Jun 08, 2020 at 22:09:56 +0800, Ming Huang wrote: >> This patch is prepare for optimizing Smbios type 9. > > How? > The commit message should describe what the patch does. > > (Yes, I can see with "git diff -w" that this is mainly > whitespace/inde

[edk2-devel] [PATCH edk2-platforms v3 3/4] Silicon/Hisilicon/Acpi: Add update sas address feature

2020-06-09 Thread Ming Huang
The updating sas address feature is similar with apdating mac address. Modify updating dsdt flow for add this feature. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + Sili

[edk2-devel] [PATCH edk2-platforms v3 0/4] Improve D0x

2020-06-09 Thread Ming Huang
Main changes since v2: 1 Remove needless three lines. Ming Huang (4): Silicon/Hisilicon: Change updating dsdt in ready to boot event Silicon/Hisilicon: Add HISI_SAS_CONFIG_PROTOCOL Silicon/Hisilicon/Acpi: Add update sas address feature Silicon/Hisilicon: Rename EthMac files Silicon/Hisi

[edk2-devel] [PATCH edk2-platforms v3 4/4] Silicon/Hisilicon: Rename EthMac files

2020-06-09 Thread Ming Huang
As not only update mac address feature in EthMac files, so rename them to UpdateDsdt. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 2 +- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +- Silicon/Hisilicon/Drivers/AcpiPlatfo

[edk2-devel] [PATCH edk2-platforms v3 2/4] Silicon/Hisilicon: Add HISI_SAS_CONFIG_PROTOCOL

2020-06-09 Thread Ming Huang
Add HISI_SAS_CONFIG_PROTOCOL, provide get sas address interface, this is prepare for adding update sas address feature. Signed-off-by: Ming Huang --- Silicon/Hisilicon/HisiPkg.dec | 1 + Silicon/Hisilicon/Include/Protocol/HisiSasConfig.h | 43 2 files c

[edk2-devel] [PATCH edk2-platforms v3 1/4] Silicon/Hisilicon: Change updating dsdt in ready to boot event

2020-06-09 Thread Ming Huang
The dsdt need be updated before boot to OS, so change the updating to ready to boot event and can remove the needless dependence. Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm --- Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c | 56 +++- Silicon/Hisilicon/

Re: [edk2-devel] [PATCH edk2 v2 3/5] Silicon/Hisilicon/Acpi: Add update sas address feature

2020-06-09 Thread Leif Lindholm
On Tue, Jun 09, 2020 at 21:24:28 +0800, Ming Huang wrote: > > > 在 2020/6/9 1:15, Leif Lindholm 写道: > > Hi Ming, > > > > On Wed, May 27, 2020 at 22:33:56 +0800, Ming Huang wrote: > >> The updating sas address feature is similar with apdating mac address. > >> Modify updating dsdt flow for add thi

Re: [edk2-devel] [PATCH edk2 v2 3/5] Silicon/Hisilicon/Acpi: Add update sas address feature

2020-06-09 Thread Ming Huang
在 2020/6/9 1:15, Leif Lindholm 写道: > Hi Ming, > > On Wed, May 27, 2020 at 22:33:56 +0800, Ming Huang wrote: >> The updating sas address feature is similar with apdating mac address. >> Modify updating dsdt flow for add this feature. >> >> Signed-off-by: Ming Huang >> --- >> Silicon/Hisilicon/

Re: [edk2-devel] [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

2020-06-09 Thread Liming Gao
Shenglei: Seemly, ECC tool update is not related to this patch serial. Can you separate it? Besides, please update package yaml file with new ECC checker. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, June 3, 2020 4:48 PM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-06-09 Thread Liming Gao
Shenglei: Please also remove the deprecated code in MdeModulePkg. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Friday, June 5, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > > Subject: [PATCH] MdePkg: Remove code wrapped by > DIS

Re: [edk2-devel] ci problems

2020-06-09 Thread Laszlo Ersek
(Sorry about the delayed responses in all threads; I'm resuming my INBOX processing now...) On 06/05/20 23:00, Ard Biesheuvel wrote: > Hello all, > > I am seeing weird behavior trying to push some changes: > > https://github.com/tianocore/edk2/pull/664 > https://github.com/tianocore/edk2/pull/66

Re: [edk2-devel] [edk2-InfSpecification PATCH] Clarify statement on package ordering

2020-06-09 Thread Laszlo Ersek
On 06/04/20 08:25, Philippe Mathieu-Daudé wrote: > Hi Laszlo, > > On 6/3/20 8:04 PM, Laszlo Ersek wrote: >> The description of [Packages] sections states, >> >>> Packages must be listed in the order that may be required for specifying >>> include path statements for a compiler. For example, the >>

Re: [edk2-devel] [PATCH v2 0/5] Add a pipline to check Ecc issues for edk2 on open ci

2020-06-09 Thread Laszlo Ersek
On 06/04/20 07:38, Zhang, Shenglei wrote: > Hi Laszlo, > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Wednesday, June 3, 2020 10:27 PM >> To: devel@edk2.groups.io; Zhang, Shenglei >> Cc: Feng, Bob C ; Bret Barkelew >> ; Kinney, Michael D >> ; Gao, Liming

[edk2-devel] [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Ming Tan --- ...

[edk2-devel] [PATCH 1/5] Platform/Intel/SimicsOpenBoardPkg: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Agyeman Prince Signed-off-by: Ming Tan --- .../BoardX58Ich10/O

[edk2-devel] [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Ming Tan --- ...

[edk2-devel] [PATCH v3 3/4] UefiPayloadPkg/UefiPayloadPkgIa*.dsc: Change some PCDs type

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Signed-off-by: Ming T

[edk2-devel] [PATCH v3 1/4] MdeModulePkg.dec: Change PCDs for status code.

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 In order to support enable/disable report status code through memory or serial dynamic, change the following PCDs from [PcdsFeatureFlag] to [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]: PcdStatusCodeUseSerial Pcd

[edk2-devel] [PATCH v3 4/4] OvmfPkg/OvmfPkg*.dsc: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-b

[edk2-devel] [PATCH 5/5] Platform/Intel/Vlv2TbltDevicePkg: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Ming Tan --- .../Inte

[edk2-devel] [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2791 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc files. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Signed-o

[edk2-devel] [PATCH v3 2/4] EmulatorPkg/EmulatorPkg.dsc: Change PCDs type about status code

2020-06-09 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Since the type of PcdStatusCodeUseSerial and PcdStatusCodeUseMemory in MdeModulePkg.dec are changed, so change them from PcdsFeatureFlag to PcdsFixedAtBuild in dsc file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Ming Ta

Re: [edk2-devel] Device and driver

2020-06-09 Thread Kumar G
Thanks Tom On Tue, 9 Jun 2020 at 15:27, Tomas Pilar (tpilar) wrote: > Hi Kumar, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > * The UEFI drivers follow a two stage loading mechanism. When the driver > is loaded/executed, it loads itself into memory and i

Re: [edk2-devel] [PATCH 0/4] ArmVirtPkg: use PE/COFF metadata for self relocation

2020-06-09 Thread Julien Grall
Hi Ard, On 08/06/2020 18:34, Ard Biesheuvel wrote: As suggested by Jiewen in response to Ilias RFC [0], it is better to use the PE/COFF metadata for self-relocating executables than to rely on ELF metadata, given how the latter is only available when using ELF based toolchains. Also, we have had

Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level

2020-06-09 Thread Ard Biesheuvel
On 6/9/20 12:54 PM, Laszlo Ersek via groups.io wrote: gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it means that QEMU wasn't started with "-kernel". Log this status code as INFO rather than ERROR. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Philippe Mathieu-Daudé Signed-off

[edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level

2020-06-09 Thread Laszlo Ersek
gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it means that QEMU wasn't started with "-kernel". Log this status code as INFO rather than ERROR. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Philippe Mathieu-Daudé Signed-off-by: Laszlo Ersek --- Notes: Repo: https://pagur

Re: [edk2-devel] [PATCH v3 14/14] OvmfPkg: use generic QEMU image loader for secure boot enabled builds

2020-06-09 Thread Ard Biesheuvel
On 6/9/20 11:51 AM, Laszlo Ersek via groups.io wrote: Hi Ard, On 03/05/20 14:46, Ard Biesheuvel wrote: The QemuLoadImageLib implementation we currently use for all OVMF builds copies the behavior of the QEMU loader code that precedes it, which is to disregard UEFI secure boot policies entirely

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Ensure USB controller init before console

2020-06-09 Thread Pete Batard
On 2020.06.09 11:40, Ard Biesheuvel wrote: On 6/9/20 12:36 PM, Pete Batard wrote: Hi Ard, On 2020.06.09 11:06, Ard Biesheuvel wrote: Hi Pete, On 6/9/20 11:58 AM, Pete Batard wrote: Due to the nature of USB init on the Pi platforms, commit c8000e83b728baf04ced2fedb870bc3bc1b3 introduced a

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Ensure USB controller init before console

2020-06-09 Thread Ard Biesheuvel
On 6/9/20 12:36 PM, Pete Batard wrote: Hi Ard, On 2020.06.09 11:06, Ard Biesheuvel wrote: Hi Pete, On 6/9/20 11:58 AM, Pete Batard wrote: Due to the nature of USB init on the Pi platforms, commit c8000e83b728baf04ced2fedb870bc3bc1b3 introduced a regression with regards to ensuring that US

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Ensure USB controller init before console

2020-06-09 Thread Pete Batard
Hi Ard, On 2020.06.09 11:06, Ard Biesheuvel wrote: Hi Pete, On 6/9/20 11:58 AM, Pete Batard wrote: Due to the nature of USB init on the Pi platforms, commit c8000e83b728baf04ced2fedb870bc3bc1b3 introduced a regression with regards to ensuring that USB devices are operational by the time th

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Ensure USB controller init before console

2020-06-09 Thread Ard Biesheuvel
Hi Pete, On 6/9/20 11:58 AM, Pete Batard wrote: Due to the nature of USB init on the Pi platforms, commit c8000e83b728baf04ced2fedb870bc3bc1b3 introduced a regression with regards to ensuring that USB devices are operational by the time the console is up. This commit fixes this by adding ex

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

2020-06-09 Thread Pete Batard
NB: This patch is now superseded by https://edk2.groups.io/g/devel/message/60941 On 2020.06.08 18:24, Pete Batard via groups.io wrote: On 2020.06.08 18:10, Ard Biesheuvel wrote: On 6/8/20 7:01 PM, Pete Batard wrote: On 2020.06.08 17:43, Ard Biesheuvel wrote: On 6/8/20 5:51 PM, Pete Batard wr

[edk2-devel] [PATCH] ArmPkg/ArmExceptionLib: use static buffer for sp_el0

2020-06-09 Thread Heyi Guo
The exception library is also used in DxeMain before memory services are available, and AllocatePages() will fail in this case and cause sp_el0 remains 0. Then if any exception occurs before CpuDxe driver is loaded, a recursive exception will be trigged by page translation fault for sp = 0 - 0x130.

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Ensure USB controller init before console

2020-06-09 Thread Pete Batard
Due to the nature of USB init on the Pi platforms, commit c8000e83b728baf04ced2fedb870bc3bc1b3 introduced a regression with regards to ensuring that USB devices are operational by the time the console is up. This commit fixes this by adding explicit calls to connect USB controllers before cons

Re: [edk2-devel] Device and driver

2020-06-09 Thread Tomas Pilar (tpilar)
Hi Kumar, The UEFI drivers follow a two stage loading mechanism. When the driver is loaded/executed, it loads itself into memory and installs a DRIVER_BINDING_PROTOCOL on its own handle. That protocol provides API for the platform to ask the driver whether it supports a particular device and to

Re: [edk2-devel] [PATCH v3 14/14] OvmfPkg: use generic QEMU image loader for secure boot enabled builds

2020-06-09 Thread Laszlo Ersek
Hi Ard, On 03/05/20 14:46, Ard Biesheuvel wrote: > The QemuLoadImageLib implementation we currently use for all OVMF > builds copies the behavior of the QEMU loader code that precedes it, > which is to disregard UEFI secure boot policies entirely when it comes > to loading kernel images that have

[edk2-devel] [PATCH edk2-platforms V2 1/2] Silicon/NXP: Add SATA controller initialization driver

2020-06-09 Thread Meenakshi Aggarwal
Add support of SATA controller driver which performs controller initialization and register itself as NonDiscoverableMmioDevice Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/NxpQoriqLs.dec | 6 + Silicon/NXP/NxpQoriqLs.dsc.inc | 10 ++ Silicon/NXP/Dri

[edk2-devel] [PATCH edk2-platforms V2 0/2] Add SATA driver support

2020-06-09 Thread Meenakshi Aggarwal
This patchset implement SATA driver for NXP Platforms enable SATA for LX2160A Platform. Changes in v2: - Incorporated review comments - Removed header file and define macro in .c file Meenakshi Aggarwal (2): Silicon/NXP: Add SATA controller initialization driver Platform/NXP:L

[edk2-devel] [PATCH edk2-platforms V2 2/2] Platform/NXP:LX2160: Enable support of SATA controller

2020-06-09 Thread Meenakshi Aggarwal
- Enable support of SATA drives on lx2160 RDB board. - Increase FD size to accomodate SATA driver. Signed-off-by: Meenakshi Aggarwal --- Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 + Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++ Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf |

Re: [edk2-devel] [PATCH edk2-platforms v5 0/3] Add SerDes Support

2020-06-09 Thread Jonathan Cameron
On Tue, 9 Jun 2020 00:22:32 +0530 Wasim Khan wrote: > From: Wasim Khan Hi Wasim, Minor moan, please put a prefix on the patch description so those of us who scan read EDK2 lists don't have to open the thread to find out what SoC this applies to. Silicon/NXP: as done for the patches would wo

[edk2-devel] [Patch] BaseTools GenFv: Report the correct spare FV image size

2020-06-09 Thread Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2790 If the top FFS is placed in FV image, current FV will show there is no space. In fact, the pad ffs in FV image can be regarded as the spare space. This change reports the max pad ffs size as the spare space for use. Signed-off-by: Liming Ga