Re: [edk2-devel] [PATCH 2/5] MdeModulePkg/SmmCore: Remove UEFI LOADED_IMAGE from SMM.

Hi Mike, I did some investigation. The driver does affect drivers or libraries that use EDI_LOADED_IMAGE_PROTOCOL or Image Handle. In EDK2 repo, I find the following modules should be modified because of this code change. And after proper modification, the module will remain the same functionall

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

Reviewed-by: Eric Dong eric.d...@intel.com Pushed: SHA-1: 00b8bf7eda00fb6f0197d3968b6078cfdb4870fa * UefiCpuPkg/SecCore: Add pre-memory AP vector REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2776 Thanks, Eric From: Ni, Ray Sent: Tuesday, June 23, 2020 8:57 AM

Re: [edk2-devel] [PATCH v4 1/1] ProcessorPkg/Library: Add RiscVEdk2SbiLib

Thanks for spent time on reviewing this. Yes, we can have further discussions on where to merge RISC-V code. For now, we will merge those code to edk2-platforms master branch as the temporary home for RISC-V. Another matter regards to the inconsistent naming of "RISC-V", "RiscV" and etc. brough

Re: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application

Already give the R-B to the remain patches. Thanks, Zhichao > -Original Message- > From: Tomas Pilar > Sent: Monday, June 22, 2020 8:24 PM > To: devel@edk2.groups.io > Cc: nd ; Ni, Ray ; Gao, Zhichao > > Subject: RE: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application > > Hi Ra

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/23/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 23 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816013 ) *Organizer:* Brian Richardson brian.richa

Re: [edk2-devel] [PATCH v3 7/7] ShellPkg/AcpiView: Add application wrapper

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Tomas Pilar > Sent: Monday, June 15, 2020 10:04 PM > To: devel@edk2.groups.io > Cc: n...@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [PATCH v3 7/7] ShellPkg/AcpiView: Add application wrapper > > Simple application

Re: [edk2-devel] [PATCH v3 6/7] ShellPkg: Add AcpiViewCommandLib

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tomas Pilar > (tpilar) > Sent: Monday, June 15, 2020 10:04 PM > To: devel@edk2.groups.io > Cc: n...@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [edk2-devel] [PATCH v3 6/7] ShellPkg:

Re: [edk2-devel] [PATCH v3 5/7] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Tomas Pilar > Sent: Monday, June 15, 2020 10:04 PM > To: devel@edk2.groups.io > Cc: n...@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [PATCH v3 5/7] ShellPkg/AcpiView: Refactor DumpAcpiTableToFile > > Method is refa

Re: [edk2-devel] [PATCH v3 2/7] ShellPkg/AcpiView: Refactor configuration

See below. > -Original Message- > From: Tomas Pilar > Sent: Monday, June 15, 2020 10:04 PM > To: devel@edk2.groups.io > Cc: n...@arm.com; Ni, Ray ; Gao, Zhichao > > Subject: [PATCH v3 2/7] ShellPkg/AcpiView: Refactor configuration > > A new file and header (AcpiViewConfig.[ch]) is creat

Re: [edk2-devel] [PATCH v9 08/46] UefiCpuPkg: Implement library support for VMGEXIT

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Friday, June 19, 2020 11:39 PM > To: Tom Lendacky ; devel@edk2.groups.io; > Dong, Eric > Cc: Brijesh Singh ; Ard Biesheuvel > ; Justen, Jordan L ; > Gao, Liming ; Kinney, Michael D > ; Ni, Ray > Subje

Re: [edk2-devel] [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector

Reviewed-by: Ray Ni > -Original Message- > From: Cole, Deric > Sent: Wednesday, June 3, 2020 12:42 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [PATCH] UefiCpuPkg/SecCore: Add pre-memory AP vector > > Ray, > > The NOP is not a functional chan

Re: [edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

Hi Garrett, Thanks for report quickly and it work and the 'Mac format issue disappear'. But another build error occur 'error LNK2005: _InitializeFloatingPointUnits already defined in FspSecCoreT.lib(InitializeFpu.obj)' It seem that result by ApicLib who depend UefiCpuLib now. I want to know why

Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero

Adding Ard's new Arm e-mail address, and removing the old Linaro e-mail. Thanks, --Samer > -Original Message- > From: devel@edk2.groups.io On Behalf Of Irene > Park via groups.io > Sent: Monday, June 22, 2020 4:15 PM > To: devel@edk2.groups.io; ard.biesheu...@linaro.org > Subject: Re: [e

Re: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 if FiFoDepth is zero

Hi Ard, Would you please review this change ? I also wonder what you think of the following. #if FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) == 0 VS if (FixedPcdGet16 (PcdUartDefaultReceiveFifoDepth) == 0) or if (HardwareFifoDepth == 0) Thank you, Irene -Original Message- From: Irene

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg: Remove gEfiFormBrowserExProtocolGuid

Hi Edhaya, Thank you for the review. By the way, I don’t see it got mainlined yet. Do you mind to share when you’re going to pick it up ? Thank you, Irene From: devel@edk2.groups.io On Behalf Of G Edhaya Chandran Sent: Friday, June 5, 2020 4:12 AM To: Irene Park ; devel@edk2.groups.io Subject: Re

[edk2-devel] [PATCH v2] MdeModulePkg/DxeCorePerformanceLib: Switch to UnicodeStrnToAsciiStrS

UnicodeStrToAsciiStrS requires that the source string is shorter than the destination buffer and will ASSERT if this is not true. Switch to UnicodeStrnToAsciiStrS as there are cases where the source string is longer than the buffer allocated for the device path. Signed-off-by: Jeff Brasen --- ..

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo Sync Fails to Update Local Manifest

It seems when patches are being applied we are getting mixed line endings. This is making the patches a bit more difficult to review. We may want to look into fixing this. The quick fix would be to convert all Python files to CRLF. Reviewed-by: Erik Bjorge -Original Message- From: D

Re: [edk2-devel] [PATCH V1] UefiPayloadPkg:Fix NOOPT build failure

Reviewed-by: Maurice Ma > -Original Message- > From: Dong, Guo > Sent: Saturday, June 20, 2020 19:15 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo > Subject: [edk2-devel] [PATCH V1] UefiPayloadPkg:Fix NOOPT build failure > > When build UEFI payload using N

Re: [edk2-devel] EDK2 code standard question

On 06/19/20 19:25, Hernan via groups.io wrote: > Hi, > > I am a new to this group and I found something I think it is a problem in the > documentation for code standards of edk2. > Can you help me understand who/how I can request a revision on such detail in > the documentation? > > https://edk

Re: [edk2-devel] [PATCH v6 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

On 06/22/20 15:18, Garrett Kirkendall wrote: > AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register > causes and exception on AMD processors. If Execution Disable is > supported, but if the processor is an AMD processor, skip manipulating > MSR_IA32_MISC_ENABLE[34] XD Disable bit. >

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

On 06/22/20 06:57, Bi, Dandan wrote: >> -Original Message- >> From: devel@edk2.groups.io On Behalf Of Laszlo >> Ersek >> Sent: Friday, June 19, 2020 8:48 PM >> To: r...@edk2.groups.io; Bi, Dandan ; >> devel@edk2.groups.io >> Cc: Dong, Eric ; Ni, Ray ; Wang, >> Jian J ; Wu, Hao A ; Tan, >>

[edk2-devel] [PATCH v6 1/4] PcAtChipsetPkg: PcAtChipsetPkg.dsc add UefiCpuLib LibraryClass

In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, PcAtChipset/PcAtChipsetPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be using BaseX2XAp

[edk2-devel] [PATCH v6 0/4] AMD processor MSR_IA32_MISC_ENABLE

AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing this register on AMD causes an unhandled exception in SmmEntry.nasm and a subsequent failure to boot since this is too early in SMM path for the exception handler to be loaded. 1. Prepare PcAtChipsetPkg/PcAtChipsetPkg.dsc to

[edk2-devel] [PATCH v6 2/4] SourceLevelDebugPkg: SourceLevelDebugPkg.dsc add UefiCpuLib LibraryClass

In preparation for moving StandardSignatureIsAuthenticAMD to UefiCpuLib in UefiCpuPkg, SourceLevelDebugPkg/SourceLevelDebugPkg.dsc needs LibraryClass UefiCpuLib. LocalApicLib|UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.inf will need UefiCpuLib LibraryClass. Likely most "real" platforms will be us

[edk2-devel] [PATCH v6 3/4] UefiCpuPkg: Move StandardSignatureIsAuthenticAMD to BaseUefiCpuLib

Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib. This allows for future use of StandarSignatureIsAuthinticAMD without creating more instances in other modules. This function allows IA32/X64 code to determine if it

[edk2-devel] [PATCH v6 4/4] UefiCpuPkg: PiSmmCpuDxeSmm skip MSR_IA32_MISC_ENABLE manipulation on AMD

AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register causes and exception on AMD processors. If Execution Disable is supported, but if the processor is an AMD processor, skip manipulating MSR_IA32_MISC_ENABLE[34] XD Disable bit. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-o

Re: [edk2-devel] [PATCH v3 0/7] Standalone AcpiView Application

Hi Ray, Zhichao, Do you have any opinions on the respun patches? Cheers, Tom -Original Message- From: devel@edk2.groups.io On Behalf Of Tomas Pilar (tpilar) via groups.io Sent: 15 June 2020 15:04 To: devel@edk2.groups.io Cc: nd ; Ray Ni ; Zhichao Gao Subject: [edk2-devel] [PATCH v3 0

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Looks good to me. Not sure if there was a reason to call BmDestroyRamDisk before ReportStatusCode. By the way, it is an interesting case that there is a custom boot option or application that needs the memory that was occupied by the RAM disk. It looks to me like the custom boot option or appli

Re: [edk2-devel] [PATCH] Features/Intel/Debugging: Fix build error when use Xcode

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tan, > Ming > Sent: Monday, June 22, 2020 3:33 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-devel] [PATCH] Features/Intel/Debugging: Fix build error > when use Xcode >

[edk2-devel] [PATCH] Features/Intel/Debugging: Fix build error when use Xcode

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2822 When use Xcode, it will report following compile error: duplicate symbol _mRscHandlerProtocol in: So in the Features/Intel/Debugging/, change the global variable name in the following files RuntimeDxeBeepStatusCodeHandlerLib.c Runtime

Re: [edk2-devel] [edk2-rfc] MdeModulePkg/StatusCodeHandler: Separate NULL class libraries for Memory and serial handlers from MdeModulePkg/Universal/StatusCodeHandler modules

Hi Brian, Personally, I prefer to add the NULL class Library to StatusCodeHandler modules. 1. I think we should make the functionality of each module clear and separated. It may also be why we added ReportStatusCodeRouter and StatusCodeHandler modules in edk2 repo before. ReportStatusCodeRo