Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes

Sure. Update the commit message here: The partition binding driver would run serval times during BDS. If the partition supports MBR, it would pass the first connect in the MBR routine function. The second connect would return already started which would be treated as not found and continue to

[edk2-devel] [Patch v5 1/1] BaseTools: Add Guid name support in GenFfs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762 The Fv Section in the FDF files use hard coding Guid values which is inconvenient to manage. This patch adds Guid name support in GenFfs to solve this problem. v5 modified the format without fuctional change. Signed-off-by: Yuwei Chen

[edk2-devel] [Patch v4] BaseTools: Add Guid name support in GenFfs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762 The Fv Section in the FDF files use hard coding Guid values which is inconvenient to manage. This patch adds Guid name support in GenFfs to solve this problem. Signed-off-by: Yuwei Chen --- .../Source/Python/AutoGen/WorkspaceAutoGen.py |

Re: [edk2-devel] [PATCH v7 00/16] Add a plugin to check Ecc issues for edk2 on open ci

Shenglei: I have no other comment. This patch set is good to me. Reviewed-by: Liming Gao If no other comment, I suggest to merge this patch set before end of this week. Thanks Liming -Original Message- From: Zhang, Shenglei Sent: 2020年7月8日 9:57 To: Leif Lindholm Cc:

Re: [edk2-devel] [Patch] MdeModulePkg/Variable/RuntimeDxe: Fix return status from Reclaim()

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael D > Kinney > Sent: Friday, July 10, 2020 11:05 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [edk2-devel] [Patch] MdeModulePkg/Variable/RuntimeDxe:

Re: [edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchCheck.py: Add LicenseCheck"

Leif: Shenglei is working on new patch to add license checker as open CI plug-in (BZ 2833). This way allows to add the exception. So, the autogen file can be handled. Based on current statement, only BSD-2-Clause-Patent license will be allowed. Other license can be added as the exception case

Re: [edk2-devel] [Patch] MdeModulePkg/Variable/RuntimeDxe: Fix return status from Reclaim()

> -Original Message- > From: Kinney, Michael D > Sent: Friday, July 10, 2020 11:05 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Gao, Liming > Subject: [Patch] MdeModulePkg/Variable/RuntimeDxe: Fix return status from > Reclaim() > > REF:

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove >

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove >

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr()

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 4:13 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove >

Re: [edk2-devel] [PATCH V3 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value

Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 14, 2020 9:23 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH V3 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last > block value > > REF:

Re: [edk2-devel] [PATCH V3 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM

Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 14, 2020 9:23 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray > Subject: [PATCH V3 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add > for CD-ROM > > REF:

Re: [edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes

Zhichao, Can you add more information in the commit message on what bug the patch can fix? With that, Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Tuesday, July 14, 2020 9:23 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ;

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 07/14/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 14 July 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816381 ) *Organizer:* Brian Richardson

[edk2-devel] [PATCH V3 3/3] MdeModulePkg/PartitionDxe: Add already start check for child hanldes

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 Treat the EFI_ALREADY_STARTED as EFI_SUCCESS to avoid the partition driver continuely check next routine function. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Zhichao Gao Reviewed-by: Hao A Wu ---

[edk2-devel] [PATCH V3 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 Refer to http://manpages.ubuntu.com/manpages/bionic/man8/mkudffs.8.html. Some Linux ISOs may have the MBR table for compatibility reasons for Windows. The MBR tale would contain the partition entry with start LBA0 and whole media size.

[edk2-devel] [PATCH V3 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 PartitionValidMbr function's second parameter should be the last sector of the device. For MBR partition, the block size is sector size, i.e. 512 bytes. The original value is media block last LBA which is counted by the media block size.

[edk2-devel] [PATCH V3 0/3] MdeModulePkg/PartitionDxe: Fix the partition check issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2823 V1: Separate the UDF from the partition rountine array and do the check for every media. V2: Drop V1 because it is a bug: there should not be two partition types in one media. 1. Correct the LastBlock value in MBR handler. It should be

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.

Sure Laszlo, I will figure it out. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, July 14, 2020 2:06 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Schaefer, Daniel (DualStudy) ; Jian J Wang > ; Xiaoyu Lu ; Leif

Re: [edk2-devel] [PATCH V3 4/4] UefiCpuPkg: Add New Memory Attributes

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Friday, July 3, 2020 4:51 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Bi, Dandan ; Ni, Ray > ; ler...@redhat.com; Kumar, Rahul1 > ;

Re: [edk2-devel] [PATCH V3 3/4] UefiCpuPkg: Update EFI_MEMORY_CACHETYPE_MASK definition

Sorry, I missed this patch serial. Acked-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oleksiy > Yakovlev > Sent: Friday, July 3, 2020 4:51 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Kinney, Michael D > ; Bi, Dandan ; Ni, Ray > ; ler...@redhat.com;

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

On 7/13/20 12:09 PM, Laszlo Ersek wrote: Can you please ping me when the PatchCheck.py problem has been solved, so I can go ahead with the merge? Will do. -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#62455):

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

On 7/13/20 10:16 AM, Laszlo Ersek wrote: My understanding has been that you and Peter Grehan would be added as "R"s to Maintainers.txt, covering "OvmfPkg/Bhyve/". Has anything changed in that regard? No, that's still the plan. I'll update Maintainers.txt in a follow-up patch. -- Rebecca

Re: [edk2-devel] [edk2-platforms][PATCH v3 2/4] Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib

On Fri, Jul 03, 2020 at 16:48:54 +0530, Pranav Madhu wrote: > From: Deepak Pandey > > A slave error is generated when host accesses the config space of > non-available device or unimplemented function on a given bus. So > implement a n1sdp specific PciExpressLib library with a workaround to >

[edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

Hi Rebecca, On 07/13/20 18:55, Laszlo Ersek wrote: > On 07/13/20 07:41, Rebecca Cran wrote: >> BhyvePkg supports the bhyve hypervisor, which is a hypervisor/virtual >> machine manager available on FreeBSD, macOS and Illumos. >> >> Signed-off-by: Rebecca Cran >> --- >>

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.

On 07/13/20 11:27, Laszlo Ersek wrote: > Hi Abner, > > just noticed the following difference in this patch (now commit > 9025a014f9d9a): > > On 03/06/20 06:36, Abner Chang wrote: > >> diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf >> b/CryptoPkg/Library/OpensslLib/OpensslLib.inf >>

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation

On Fri, Jul 03, 2020 at 16:48:53 +0530, Pranav Madhu wrote: > From: Deepak Pandey > > Add the initial Arm's Neoverse N1 System-on-Chip platform library > support. This includes the virtual memory map and helper functions for > platform initialization. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board

Hi Pranav, Trying to build this port with clang fails for both DEBUG and RELEASE builds (CLANG38 profile, clang 7.0.1-8, debian) with: /work/git/edk2-platforms/Silicon/ARM/NeoverseN1Soc/Library/NeoverseN1SocPciExpressLib/NeoverseN1SocPciExpressLib.c:141:7: error: variable 'TableBase' is used

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

On 07/13/20 07:41, Rebecca Cran wrote: > BhyvePkg supports the bhyve hypervisor, which is a hypervisor/virtual > machine manager available on FreeBSD, macOS and Illumos. > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 251 +++ >

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable

Dont worry. The newes change did fix the issue. All our patches are on github. I will add them as references in future. Thanks, Marcello On Mon, Jul 13, 2020 at 5:58 PM Dong, Guo wrote: > > > Hi Marcello, > > > > I had fixed this issue in latest UefipayloadPkg. Please double check. > > > >

[edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs

Fix Option ROM enumeration and support scanning. (Resent because of missing CC) Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-Option_ROMs PR: https://github.com/tianocore/edk2/pull/790 Patrick Rudolph (2): MdeModulePkg: Fix OptionROM scanning UefiPayloadPkg: Scan for

[edk2-devel] [PATCH v1 2/2] UefiPayloadPkg: Scan for Option ROMs

From: Patrick Rudolph Install the gPciPlatformProtocol to scan for Option ROMs. For every device we probe the Option ROM and provide a pointer to the activated BAR if found. It's safe to assume that all ROM bars have been enumerated, reserved in the bridge resources and are disabled by

[edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix OptionROM scanning

From: Patrick Rudolph The Option ROM scanner can't work as enumeration was done by the first stage bootloader. Running it will disable the ability of the PCIPlatform code to scan for ROMs. Required for the following patch that enables custom Option ROM scanning using gPciPlatformProtocol.

[edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

From: Patrick Rudolph The BaseSerialPortLib16550 does fallback to a fixed address UART defined by PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a serial port at 0x3F8, otherwise it could cause errors during initialisation of a non-existent serial port on non legacy

[edk2-devel] [PATCH v2 0/1] Remove x86 legacy UART defaults

Do not fallback to a fixed UART base address, otherwise it can cause errors during initialisation of a non-existent serial port non legacy platforms. (Resent because of missing CC) v2: * extend commit message * add all Maintainer Patrick Rudolph (1): UefiPayloadPkg: Remove x86 legacy UART

Re: [edk2-devel] [PATCH edk2-platforms v3 4/5] Platform/NXP: Add LS1046AFRWY Platform

On Tue, Jul 07, 2020 at 23:57:18 -0500, Pankaj Bansal wrote: > From: Pankaj Bansal > > LS1046A Freeway (FRWY) is a high-performance development > platform that supports the QorIQ LS1046A Layerscape Architecture SOCs. > > Co-authored-by: Pramod Kumar > Signed-off-by: Pankaj Bansal

Re: [edk2-devel] [PATCH 1/1] Add BhyvePkg, to support the bhyve hypervisor

On 07/13/20 07:41, Rebecca Cran wrote: > BhyvePkg supports the bhyve hypervisor, which is a hypervisor/virtual > machine manager available on FreeBSD, macOS and Illumos. > > Signed-off-by: Rebecca Cran > --- > OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 251 +++ >

Re: [edk2-devel] [PATCH V3 3/4] UefiCpuPkg: Update EFI_MEMORY_CACHETYPE_MASK definition

Eric, Ray, can you please ACK this patch? Thanks Laszlo On 07/02/20 22:50, Oleksiy Yakovlev wrote: > Add EFI_MEMORY_WP attribute to > EFI_MEMORY_CACHETYPE_MASK definition. > > Signed-off-by: Oleksiy Yakovlev > --- > UefiCpuPkg/CpuDxe/CpuDxe.h | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [edk2-devel] [PATCH V3 2/4] MdeModulePkg: Add New Memory Attributes

Jian, Hao, do you intend to review this patch, or should we go with Dandan's R-b from ? Thanks Laszlo On 07/06/20 11:13, Laszlo Ersek wrote: > On 07/02/20 22:50, Oleksiy Yakovlev wrote: >> Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO >>

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

Reviewed-by: Guo Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marcello > Sylvester Bauer > Sent: Monday, July 13, 2020 1:25 AM > To: devel@edk2.groups.io > Cc: Patrick Rudolph ; Christian Walter > ; Ma, Maurice ; > Desimone, Nathaniel L ; Zeng, Star > >

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable

Hi Marcello, I had fixed this issue in latest UefipayloadPkg. Please double check. Sorry for the merge mistake. There is some issues to apply the patch copied from the email. So I manually add the changes since only few lines changes. But the mistake happens in that time ☹. I would be great

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

Wasim, Was there a specific function you had concerns about? Or was it confusion about the names? Hopefully the name confusion would have been fixed by 089e9c19a8c? Thanks, Andrew Fish > On Jul 13, 2020, at 8:31 AM, Laszlo Ersek wrote: > > On 07/12/20 18:54, Andrew Fish via groups.io

Re: [edk2-devel] EFI Timeout variable is ignored (initialized to default on every boot)

Hi, On 07/11/20 15:12, Andrei Borzenkov wrote: > Using 202005 version I am not able to change "Boot Maintenance Manager" > - "Auto Boot Time-out" or set Timeout variable from within Linux with > efibootmgr - value is overwritten with default (normally 0) on every > boot. The only possibility is

Re: [edk2-devel] [edk2-discuss] Need memory barriers in IoLib for AARCH64

On 07/12/20 18:54, Andrew Fish via groups.io wrote: > > >> On Jul 11, 2020, at 10:17 PM, Wasim Khan wrote: >> >> Hello >> >> Any comments ? >> > > I don’t see IoLibArm.c in master? I see IoLibNoIo.c. That's due to the rename in commit 089e9c19a8c1 ("MdePkg/BaseIoLibIntrinsic: Rename

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

As I mentioned in the previous comments, could you please CC all UefiPayloadPkg maintainers listed in the Maintainers.txt under the root of the EDK2 directory for code changes in UefiPayloadPkg ? Other than that, this patch looks good to me. Reviewed-by: Maurice Ma Thanks Maurice >

Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix OptionROM scanning

Hi, On 07/13/20 12:22, Marcello Sylvester Bauer wrote: > From: Patrick Rudolph > > The Option ROM scanner can't work as enumeration was done by the > first stage bootloader. Running it will disable the ability of the > PCIPlatform code to scan for ROMs. > > Required for the following patch

Re: [edk2-devel] openssl.exe disappeared

Hi Kilian, It must have been a temporary issue. The link is working for me this morning. Mike From: devel@edk2.groups.io On Behalf Of Kilian Kegel Sent: Sunday, July 12, 2020 5:35 AM To: devel@edk2.groups.io; Kinney, Michael D Cc: Richardson, Brian Subject: [edk2-devel] openssl.exe

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr()

On 07/13/20 10:12, Ni, Ray wrote: > MtrrSetFixedMtrr() sets all the fixed MTRR settings. > But in fact MtrrSetAllMtrrs() is always used by callers to set all > MTRR settings including the fixed and variable ones. > > The patch removes the necessary API MtrrSetFixedMtrr() to simplify (1)

Re: [edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

On 07/13/20 10:12, Ni, Ray wrote: > MtrrSetVariableMtrr() sets all the variable MTRR settings. > But in fact MtrrSetAllMtrrs() is always used by callers to set all > MTRR settings including the fixed and variable ones. > > The patch removes the necessary API MtrrSetVariableMtrr() to simplify (1)

Re: [edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

On 07/13/20 10:12, Ni, Ray wrote: > MtrrGetVariableMtrr() returns all the variable MTRR settings. > But in fact MtrrGetAllMtrrs() and > MtrrGetMemoryAttributeInVariableMtrr() are used by callers to get the > MTRR settings. The former one returns both the fixed and variable > MTRR settings. > >

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2PhysicalPresenceLib: Fix incorrect TCG VER comparision

On 07/10/20 16:27, Stefan Berger wrote: > On 7/10/20 9:53 AM, Stefan Berger wrote: >> On 7/10/20 1:43 AM, Laszlo Ersek wrote: >>> (+Marc-André, Stefan) >>> >>> On 07/10/20 02:44, Gao, Zhichao wrote: This bug is not obeserved by me. But I view the code. The condition is incorrect and it

Re: [edk2-devel] [Patch v4] BaseTools: Add Guid name support in GenFfs.

Yuwei, please remove Change-Id. -Original Message- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Monday, July 13, 2020 3:39 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [edk2-devel] [Patch v4] BaseTools: Add Guid name support in GenFfs. REF:

Re: [edk2-devel] [PATCH v3 0/2] refine TPM2 operation pull down list

Reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Monday, July 6, 2020 11:50 AM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Zhang, Chao B > ; Kumar, Rahul1 > Subject: [PATCH v3 0/2] refine TPM2 operation pull down list > > v2

Re: [edk2-devel] [edk2][PATCH 1/1] BcmGenetDxe: don't consume RX buffer until it's actually copied

One very minor formatting issue inline (that can be sorted during integration): On 2020.07.12 05:28, Andrei Warkentin wrote: This was originally a bit sloppy, and could hypothetically under heavy load result in a buffer being overwritten by hardware before the received buffer is copied.

[edk2-devel] [edk2-platforms][PATCH v3 1/1] Platform/RaspberryPi/Drivers: Add SD/(e)MMC card detection

The Raspberry Pi 3 and Pi 4 platforms (with latest EEPROM) can boot straight from USB, without the need for an SD card being present. However, the IsCardPresent () calls from the ArasanMmcHost and SdHost drivers are currently hardwired to return TRUE, which results in straight to USB boot failing

[edk2-devel] [edk2-platforms][PATCH v3 0/1] Platform/RaspberryPi/Drivers: Add SD/(e)MMC card detection

This supersedes https://edk2.groups.io/g/devel/message/62339 - 62340 Changes from v2: - Fix regression for CM3 module due to MMC/eMMC not accepting CMD8 Pete Batard (1): Platform/RaspberryPi/Drivers: Add SD/(e)MMC card detection

[edk2-devel] EFI Timeout variable is ignored (initialized to default on every boot)

Using 202005 version I am not able to change "Boot Maintenance Manager" - "Auto Boot Time-out" or set Timeout variable from within Linux with efibootmgr - value is overwritten with default (normally 0) on every boot. The only possibility is to use -boot menu=on QEMU option. Looking at code,

[edk2-devel] [PATCH] SignedCapsulePkg: Address NULL pointer dereference case.

Original code GetFmpImageDescriptors for OriginalFmpImageInfoBuf pointer, if failed, return a NULL pointer. The OriginalFmpImageInfoBuf should not be NULL and the NULL pointer dereference case should be false positive. Signed-off-by: Vin Xue --- .../SystemFirmwareUpdateDxe.c |

Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1g

On 07/10/20 04:27, Guomin Jiang wrote: > Upgrade openssl to 1.1.1g. the directory have been reorganized, > openssl moved crypto/include/internal to include/crypto folder. > So we change directory to match the re-organization. Right, the relevant OpenSSL commit seems to be 0c994d54afbb

[edk2-devel] [PATCH v1 2/2] UefiPayloadPkg: Scan for Option ROMs

From: Patrick Rudolph Install the gPciPlatformProtocol to scan for Option ROMs. For every device we probe the Option ROM and provide a pointer to the activated BAR if found. It's safe to assume that all ROM bars have been enumerated, reserved in the bridge resources and are disabled by

[edk2-devel] [PATCH v1 0/2] Add support for scanning Option ROMs

Fix Option ROM enumeration and support scanning. Branch: https://github.com/9elements/edk2-1/tree/UefiPayloadPkg-Option_ROMs PR: https://github.com/tianocore/edk2/pull/790 Patrick Rudolph (2): MdeModulePkg: Fix OptionROM scanning UefiPayloadPkg: Scan for Option ROMs

[edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix OptionROM scanning

From: Patrick Rudolph The Option ROM scanner can't work as enumeration was done by the first stage bootloader. Running it will disable the ability of the PCIPlatform code to scan for ROMs. Required for the following patch that enables custom Option ROM scanning using gPciPlatformProtocol.

Re: [edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDxe build time configurable

Hello Guo, regarding the master commit 48aa2edf5dae7a1e819ae01c43a326b6c97f20b1, I noticed that the patch was not merged properly. Instead of making TerminalDxe depend on DISABLE_SERIAL_TERMINAL, it does apply it to GraphicsConsoleDxe. Therefore it does not work as expected. Did this happen by

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 05/11] CryptoPkg: Add RISC-V architecture for EDK2 CI.

Hi Abner, just noticed the following difference in this patch (now commit 9025a014f9d9a): On 03/06/20 06:36, Abner Chang wrote: > diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf > b/CryptoPkg/Library/OpensslLib/OpensslLib.inf > index 3fa52f5543..01ee665183 100644 > ---

[edk2-devel] [PATCH v2 1/1] UefiPayloadPkg: Remove x86 legacy UART defaults

From: Patrick Rudolph The BaseSerialPortLib16550 does fallback to a fixed address UART defined by PcdSerialRegisterBase and does not initialize if it is zero. Do not assume a serial port at 0x3F8, otherwise it could cause errors during initialisation of a non-existent serial port on non legacy

[edk2-devel] [PATCH v2 0/1] Remove x86 legacy UART defaults

Do not fallback to a fixed UART base address, otherwise it can cause errors during initialisation of a non-existent serial port non legacy platforms. v2: * extend commit message * add all Maintainer Patrick Rudolph (1): UefiPayloadPkg: Remove x86 legacy UART defaults

Re: [edk2-devel] [PATCH] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

Please ignore this patch. I will send V2 with updated commit message. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, July 13, 2020 3:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM

> -Original Message- > From: Ni, Ray > Sent: Monday, July 13, 2020 2:45 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wu, Hao A ; Laszlo Ersek > Subject: RE: [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add > for CD-ROM > > > +// > > +// If the MBR with

[edk2-devel] [PATCH v2 1/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

MtrrGetVariableMtrr() returns all the variable MTRR settings. But in fact MtrrGetAllMtrrs() and MtrrGetMemoryAttributeInVariableMtrr() are used by callers to get the MTRR settings. The former one returns both the fixed and variable MTRR settings. The patch removes the necessary API

[edk2-devel] [PATCH v2 3/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr()

MtrrSetFixedMtrr() sets all the fixed MTRR settings. But in fact MtrrSetAllMtrrs() is always used by callers to set all MTRR settings including the fixed and variable ones. The patch removes the necessary API MtrrSetFixedMtrr() to simplify the MtrrLib API. There is no code in edk2 and

[edk2-devel] [PATCH v2 2/3] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr()

MtrrSetVariableMtrr() sets all the variable MTRR settings. But in fact MtrrSetAllMtrrs() is always used by callers to set all MTRR settings including the fixed and variable ones. The patch removes the necessary API MtrrSetVariableMtrr() to simplify the MtrrLib API. There is no code in edk2 and

[edk2-devel] [PATCH v2 0/3] Remove unnecessary APIs in MtrrLib

Ray Ni (3): UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr() UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetVariableMtrr() UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrSetFixedMtrr() UefiCpuPkg/Include/Library/MtrrLib.h | 47 +--

Re: [edk2-devel] [PATCH v5 9/9] SecurityPkg/TcgPei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Guomin > Sent: Thursday, July 09, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B ; Zhang, Qi1 ; > Kumar, Rahul1 > Subject: [PATCH v5 9/9] SecurityPkg/TcgPei: Use

Re: [edk2-devel] [PATCH v5 7/9] UefiCpuPkg/CpuMpPei: Enable paging and set NP flag to avoid TOCTOU (CVE-2019-11098)

Guomin, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Thursday, July 09, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek > ; Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v5 7/9] UefiCpuPkg/CpuMpPei: Enable paging

[edk2-devel] [PATCH] UefiCpuPkg/MtrrLib: Remove unnecessary API MtrrGetVariableMtrr()

MtrrGetVariableMtrr() returns all the variable MTRR settings. But in fact MtrrGetAllMtrrs() is always used by callers to get all MTRR settings including the fixed and variable ones. The patch removes the necessary API MtrrGetVariableMtrr() to simplify the MtrrLib API. There is no code in edk2

[edk2-devel] [Patch v4] BaseTools: Add Guid name support in GenFfs.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762 The Fv Section in the FDF files use hard coding Guid values which is inconvenient to manage. This patch adds Guid name support in GenFfs to solve this problem. v4 add comments for new function without functional modification. Change-Id:

Re: [edk2-devel] [PATCH V2 1/3] MdeModulePkg/PartitionDxe: Correct the MBR last block value

Sure. I would follow the 3 suggestion in next version patch set. Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Monday, July 13, 2020 1:59 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wu, Hao A ; Laszlo Ersek > Subject: RE: [PATCH V2 1/3] MdeModulePkg/PartitionDxe:

Re: [edk2-devel] [PATCH v5 6/9] SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Jiang, Guomin > Sent: Thursday, July 09, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B ; Zhang, Qi1 ; > Kumar, Rahul1 > Subject: [PATCH v5 6/9] SecurityPkg/Tcg2Pei: Use

Re: [edk2-devel] [PATCH v5 5/9] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

Guomin, Some typo or syntax issues below. > -Original Message- > From: Jiang, Guomin > Sent: Thursday, July 09, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Bi, Dandan ; Gao, Liming ; De, > Debkumar ; Han, Harry ; > West, Catharine ; Laszlo Ersek >

Re: [edk2-devel] [PATCH v5 4/9] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

Guomin, Just one minor comment below. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guomin > Jiang > Sent: Thursday, July 09, 2020 9:57 AM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Dong, Eric > ; Ni, Ray ; Laszlo Ersek > ; Kumar, Rahul1 ; De, >

Re: [edk2-devel] [PATCH V2 2/3] MdeModulePkg/PartitionDxe: Skip the MBR that add for CD-ROM

> +// > +// If the MBR with partition entry contains itself, i.e. start with LBA0, > +// and have the same size with the media, we treat it as a El Torito > partition. > +// > +if ((StartingLBA == 0) && > +(SizeInLBA != 0) && 1. Can this check "SizeInLBA != 0" be

Re: [edk2-devel] [PATCH v5 2/9] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

Guomin, See my 16 comments embedded below. About PcdMigrateTemporaryRamFirmwareVolumes, I think we need more discussions on its use scenario along with PcdShadowPeimOnBoot and PcdShadowPeimOnS3Boot. Currently it need all of them enabled to make this solution work, which is a bit complex and