Re: [edk2-devel] [PATCH V2 1/2] BaseTools: Add gcc flag to warn on void* pointer arithmetic

What would be your suggestion on the approach to apply this build option to all architectures? Change the tool_def.txt firstly and push platform owner to fix the corresponding firmware code, or changing the tool_def.txt later, until this change will not break any platform build? -Original

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

Acked-by: Samer El-Haj-Mahmoud > -Original Message- > From: Pankaj Bansal > Sent: Saturday, July 4, 2020 11:52 AM > To: devel@edk2.groups.io; Eric Jin ; G Edhaya Chandran > > Cc: Pankaj Bansal ; Paul Yang > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Gaurav Jain > Subject: [PATCH

[edk2-devel] [edk2-test][PATCH v1 0/3] uefi-sct/SctPkg: Build Aarch64 with latest EDK2

Update the SctPkg build scripts and HowTo to build for AARCH64 with latest EDK2, without depending on UDK2017. This series depends on the change in: https://edk2.groups.io/g/devel/message/60407 Samer El-Haj-Mahmoud (3): uefi-sct/SctPkg: Fix build with latest EDK2 uefi-sct/SctPkg: Add build

[edk2-devel] [edk2-test][PATCH v1 3/3] uefi-sct/SctPkg: Remove obsolete version macros

Remove the obsolete EFI_SPECIFICATION_VERSION and TIANO_RELEASE_VERSION macros, which are not passed in as command line arguments anymore. Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 20

[edk2-devel] [edk2-test][PATCH v1 2/3] uefi-sct/SctPkg: Add build instructions with latest EDK2

Add new HowToBuild instructions with latest EDK2, for AARCH64 Linux. Tested with WSL on Windows 10 Build 19041 Cc: G Edhaya Chandran Cc: Eric Jin Cc: Irene Park Cc: Heinrich Schuchardt Signed-off-by: Samer El-Haj-Mahmoud --- uefi-sct/HowToBuild/How to build SCT.txt | 15 +++ 1

[edk2-devel] [edk2-test][PATCH v1 1/3] uefi-sct/SctPkg: Fix build with latest EDK2

Update the SctPkg build.sh script to work with latest EDK2, without depending on UDK2017. Changes include: - Allowing GCC versions 5+ - Refactoring WORKSPACE based on the new EDK2 stuructre (SctPkg is treated as another PACKAGES_PATH component, not a package in the Edk2 folder itself) -

Re: [edk2-devel] [PATCH] UefiCpuPkg/MtrrLib/UnitTest: Add host based unit test

Hi Ray, In the following Unit Test Functions, I recommend passing in mDefaultSystemParameter as the Context parameter to reduce the use of a global variables. * UnitTestIsMtrrSupported() * UnitTestGetVariableMtrrCount() * UnitTestGetFirmwareVariableMtrrCount() * UnitTestMtrrGetFixedMtrr() *

[edk2-devel] [Patch] MdePkg/Library/UnitTestHostBaseLib: Add missing services

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2862 Add ReadMmx()/WriteMmx() services Add MemoryFence() service Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Michael D Kinney --- .../Library/BaseLib/UnitTestHostBaseLib.inf | 34 +++ 1 file changed,

[edk2-devel] [PATCH v4 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it

[edk2-devel] [PATCH v4 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Signed-off-by: Vladimir Olovyannikov Tested-By: Samer El-Haj-Mahmoud Tested-By: Laszlo Ersek Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image

Re: [edk2-devel] [PATCH v11 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

On 7/23/20 9:59 AM, Gao, Liming wrote: Tom: -Original Message- From: Tom Lendacky Sent: Thursday, July 23, 2020 10:19 PM To: Gao, Liming ; Laszlo Ersek ; Liu, Zhiguang ; devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Kinney, Michael D ;

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

Hi Andrew, On 2020.07.23 18:15, Andrew Fish wrote: On Jul 23, 2020, at 8:47 AM, Leif Lindholm > wrote: Hi Pete, On Thu, Jul 23, 2020 at 15:38:55 +0100, Pete Batard wrote: @@ -626,6 +627,28 @@ BIOSInfoUpdateSmbiosType0 (    INTN   i;    INTN   State = 0;    INTN   

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 23, 2020 6:30 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re:

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

Hi Laszlo, Thank you for testing! > -Original Message- > From: Laszlo Ersek > Sent: Thursday, July 23, 2020 8:03 AM > To: devel@edk2.groups.io; vladimir.olovyanni...@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

> On Jul 23, 2020, at 8:47 AM, Leif Lindholm wrote: > > Hi Pete, > > On Thu, Jul 23, 2020 at 15:38:55 +0100, Pete Batard wrote: @@ -626,6 +627,28 @@ BIOSInfoUpdateSmbiosType0 ( INTN i; INTN State = 0; INTN Value[2]; + INTN Year = (__DATE__[7] == '?'

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

Hi Pete, On Thu, Jul 23, 2020 at 15:38:55 +0100, Pete Batard wrote: > > > @@ -626,6 +627,28 @@ BIOSInfoUpdateSmbiosType0 ( > > > INTN i; > > > INTN State = 0; > > > INTN Value[2]; > > > + INTN Year = (__DATE__[7] == '?' ? 1900 \ > > > + : (((__DATE__[7] - '0') *

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 07/23/20 16:54, Laszlo Ersek wrote: > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: >> Introduce an http client utilizing EDK2 HTTP protocol, to >> allow fast image downloading from http/https servers. >> HTTP download speed is usually faster than tftp. >> The client is based on

Re: [edk2-devel] [PATCH v11 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

Tom: > -Original Message- > From: Tom Lendacky > Sent: Thursday, July 23, 2020 10:19 PM > To: Gao, Liming ; Laszlo Ersek ; > Liu, Zhiguang ; > devel@edk2.groups.io > Cc: Brijesh Singh ; Ard Biesheuvel > ; Dong, Eric ; Justen, > Jordan L ; Kinney, Michael D > ; Ni, Ray > Subject: Re:

Re: [edk2-devel] [PATCH v2 1/2] ArmVirtPkg: enable HttpDynamiCommand

On 07/22/20 22:54, Vladimir Olovyannikov wrote: > Enable HttpDynamicCommand (http Shell command) > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 > > Signed-off-by: Vladimir Olovyannikov > --- > ArmVirtPkg/ArmVirt.dsc.inc | 4 > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > Introduce an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command,

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

Hi Leif, On 2020.07.23 12:08, Leif Lindholm wrote: On Mon, Jul 20, 2020 at 17:15:07 +0100, Pete Batard wrote: Per SMBIOS specs, The Type 0 BIOS Release Date is not a free form field but must be specified in a US middle-endian format (mm/dd/), so make sure we populate it accordingly by

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 24 July 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200723T142054Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200724T013000Z DTEND:20200724T023000Z

Re: [edk2-devel] [PATCH v11 06/46] MdePkg/BaseLib: Add support for the XGETBV instruction

On 7/22/20 8:16 PM, Gao, Liming wrote: Laszlo: -Original Message- From: Laszlo Ersek Sent: 2020年7月23日 4:28 To: Liu, Zhiguang ; devel@edk2.groups.io; thomas.lenda...@amd.com Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Gao, Liming ; Kinney, Michael D ; Ni, Ray

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: enable HttpDynamicCommand

On 07/22/20 22:54, Vladimir Olovyannikov via groups.io wrote: > Enable HttpDynamicCommand (Shell command "http") for OvmfPkg platforms. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 > > Signed-off-by: Vladimir Olovyannikov > --- > OvmfPkg/OvmfPkgIa32.dsc| 4 >

Re: [edk2-devel] [PATCH v2 2/3] DynamicTablesPkg: Add EDK2 Core CI support

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63198): https://edk2.groups.io/g/devel/message/63198 Mute This Topic: https://groups.io/mt/75221024/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 3/3] .pytool: CI Settings to support DynamicTablesPkg

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63200): https://edk2.groups.io/g/devel/message/63200 Mute This Topic: https://groups.io/mt/75221027/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 4/4] .azurepipelines: Add DynamicTablesPkg to CI matrix

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63199): https://edk2.groups.io/g/devel/message/63199 Mute This Topic: https://groups.io/mt/75221030/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Fix issues reported by EDKII CI

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63197): https://edk2.groups.io/g/devel/message/63197 Mute This Topic: https://groups.io/mt/75221026/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v2 0/3] Add EDKII CI support for DynamicTablesPkg

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#63201): https://edk2.groups.io/g/devel/message/63201 Mute This Topic: https://groups.io/mt/75221023/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH edk2-test 1/1] SctPkg: fix page alignment calculations

ping!! > -Original Message- > From: Pankaj Bansal (OSS) > Sent: Saturday, July 4, 2020 9:22 PM > To: devel@edk2.groups.io; Eric Jin ; G Edhaya Chandran > > Cc: Pankaj Bansal ; Paul Yang ; > Samer El-Haj-Mahmoud ; Gaurav Jain > > Subject: [PATCH edk2-test 1/1] SctPkg: fix page alignment

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > Introduce an http client utilizing EDK2 HTTP protocol, to > allow fast image downloading from http/https servers. > HTTP download speed is usually faster than tftp. > The client is based on the same approach as tftp dynamic command,

Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg: enable HttpDynamicCommand

On 07/22/20 22:54, Vladimir Olovyannikov via groups.io wrote: > Enable HttpDynamicCommand (Shell command "http") for OvmfPkg platforms. > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 > > Signed-off-by: Vladimir Olovyannikov > --- > OvmfPkg/OvmfPkgIa32.dsc| 4 >

Re: [edk2-devel] [PATCH v2 1/2] ArmVirtPkg: enable HttpDynamiCommand

On 07/22/20 22:54, Vladimir Olovyannikov via groups.io wrote: > Enable HttpDynamicCommand (http Shell command) > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2857 > > Signed-off-by: Vladimir Olovyannikov > --- > ArmVirtPkg/ArmVirt.dsc.inc | 4 >

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib

Series pushed as d0da48f112de..e43d0884ed93, with parentheses dropped as per Laszlo's comment, and Pierre added as reported-by for this flavour of this patch. Regards, Leif On Wed, Jul 22, 2020 at 22:34:52 +0200, Laszlo Ersek wrote: > On 07/21/20 14:50, Leif Lindholm wrote: > > Commit

Re: [edk2-devel] [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header

Liming. Thanks for completing the review. This is just a comment change ask and I can mend the comment to send again. Ashraf > -Original Message- > From: Gao, Liming > Sent: Thursday, July 23, 2020 3:18 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Kinney, Michael D > Subject:

Re: [edk2-devel] [PATCH V3 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers

Liming; My response inline. Thanks for the review. Ashraf > -Original Message- > From: Gao, Liming > Sent: Thursday, July 23, 2020 3:36 PM > To: devel@edk2.groups.io; Javeed, Ashraf > Cc: Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH V3 1/2] MdePkg/Include/IndustryStandard: >

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

On Mon, Jul 20, 2020 at 17:15:07 +0100, Pete Batard wrote: > Per SMBIOS specs, The Type 0 BIOS Release Date is not a free form field but > must be specified in a US middle-endian format (mm/dd/), so make sure > we populate it accordingly by converting gcc's __DATE__ string. This is > required

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: fix gcc build errors in AndroidBootImgLib

On Wed, Jul 22, 2020 at 22:34:52 +0200, Laszlo Ersek wrote: > On 07/21/20 14:50, Leif Lindholm wrote: > > Commit dbd546a32d5a > > ("BaseTools: Add gcc flag to warn on void* pointer arithmetic") > > does its work and triggers build errors in this library. > > Update the affected code to build

Re: [edk2-devel] [PATCH v1 2/2] EmbeddedPkg: Add cast from (void*) for VS2017 build

On Wed, Jul 22, 2020 at 23:11:40 +0200, Laszlo Ersek wrote: > >> diff --git a/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > >> b/EmbeddedPkg/Library/AndroidBootImgLib/AndroidBootImgLib.c > >> index > >>

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: enable HttpDynamicCommand

On 07/22/20 22:02, Vladimir Olovyannikov wrote: > Hi Laszlo, > > Thank you for reviewing the patchset. Thank *you* for submitting the set, at my request! :) >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, July 22, 2020 12:52 PM >> To: Vladimir Olovyannikov ; >>

Re: [edk2-devel] [PATCH V3 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers

Ashraf: -Original Message- From: devel@edk2.groups.io On Behalf Of Javeed, Ashraf Sent: 2020年7月22日 23:22 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [edk2-devel] [PATCH V3 1/2] MdePkg/Include/IndustryStandard: CXL 1.1 Registers BZ:

Re: [edk2-devel] [PATCH v3 2/3] MdePkg/BasePciExpressLib: Support variable size MMCONF

-Original Message- From: devel@edk2.groups.io On Behalf Of Marcello Sylvester Bauer Sent: 2020年7月22日 21:16 To: devel@edk2.groups.io Cc: Patrick Rudolph ; Christian Walter ; Kinney, Michael D ; Gao, Liming Subject: [edk2-devel] [PATCH v3 2/3] MdePkg/BasePciExpressLib: Support

Re: [edk2-devel] [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header

Asharf: -Original Message- From: Javeed, Ashraf Sent: 2020年7月22日 23:22 To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming Subject: [PATCH V3 2/2] MdePkg/Include/IndustryStandard: Main CXL header BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2611 Introducing the Cxl.h

Re: [edk2-devel] [PATCH V2 1/2] BaseTools: Add gcc flag to warn on void* pointer arithmetic

Hi Andrew, Agreed. I also think this should be applied across all architectures, not just ARM/AARCH64. Since Visual Studio has never been been able to compile the affected code, I expect impact to Ia32/X64 to be minimal. Regards, Leif On Wed, Jul 22, 2020 at 19:49:01 -0700, Andrew Fish via

Re: [edk2-devel] A problem to build KabyLake

Thank you, Nate. Canh On Wed, Jul 22, 2020 at 8:18 PM Desimone, Nathaniel L < nathaniel.l.desim...@intel.com> wrote: > Hi Canh, > > > > Yes, the Intel Amberlake FSP has been automatically included in the FD > file. The final FD file is found at >

Re: [edk2-devel] [Patch] Revert "BaseTools: Add gcc flag to warn on void* pointer arithmetic"

On Thu, Jul 23, 2020 at 08:41:29 +0800, Bob Feng wrote: > This reverts commit dbd546a32d5abe225306e22d43a7d86e3a042eee. > > This patch also breaks about half of the ARM/AARCH64 platforms in > edk2-platforms > > Signed-off-by: Bob Feng Reviewed-by: Leif Lindholm Thanks! > Cc: Pierre Gondois

Re: [edk2-devel] [PATCH v11 03/46] MdePkg: Add the MSR definition for the GHCB register

Reviewed-by: Liming Gao -Original Message- From: devel@edk2.groups.io On Behalf Of Lendacky, Thomas Sent: 2020年7月22日 5:19 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject:

Re: [edk2-devel] [PATCH v11 04/46] MdePkg: Add a structure definition for the GHCB

Reviewed-by: Liming Gao -Original Message- From: Tom Lendacky Sent: 2020年7月22日 5:19 To: devel@edk2.groups.io Cc: Brijesh Singh ; Ard Biesheuvel ; Dong, Eric ; Justen, Jordan L ; Laszlo Ersek ; Gao, Liming ; Kinney, Michael D ; Ni, Ray Subject: [PATCH v11 04/46] MdePkg: Add a

[edk2-devel] [PATCH] SecurityPkg/Library: Adjust the status codes for SubmitCommand

The status codes of EFI_TCG2_PROTOCOL.SubmitCommand() defined in "TCG EFI Protocol Specification for TPM 2.0" Version 1.0 Revision 0.13 are EFI_SUCCESS, EFI_DEVICE_ERROR, EFI_INVALID_PARAMETER, and EFI_BUFFER_TOO_SMALL. Since Tcg2SubmitCommand() returns the status code of Tpm2SubmitCommand()

Re: [edk2-devel] [PATCH v3 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule.

Reviewed-by: Bob Feng -Original Message- From: Jiang, Guomin Sent: Wednesday, July 22, 2020 6:33 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH v3 1/1] BaseTools/Scripts: Ignore the CRLF check when upgrade submodule. If the submodule is upgraded, skip the