Re: [edk2-devel] Doubt in MinPlatform QemuOpenBoardPkg task

2021-04-09 Thread Nate DeSimone
Hi Kaaira, Great questions! So I’ll start out describing what the FSP is and why we built it. The FSP (Firmware Support Package) is a mechanism Intel developed to distribute chipset initialization code that must be run during bootup in a binary format. Historically there were multiple

Re: [EXTERNAL] Re: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Bret Barkelew via groups.io
Andrew, Not a scheme that I would consider a “good” scheme. You can see what we’re running CI against (in Mu and EDK, both), by checking for the “UsePythonVersion” command in the .azurepipelines/pr-gate-steps.yml file. Shivanshi, I just ran a build on my system with that exact version of

Re: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Andrew Fish via groups.io
> On Apr 9, 2021, at 1:55 PM, Bret Barkelew via groups.io > wrote: > > It looks like a Python 3.8.x vs 3.9.x issue. > Do we have a scheme to require a min Python version? Thanks, Andrew Fish > It looks as if you’re using Mu Q35 as your platform. Can you tell me what > branch you’re on? >

Re: [edk2-devel] [RFC PATCH 00/19] Add AMD Secure Nested Paging (SEV-SNP) support

2021-04-09 Thread Brijesh Singh
On 4/9/21 7:24 AM, Laszlo Ersek wrote: > On 04/08/21 13:59, Brijesh Singh wrote: >> On 4/8/21 4:58 AM, Laszlo Ersek wrote: >>> On 03/24/21 16:31, Brijesh Singh wrote: At this time we only support the pre-validation. OVMF detects all the available system RAM in the PEI phase. When

Re: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Pandya, Shivanshi
Hi Bret, That's correct. I cloned release/202008 branch. Just trying to follow below instructions : https://github.com/microsoft/mu_tiano_platforms/blob/release/202008/Platforms/QemuQ35Pkg/Docs/Development/building.md Regards, Shivanshi From: Bret Barkelew Sent: Friday, April 9, 2021 3:56 PM

[edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template

2021-04-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3313 Change MAKE_FLAG to MAKE_FLAGS to match required name from EDK II Build Specifications for VS20xx tool chains. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- BaseTools/Conf/tools_def.template | 16

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability

2021-04-09 Thread Nate DeSimone
The series has been pushed as 3204cbfe~..ade2b32 Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, April 8, 2021 2:25 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject:

[edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-09 Thread Michael D Kinney
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3312 Update parsing of MAKE_FLAGS in DSC [BuildOptions] sections to split the flags into a list to be compatible with running the make command using Popen(). Parsing MAKE_FLAGS from tools_def.txt already uses _SplitOption(). This change uses

Re: [edk2-devel] [edk2-platforms] [PATCH v5 0/4] Add Large Variable Libraries

2021-04-09 Thread Nate DeSimone
The series has been pushed as 8c62040~..c1d10aa Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, April 7, 2021 12:17 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Liming Gao ; Dong, Eric ; Michael Kubacki ; Oram, Isaac W Subject:

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/2] MinPlatformPkg: Improve NULL ACPI table lib maintainability

2021-04-09 Thread Nate DeSimone
For the series... Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, April 8, 2021 2:25 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-devel]

Re: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Bret Barkelew via groups.io
It looks like a Python 3.8.x vs 3.9.x issue. It looks as if you’re using Mu Q35 as your platform. Can you tell me what branch you’re on? - Bret From: Pandya, Shivanshi via groups.io Sent: Friday, April 9, 2021 1:52 PM To:

Re: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Andrew Fish via groups.io
1st thing to check is to see if your *.FDF files have a syntax error and the is just bad error processing. Thanks, Andrew Fish > On Apr 9, 2021, at 12:10 PM, Pandya, Shivanshi > wrote: > > Hello, > > Build failed with following call trace > > build.py... > INFO - : error C0DE: Unknown

[edk2-devel] Build Failed for QEMU35Pkg

2021-04-09 Thread Pandya, Shivanshi
Hello, Build failed with following call trace build.py... INFO - : error C0DE: Unknown fatal error when processing [c:\bea\dfci\mu_tiano_platforms\Common\PRM\PrmPkg\Library\DxePrmModuleDiscoveryLib\DxePrmModuleDiscoveryLib.inf [X64, VS2017, DEBUG]] INFO - INFO - (Please send email to

Re: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

2021-04-09 Thread Bret Barkelew via groups.io
+ @Liming Gao - Bret From: Bret Barkelew via groups.io Sent: Friday, April 9, 2021 11:25 AM To: devel@edk2.groups.io Cc: Jian J Wang; Hao A

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

2021-04-09 Thread Bret Barkelew
DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer pointer is NULL and the indirect Size is anything but 0. Since this TempSize was not being initialized it is very likely that this sequence would not return the total buffer size as expected. Bugzilla:

[edk2-devel] separate OVMF binary for TDX? [was: OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest]

2021-04-09 Thread Laszlo Ersek
On 04/09/21 15:44, Yao, Jiewen wrote: > Hi Laszlo > Thanks. > > We did provide a separate binary in the beginning - see > https://github.com/tianocore/edk2-staging/tree/TDVF, with same goal - easy to > maintain and develop. A clean solution, definitely. > > However, we got requirement to

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

2021-04-09 Thread Yao, Jiewen
Hi Laszlo Thanks. We did provide a separate binary in the beginning - see https://github.com/tianocore/edk2-staging/tree/TDVF, with same goal - easy to maintain and develop. A clean solution, definitely. However, we got requirement to deliver one binary solution together with 1) normal OVMF,

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

2021-04-09 Thread Laszlo Ersek
Hi Ray, On 04/09/21 02:45, Ni, Ray wrote: > Laszlo, > OVMF isn't using this timerlib so I will assume you doesn't care about > this change. correct; that's why I gave my ACK for v1 in last September [1] [2] [3] -- I didn't want to block progress on this patch. To be frank, I don't understand

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

2021-04-09 Thread Laszlo Ersek
Hi Min, On 04/08/21 15:31, Lendacky, Thomas wrote: > On 4/8/21 1:24 AM, Xu, Min M wrote: >> Yes this is the root cause. TDX requires the startup mode to be 32-bit >> protected mode while the legacy VM startup mode is 16-bit real mode. >> Add more BITS directives can work round this. I have tried

Re: [edk2-devel] [RFC PATCH 01/19] OvmfPkg: Reserve the Secrets and Cpuid page for the SEV-SNP guest

2021-04-09 Thread Laszlo Ersek
On 04/08/21 15:31, Tom Lendacky wrote: > On 4/8/21 1:24 AM, Xu, Min M wrote: >> On Wednesday, April 7, 2021 11:03 PM, Laszlo wrote: >>> On 04/07/21 02:44, James Bottomley wrote: On Wed, 2021-04-07 at 00:21 +, Xu, Min M wrote: > Hi, Laszlo > > For Intel TDX supported guest, all

Re: [edk2-devel] [RFC PATCH 00/19] Add AMD Secure Nested Paging (SEV-SNP) support

2021-04-09 Thread Laszlo Ersek
On 04/08/21 13:59, Brijesh Singh wrote: > On 4/8/21 4:58 AM, Laszlo Ersek wrote: >> On 03/24/21 16:31, Brijesh Singh wrote: >>> At this time we only support the pre-validation. OVMF detects all the >>> available >>> system RAM in the PEI phase. When SEV-SNP is enabled, the memory is >>>

[edk2-devel] [PATCH] DynamicTablesPkg: add validation for PcdNonBsaCompliant16550SerialHid

2021-04-09 Thread Joey Gouly
According to ACPI 6.4, 6.1.5 _HID states: - A valid PNP ID must be of the form "AAA" where A is an uppercase letter and # is a hex digit. - A valid ACPI ID must be of the form "" where N is an uppercase letter or a digit ('0'-'9') and # is a hex digit. Signed-off-by: Joey

Re: [edk2-devel] MinPlatform Board port (GSoC 2021)

2021-04-09 Thread Nate DeSimone
On Thu, Apr 8, 2021 at 10:33 PM, Benjamin Doron wrote: > Sorry, I meant that the specifics of flashing might not be relevant if no > TianoCore mentor/developer will have one of these boards. Ah I understand now, yes that makes much more sense! > Okay, nice! I suppose within EDK2, dispatch mode