Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

2021-04-11 Thread Abner Chang
Ah, yes. I will revise the copyrights in Redfish.fdf.inc and RedfishComponents.dsc.inc when merge it. Thanks for catching this. Abner > -Original Message- > From: Wang, Nickle (HPS SW) > Sent: Monday, April 12, 2021 11:53 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

2021-04-11 Thread Nickle Wang
Looks good to me. But for the copyright, I think it would be "2020-2021", right? For example: -# (C) Copyright 2020 Hewlett Packard Enterprise Development LP +# (C) Copyright 2021 Hewlett Packard Enterprise Development LP Thanks, Nickle -Original Message- From: devel@edk2.groups.io On

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: EFI Redfish Discover Protocol

2021-04-11 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, March 26, 2021 12:54 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Jiaxin Wu ; Siyuan Fu ; Fan Wang ; Jiewen Yao Subject: [PATCH]

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of Base instance.

2021-04-11 Thread Ni, Ray
Laszlo, This is also related to CpuTimerLib. I assume that you won't have any concern if I merge today We need the INF change very urgently because with the removal of DxeCpuTimerLib, DXE module must use BaseCpuTImerLib but the INF doesn't allow it. Thanks, Ray > -Original Message- >

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

2021-04-11 Thread Wu, Hao A
> -Original Message- > From: Bret Barkelew > Sent: Saturday, April 10, 2021 2:25 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in > VarCheckPolicyLib > > DumpVariablePolicy() will return

Re: [edk2-devel] [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of Base instance.

2021-04-11 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Lou, Yun > Sent: Saturday, April 10, 2021 11:23 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Dong, Eric > ; Laszlo Ersek ; Kumar, Rahul1 > > Subject: [PATCH v1] UefiCpuPkg/CpuTimerLib: Update LIBRARY_CLASS of > Base instance.

Re: [edk2-devel] [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and MAKE_PATH fixes

2021-04-11 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: Kinney, Michael D > Sent: Saturday, April 10, 2021 5:49 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Liming Gao > ; Chen, Christine > Subject: [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and > MAKE_PATH fixes > > REF:

Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template

2021-04-11 Thread Yuwei Chen
Reviewed-by: Yuwei Chen > -Original Message- > From: Kinney, Michael D > Sent: Saturday, April 10, 2021 6:00 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Liming Gao > ; Chen, Christine > Subject: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in > tools_def.template > > REF:

回复: [EXTERNAL] [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib

2021-04-11 Thread gaoliming
Bret: This fix is correct. I am interest that why the compiler doesn’t detect this issue. Reviewed-by: Liming Gao Thanks Liming 发件人: Bret Barkelew 发送时间: 2021年4月10日 2:34 收件人: devel@edk2.groups.io; b...@corthon.com; Liming Gao 抄送: Jian J Wang ; Hao A Wu 主题: RE: [EXTERNAL]

[edk2-devel] 回复: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in tools_def.template

2021-04-11 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Michael D Kinney > 发送时间: 2021年4月10日 6:00 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng ; Liming Gao > ; Yuwei Chen > 主题: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in > tools_def.template > > REF:

回复: [edk2-devel] Build Failed for QEMU35Pkg

2021-04-11 Thread gaoliming
This issue has been fixed in Edk2 trunk 20b292d0cdf7dce58d824fdf9ab1613c2a1ad2ec. Edk2 Build supports Python 3.8 & Python3.9 both. Thanks Liming 发件人: devel@edk2.groups.io 代表 Andrew Fish via groups.io 发送时间: 2021年4月10日 7:54 收件人: edk2-devel-groups-io ; bret.barke...@microsoft.com 抄送: