hi Michael,
Thanks for your review.
On Tue, 20 Apr 2021 at 21:26, Kinney, Michael D
wrote:
> Hi,
>
> I think this patch is functional, but there are a few things that can be
> improved.
>
> 1) We should not use of the hard coded constants for the
> ImageCapsuleSupport values.
>The UEFI spec
On 04/21/21 02:38, Yao, Jiewen wrote:
> Hello
> Do we have some conclusion on this topic?
>
> Do we agree the one-binary solution in OVMF or we need more discussion?
Well it's not technically impossible to do, just very ugly and brittle.
And I'm doubtful that this is a unique problem ("just fix
From: Pierre Gondois
This patch fixes the following Ecc reported error:
The #ifndef at the start of an include file should have
one postfix underscore, and no prefix underscore character
Some include guards have been modified to match the name of the
header file. Some comments have also been add
From: Pierre Gondois
Add the OemMiscLibNull library to the [Components] section of
ArmPkg.dsc, allowing to complete the 'DscCompleteCheck' CI test.
According to .pytool/Readme about the 'DscCompleteCheck' test:
The test considers it an error if any INF does not appear in the
`Components` section
From: Pierre Gondois
Enable upstream CI for the ArmPkg and ArmPlatformPkg.
Bugzilla tickets have been created for theirenablement:
ArmPkg:
https://bugzilla.tianocore.org/show_bug.cgi?id=3349
ArmPlatformPkg:
https://bugzilla.tianocore.org/show_bug.cgi?id=3348
The patch-set also fixes some Ecc rep
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Non-Boolean comparisons should use a compare operator
(==, !=, >, < >=, <=)
Signed-off-by: Pierre Gondois
---
.../Library/StandaloneMmMmuLib/AArch64/ArmMmuStandaloneMmLib.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
From: Pierre Gondois
The 'cspell' CI test detected some small typos in ArmPkg.
Correct them.
Signed-off-by: Pierre Gondois
---
ArmPkg/Drivers/CpuDxe/Arm/Mmu.c | 2 +-
ArmPkg/Filesystem/SemihostFs/Arm/SemihostFs.c | 2 +-
ArmPkg/Library/ArmMmuLib/Arm/Ar
From: Pierre Gondois
Some library headers are missing/incorrect in ArmPkg.dec.
This makes the 'LibraryClassCheck' CI test fail. This patch
adds/corrects them.
According to .pytool/Readme about the 'LibraryClassCheck' test:
This test scans at all library header files found in the
`Library` folder
From: Pierre Gondois
Add ArmPkg.ci.yaml to configure the CI for the
ArmPkg.
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.ci.yaml | 222 ++
1 file changed, 222 insertions(+)
create mode 100644 ArmPkg/ArmPkg.ci.yaml
diff --git a/ArmPkg/ArmPkg.ci.yaml
From: Pierre Gondois
Enable the CI for the ArmPkg.
Signed-off-by: Pierre Gondois
---
.pytool/CISettings.py | 3 ++-
.pytool/Readme.md | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 5f71eca1992e..6f7daeca076b 100644
From: Pierre Gondois
Enable the CI for the ArmPlatformPkg.
Signed-off-by: Pierre Gondois
---
.pytool/CISettings.py | 1 +
.pytool/Readme.md | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index 6f7daeca076b..96e6baa5190d 1
From: Pierre Gondois
Add ArmPlatformPkg.ci.yaml to configure the CI for the
ArmPlatformPkg.
Signed-off-by: Pierre Gondois
---
ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 100 ++
1 file changed, 100 insertions(+)
create mode 100644 ArmPlatformPkg/ArmPlatformPkg.ci.yaml
dif
From: Pierre Gondois
Add an entry to build the ArmPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3348
Signed-off-by: Pierre Gondois
---
.azurepipelines/templates/pr-gate-build-job.yml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.azurepipelines/templates/pr-gate
From: Pierre Gondois
Add an entry in the documentation for the LicenseCheck and
EccCheck plugins.
Signed-off-by: Pierre Gondois
---
.pytool/Readme.md | 10 ++
1 file changed, 10 insertions(+)
diff --git a/.pytool/Readme.md b/.pytool/Readme.md
index eca86c6a822d..f6505507966a 100644
--
From: Pierre Gondois
Add an entry to build the ArmPlatformPkg in the CI.
Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=3349
Signed-off-by: Pierre Gondois
---
.azurepipelines/templates/pr-gate-build-job.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.azurepipeli
Hi Pranav,
@@ -20,6 +20,132 @@
�#define EFI_ACPI_ARM_CREATOR_ID SIGNATURE_32('A','R','M',' ')
�#define EFI_ACPI_ARM_CREATOR_REVISION 0x0099
+#define CORE_COUNT����� FixedPcdGet32 (PcdCoreCount)
+#define CLUSTER_COUNT�� FixedPcdGet32 (PcdClusterCount)
+
+#pragma pack(1)
+//
https://edk2-docs.gitbook.io/edk-ii-build-specification/2_design_discussion/23_boot_sequence
> On Apr 20, 2021, at 11:34 PM, Eric van Tassell wrote:
>
>
>
>> On 4/20/21 5:54 PM, Tom Lendacky wrote:
>> From: Tom Lendacky
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345
>> The TPM sup
Sughosh,
My feedback on compatibility was for the parameter list to the Python methods.
Not the C structures. The python modules in the Common directory could be used
by other tools.
Mike
From: Sughosh Ganu
Sent: Wednesday, April 21, 2021 12:02 AM
To: Kinney, Michael D
Cc: devel@edk2.group
Hi Laszlo,
I am sorry to hear that it sounded like we are dictating a certain
approach. Although I can see why it sounded that way, it certainly was not
my intention.
We want to work with the EDK2 community to have a solution that is
beneficial for everyone and we appreciate the inputs that we got
Tom,
The phases are defined by the UEFI Platform Initialization Specification [1]
(PI Spec). Basically the UEFI Specification defines how to write EFI OS Loaders
and Option ROMs and EFI is just defined in the context of how EFI services are
passed into applications or drivers. The UEFI Platform
On 4/21/21 12:20 PM, Andrew Fish wrote:
> Tom,
I think you meant this for Eric, who orignally asked the question.
Thanks,
Tom
>
> The phases are defined by the UEFI Platform Initialization Specification
> [1] (PI Spec). Basically the UEFI Specification defines how to write EFI
> OS Loaders and
To add onto Guo's response, this series is mostly focused on refactoring
via code consolidation as I'm concerned with the driver that produces
the FVB protocol (SpiFvbServiceSmm via SmmSpiFlashCommonLib).
Fortunately, SmmSpiFlashCommonLib uses gPchSmmProtocolGuid as a SPI HW
abstraction and in
1) To expedite the required reviews, you may want to add CC to the package
maintainers for ArmPkg to this commit message and email. I know a lot of people
filter based on direct mention vs mailing list.
2) Generally, other packages have a brief description of the lib in the DEC, as
well. Exampl
Same comment about CC to the package maintainers.
Reviewed-by: Bret Barkelew
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#74341): https://edk2.groups.io/g/devel/message/74341
Mute This Topic: https://groups.io/mt/82258505/21656
Group
Sorry Tom!
It was hard to follow the mangled threading on my iPhone, especially before my
1st cup of coffee!
Thanks,
Andrew Fish
> On Apr 21, 2021, at 10:45 AM, Lendacky, Thomas
> wrote:
>
> On 4/21/21 12:20 PM, Andrew Fish wrote:
>> Tom,
>
> I think you meant this for Eric, who orignally
On 04/21/21 00:54, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345
>
> The MOVZX and MOVSX instructions use the ModRM byte in the instruction,
> but the instruction decoding support was not decoding it. This resulted
> in invalid decoding
This patch is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, April 21, 2021 1:44 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Liming Gao ;
Chen, Christine
Subject: [Patch 1/1] BaseTools/Source/Python: Verify TAB_TOD_DEFINES_FAMILY key
On 04/21/21 00:54, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345
>
> Enabling TPM support results in guest termination of an SEV-ES guest
> because it uses MMIO opcodes that are not currently supported.
>
> Add support for the new MMIO opc
hi Michael,
On Wed, 21 Apr 2021 at 21:04, Kinney, Michael D
wrote:
> Sughosh,
>
>
>
> My feedback on compatibility was for the parameter list to the Python
> methods. Not the C structures. The python modules in the Common
> directory could be used by other tools.
>
Okay, understood. I will ma
On 04/21/21 01:17, Eric van Tassell wrote:
>
>
> On 4/20/21 5:54 PM, Tom Lendacky wrote:
>> From: Tom Lendacky
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3345
>>
>> The TPM support in OVMF performs MMIO accesses during the PEI phase. At
>
> where are the phases defined and how man
30 matches
Mail list logo
